gerritbot added a comment.
Change 449766 abandoned by WMDE-leszek:
DNM Hunting T200693
https://gerrit.wikimedia.org/r/449766TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: greg,
gerritbot added a comment.
Change 450054 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Get rid of Reflection hack used to override factory member
https://gerrit.wikimedia.org/r/450054TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449764 abandoned by Addshore:
DNM Hunting after T200693
https://gerrit.wikimedia.org/r/449764TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: greg,
gerritbot added a comment.
Change 450590 merged by jenkins-bot:
[integration/config@master] Revert "Temporarily exclude WikibaseLexeme from jobs including Wikibase"
https://gerrit.wikimedia.org/r/450590TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450590 had a related patch set uploaded (by Addshore; owner: Addshore):
[integration/config@master] Revert "Temporarily exclude WikibaseLexeme from jobs including Wikibase"
https://gerrit.wikimedia.org/r/450590TASK
Esanders added a comment.
Thanks everyone for getting this fixed!
In T200693#4480095, @WMDE-leszek wrote:
Is there some general practice/guidelines here that could be applied? I am especially thinking of a case when (especially unexpected) test failures of extension X cause CI jobs for Y, Z or H
gerritbot added a comment.
Change 450044 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] phpunit tests: do not persist in providers
https://gerrit.wikimedia.org/r/450044TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449443 restored by Addshore:
Skip statement.add browser test
Reason:
Restore to test something
https://gerrit.wikimedia.org/r/449443TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450517 abandoned by Tarrow:
Skip failing Lua test to hack around T200693
https://gerrit.wikimedia.org/r/450517TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore,
gerritbot added a comment.
Change 449447 abandoned by Tarrow:
DNM TESTING for T200693
https://gerrit.wikimedia.org/r/449447TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: greg,
gerritbot added a comment.
Change 449483 abandoned by Tarrow:
WIP DNM Logging for T200693
https://gerrit.wikimedia.org/r/449483TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: greg,
gerritbot added a comment.
Change 449443 abandoned by Tarrow:
Skip statement.add browser test
https://gerrit.wikimedia.org/r/449443TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc:
Addshore added a comment.
It looks like ContentTranslation is unblocked now, I just +2ed https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContentTranslation/+/449441/ to double check.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450517 restored by Tarrow:
Skip failing Lua test to hack around T200693
https://gerrit.wikimedia.org/r/450517TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,
gerritbot added a comment.
Change 450517 abandoned by Tarrow:
Skip failing Lua test to hack around T200693
https://gerrit.wikimedia.org/r/450517TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,
gerritbot added a comment.
Change 450194 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make getDefaultValueFormatterBuilders in sync with WikibaseClient singleton resetting
https://gerrit.wikimedia.org/r/450194TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450517 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Skip failing Lua test to hack around T200693
https://gerrit.wikimedia.org/r/450517TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Addshore added a comment.
So https://gerrit.wikimedia.org/r/450514 is deployed and https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/9891/console which ran for https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContentTranslation/+/449441/ now fails with Wikibase test
gerritbot added a comment.
Change 450514 merged by jenkins-bot:
[integration/config@master] Temporarily exclude WikibaseLexeme from jobs including Wikibase
https://gerrit.wikimedia.org/r/450514TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450514 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[integration/config@master] Temporarily exclude WikibaseLexeme from jobs including Wikibase
https://gerrit.wikimedia.org/r/450514TASK
Esanders added a comment.
Is there a plan B here? Having a WMF project blocked on CI for over a week is not good. Can we disable these tests in CX until the issue is resolved?TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449440 abandoned by Jakob:
DNM Debugging T200693
https://gerrit.wikimedia.org/r/449440TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: Ladsgroup,
gerritbot added a comment.
Change 449439 abandoned by Jakob:
DNM WIP Debugging T200693
https://gerrit.wikimedia.org/r/449439TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: Ladsgroup,
gerritbot added a comment.
Change 449444 abandoned by Pablo Grass (WMDE):
Skip form add test
Reason:
Root cause resolved in https://phabricator.wikimedia.org/T200693
https://gerrit.wikimedia.org/r/449444TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450194 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Make getDefaultValueFormatterBuilders in sync with WikibaseClient singleton resetting
https://gerrit.wikimedia.org/r/450194TASK
Tarrow added a comment.
More details about the newly failing senses tests: https://phabricator.wikimedia.org/T201137TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Ladsgroup, WMDE-leszek, Addshore,
WMDE-leszek added a comment.
Here are my findings regarding the following PHPUnit failing tests (of Wikibase). Please note however, that I have the working theory of mine at least three times while investigating these, so take the most current one with a grain of salt.
14:18:15 There were 4
Pablo-WMDE added a comment.
Created a revert for the selenium hack we implemented to get this (partially green) https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/450052/
/cc @Jakob_WMDETASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 450054 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Get rid of Reflection hack used to override factory member
https://gerrit.wikimedia.org/r/450054TASK
Pablo-WMDE added a comment.
Checked all the other WikibaseLexeme data providers - apparently they are all clean; only return values w/o causing side effects.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 450038 abandoned by Addshore:
WIP DNM Hardcode an id that is not Q1
https://gerrit.wikimedia.org/r/450038TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,
gerritbot added a comment.
Change 450044 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] phpunit tests: do not persist in providers
https://gerrit.wikimedia.org/r/450044TASK
gerritbot added a comment.
Change 450038 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] WIP DNM Hardcode an id that is not Q1
https://gerrit.wikimedia.org/r/450038TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Pablo-WMDE added a comment.
Apparently the provider SpecialNewLexemeTest::provideValidEntityCreationRequests() is at fault
See https://github.com/sebastianbergmann/phpunit/issues/2007TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Addshore added a comment.
Some stuff from IRC:
<•addshore> 6 Query INSERT /* MediaWiki\Storage\SqlBlobStore::storeBlob nobody@2e7d0434... */ INTO `text` (old_id,old_text,old_flags) VALUES
Pablo-WMDE added a comment.
Picking up from where I left yesterday, checking what the DB contains after test "run" of SpecialNewLexemeTest.php, in particular with regards to wb_counters.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Addshore added a comment.
Wikibase quibble job does not include Scribunto
Sounds like something we should fix, if you get a patch up send it my way and I'll see if I can get it in.
But it shall not be missed, that these 4 failures are not the only problem, see browser test failures that have
Addshore added a comment.
The failures seem to also happen while running the Property Suggestor CI? https://integration.wikimedia.org/ci/job/quibble-composer-mysql-hhvm-docker/492/console which was the CI for https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PropertySuggester/+/449878/ has
gerritbot added a comment.
Change 449766 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/ContentTranslation@master] DNM Hunting T200693
https://gerrit.wikimedia.org/r/449766TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449764 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] DNM Hunting after T200693
https://gerrit.wikimedia.org/r/449764TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Jakob_WMDE added a comment.
I was able to reproduce those lexeme related test failures with quibble locally. The test failures go away if I add PropertySuggester to the --exclude-groups. The PropertySuggester extension hasn't changed in ages, so this is all very strange.TASK
Nikerabbit added a comment.
The errors seems to have changed and now appear in PHPUnit section: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/9369/console
You are probably aware, but mentioning just in case.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449453 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Create a dummy item before running the first browser test.
https://gerrit.wikimedia.org/r/449453TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Tarrow added a comment.
Still looking. Not yet done much link cache investigation but have got the mysql general log out of my local quibble. It's not attached ( >70MB ) so anyone else who wants to dig through let me know.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449453 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Create a dummy item before running the first browser test.
https://gerrit.wikimedia.org/r/449453TASK
Addshore added a comment.
In T200693#4465900, @Tarrow wrote:
Just tried @Addshore 's thought. It does fail! Looks like something is left over from phpunit or qunit. Now to track it down
Did you manage to look LinkCache possible oddities any more?TASK
Pablo-WMDE added a comment.
Also happens if "Lexeme:Forms can be added" is the only spec run (with NODE_DEBUG=request)
REQUEST { method: 'POST',
headers: { 'User-Agent': 'mwbot/1.0.10' },
qs: { format: 'json' },
form:
{ action: 'wbeditentity',
new: 'item',
data:
Pablo-WMDE added a comment.
Followed a hunch on the TitleExists hook which in this integration EducationProgram provides but can likely be ruled out as the culprit.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Tarrow added a comment.
Just tried @Addshore 's thought. It does fail! Looks like something is left over from phpunit or qunit. Now to track it downTASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc:
Addshore added a comment.
In T200693#4464211, @hashar wrote:
I ran the Selenium tests through Quibble using all the extensions and unfortunately it passes just fine locally.
Did you try a run as in CI, with phpunit qunit & selenium in the same run?TASK
gerritbot added a comment.
Change 449483 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] WIP DNM Logging for T200693
https://gerrit.wikimedia.org/r/449483TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Jakob_WMDE added a comment.
So, the latest silly test confirmed that the test fails because it fails to create an item via the wbeditentity API. It attempts to create Q1, and claims that it already exists. A possible issue could be a dirty table, but that's just speculation.
The browser test in
Tarrow added a comment.
We have tried skipping the offending test in: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContentTranslation/+/449447/
Unfortunately this just seems to move the failure to the next test along.
We've been progressively debugging but since we can't reproduce
gerritbot added a comment.
Change 449417 abandoned by Nikerabbit:
DNM Debugging T200693
https://gerrit.wikimedia.org/r/449417TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: Addshore,
Nikerabbit added a comment.
Based on my debugging it seems that it is the very first call to WikibaseApi.createItem() that is failing. It seems Tarrow is already debugging inside Wikibase why that is happening, so I am not planning to continue debugging this for now.TASK
gerritbot added a comment.
Change 449447 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/ContentTranslation@master] DNM TESTING for T200693
https://gerrit.wikimedia.org/r/449447TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449444 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Skip form add test
https://gerrit.wikimedia.org/r/449444TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449443 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Skip statement.add browser test
https://gerrit.wikimedia.org/r/449443TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449440 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/ContentTranslation@master] DNM Debugging T200693
https://gerrit.wikimedia.org/r/449440TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449439 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] DNM WIP Debugging T200693
https://gerrit.wikimedia.org/r/449439TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
hashar added a comment.
On a dummy change phpunit now fails:
1) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "ContentTranslationStats" (SpecialContentTranslationStats Object (...))
Error: Call to a member function getPrefixedDBkey() on null
Which I guess is not related to the
Tarrow added a comment.
The failed-save: The save has failed. error appear to us to be an error from the API not an interaction with the page.
We also note that it is the *first* test of the group and wonder if this is connected.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Nikerabbit added a comment.
Possibly unrelated but now I am also seeing quite a few of these:
WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined', 'TypeError: Cannot read property 'id' of undefined
at Object.deserializeForm
WARN: 'jQuery.Deferred exception: Cannot read
hashar added a comment.
I ran the Selenium tests through Quibble using all the extensions and unfortunately it passes just fine locally.TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot,
gerritbot added a comment.
Change 449418 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] DNM Debugging T200693
https://gerrit.wikimedia.org/r/449418TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
gerritbot added a comment.
Change 449417 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/WikibaseLexeme@master] DNM Debugging T200693
https://gerrit.wikimedia.org/r/449417TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL
Nikerabbit added a comment.
I would start from Unhandled rejection Error: failed-save: The save has failed.
You could modify the test to output more information than just the error code failed-saved.
We would also appreciate that if this test could be temporarily disabled if it cannot be fixed
67 matches
Mail list logo
