[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-09-21 Thread gerritbot
gerritbot added a comment. Change 453147 abandoned by Addshore: phpunit: WikibaseRepo statics persist between tests Reason: I think we can abandon this now? I'm gonna be bold and just do it. Feel free to un-abandon! https://gerrit.wikimedia.org/r/453147TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-09-11 Thread gerritbot
gerritbot added a comment. Change 453143 abandoned by Pablo Grass (WMDE): phpunit: clear in-memory caches between tests Reason: Made irrelevant by I82b5e94009527f9e46262bf6f505a43ddc9767f0 & Idd12370b09ad0ebae23d77c743b79a7163961436 https://gerrit.wikimedia.org/r/453143TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-09-11 Thread gerritbot
gerritbot added a comment. Change 453140 abandoned by Pablo Grass (WMDE): Store: add ability to clean in-memory cache Reason: Made irrelevant by I82b5e94009527f9e46262bf6f505a43ddc9767f0 & Idd12370b09ad0ebae23d77c743b79a7163961436 https://gerrit.wikimedia.org/r/453140TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-29 Thread Pablo-WMDE
Pablo-WMDE added a comment. Competing patches by @Addshore https://gerrit.wikimedia.org/r/455176 https://gerrit.wikimedia.org/r/455180 TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc:

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-21 Thread Pablo-WMDE
Pablo-WMDE added a comment. Patches that should prevent that in the future are up: https://gerrit.wikimedia.org/r/453140 https://gerrit.wikimedia.org/r/453143 https://gerrit.wikimedia.org/r/453147 TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-17 Thread Pablo-WMDE
Pablo-WMDE added a comment. Blocked patch turned green on Aug 15 2:53 PM through https://gerrit.wikimedia.org/r/452912TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-16 Thread gerritbot
gerritbot added a comment. Change 453147 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] phpunit: WikibaseRepo statics persist between tests https://gerrit.wikimedia.org/r/453147TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-16 Thread gerritbot
gerritbot added a comment. Change 453143 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] phpunit: clear in-memory caches between tests https://gerrit.wikimedia.org/r/453143TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-16 Thread gerritbot
gerritbot added a comment. Change 453140 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] Store: add ability to clean in-memory cache https://gerrit.wikimedia.org/r/453140TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/452927 and https://gerrit.wikimedia.org/r/452946 were created in the wake of this.TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc:

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread gerritbot
gerritbot added a comment. Change 452912 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] LexemeSpecialWhatLinksHereTest: create property https://gerrit.wikimedia.org/r/452912TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread gerritbot
gerritbot added a comment. Change 452912 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] LexemeSpecialWhatLinksHereTest: create property https://gerrit.wikimedia.org/r/452912TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment. Happens too when executing only the tests inside /var/www/mediawiki/extensions/WikibaseLexeme/tests/phpunit/mediawikiTASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc:

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread thiemowmde
thiemowmde added a comment. I just realized what this error message means: Some test (at the moment I don't know which) creates an Item, but this Item ends in code that expects a Lexeme. One possible improvement is to let FormIdTextFormatter::formatEntityId throw an exception when the Entity

[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment. Locally reproduceable on WB+WBL masters Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testLexemeLanguage Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testLexemeLexicalCategory