gerritbot added a comment.
Change 472630 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Lint against IE 11
https://gerrit.wikimedia.org/r/472630TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/ema
gerritbot added a comment.
Change 472633 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Actually activate js compatibility linting
https://gerrit.wikimedia.org/r/472633TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pan
gerritbot added a comment.
Change 472633 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Actually activate js compatibility linting
https://gerrit.wikimedia.org/r/472633TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFE
gerritbot added a comment.
Change 472630 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Lint against IE 11
https://gerrit.wikimedia.org/r/472630TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCES
Michael added a comment.
So, the conclusion is that wmf will upstream the changes to their wikimedia config soonish. This is tracked by issue #113 on GitHub. Once this patch has landed and is released we bump the version and should be done. There will be another phabricator ticket for this version
Addshore added a comment.
Next snippet of conversation with James in the same channel:
1:47 PM <+James_F> addshore: There’s an informal CI group that runs it. Me, edsanders, Krinkle, others who turn up.
1:47 PM gotcha, also morning
1:49 PM <+James_F> Yeah, we’re close to landing that ish.
1:49
Addshore added a comment.
So, from the discussion I had in #wikimedia-editing on IRC: (a rough summary)
11:49 AM Hi again edsanders :D Does mediawiki have one of these? https://eslint.org/docs/developer-guide/shareable-configs
11:50 AM basically we want to use https://gerrit.wikimedia.org/r/#/c
Michael added a comment.
matmarex: No, it does not, or at least: not yet. Your approach covers the problem we had with Object.assign(), so I would expect that they complement each other for the time being.TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCEShttps://phabricator.wikim
matmarex added a comment.
Recently I've been working on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/463464 – do you think that plugin covers all of the functionality I'm trying to implement here?TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCEShttps://phabricator.wikimedia
gerritbot added a comment.
Change 472131 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Lint against IE 11
https://gerrit.wikimedia.org/r/472131TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCEShttps://phab
Addshore added a comment.
It sounds like adding eslint-plugin-compat would make sense for us, especially if the upstream bug https://github.com/amilajack/eslint-plugin-compat/issues/89 looks like it might be fixed in the future.TASK DETAILhttps://phabricator.wikimedia.org/T207169EMAIL PREFERENCESht
Michael added a comment.
I looked into this further. While eslint-plugin-compat is straightforward to integrate, it doesn't pick up the Object.assign() error, either. This is a known issue: #89 on GitHub.
Adding this plugin to our eslint setup might make sense nonetheless?TASK DETAILhttps://phabri
Michael added a comment.
There are apparently two options: eslint-plugin-ie11 and eslint-plugin-compat
However, eslint-plugin-ie11 seems to have only 4 rules and they don't cover the issue with Object.assign(). Also it seems to be rarely used and the last release was a year ago.
On the other hand
13 matches
Mail list logo
