[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

Greta_Doci_WMDE added a comment. In T212869#5152180 , @Lea_Lacroix_WMDE wrote: > I tested it on beta and prod and both seems to work, but now I'm a bit confused. Is it already live, or did I test the wrong thing? It is already

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

Lea_Lacroix_WMDE added a comment. I tested it on beta and prod and both seems to work, but now I'm a bit confused. Is it already live, or did I test the wrong thing? TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 506182 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use LabelDescriptionNotEqualValidator in TermValidatorFactory https://gerrit.wikimedia.org/r/506182 TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 506181 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add CompositeFingerprintValidator https://gerrit.wikimedia.org/r/506181 TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 506172 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add LabelDescriptionNotEqualValidator https://gerrit.wikimedia.org/r/506172 TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

alaa_wmde added a comment. @Lucas_Werkmeister_WMDE gold  Just wanted to raise awareness of that aspect, and seems I was lacking behind the current awareness around the topic.. that's awesome news! TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

Lucas_Werkmeister_WMDE added a comment. In T212869#5135925 , @hoo wrote: > In T212869#5122970 , @Lucas_Werkmeister_WMDE wrote: > > > Unfortunately the `ChangeOp` approach seems to

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

alaa_wmde added a comment. Sorry to come late to this one. I can still see one problem here even if we find a way to tell the second request to look at the right revision id. The problem comes from the fact that UI is making two separate requests for what appears to be an atomic action

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

hoo added a comment. In T212869#5122970 , @Lucas_Werkmeister_WMDE wrote: > Unfortunately the `ChangeOp` approach seems to have the same problem: it uses the base revision, not the parent revision, to check if the label and the

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 506182 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Use LabelDescriptionNotEqualValidator in TermValidatorFactory https://gerrit.wikimedia.org/r/506182 TASK

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 506181 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add CompositeFingerprintValidator https://gerrit.wikimedia.org/r/506181 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 506172 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi): [mediawiki/extensions/Wikibase@master] Add LabelDescriptionNotEqualValidator https://gerrit.wikimedia.org/r/506172 TASK DETAIL https://phabricator.wikimedia.org/T212869

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

Lucas_Werkmeister_WMDE added a comment. Unfortunately the `ChangeOp` approach seems to have the same problem: it uses the base revision, not the parent revision, to check if the label and the description are the same :( TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 504283 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Prevent label = description to Special:NewProperty https://gerrit.wikimedia.org/r/504283 TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

hoo added a comment. Why not do this as part of `ChangeOpDescription` and `ChangeOpLabel`? I know some places don't use this, but this seems to be the right place to me. TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

abian added a comment. In T212869#5114173 , @Lucas_Werkmeister_WMDE wrote: > But this might also affect undo/restore/rollback… I don't think (as an editor) that's a problem. The wrong edit, and the one that should be reverted,

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

Lucas_Werkmeister_WMDE added a comment. Greta and I tried yesterday to implement this in the `SetLabel` and `SetDescription` APIs. Their parent class `ModifyEntity` has a convenient `validateEntitySpecificParameters` method, where you can validate the `array $preparedParameters` against the

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

gerritbot added a comment. Change 504283 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi): [mediawiki/extensions/Wikibase@master] Prevent label = description to Special:NewProperty https://gerrit.wikimedia.org/r/504283 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

alaa_wmde added a comment. For `Special:NewProperty` yes it is part of the acceptance criteria so it should also fix that one. For rollback, I think that it should not, because it will get us stuck in situation where a vandal might introduce a change that we want to revert. If the

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

Greta_Doci_WMDE added a comment. A few questions: should this affect Special:NewProperty? Should it also prevent undo/restore/rollback, if the resulting content has labels and descriptions that are the same? TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES