[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-10-10 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.  TASK DETAIL https://phabricator.wikimedia.org/T224014 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Lydia_Pintscher Cc: Jakob_WMDE, Lea_WMDE, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-10-10 Thread alaa_wmde
alaa_wmde added a comment. It isn't as it appears in the code so far. it is hard coded in the class and used directly .. perhaps that's something we can do later and make it configurable? TASK DETAIL https://phabricator.wikimedia.org/T224014 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-10-10 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Yeah that sounds good! I wonder: if the 500 is a configurable limit if we should take that into account as well. TASK DETAIL https://phabricator.wikimedia.org/T224014 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-10-10 Thread alaa_wmde
alaa_wmde added a comment. So as for now, I propose to do the following: 1. Use 480 as a limit for the generated summary. 2. If we have <= 5 terms changed, we generate expanded version. Then if it is below the limit, we stop and use it. 3. If we have <= 50 languages changed, we

[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-10-09 Thread alaa_wmde
alaa_wmde added a comment. So trying to save the above example of long version, it ended up in database in comment table (comment_text column) as: `/* wbsetclaim-create:2||en, label, "Frame of Notre-Dame de Paris"|fr, alias, Marie|es, description, ""this is a

[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-10-09 Thread alaa_wmde
alaa_wmde added a comment. Testing storing necessary comment arguments for the following examples of each version (if all can be stored succesfully, then the simple count limits we have in the parent task is more than sufficient: **Expanded version** Added [en] label: Frame of

[Wikidata-bugs] [Maniphest] [Commented On] T224014: Figure out the limits in which versions fallback to the next one

2019-08-20 Thread Jakob_WMDE
Jakob_WMDE added a comment. Storage capacity for the summary is not a problem, I think. Edit summaries go to the comment table and are stored as blobs. 64kb should be plenty even if we want to store the changes/additions/deletions of