[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Addshore added a comment. In T226216#5409666 , @alaa_wmde wrote: >> I think the reason is that the graphs are in log scale > > can't see where they are in log scale, they are all in time or percentage here

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

alaa_wmde added a comment. > I think the reason is that the graphs are in log scale can't see where they are in log scale, they are all in time or percentage here https://grafana.wikimedia.org/d/00615/wikibase-editentity?orgId=1 was this much bigger effort than the actual

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Ladsgroup added a comment. In T226216#5404331 , @Addshore wrote: > I believe this one was deployed with: > > 19:36 Synchronized php: group1 wikis to 1.34.0-wmf.17 (duration: 00m 54s) > > If so no real impact has been

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Addshore added a comment. I believe this one was deployed with: 19:36 Synchronized php: group1 wikis to 1.34.0-wmf.17 (duration: 00m 54s) If so no real impact has been immediately evident while looking at https://grafana.wikimedia.org/d/00615/wikibase-editentity

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Lea_Lacroix_WMDE added a comment. Seems good. TASK DETAIL https://phabricator.wikimedia.org/T226216 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lea_Lacroix_WMDE Cc: Lea_Lacroix_WMDE, Ladsgroup, matej_suchanek, Sjoerddebruin,

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Ladsgroup added a comment. In T226216#5383432 , @Lea_Lacroix_WMDE wrote: > Discussions are still happening on the talk page

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Lea_Lacroix_WMDE added a comment. Discussions are still happening on the talk page . I announced a deployment on August 6th but we may have to delay it if some

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524563 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove id from (Item|Property)Content::getTextForFilters() https://gerrit.wikimedia.org/r/524563 TASK DETAIL https://phabricator.wikimedia.org/T226216 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524552 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove hashes from (Item|Property)Content::getTextForFilters() https://gerrit.wikimedia.org/r/524552 TASK DETAIL https://phabricator.wikimedia.org/T226216 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524554 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Remove hashes from LexemeContent::getTextForFilters() https://gerrit.wikimedia.org/r/524554 TASK DETAIL https://phabricator.wikimedia.org/T226216 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

alaa_wmde added a comment. > However, for the future, we should take a decision about if the abusefilter output is stable or unstable, so we don't run into this unclear situation again. Yeap, I'll schedule smth to have discussion and decide on that. Thank you! TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Lea_Lacroix_WMDE added a comment. Yep, I think it's fine the way it is now (I announced it, with a reasonable delay for people to fix the things, people reacted positively). However, for the future, we should take a decision about if the abusefilter output is stable or unstable, so we

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

alaa_wmde added a comment. > As for this, do we anticipate lots of other code depending on this output to break? If we can be fairly sure there is almost nothing that will break, then it should be fine I think. If we cannot know (or we know things will break) then maybe it deserves a BC

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

alaa_wmde added a comment. In T226216#5378960 , @Ladsgroup wrote: > In T226216#5378921 , @alaa_wmde wrote: > >> @Lea_Lacroix_WMDE This one needs announcement for the breaking change

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

Ladsgroup added a comment. In T226216#5378921 , @alaa_wmde wrote: > @Lea_Lacroix_WMDE This one needs announcement for the breaking change (change is approved but won't be merged before the announced release date per this announcement).

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524554 had a related patch set uploaded (by Alaa Sarhan; owner: Ladsgroup): [mediawiki/extensions/WikibaseLexeme@master] Remove hashes from LexemeContent::getTextForFilters() https://gerrit.wikimedia.org/r/524554 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524552 had a related patch set uploaded (by Alaa Sarhan; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Remove hashes from (Item|Property)Content::getTextForFilters() https://gerrit.wikimedia.org/r/524552 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524563 had a related patch set uploaded (by Alaa Sarhan; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Remove id from (Item|Property)Content::getTextForFilters() https://gerrit.wikimedia.org/r/524563 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDS should not appear in AbuseFilter text for Wikibase

Ladsgroup added a comment. > This "id" field is very generic and will also match a bunch of other stuff in the JSON that we are not sure about. It drops entity id as well (and nothing else AFAIC), people can obtain it using `page_title` (except in MediaInfo but we can keep it in

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDS should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524554 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/WikibaseLexeme@master] Remove hashes from LexemeContent::getTextForFilters() https://gerrit.wikimedia.org/r/524554 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226216: Statement GUIDS should not appear in AbuseFilter text for Wikibase

gerritbot added a comment. Change 524552 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Remove hashes from (Item|Property)Content::getTextForFilters() https://gerrit.wikimedia.org/r/524552 TASK DETAIL