[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. > So should we now add a border-top of our own on mobile? (But still no border on the other sides?) (The above change assumes that the answer to these questions is “yes”, though I’d appreciate a confirmation from UX to be sure.) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 578928 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add border-top for header on mobile https://gerrit.wikimedia.org/r/578928 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. Oh, I see what happened… on Desktop, there is a surrounding border by the OOUI window, so we make our own header 41px high without a border. F31674168: Screenshot from 2020-03-10 13-06-48.png

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576114 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: make header larger on mobile https://gerrit.wikimedia.org/r/576114 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575558 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: fix list style on mobile https://gerrit.wikimedia.org/r/575558 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576113 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: add XL EventEmittingButton size https://gerrit.wikimedia.org/r/576113 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Charlie_WMDE added a comment. In T239421#5932957 , @Lucas_Werkmeister_WMDE wrote: >> The string data value textfield should have a height of 40px (including border) and a font-size of 16px (https://gerrit.wikimedia.org/r/575567) > >

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575567 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: make input field larger on mobile https://gerrit.wikimedia.org/r/575567 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576014 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: make EventEmittingButton sizes responsive https://gerrit.wikimedia.org/r/576014 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576114 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: make header larger on mobile https://gerrit.wikimedia.org/r/576114 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576113 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add XL EventEmittingButton size https://gerrit.wikimedia.org/r/576113 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576015 abandoned by Lucas Werkmeister (WMDE): bridge: make bailout button size responsive Reason: no longer needed with new version of base change (M size is already responsive) https://gerrit.wikimedia.org/r/576015 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. > The string data value textfield should have a height of 40px (including border) and a font-size of 16px (https://gerrit.wikimedia.org/r/575567) @Charlie_WMDE a question that came up during review: does the height have to change as soon as the

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. > The “publish” button’s height is relative to the browser font size (rem), but the “cancel”/“close” button’s height and the height of the full header are both absolute (px). IRL discussion summary: We don’t yet have comprehensive specs for what

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. I just noticed another thing: we currently have a discrepancy between the “publish” button, the “cancel”/“close” button, and the header height. The “publish” button’s height is relative to the browser font size (rem), but the “cancel”/“close” button’s

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576015 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: make bailout button size responsive https://gerrit.wikimedia.org/r/576015 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 576014 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add responsive sizes for EventEmittingButton https://gerrit.wikimedia.org/r/576014 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575574 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: remove side margins on mobile https://gerrit.wikimedia.org/r/575574 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575290 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Increase bodyS font-sizes in mobile to bodyM https://gerrit.wikimedia.org/r/575290 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575574 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: remove side margins on mobile https://gerrit.wikimedia.org/r/575574 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575567 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: make input field larger on mobile https://gerrit.wikimedia.org/r/575567 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. > The Publish button should be a size XL on mobile, with the same font-size and line-height but more `padding: 12px 16px 12px 16px;` That gives me a total size of 50px (border-top-width + padding-top + font-size * line-height + padding-bottom +

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575558 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: fix list style on mobile https://gerrit.wikimedia.org/r/575558 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. > [ ] the bailout and permission error views are missing bullet points in front of the list items, but only on mobile, not on desktop This turns out to be because MinervaNeue includes its own reset.css, which sets `list-style: none` for every `ul`

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Michael added a comment. This should (hopefully) be the last batch of changes associated with this ticket: [ ] the font-size of everything that is `body-S`, i.e. 14px, on desktop, should be `body-M`, i.e. 16px on mobile. (https://gerrit.wikimedia.org/r/575290) [ ] the bailout and

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 575290 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Increase bodyS font-sizes in mobile to bodyM https://gerrit.wikimedia.org/r/575290 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 573999 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: fix EventEmittingButton sizes https://gerrit.wikimedia.org/r/573999 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 573999 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: fix EventEmittingButton sizes https://gerrit.wikimedia.org/r/573999 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572695 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Centralize styling for , , and https://gerrit.wikimedia.org/r/572695 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572651 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Align ul styling https://gerrit.wikimedia.org/r/572651 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 547198 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Adjust the size of the Header and close button x https://gerrit.wikimedia.org/r/547198 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572010 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Adjust margins in bailout components https://gerrit.wikimedia.org/r/572010 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572032 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: add missing side margins to permission errors https://gerrit.wikimedia.org/r/572032 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571996 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Add body mixins and use them where appropriate https://gerrit.wikimedia.org/r/571996 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572695 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova): [mediawiki/extensions/Wikibase@master] brige: Centralize styling for , , and https://gerrit.wikimedia.org/r/572695 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572651 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Align ul styling https://gerrit.wikimedia.org/r/572651 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 547198 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Adjust the size of the Header and close button x https://gerrit.wikimedia.org/r/547198 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572010 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Adjust margins in bailout components https://gerrit.wikimedia.org/r/572010 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 572032 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: add missing side margins to permission errors https://gerrit.wikimedia.org/r/572032 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571996 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Add body mixins and use them where appropriate https://gerrit.wikimedia.org/r/571996 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Lucas_Werkmeister_WMDE added a comment. @Michael Is this ready for Verification already or is more work still missing? TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Charlie_WMDE added a comment. Michael, sarai, charlie agreed we go by: for mobile and desktop [ ] bridge UI [ ] bail out path [ ] permission error view in each we need to look at: [ ] font styles [ ] components (buttons, header, input field, component groups) [ ]

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Michael added a comment. @Charlie_WMDE My suggested views to look at for this task: [ ] Bailout views [ ] Permission Error view [ ] Mobile TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571514 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: define vertical margins in DataBridge-component https://gerrit.wikimedia.org/r/571514 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571505 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Adjust input field padding https://gerrit.wikimedia.org/r/571505 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571504 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: The default line-height everywhere is now 1.5 https://gerrit.wikimedia.org/r/571504 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571503 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Adjust spacing within components https://gerrit.wikimedia.org/r/571503 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571502 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Remove extra horizontal margins on mobile https://gerrit.wikimedia.org/r/571502 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571501 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Align styling of header messages https://gerrit.wikimedia.org/r/571501 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571500 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Change our base color to $wmui-color-base10 https://gerrit.wikimedia.org/r/571500 TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571514 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: define vertical margins in DataBridge-component https://gerrit.wikimedia.org/r/571514 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571505 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Adjust input field padding https://gerrit.wikimedia.org/r/571505 TASK DETAIL https://phabricator.wikimedia.org/T239421

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571503 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Adjust spacing within components https://gerrit.wikimedia.org/r/571503 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571504 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: The default line-height everywhere is now 1.5 https://gerrit.wikimedia.org/r/571504 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571501 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Align styling of header messages https://gerrit.wikimedia.org/r/571501 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571502 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Remove extra horizontal margins on mobile https://gerrit.wikimedia.org/r/571502 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

gerritbot added a comment. Change 571500 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Change our base color to $wmui-color-base10 https://gerrit.wikimedia.org/r/571500 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

Charlie_WMDE added a comment. We've added a subtast that we should discuss at the next opportunity TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Lydia_Pintscher,