[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lectrician1 removed a parent task: T213803: [Tracking] Request for new constraint types. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel, Lectrician1 Cc: Lectrician1, Michael, Manuel,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lectrician1 added a parent task: T213803: [Tracking] Request for new constraint types. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel, Lectrician1 Cc: Lectrician1, Michael, Manuel, Eihel,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE merged a task: T301533: Add constraint applies to entity type constraint qualifier. Lucas_Werkmeister_WMDE added a subscriber: Lectrician1. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714076 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/extensions/WikibaseQualityConstraints@master] Avoid parsing the same parameters twice Reason: https://gerrit.wikimedia.org/r/714076 TASK DETAIL

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T269724 WORKBOARD

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Addshore reassigned this task from Lucas_Werkmeister_WMDE to Manuel. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel, Addshore Cc: Michael, Manuel, Eihel, Esc3300, MisterSynergy, abian,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael removed a project: Patch-For-Review. Michael added a comment. The required functionality is now implemented. The remaining open patch will be better

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.22; 2021-09-06). TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Michael, Manuel, Eihel,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 715002 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Unify terminology around allowed/valid types https://gerrit.wikimedia.org/r/715002 TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714075 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add constraint scope for entity types https://gerrit.wikimedia.org/r/714075 TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714074 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterParser mappings into methods https://gerrit.wikimedia.org/r/714074 TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714073 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add ConstraintParameterParser::mapItemId() helper https://gerrit.wikimedia.org/r/714073 TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714072 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add ConstraintParameterParser::parseItemIdsParameter() helper https://gerrit.wikimedia.org/r/714072 TASK DETAIL https://phabricator.wikimedia.org/T269724

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 713888 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Introduce ConstraintChecker::getSupportedEntityTypes() https://gerrit.wikimedia.org/r/713888 TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. Another to fix: The property scope constraint for ALA-LC romanisation should be split, with "main value" for forms and "qualifier" for items. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 715002 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Unify terminology around allowed/valid types https://gerrit.wikimedia.org/r/715002

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. Another one to fix once the constraint is available: The property scope constraint for pronunciation variety should be split into two, with "qualifier" for item and form, and "main value" for mediainfo. TASK DETAIL

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714076 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Avoid parsing the same parameters twice https://gerrit.wikimedia.org/r/714076 TASK

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714075 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add constraint scope for entity types https://gerrit.wikimedia.org/r/714075 TASK

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714074 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterParser mappings into methods

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714073 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add ConstraintParameterParser::mapItemId() helper

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 714072 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add ConstraintParameterParser::parseItemIdsParameter() helper

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Michael, Manuel, Eihel, Esc3300, MisterSynergy, abian,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

gerritbot added a comment. Change 713888 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Introduce ConstraintChecker::getSupportedEntityTypes()

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T269724 WORKBOARD

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Michael removed Michael as the assignee of this task. Michael moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T269724 WORKBOARD

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Michael claimed this task. Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T269724 WORKBOARD

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Addshore moved this task from Prioritized Product (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Addshore set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Manuel, Eihel, Esc3300, MisterSynergy, abian, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: Manuel, Eihel, Esc3300, MisterSynergy, abian, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Nikki,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Manuel, Eihel, Esc3300, MisterSynergy, abian, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Manuel, Eihel, Esc3300, MisterSynergy, abian, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Manuel added a comment. Thank you, Lucas, let's make it so! TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: Manuel, Eihel, Esc3300, MisterSynergy, abian, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE added a comment. > Should we reuse the scope parameter? I guess one solution to this would be that we implement this parameter with a separate configuration variable, for a second property ID, but then use the same property ID as for the existing scope parameter

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Manuel Cc: Eihel, Esc3300, MisterSynergy, abian, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Nikki, Aklapper,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Eihel added a comment. Same problem for "allowed entity types constraint (Q52004125)" : "Wikibase MediaInfo (Q59712033)" which is reported on Commons. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Esc3300, MisterSynergy, abian, Lydia_Pintscher, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Esc3300 added a comment. I think it's an error to use Wikidata constraints for Commons as such. Constraints are defined for Wikidata, not any possible other Wikibase using Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. sponsor had an "item requires statement" constraint which should only apply to items, not media files. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. And another: reading pattern of Han character should be qualifier on items and main value on forms, not main value or qualifier everywhere. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. And the next one: transliteration has some constraints for what type of items it can be used on. Those constraints apply to usage on items and do not make sense applied to lexemes. Since I

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. Next example: Pinyin transliteration should have a property scope of qualifier on items and lexemes and main property on forms. Since we can't do that, it now says the scope is main property or qualifier everywhere.

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Nikki Cc: abian, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Nikki, Aklapper, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

abian added a comment. In T269724#6711904 , @Nikki wrote: > I can't take the credit for the task description, that's Lydia's work. :) What a shame, what a disappointment… > I don't think it would be a good idea to split this

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. In T269724#6684661 , @abian wrote: > I understand the motivation (thanks to the fact that Nikki's tasks are much more interesting and better described than mine), :-) I can't take the credit for the task

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

abian added a comment. I understand the motivation (thanks to the fact that Nikki's tasks are much more interesting and better described than mine), :-) but I believe we should strive to contain the complexity of the constraint system and, if possible, reduce the current complexity, which

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE added a comment. In T269724#6678791 , @Nikki wrote: >> Should we reuse the scope parameter? > > That would make sense to me since they both cover where to check run the checks, but it might also make it harder

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki added a comment. > Should we exclude certain entity types or include? So should we have a allow or deny list? I would prefer listing the types where the constraint //should// be checked, which also matches how constraint scope works right now. > Should we reuse the scope

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher added a subscriber: abian. Lydia_Pintscher added a comment. Would love to hear people's thoughts on the open questions in the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher removed a parent task: T213803: [Tracking] Request for new constraint types. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Nikki, Aklapper, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher added a comment. Ah good point. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Nikki, Aklapper, Akuckartz,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lucas_Werkmeister_WMDE, Nikki, Aklapper, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE added a comment. I don’t think this belongs under T213803: [Tracking] Request for new constraint types – it’s not really a new constraint type, but rather a new kind of constraint metadata (closest to constraint scope

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lydia_Pintscher added a parent task: T213803: [Tracking] Request for new constraint types. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Nikki, Aklapper, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Lucas_Werkmeister_WMDE added a project: Wikibase-Quality-Constraints. TASK DETAIL https://phabricator.wikimedia.org/T269724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Nikki, Aklapper, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T269724: Allow restricting constraints to certain entity types

Nikki created this task. Nikki added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION e.g. https://www.wikidata.org/wiki/Property:P443#P443$8116725c-4f59-8b08-31bc-99eeb5dd52df should be checked on items but not on lexemes TASK DETAIL