[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 803918 **merged** by jenkins-bot: [mediawiki/core@master] Revert "phpunit: Default to vendor/bin/phpunit, remove suites.xml" https://gerrit.wikimedia.org/r/803918 TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 803918 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Revert "phpunit: Default to vendor/bin/phpunit, remove suites.xml" https://gerrit.wikimedia.org/r/803918 TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

kostajh added a comment. In T310255#7991842 , @kostajh wrote: > In T310255#7991676 , @Lucas_Werkmeister_WMDE wrote: > >> Wait, no. `ApiStructureTest` isn’t a unit test, it’s an

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

kostajh added a comment. Let's see if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804319 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/804283 work, otherwise we should revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/741970 (cc @Krinkle). TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 804319 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan): [mediawiki/core@master] DevelopmentSettings: Set CentralAuthDatabase to main DB name https://gerrit.wikimedia.org/r/804319 TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 804305 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan): [mediawiki/core@master] phpunit: Temporary revert entrypoint to phpunit.php https://gerrit.wikimedia.org/r/804305 TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

kostajh added a comment. In T310255#7991664 , @Lucas_Werkmeister_WMDE wrote: > In T310255#7991620 , @gerritbot wrote: > >> Change 804283 had a related patch set uploaded (by Lucas

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

kostajh added a comment. In T310255#7991676 , @Lucas_Werkmeister_WMDE wrote: > Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test already, both by location (`tests/phpunit/structure/`) and type (`extends

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Nikerabbit added subscribers: ngkountas, Nikerabbit. Nikerabbit added a comment. We also observed the ApiStructureTest failure for ContentTranslation. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a comment. Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test already, both by location (`tests/phpunit/structure/`) and type (`extends MediaWikiIntegrationTestCase`). But I guess the data providers are evaluated before the

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a comment. In T310255#7991620 , @gerritbot wrote: > Change 804283 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): > >

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a comment. Prior to 7238dff532 , that test produces the following error: Premature access to service container [Called from wfGetDB in

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a comment. > I think we’re now running anything that claims to be a unit test against the real database of the wiki Confirmed: name=tests/phpunit/unit/includes/LucasTest.php selectRow( 'recentchanges',

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 804283 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to integration tests https://gerrit.wikimedia.org/r/804283 TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

kostajh added a comment. In T310255#7991592 , @Lucas_Werkmeister_WMDE wrote: > Okay, CentralAuth sets up its database in `UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only run by

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 804279 **abandoned** by Kosta Harlan: [mediawiki/extensions/Wikibase@master] ApiFormatReferenceTest: Temporarily disable testInvalidReferenceJson Reason: https://gerrit.wikimedia.org/r/804279 TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a comment. Okay, CentralAuth sets up its database in `UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only run by `MediaWikiIntegrationTestCase::setupTestDB()`. `ApiFormatReferenceTest` and `QuerySearchEntitiesTest` are nominally unit

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a project: MediaWiki-extensions-CentralAuth. Lucas_Werkmeister_WMDE added a comment. Okay, I can reproduce the error with `wfLoadExtension( 'CentralAuth' );` in LocalSettings. If I add `$wgCentralAuthDatabase = $wgDBname;`, then the error message changes:

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Lucas_Werkmeister_WMDE added a comment. I can’t reproduce this yet, `vendor/bin/phpunit extensions/Wikibase/client/tests/phpunit/unit/` works fine for me with latest MediaWiki core and Wikibase… TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt,

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt,

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

gerritbot added a comment. Change 804279 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan): [mediawiki/extensions/Wikibase@master] ApiFormatReferenceTest: Temporarily disable testInvalidReferenceJson https://gerrit.wikimedia.org/r/804279 TASK DETAIL

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

kostajh renamed this task from "Math CI tests fail" to "Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure". kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES