[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Jdforrester-WMF closed this task as "Resolved". Jdforrester-WMF assigned this task to Lucas_Werkmeister_WMDE. Jdforrester-WMF added a comment. Thank you! TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Stashbot added a comment. Mentioned in SAL (#wikimedia-releng) [2024-04-26T18:18:26Z] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code for T360560 T324202 T353161

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1023401 **merged** by jenkins-bot: [integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code https://gerrit.wikimedia.org/r/1023401 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a comment. In T324202#9302370 , @Lucas_Werkmeister_WMDE wrote: > Given that this cache is (AFAICT) used among other things for the term store / formatter cache, where it has a very high absolute hit rate

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1023401 had a related patch set uploaded (by Jforrester; author: Jforrester): [integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code https://gerrit.wikimedia.org/r/1023401 TASK DETAIL

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.3; 2024-04-30); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23). TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1015992 **abandoned** by Jforrester: [mediawiki/extensions/Wikibase@master] Replace deprecated utf8_encode Reason: Removed in other patches, instead. https://gerrit.wikimedia.org/r/1015992 TASK DETAIL

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1019060 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Extract methods from unserialize() https://gerrit.wikimedia.org/r/1019060 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1018958 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Check cached data more thoroughly https://gerrit.wikimedia.org/r/1018958 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1017817 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove double UTF-8 (3/3) https://gerrit.wikimedia.org/r/1017817 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1020229 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove double UTF-8 (2/3) https://gerrit.wikimedia.org/r/1020229 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.2; 2024-04-23); removed MW-1.43-notes (1.43.0-wmf.1; 2024-04-16). TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1020229 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove double UTF-8 (2/3) https://gerrit.wikimedia.org/r/1020229 TASK

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1017816 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove double UTF-8 (2/3) https://gerrit.wikimedia.org/r/1017816 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1019175 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove double UTF-8 (1/3) https://gerrit.wikimedia.org/r/1019175 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1019175 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove double UTF-8 (1/3) https://gerrit.wikimedia.org/r/1019175 TASK

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16). TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ArthurTaylor removed ArthurTaylor as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1017815 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove double UTF-8 (1/3) https://gerrit.wikimedia.org/r/1017815 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1019060 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Extract methods from unserialize() https://gerrit.wikimedia.org/r/1019060

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1018958 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Check cached data more thoroughly https://gerrit.wikimedia.org/r/1018958

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ArthurTaylor claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T324202 WORKBOARD

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1017817 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove double UTF-8 (3/3) https://gerrit.wikimedia.org/r/1017817 TASK

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1017816 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove double UTF-8 (2/3) https://gerrit.wikimedia.org/r/1017816 TASK

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1017815 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove double UTF-8 (1/3) https://gerrit.wikimedia.org/r/1017815 TASK

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a comment. > I’m pretty sure this use of the functions is pointless (though “correct” in that the methods perform their inverse operations). MediaWiki sets `mb_internal_encoding( 'UTF-8' );` early in `Setup.php` (since T137509

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change #1015992 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Fomafix): [mediawiki/extensions/Wikibase@master] Replace deprecated utf8_encode https://gerrit.wikimedia.org/r/1015992 TASK DETAIL

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team; removed [DEPRECATED] wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Jdforrester-WMF,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | Notes | | --- | |

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Jdforrester-WMF added a comment. Thank you hugely, @thiemowmde! TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26). TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change 983300 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Replace utf8_decode with mb_convert_encoding https://gerrit.wikimedia.org/r/983300 TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Jdforrester-WMF added a parent task: T360560: Make PHP 8.2 voting on development branch of Wikibase. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: Jdforrester-WMF,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Jdforrester-WMF added a comment. Would it be possible to expedite this fix, please? It's blocking CI (and the MediaWiki support for) PHP 8.2 generally. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

WMDE-leszek added a comment. Very bad choice of words in the argumentation, my apologies. What I attempted to mean is that I'd encourage to compare both the cost of adding some additional logic to some low level code (and for how long? for a day or long-term?) as well as the "operational"

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a comment. In T324202#9419893 , @WMDE-leszek wrote: > Finally, I'd like to address the above remarks of possibly introducing some fallback cache key generation algorithm to not change keys while changing the

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

WMDE-leszek added a comment. As I was explicitly called out, a few answers, plus an opinion at the end. > The weird code was added in patchset 20 in July 2018, apparently by @WMDE-leszek:

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

gerritbot added a comment. Change 983300 had a related patch set uploaded (by Ollie Shotton; author: Paladox): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Replace utf8_decode with mb_convert_encoding https://gerrit.wikimedia.org/r/983300 TASK DETAIL

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

thiemowmde added a subscriber: WMDE-leszek. thiemowmde added a comment. Oh, got it. It's the wrong way around. The weird code was added in patchset 20 in July 2018, apparently by @WMDE-leszek:

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a comment. In T324202#9410163 , @thiemowmde wrote: >> though “correct” in that the methods perform their inverse operations […] we’re just putting JSONified mojibake in the inner cache. > > The

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

thiemowmde added a comment. > though “correct” in that the methods perform their inverse operations […] we’re just putting JSONified mojibake in the inner cache. The `utf8_decode` documentation says "UTF-8 characters which do not exist in ISO-8859-1 (that is, code points above U+00FF)

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ItamarWMDE added a project: Wikibase Product Platform Team WPP. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

ItamarWMDE added a comment. Yeah, I think since this change is a bit more global to Wikibase than just affecting Wikidata.org, then #wikibase_product_platform_team_wpp should probably take a look at this. So

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a comment. Note: the practical impact of this issue is that any Wikibase developer on PHP 8.2 will need to disable deprecation warnings on their wiki (I use `error_reporting( E_ALL & ~E_DEPRECATED ); // T324202`). In Wikidata team prioritization terms, I’d say

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE added a project: wmde-wikidata-tech. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Umherirrender, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: PHP 8.2 support, Wikidata, wdwb-tech. TASK DESCRIPTION `utf8_encode()` and `utf8_decode()` are deprecated in PHP 8.2, because their names are quite misleading (RFC