[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

2023-10-02 Thread sbassett
sbassett added a comment. In T340201#9213154 , @Reedy wrote: > I'm curious how we can track issues found by this... > > Just xref this task in the description? We could subtask them under this task. Or sure, cross-ref this task

[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

2023-09-30 Thread Reedy
Reedy added a comment. I'm curious how we can track issues found by this... Just xref this task in the description? TASK DETAIL https://phabricator.wikimedia.org/T340201 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

2023-09-30 Thread Bawolff
Bawolff added a comment. Creating T347787 to brainstorm ideas about the Pager class hierarchy. I didn't create a brainstorming one for LogFormatter, as that case seems pretty hopeless. TASK DETAIL https://phabricator.wikimedia.org/T340201 EMAIL

[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

2023-09-29 Thread Daimona
Daimona added a comment. In T340201#9211976 , @Bawolff wrote: > - mustache templates Yup, that would be T199397 . I'm not sure how feasible that would be. > Maybe we should think

[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

2023-09-29 Thread Bawolff
Bawolff added a comment. This also seems to be really demonstrating the value of phan taint check. So far it seems like most of the found issues are in some corner that phan-taint-check can't analyze - mustache templates (+ some skin stuff which I didn't look too closely at. Not sure

[Wikidata-bugs] [Maniphest] T340201: Use custom language code to find i18n XSS issues

2023-09-29 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T340201 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Bawolff, Daimona, Nikerabbit, Jdforrester-WMF, Fomafix,