[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Bugreporter added a comment. In T65632#9008027 , @hoo wrote: > Note: Given this moves the edit filters to be run much later, right before the edit happens, this might cause a regression similar to T232620

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

hoo added a comment. The above patch wont help solving in case of inspecting past edits, though… this will only help for actual submissions (and probably not all of them, we would need to audit all places using `MediaWikiEditFilterHookRunner`). TASK DETAIL

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

hoo added a comment. The problem here is that Wikibase calls the `EditFilterMergedContent` hook before preparing the actual update, thus the `WikiPage` wont have a `PageUpdater` available (besides the `WikiPage` not being passed on to the new context). The following, //**extremely

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Isabelladantes1983, Themindcoder,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 932225 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler): [mediawiki/core@master] EXPERIMENT: Introduce EditFilterOutcomeHook https://gerrit.wikimedia.org/r/932225 TASK DETAIL https://phabricator.wikimedia.org/T65632

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 930939 **abandoned** by Ladsgroup: [mediawiki/extensions/Wikibase@master] EditEntity: Pass around WikiPage in MediawikiEditFilterHookRunner Reason: https://gerrit.wikimedia.org/r/930939 TASK DETAIL

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Ladsgroup added a comment. That didn't work in mwdebug and from what I'm seeing we need to set WikiPage in the context somewhere being passed around from ModifyEntity -> EntitySavingHelper -> MediaWikiEditEntityFactory -> MediaWikiEditEntity -> MediaWikiEditFilterHookRunner. But can't

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 930939 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] EditEntity: Pass around WikiPage in MediawikiEditFilterHookRunner https://gerrit.wikimedia.org/r/930939 TASK DETAIL

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Ladsgroup added a comment. @daniel might have some opinions on this. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Daimona added a comment. In T65632#8945234 , @matej_suchanek wrote: > I suspect MediawikiEditFilterHookRunner::getContextForEditFilter

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Ladsgroup added a comment. In T65632#8945234 , @matej_suchanek wrote: > I suspect MediawikiEditFilterHookRunner::getContextForEditFilter

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

matej_suchanek added a comment. I suspect MediawikiEditFilterHookRunner::getContextForEditFilter does not carry over the

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

matej_suchanek added a comment. In my test environment, it logs: my_wiki: Loading all_links from DB my_wiki: Loading old_links from DB This is wrong, and it also means the `PreparedUpdate` is not available because `Wikimedia\Assert\PreconditionException` is thrown where we

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Ladsgroup added a comment. This is blocking deployment of T337431: Rework MediaWiki:SpamBlacklist on wikidata and commons. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Ladsgroup added a comment. In T65632#8927795 , @matej_suchanek wrote: > Fixed for live edits but not for the "examine past edits" feature. I'm not sure it's fixed. Maybe I'm missing something,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-06-13T18:44:55Z] Finished scap: Backport for [[gerrit:929657|Retrieve external links from PreparedUpdate (T65632 T264104 )]]

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-06-13T18:34:10Z] ladsgroup: Backport for [[gerrit:929657|Retrieve external links from PreparedUpdate (T65632 T264104 )]] synced to

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-06-13T18:32:36Z] Started scap: Backport for [[gerrit:929657|Retrieve external links from PreparedUpdate (T65632 T264104 )]] TASK

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 929657 **merged** by jenkins-bot: [mediawiki/extensions/AbuseFilter@wmf/1.41.0-wmf.13] Retrieve external links from PreparedUpdate https://gerrit.wikimedia.org/r/929657 TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Isabelladantes1983, Themindcoder,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 929657 had a related patch set uploaded (by Ladsgroup; author: Matěj Suchánek): [mediawiki/extensions/AbuseFilter@wmf/1.41.0-wmf.13] Retrieve external links from PreparedUpdate https://gerrit.wikimedia.org/r/929657 TASK DETAIL

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

matej_suchanek changed the task status from "In Progress" to "Open". matej_suchanek removed matej_suchanek as the assignee of this task. matej_suchanek added a comment. Fixed for live edits but not for the "examine past edits" feature. This should not impact Wikidata since the only four

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek, Maintenance_bot Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 819484 **merged** by jenkins-bot: [mediawiki/extensions/AbuseFilter@master] Retrieve external links from PreparedUpdate https://gerrit.wikimedia.org/r/819484 TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

matej_suchanek changed the task status from "Open" to "In Progress". matej_suchanek claimed this task. matej_suchanek changed the subtype of this task from "Task" to "Bug Report". TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Hellket777, Astuthiodit_1, 786,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

gerritbot added a comment. Change 819484 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek): [mediawiki/extensions/AbuseFilter@master] Retrieve external links from PreparedUpdate https://gerrit.wikimedia.org/r/819484 TASK DETAIL

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Bugreporter removed a parent task: T76230: [Epic] data quality and trust. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bugreporter Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

Lydia_Pintscher added a project: Wikidata data quality and trust. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo,

[Wikidata-bugs] [Maniphest] T65632: AbuseFilter *_links variables incorrect on item edits.

matej_suchanek added a comment. Examples can still be seen in this abuse log . I think T242249 has brought this closer to fixing. T264104