[Wikidata-bugs] [Maniphest] [Assigned] T185597: Allow bureaucrats to add/remove 'accountcreator' permission on Wikidata
Urbanecm assigned this task to Jayprakash12345.Urbanecm added a project: User-Urbanecm.Urbanecm added a comment. You're still author of this patch, however, I'll add it to my SWAT plan at Monday (14:00-15:00 UTC, as usual).TASK DETAILhttps://phabricator.wikimedia.org/T185597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jayprakash12345, UrbanecmCc: Urbanecm, Jayprakash12345, Rschen7754, TerraCodes, gerritbot, Aklapper, Pasleim, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, DatGuy, Devwaker, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T185738: Certain entries/pages on Wiktionaries lack their corresponding links to el.wiktionary
Aklapper renamed this task from "el.wiktionary and wikidata" to "Certain entries/pages on Wiktionaries lack their corresponding links to el.wiktionary".Aklapper added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T185738EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Xoristzatziki, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unassigned] T185597: Allow bureaucrats to add/remove 'accountcreator' permission on Wikidata
Jayprakash12345 removed Jayprakash12345 as the assignee of this task.Jayprakash12345 added a comment. Due to I have no connectivity in my area. Please, Anyone, try to deploy it.TASK DETAILhttps://phabricator.wikimedia.org/T185597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jayprakash12345Cc: Jayprakash12345, Rschen7754, TerraCodes, gerritbot, Aklapper, Pasleim, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164735: Move data retrieval/access services to Data Access component
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T164735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, thiemowmde, Aleksey_WMDE, Jonas, aude, Lydia_Pintscher, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164735: Move data retrieval/access services to Data Access component
gerritbot added a comment. Change 406259 had a related patch set uploaded (by Samwilson; owner: Samwilson): [mediawiki/extensions/ProofreadPage@master] Convert the quality radio buttons to OOUI https://gerrit.wikimedia.org/r/406259TASK DETAILhttps://phabricator.wikimedia.org/T164735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, thiemowmde, Aleksey_WMDE, Jonas, aude, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema
Legoktm added a comment. No, I don't think we're generating the composer autoloader...we should probably just switch this to MediaWiki's PSR-4 autoloader instead.TASK DETAILhttps://phabricator.wikimedia.org/T185609EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Umherirrender, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description
daniel added a comment. We're still talking about when that switch will happen -- the current plan is to switch when there are non-blank descriptions on 2 million article pages. That might happen quickly, or it might take a long time, depending on how the community chooses to use the magic word. We are encouraging data duplication now? That seems like a bad idea. This ticket doesn't say how it is motivated. My understanding is that it's about Wikipedia editors wanting more control over the data, to prevent vandalism. To allow this, I'd propose the following: expose the short description (and perhaps also the label) on desktop page views. This is trivial enough, the only question is where to show it. to do that, the description (and labels) need to be recorded in the ParserOutput. This can be done by hooking into the parsing process. If the magic word is present, record the description from that. If not, pull the description from wikidata, and record that, and track that usage via wikidata usage tracking. This way, changes to the descriptions will show up on recentchanges/watchlists, so the community can patrol them. They also become visible to desktop users, so vandalism can be detected. And it's still possible to override the description from wikidata, if desired. I think this would provide the community with the necessary tools to have control of the content, without the need of duplicating millions of descriptions just so edits show up in watchlists. The integration of Wikidata with local workflows on Wikipedia isn't optimal right now. I think we should fix that by improving that integration, not by removing it.TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: TheDJ, daniel, Bmueller, Addshore, Lydia_Pintscher, Samwilson, Aklapper, DannyH, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, B20180, Nakon, MusikAnimal, Niharika, Fhocutt, Wikidata-bugs, aude, Ricordisamoa, -jem-, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178712: Support continuation for WDQS MWAPI
gerritbot added a comment. Change 406241 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [wikidata/query/rdf@master] Support continuations in MWAPI https://gerrit.wikimedia.org/r/406241TASK DETAILhttps://phabricator.wikimedia.org/T178712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jarekt, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T178712: Support continuation for WDQS MWAPI
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T178712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jarekt, Aklapper, Smalyshev, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T94948: Wikibase API doesn't document valid wbptterms parameter to pageterms query module, or behavior if they're omitted
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T94948EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Spage, gerritbotCc: gerritbot, Aklapper, Spage, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T94948: Wikibase API doesn't document valid wbptterms parameter to pageterms query module, or behavior if they're omitted
gerritbot added a comment. Change 406240 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski): [mediawiki/extensions/Wikibase@master] Doc: pageterms query response type for wbptterms https://gerrit.wikimedia.org/r/406240TASK DETAILhttps://phabricator.wikimedia.org/T94948EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Spage, gerritbotCc: gerritbot, Aklapper, Spage, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T131896: CommonsMetadata should consider an image non-free if any of the license metadata blocks is nonfree
TheDJ added a comment. Only just notice this is fixed. Thx @MarkTraceur !!TASK DETAILhttps://phabricator.wikimedia.org/T131896EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarkTraceur, TheDJCc: TheDJ, MarkTraceur, Capt_Swing, SandraF_WMF, Ramsey-WMF, Jdrewniak, dr0ptp4kt, Fako85, Xaosflux, gerritbot, Ricordisamoa, Aklapper, Steinsplitter, Tgr, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Cparle, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Bawolff, Lydia_Pintscher, Fabrice_Florin, Raymond, Matanya, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema
Umherirrender added a comment. Is that a composer unit test run? The extension is using psr4-autoloader of composer.json (with require_once __DIR__ . '/vendor/autoload.php'; in the entry point)TASK DETAILhttps://phabricator.wikimedia.org/T185609EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UmherirrenderCc: Umherirrender, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T185709: Cache CheckResult serializations per-entity in ObjectCache
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- introduce message class: T185710 - make `Constraint` serializable: T185711 - make `Context` serializable: T185712 - make `Status` serializable: T185713 - make `CheckResult` serializable: T185714 - update `CachingResultsBuilder` (not sure what will be necessary here – if current caching is already enabled on Wikidata, we might need to support a hybrid mode for a while)TASK DETAILhttps://phabricator.wikimedia.org/T185709EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185714: Make CheckResult serializable
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONOnce all the components of a CheckResult are serializable (we can probably ignore the parameters, they’re only used on the special page), we need to be able to serialize and deserialize CheckResults themselves.TASK DETAILhttps://phabricator.wikimedia.org/T185714EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185713: Make CheckResult status serializable
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONThe status of a CheckResult is a simple string, but we can reduce the size of the cached value by storing an abbreviated version. Right now it seems like taking the initial letter is actually unambiguous, so that should do fine.TASK DETAILhttps://phabricator.wikimedia.org/T185713EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185712: Make Context serializable
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONFor T185709: Cache CheckResult serializations per-entity in ObjectCache, we need to be able to serialize and deserialize Contexts, so that they can afterwards be used to store the deserialized CheckResults into an array again. I assume this will have to be specific for the three context types we support, and each of them will serialize the data it needs, and then there’ll be some code somewhere that delegates to the correct one of the three subclasses for deserialization. I’m not sure how this would look – non-static serialize and static deserialize methods on Context and its subclasses? Or should it be a separate kind of ContextSerialization service? I think my colleagues know more about this than me, there’s a lot of serialization going on in Wikibase ;)TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185711: Make Constraint serializable
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONFor T185709: Cache CheckResult serializations per-entity in ObjectCache, we need to be able to serialize and deserialize Constraint objects. Shouldn’t be difficult, they’re pure value objects (constraint ID, property ID, constraint type ID, parameters). The only question is whether to serialize the parameters or not. They’re large and we won’t use them at all, so I definitely don’t want them in the cache. Should it be configurable whether they’re serialized or not, or do we just never serialize them?TASK DETAILhttps://phabricator.wikimedia.org/T185711EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages
Lucas_Werkmeister_WMDE added a comment. Suggested names: ViolationMessage and ViolationMessageRenderer. (Non-violations simply have a null message – we currently use '' for those, anyways.) But that’s slightly inaccurate because bad-parameters results aren’t strictly speaking violations… any better ideas?TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185710: Introduce class for constraint violation messages
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONFor T185709: Cache CheckResult serializations per-entity in ObjectCache, we cannot just store Message objects – the parameters which we pass to our messages contain entity labels, which are already language-specific. We need something more at the ConstraintParameterRenderer level: a message object with parameter types like “string”, “entity ID”, “list of item IDs”. Only when the message is finally rendered do we pass those parameters into, say, an $entityIdLabelFormatter. This also means one less object to inject into all checkers: the checkers will instantiate such a message, which is a pure value object, and the task of rendering it is then delayed until the CheckConstraints API or SpecialConstraintReport, which means that the checkers no longer need a ConstraintParameterRenderer.TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185709: Cache CheckResult serializations per-entity in ObjectCache
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONCurrently, we cache almost the full wbcheckconstraints response (T181060). This means that we have to cache the response separately for each language, since it contains rendered messages in the user’s language. Instead, we should store some serialized form of the CheckResult objects, which should contain message objects, not rendered strings. We can then render the messages only after getting the response from the cache, so we can reuse the same cached results for all languages. One additional benefit is that we don’t need to cache the NullResults which we generate (cf. T178160), which should also save a lot of space in the cached value (given that we expect the average entity to yield few actual results that we would cache). This also means that we can store results from any request whose status parameter is a superset of the three “interesting” statuses violation|warning|parameter, and return cached results for any request whose status parameter is a subset of them, instead of requiring an exact match. (Currently, we require an exact match because removing CheckResult arrays from the response structure is difficult.) Preliminary breakdown: introduce message class make Constraint serializable make Context serializable make Status serializable make CheckResult serializable update CachingResultsBuilder (not sure what will be necessary here – if current caching is already enabled on Wikidata, we might need to support a hybrid mode for a while) TASK DETAILhttps://phabricator.wikimedia.org/T185709EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185693: Implement a (more liberal) usage aspect deduplicater
daniel added a comment. I think we need different limits for different aspects. 10 may be sensible for statements, but it's way too low for languages.TASK DETAILhttps://phabricator.wikimedia.org/T185693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: Lucas_Werkmeister_WMDE, gerritbot, eranroz, hoo, daniel, Lydia_Pintscher, aude, Aklapper, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T185693: Implement a (more liberal) usage aspect deduplicater
Ladsgroup claimed this task.Ladsgroup added a project: Wikidata-Sprint-2018-01-17.Herald added a project: User-Ladsgroup. TASK DETAILhttps://phabricator.wikimedia.org/T185693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, eranroz, hoo, daniel, Lydia_Pintscher, aude, Aklapper, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185693: Implement a (more liberal) usage aspect deduplicater
gerritbot added a comment. Change 406181 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Turn to a general aspect if too many modifiers have been used https://gerrit.wikimedia.org/r/406181TASK DETAILhttps://phabricator.wikimedia.org/T185693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, eranroz, hoo, daniel, Lydia_Pintscher, aude, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T185693: Implement a (more liberal) usage aspect deduplicater
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, eranroz, hoo, daniel, Lydia_Pintscher, aude, Aklapper, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185689: Add language to cache key for check results
gerritbot added a comment. Change 406179 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Include user language in cache key https://gerrit.wikimedia.org/r/406179TASK DETAILhttps://phabricator.wikimedia.org/T185689EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T185689: Add language to cache key for check results
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185689EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T184908: Pulling and building of the image leads to error messages
Andrawaag closed this task as "Resolved".Andrawaag added a comment. Yes works smoothly.TASK DETAILhttps://phabricator.wikimedia.org/T184908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, AndrawaagCc: Abbe98, Lydia_Pintscher, Addshore, Andrawaag, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T184025: Default deletion log for Wikidata items doesn't include label
Ladsgroup claimed this task.Ladsgroup added a project: Wikidata-Sprint-2018-01-17.Herald added a project: User-Ladsgroup. TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, Ladsgroup, Lucas_Werkmeister_WMDE, Anomie, daniel, MisterSynergy, Izno, Sjoerddebruin, Yair_rand, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T184025: Default deletion log for Wikidata items doesn't include label
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ladsgroup, Lucas_Werkmeister_WMDE, Anomie, daniel, MisterSynergy, Izno, Sjoerddebruin, Yair_rand, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T184025: Default deletion log for Wikidata items doesn't include label
gerritbot added a comment. Change 406174 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Improve EntityContent::getTextForSummary() https://gerrit.wikimedia.org/r/406174TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ladsgroup, Lucas_Werkmeister_WMDE, Anomie, daniel, MisterSynergy, Izno, Sjoerddebruin, Yair_rand, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T175566: Check “single value” and “multi value” constraints on qualifiers and references
gerritbot added a comment. Change 405875 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed Statements from Multi/SingleValueChecker tests https://gerrit.wikimedia.org/r/405875TASK DETAILhttps://phabricator.wikimedia.org/T175566EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T185689: Add language to cache key for check results
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-17. TASK DETAILhttps://phabricator.wikimedia.org/T185689EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)). TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, ReleaseTaggerBotCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T184025: Default deletion log for Wikidata items doesn't include label
Ladsgroup added a comment. I love this bug, let me take a lookTASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lucas_Werkmeister_WMDE, Anomie, daniel, MisterSynergy, Izno, Sjoerddebruin, Yair_rand, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T185696: Change default scope of “distinct values” constraint to main snak only
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONPer [community discussion](https://www.wikidata.org/wiki/Wikidata:Project_chat#Format_of_references_referring_to_an_external_database_and_distinct_values_constraint), we probably want to change the default scope of `UniqueValuesChecker` to only `Context::TYPE_STATEMENT`.TASK DETAILhttps://phabricator.wikimedia.org/T185696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-External-Validation, Release-Engineering-Team.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThe post-merge mwext-phpunit-coverage-publish job for the WikibaseQualityExternalValidation seems to fail consistently (example 1, example 2). I’m not sure why – perhaps because the extension isn’t part of the wmf.* deployment branches? If this problem isn’t easy to fix, then perhaps we could just disable coverage builds for this extension again – it’s not deployed and not really under active development at the moment, so I think not having coverage reports for it is acceptable.TASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Liudvikas, Scott_WUaS, Luke081515, abian, Wikidata-bugs, aude, zeljkofilipin, Mbch331, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T185196: Enable CI for wikibase/property-suggester-scripts
Ladsgroup claimed this task.Herald added a project: User-Ladsgroup. TASK DETAILhttps://phabricator.wikimedia.org/T185196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, hashar, Aklapper, aude, PokestarFan, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185696: Change default scope of “distinct values” constraint to main snak only
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONPer community discussion, we probably want to change the default scope of UniqueValuesChecker to only Context::TYPE_STATEMENT.TASK DETAILhttps://phabricator.wikimedia.org/T185696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 405881 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use external username when building RecentChange entry https://gerrit.wikimedia.org/r/405881TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185196: Enable CI for wikibase/property-suggester-scripts
gerritbot added a comment. Change 406170 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [integration/config@master] Enable jenkins on wikibase/property-suggester-scripts https://gerrit.wikimedia.org/r/406170TASK DETAILhttps://phabricator.wikimedia.org/T185196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Aklapper, aude, PokestarFan, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185196: Enable CI for wikibase/property-suggester-scripts
gerritbot added a comment. Change 406169 merged by Thiemo Kreuz (WMDE): [wikibase/property-suggester-scripts@master] Prepare the repo for jenkins https://gerrit.wikimedia.org/r/406169TASK DETAILhttps://phabricator.wikimedia.org/T185196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Aklapper, aude, PokestarFan, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T185196: Enable CI for wikibase/property-suggester-scripts
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Aklapper, aude, PokestarFan, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185196: Enable CI for wikibase/property-suggester-scripts
gerritbot added a comment. Change 406169 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [wikibase/property-suggester-scripts@master] Prepare the repo for jenkins https://gerrit.wikimedia.org/r/406169TASK DETAILhttps://phabricator.wikimedia.org/T185196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Aklapper, aude, PokestarFan, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)
Lucas_Werkmeister_WMDE added a comment. Just to clarify the situation: we do constraint checks any time a user with the checkConstraints gadget enabled visits an entity page, or after they save a statement. A constraint check can involve multiple regex checks: possibly several per statement, and a full constraint check involves all statements of an entity. We already store results of individual regex checks in the WANObjectCache (T173696 – cache hit rate roughly estimated at 30%, see Grafana), and plan to soon cache full check results as well (T181060, T184812). The gadget is currently used by 323 users, 231 of them active, according to Special:GadgetUsage, but we plan to have it enabled for all logged-in users by 2018-04-04 (T184069).TASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Halfak, Anomie, Smalyshev, tstarling, daniel, GWicke, Joe, Lucas_Werkmeister_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Wikidata validates each newly stored statements against the constraints from the associated property. The properties themselveconstraints are user-generateddefined and one of the possible constraint types for text values is a regex patternTASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Halfak, Anomie, Smalyshev, tstarling, daniel, GWicke, Joe, Lucas_Werkmeister_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185693: Implement a (more liberal) usage aspect deduplicater
Ladsgroup created this task.Ladsgroup triaged this task as "Normal" priority.Ladsgroup added projects: MediaWiki-extensions-WikibaseClient, Wikidata. TASK DESCRIPTIONAfter T178079: Implement a (conservative) usage aspect deduplicater (days: 4) being done it's needed to implement a deduplicator that turn too many usecases of on aspect with modifier to the aspect without modifier. This is helpful in case the lua function is iterating over all languages or properties. For example: C.P1, C.P2, C.P3, C.P4, C.P5, ... -> C The threshold for C, D, and L aspects need to be determined before moving forward.TASK DETAILhttps://phabricator.wikimedia.org/T185693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: eranroz, hoo, daniel, Lydia_Pintscher, aude, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T185688: Constraint check results are cached independent of language
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Alternatively, we could change what we cache: instead of caching essentially the full `wbcheckconstraints` response, cache something closer to a list of `CheckResult` serializations, after changing `CheckResult` to hold a `Message` object instead of a `string`. This also opens up other opportunities: the `wbcheckconstraints` response includes entries even for statements with no violations (cf. T178160), which we can’t remove from the API response, but could remove from the value that we cache. (That is: don’t store `NullResult`s, instead recreate them when reading from cache.) And this will also allow us to store results from requests with a wider `status` parameter in the cache, and use the cache for requests with a narrower parameter, instead of only using the cache if the parameter is exactly `violation|warning|bad-parameters`.TASK DETAILhttps://phabricator.wikimedia.org/T185688EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185689: Add language to cache key for check results
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. TASK DESCRIPTIONQuick-and-dirty solution for T185688: Constraint check results are cached independent of language. I’m confident we can get this done in time for the next MediaWiki train (February 7th), so we can hopefully enable caching shortly after that.TASK DETAILhttps://phabricator.wikimedia.org/T185689EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T178079: Implement a (conservative) usage aspect deduplicater (days: 4)
thiemowmde closed this task as "Resolved".thiemowmde removed a project: Patch-For-Review.thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* `X`, `D.de` → `X`, `D.de` #patch-for-review: [] https://gerrit.wikimedia.org/r/405013 [] https://gerrit.wikimedia.org/r/405895 [] https://gerrit.wikimedia.org/r/405896TASK DETAILhttps://phabricator.wikimedia.org/T178079EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, thiemowmdeCc: gerritbot, Ladsgroup, eranroz, daniel, Lydia_Pintscher, aude, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T49288: [Epic] Track Wikidata entity usage on client pages
thiemowmde closed subtask T178079: Implement a (conservative) usage aspect deduplicater (days: 4) as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T49288EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: PokestarFan, DixonD, Aklapper, Bianjiang, aude, jeremyb, liangent, Wikidata-bugs, greg, Abraham, Legoktm, Tobi_WMDE_SW, Daniel_Mietchen, jayvdb, Micru, Ricordisamoa, MZMcBride, Liuxinyu970226, Ainali, Sannita, Lydia_Pintscher, Eloquence, zhuyifei1999, daniel, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T178079: Implement a (conservative) usage aspect deduplicater (days: 4)
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/405013 [x] https://gerrit.wikimedia.org/r/405895 [x] https://gerrit.wikimedia.org/r/405896TASK DETAILhttps://phabricator.wikimedia.org/T178079EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, thiemowmdeCc: gerritbot, Ladsgroup, eranroz, daniel, Lydia_Pintscher, aude, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T185688: Constraint check results are cached independent of language
Lucas_Werkmeister_WMDE added a parent task: T184812: Enable constraint result caching on Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T185688EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata
Lucas_Werkmeister_WMDE added a subtask: T185688: Constraint check results are cached independent of language. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T185688: Constraint check results are cached independent of language
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "Normal" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality.Herald added a subscriber: Aklapper. TASK DESCRIPTION@Ladsgroup pointed out that we store localized violation messages in the cache, but use the same cache for requests independent of language, so whichever request to miss the cache writes messages in that request’s language to the cache, and all other requests for the same entity then get cached violation messages in the first request’s language instead of their own. The quick-and-dirty fix is to add the language to the cache key. Purging gets slightly tricky (we need to delete the cache entry for all possible languages), but otherwise this is fairly simple. However, caching results independently per-language both bloats the cache (caching effectively the same results several times) and slows down constraint checks for lesser-used languages (since they’re less likely to get cached results). Alternatively, we could change what we cache: instead of caching essentially the full wbcheckconstraints response, cache something closer to a list of CheckResult serializations, after changing CheckResult to hold a Message object instead of a string. This also opens up other opportunities: the wbcheckconstraints response includes entries even for statements with no violations (cf. T178160), which we can’t remove from the API response, but could remove from the value that we cache. (That is: don’t store NullResults, instead recreate them when reading from cache.)TASK DETAILhttps://phabricator.wikimedia.org/T185688EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T185196: Enable CI for wikibase/property-suggester-scripts
Ladsgroup added a comment. Travis is enabled there now: https://travis-ci.org/wikimedia/wikibase-property-suggester-scriptsTASK DETAILhttps://phabricator.wikimedia.org/T185196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: hashar, Aklapper, aude, PokestarFan, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
