[Wikidata-bugs] [Maniphest] [Created] T202032: Duplicate ar_rev_id values in several wikis

2018-08-15 Thread tstarling
tstarling created this task.tstarling triaged this task as "Normal" priority.tstarling added projects: Structured-Data-Commons, Multi-Content-Revisions (MCR Deployment), Core-Platform-Team (CPT-Q1-Jul-Sep-2018).Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONSome wikis have archive tables with duplicate ar_rev_id values. This causes duplicate key errors when running populateContentTables.php.

Analysis

populateArchiveRevId.php allocated rev_id values by inserting a dummy row into the revision table and then deleting it in the same transaction. It's evident from the MariaDB documentation that this is unsafe in MariaDB 10.1. In fact even ordinary article deletion is unsafe in MariaDB 10.1: if the latest revision is deleted, and then the master DB server is restarted, the autoincrement value will be reset to MAX(rev_id)+1 and so new revision creations will reuse the ID supposedly reserved by ar_rev_id.

According to the MySQL documentation, the autoincrement value will be reset to MAX(...)+1 if a row is inserted or updated with a non-null value specified for the autoincrement column. It is unclear whether this is also true for MariaDB.

The affected wikis are: aawikibooks, cawiki, gotwikibooks, kswikiquote, lvwikibooks, nostalgiawiki, wawikibooks and wikimania2005wiki.

Taking aawikibooks as an example:  The deletion log shows that 1749 pages in namespace 8 were deleted in 2007. Another 28 pages were also deleted in 2007.  Then one was deleted in 2008. In 2015, 5 pages were deleted, with 9 revisions.. This is a closed, read-only wiki which has not been edited since 2015. ar_rev_id was apparently introduced in 2005, so none of these archive rows should have had ar_rev_id=NULL, and so none should have been affected by populateContentTables.php. But I can't see how it could have been caused by the original deletion in October 2007, since there are conflicting ar_rev_id values for revisions that would have been in the revision table at the same time.

A list of affected archive rows in aawikibooks:

P7461 aawikibooks ar_rev_id conflicts

Note that ar_id was only introduced in 2012, it's not exactly monotonic with deletion time. Some deletion times:

wikiadmin@10.64.16.191(aawikibooks)> select ar_id,log_timestamp from logging,archive where log_namespace=ar_namespace and log_title=ar_title and ar_id in (29,985,987,1018,1849,92,3204,6569) order by log_timestamp;
+---++
| ar_id | log_timestamp  |
+---++
|29 | 20070108212726 |
|29 | 20070108212726 |
|92 | 20070108212729 |
|92 | 20070108212729 |
|   985 | 20070108212804 |
|   985 | 20070108212804 |
|   987 | 20070108212804 |
|   987 | 20070108212804 |
|  1018 | 20070108212805 |
|  1018 | 20070108212805 |
|  1849 | 20070108212826 |
|  1849 | 20070108212826 |
|  6569 | 20070918192042 |
|  6569 | 20070918192042 |
|  3204 | 20070918192049 |
|  3204 | 20070918192049 |
|  6569 | 20080328185334 |
+---++

In summary, I don't know what happened but it's obviously broken.

The MCR write-both mode, with its unique index on slot_revision_id, should at least prevent conflicting rows from being inserted, although this potentially comes at the cost of throwing an exception on every edit until someone manually advances the autoincrement value for rev_id is advanced beyond MAX(ar_rev_id).

That is to say, if the most recent revision is deleted, and then a master switch is done, all edits would fail until manual action is taken.

Fixing it

In the long term, we will have to stop using ar_rev_id, since evidently we made incorrect assumptions about how DBMSs work. The whole concept of ar_rev_id appears to be invalid.

A quick hack would be to permanently insert a row into the revision table of the affected wikis, with a rev_id specified so as to make room for the extra ar_rev_id values. This wouldn't fix the master switch issue.

When inserting a row into revision, we could do SELECT MAX(ar_rev_id) FROM archive. If the rev_id returned when inserting is less than MAX(ar_rev_id), then we could update the rev_id in the newly-inserted row to some larger value.TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarlingCc: Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 453075 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseMediaInfo@master] Move field definitions to search-field-definitions handler

https://gerrit.wikimedia.org/r/453075TASK DETAILhttps://phabricator.wikimedia.org/T190022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Aleksey_WMDE, thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 453074 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] Move field definitions to search-field-definitions handler

https://gerrit.wikimedia.org/r/453074TASK DETAILhttps://phabricator.wikimedia.org/T190022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Aleksey_WMDE, thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 453067 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Move field definitions to search-field-definitions handler

https://gerrit.wikimedia.org/r/453067TASK DETAILhttps://phabricator.wikimedia.org/T190022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Aleksey_WMDE, thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base

2018-08-15 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T190022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Aleksey_WMDE, thiemowmde, RazShuty, WMDE-leszek, Lydia_Pintscher, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unassigned] T200983: Language fallbacks for referenced Senses in statements

2018-08-15 Thread Ladsgroup
Ladsgroup removed Ladsgroup as the assignee of this task.Ladsgroup moved this task from Doing to To Do on the Wikidata-Senses-Iteration3 board.Ladsgroup added a comment.
I tried but couldn't finish it, someone else can pick this up. (Unlicking the cookie)TASK DETAILhttps://phabricator.wikimedia.org/T200983WORKBOARDhttps://phabricator.wikimedia.org/project/board/3527/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Bugreporter, RazShuty, WMDE-leszek, Addshore, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T178410: Add wikibugs to #wikimedia-commons-sd

2018-08-15 Thread MarcoAurelio
MarcoAurelio renamed this task from "Add wikibugs to   #wikimedia-commons-sd" to "Add wikibugs to #wikimedia-commons-sd".MarcoAurelio triaged this task as "Normal" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T178410EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarcoAurelioCc: gerritbot, MarcoAurelio, Aklapper, SandraF_WMF, Legoktm, Steinsplitter, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Susannaanas, Luke081515, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Mbch331, valhallasw___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T178410: Add wikibugs to #wikimedia-commons-sd

2018-08-15 Thread MarcoAurelio
MarcoAurelio closed this task as "Resolved".MarcoAurelio removed a project: Patch-For-Review.MarcoAurelio claimed this task.MarcoAurelio added a comment.Restricted Application added a project: User-MarcoAurelio.
Deployed.TASK DETAILhttps://phabricator.wikimedia.org/T178410EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarcoAurelioCc: gerritbot, MarcoAurelio, Aklapper, SandraF_WMF, Legoktm, Steinsplitter, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Susannaanas, Luke081515, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Mbch331, valhallasw, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452967 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from f589fe44c27a10e1d071fe056472c1297258c318:

https://gerrit.wikimedia.org/r/452967TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452915 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Replace browser test with integration test

https://gerrit.wikimedia.org/r/452915TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: WMDE-leszek, Deskana, gerritbot, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Addshore, TerraCodes, Liuxinyu970226, Nikerabbit, iamjessklein, marcella, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Necroarcano, Darkminds3113, Bsandipan, Lordiis, Robinma, GoranSMilovanovic, Adik2382, chapulina, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Wess, Nizil, Srdjan_m, Ixocactus, Jrf, Husun1297, Wikidata-bugs, aude, Amire80, Swainr, Jsahleen, Darkdadaah, Arrbee, santhosh, KartikMistry, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452967 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from f589fe44c27a10e1d071fe056472c1297258c318:

https://gerrit.wikimedia.org/r/452967TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452929 merged by jenkins-bot:
[wikidata/query/gui@master] Add query totals to right toolbar

https://gerrit.wikimedia.org/r/452929TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-15 Thread Smalyshev
Smalyshev added a comment.
Since it's external query, the target server may know what foaf: is. And in any case, even if query syntax doesn't parse, it should not break the GUI.

The 404 may be separate problem, as I am seeing it on other queries too.TASK DETAILhttps://phabricator.wikimedia.org/T201950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, prssanna, Jonas, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452963 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from c23e1d2b6ce8a4a443c219fb91f946265606f175:

https://gerrit.wikimedia.org/r/452963TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452963 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from c23e1d2b6ce8a4a443c219fb91f946265606f175:

https://gerrit.wikimedia.org/r/452963TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452928 merged by jenkins-bot:
[wikidata/query/gui@master] Only show toolbar when mouse moves

https://gerrit.wikimedia.org/r/452928TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-08-15 Thread Niedzielski
Niedzielski added a comment.
The latest Barack Obama CSS size graph:

F24976898: grafana.wikimedia.org_dashboard_db_mobile-2g_panelId=90=1.pngTASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc: WMDE-leszek, Agabi10, gerritbot, Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Vali.matei, Salgo60, Lewizho99, JJMC89, Maathavan, Debenben, Jonas, Bianjiang, Izno, Nirmos, Cwek, Wikidata-bugs, Hydriz, aude, fredw, Pkra, Dinoguy1000, Lydia_Pintscher, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199884: Support haswbstatement in other properties

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452956 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[operations/mediawiki-config@master] Switch item/property type indexing from opt-in to opt-out

https://gerrit.wikimedia.org/r/452956TASK DETAILhttps://phabricator.wikimedia.org/T199884EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, MichaelSchoenitzer, debt, Smalyshev, matej_suchanek, Aklapper, Bugreporter, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T199884: Support haswbstatement in other properties

2018-08-15 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T199884EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, MichaelSchoenitzer, debt, Smalyshev, matej_suchanek, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment.
https://gerrit.wikimedia.org/r/452927 and https://gerrit.wikimedia.org/r/452946 were created in the wake of this.TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T196882: Create a code abstraction for "display entity link" use-case

2018-08-15 Thread Aleksey_WMDE
Aleksey_WMDE moved this task from Peer Review to Doing on the Wikidata-Ugly-Cat-Trailblaze (wb_terms trail blazing) board.Aleksey_WMDE added a comment.
Found the problem with current solution.

lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:142

if ( $row && $row->page_latest && !$row->page_is_redirect ) {
	return (int)$row->page_latest;
}

return false;

That means that we don't get correct revision ID if the target entity is redirect.
That leads to invalid cache record (or Exception being thrown if the patch 452931 is merged) and essentially means that the code is not production ready.

It still can be deployed as soon as this code is disabled using configuration value.TASK DETAILhttps://phabricator.wikimedia.org/T196882WORKBOARDhttps://phabricator.wikimedia.org/project/board/3407/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, gerritbot, Aleksey_WMDE, WMDE-leszek, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196882: Create a code abstraction for "display entity link" use-case

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452931 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Add internal assertions to ensure the code works correctly

https://gerrit.wikimedia.org/r/452931TASK DETAILhttps://phabricator.wikimedia.org/T196882EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Aklapper, gerritbot, Aleksey_WMDE, WMDE-leszek, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Salgo60
Salgo60 added a comment.
Thanks let me know if I should test something.TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Salgo60Cc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T147169: Make sure Wikibase dump maintenance scripts solely use the "dump" db group

2018-08-15 Thread hoo
hoo added a comment.

In T147169#4498457, @jcrespo wrote:
No need to be sorry, could this be a load balancer bug?


I just looked into this briefly and skimmed all (seemingly) relevant code paths… I still have no idea how this could happen (also these errors don't seem to be on mwlog1001?!).

Does anyone have any further hints here?TASK DETAILhttps://phabricator.wikimedia.org/T147169EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, Lucas_Werkmeister_WMDE, ArielGlenn, Addshore, aaron, Aklapper, Smalyshev, Lydia_Pintscher, jcrespo, aude, daniel, hoo, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Salgo60, Jonas, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Jonas
Jonas added a comment.
I added it to the right toolbar.
F24973808: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Jonas
Jonas claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Jonas
Jonas added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452929 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[wikidata/query/gui@master] Add query totals to right toolbar

https://gerrit.wikimedia.org/r/452929TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T155374: Add monolingual language code haz (Hazaragi)

2018-08-15 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, ReleaseTaggerBotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Luke081515, Wikidata-bugs, Snowolf, aude, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, ReleaseTaggerBotCc: gerritbot, Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-15 Thread Jonas
Jonas added a comment.
It seems foaf prefix is not defined

wdqs.min.0968a8fe8abab9fafb2d.js:1 Error: Unknown prefix: foafTASK DETAILhttps://phabricator.wikimedia.org/T201950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Aklapper, prssanna, Jonas, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread Jonas
Jonas moved this task from Bugs to Doing on the Wikidata Query UI board.Jonas triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T201951WORKBOARDhttps://phabricator.wikimedia.org/project/board/2901/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread Jonas
Jonas claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread Jonas
Jonas added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Salgo60, Lewizho99, Maathavan, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452928 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[wikidata/query/gui@master] Only show toolbar when mouse moves

https://gerrit.wikimedia.org/r/452928TASK DETAILhttps://phabricator.wikimedia.org/T201951EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, prssanna, Jonas, Aklapper, Fnielsen, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155431: Add monolingual language code uga (Ugaritic)

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 451316 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add monolingual language codes

https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155431EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, PokestarFan, Mbch331, Lydia_Pintscher, jhsoby, GerardM, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155420: Add monolingual language code mnw (Mon)

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 451316 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add monolingual language codes

https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: Raymond, gerritbot, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155421: Add monolingual language code gmy (Mycenaean Greek)

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 451316 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add monolingual language codes

https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155421EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Luke081515, Wikidata-bugs, Snowolf, aude, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155427: Add monolingual language code rar (Cook Islands Māori/Rarotongan)

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 451316 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add monolingual language codes

https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Luke081515, Wikidata-bugs, Snowolf, aude, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155418: Add monolingual language code mid (Modern Mandaic/Neo-Mandaic)

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 451316 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add monolingual language codes

https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T155374: Add monolingual language code haz (Hazaragi)

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 451316 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add monolingual language codes

https://gerrit.wikimedia.org/r/451316TASK DETAILhttps://phabricator.wikimedia.org/T155374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby, gerritbotCc: gerritbot, Mbch331, PokestarFan, Lydia_Pintscher, GerardM, jhsoby, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Jonas, Luke081515, Wikidata-bugs, Snowolf, aude, Shizhao___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Salgo60
Salgo60 added a comment.
@Jonas hm User Interface Design is not on my list of skills.

Do what is easy and not "destroy" current design...


WIth the new design maybe as part of the left or right vertical bar
Or a mouse over the overview map
or .


TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Salgo60Cc: Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reassigned] T184933: Use or to view coordinates on Wikidata

2018-08-15 Thread Jonas
Jonas reassigned this task from matej_suchanek to Tpt.Jonas added a subscriber: matej_suchanek.
TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tpt, JonasCc: matej_suchanek, WMDE-leszek, Tpt, Jonas, gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Looniverse, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Orienteerix, dachary, LawExplorer, Salgo60, Lewizho99, Maathavan, JGirault, phabyogi, Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Yurik, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452912 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeSpecialWhatLinksHereTest: create property

https://gerrit.wikimedia.org/r/452912TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: gerritbot, Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Jonas
Jonas added a comment.
Yes, it was removed when introducing the toolbar, but we can easily add it again.
Where would you like it to be shown?TASK DETAILhttps://phabricator.wikimedia.org/T201908EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452915 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Replace browser test with integration test

https://gerrit.wikimedia.org/r/452915TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: WMDE-leszek, Deskana, gerritbot, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Addshore, TerraCodes, Liuxinyu970226, Nikerabbit, iamjessklein, marcella, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Necroarcano, Darkminds3113, Bsandipan, Lordiis, Robinma, GoranSMilovanovic, Adik2382, chapulina, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Wess, Nizil, Srdjan_m, Ixocactus, Jrf, Husun1297, Wikidata-bugs, aude, Amire80, Swainr, Jsahleen, Darkdadaah, Arrbee, santhosh, KartikMistry, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201795: Setting marker size from a query in map visualization mode

2018-08-15 Thread Jonas
Jonas added a comment.
Maybe heatmaps would be better?
https://leafletjs.com/plugins.html#heatmaps
http://ursudio.com/webgl-heatmap-leaflet/

F24967311: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T201795EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Jonas, Salgo60, Lucas_Werkmeister_WMDE, Aklapper, DarTar, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T138725: Special:NewItem and Special:NewProperty allow creation of items with term language as any string

2018-08-15 Thread Petar.petkovic
Petar.petkovic removed a project: Patch-For-Review.Petar.petkovic removed a subscriber: gerritbot.Restricted Application added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T138725EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Petar.petkovicCc: greg, Smalyshev, thiemowmde, Sjoerddebruin, Nikki, Urbanecm, TerraCodes, Luke081515, hoo, daniel, aude, Lydia_Pintscher, adrianheine, Aklapper, Addshore, Zppix, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331, gerritbot, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201995: Travis CI is blocked by Linting Failure

2018-08-15 Thread Addshore
Addshore added a comment.
We will have to figure out which version last passed.
The last travis job on master to pass was https://travis-ci.org/wmde/wikibase-docker/jobs/390772356

$ bash ./.travis/run-linters.sh
Using default tag: latest
latest: Pulling from hadolint/hadolint
c259428136eb: Pulling fs layer
c259428136eb: Verifying Checksum
c259428136eb: Download complete
c259428136eb: Pull complete
Digest: sha256:28249f1e059f230b668f765054fc184e8ff4dba1371f67c2d868f6a707bcdd51
Status: Downloaded newer image for hadolint/hadolint:latestTASK DETAILhttps://phabricator.wikimedia.org/T201995EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Salgo60, Abbe98, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T201908: Bug report: Missing number of hits in resultset when displaying a Map

2018-08-15 Thread Jonas
Jonas moved this task from Backlog to Bugs on the Wikidata Query UI board.
TASK DETAILhttps://phabricator.wikimedia.org/T201908WORKBOARDhttps://phabricator.wikimedia.org/project/board/2901/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Jonas, prssanna, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Salgo60, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T201950: Edit button broken in new toolbars in embed

2018-08-15 Thread Jonas
Jonas moved this task from Backlog to Bugs on the Wikidata Query UI board.
TASK DETAILhttps://phabricator.wikimedia.org/T201950WORKBOARDhttps://phabricator.wikimedia.org/project/board/2901/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Aklapper, prssanna, Jonas, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T201951: Left chooser in embedded Wikidata Query Service hides axis labeling

2018-08-15 Thread Jonas
Jonas moved this task from Backlog to Bugs on the Wikidata Query UI board.
TASK DETAILhttps://phabricator.wikimedia.org/T201951WORKBOARDhttps://phabricator.wikimedia.org/project/board/2901/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: prssanna, Jonas, Aklapper, Fnielsen, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201995: Travis CI is blocked by Linting Failure

2018-08-15 Thread Addshore
Addshore added a comment.
Whether or not we should pin the hadolint version is up for debate.

That sounds like the best idea right now!TASK DETAILhttps://phabricator.wikimedia.org/T201995EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Salgo60, Abbe98, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-15 Thread tstarling
tstarling added a comment.
So how do we end up trying to insert a row for revision 3003 twice?

max(rev_id) on this wiki is 3002, so the ar_rev_id certainly came from populateArchiveRevId.php, which allocated ar_rev_id values by inserting dummy rows into revision and deleting them in the same transaction. It may be that MySQL has some method to reallocate autoincremented IDs in this case which we didn't know about.TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarlingCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T201995: Travis CI is blocked by Linting Failure

2018-08-15 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikibase-Containers, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONBuilds are currently not passing because the linting is failing see: https://travis-ci.org/wmde/wikibase-docker/jobs/414313694

To fix this we can either fix the rule violation: DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments from https://github.com/wmde/wikibase-docker/blob/master/wdqs-proxy/latest/Dockerfile#L6

See details in https://github.com/hadolint/hadolint/wiki/DL3025

Or the rule could be skipped see: https://github.com/hadolint/hadolint

I think this failure has happened (underneath us) because hadolint has introduced a new rule and we are always using the latest version of hadolint. Whether or not we should pin the hadolint version is up for debate.TASK DETAILhttps://phabricator.wikimedia.org/T201995WORKBOARDhttps://phabricator.wikimedia.org/project/board/3079/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Tarrow, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, Salgo60, Abbe98, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T195402: Form and Lexeme datatypes don't work anymore

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment.
@Addshore No doubt about it. I did not want to create the impression that I consider it a valid approach to put that burden onto the end user (professional honor & UX-wise).TASK DETAILhttps://phabricator.wikimedia.org/T195402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Pablo-WMDECc: Aklapper, Pablo-WMDE, Jakob_WMDE, Addshore, WMDE-leszek, Paladox, mmodell, Mbch331, Smalyshev, TerraCodes, Lea_Lacroix_WMDE, Denny, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T195402: Form and Lexeme datatypes don't work anymore

2018-08-15 Thread Addshore
Addshore added a comment.

In T195402#4229354, @Pablo-WMDE wrote:
Found an affected client that carried a local storage entry MediaWikiModuleStore:wikidatawiki with a huge map of items. Removing this entry and reloading the page resolved the issue.
 https://www.mediawiki.org/wiki/ResourceLoader/Features#Store


i just ran into an issue with this again while a data type id was changed, i wonder if we should come up with a "real" solution to this rather than telling users to clear their local storageTASK DETAILhttps://phabricator.wikimedia.org/T195402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, AddshoreCc: Aklapper, Pablo-WMDE, Jakob_WMDE, Addshore, WMDE-leszek, Paladox, mmodell, Mbch331, Smalyshev, TerraCodes, Lea_Lacroix_WMDE, Denny, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: gerritbot, Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread gerritbot
gerritbot added a comment.
Change 452912 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeSpecialWhatLinksHereTest: create property

https://gerrit.wikimedia.org/r/452912TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: gerritbot, Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment.
Happens too when executing only the tests inside /var/www/mediawiki/extensions/WikibaseLexeme/tests/phpunit/mediawikiTASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread thiemowmde
thiemowmde added a comment.
I just realized what this error message means: Some test (at the moment I don't know which) creates an Item, but this Item ends in code that expects a Lexeme.

One possible improvement is to let FormIdTextFormatter::formatEntityId throw an exception when the Entity returned by EntityRevisionLookup::getEntityRevision()->getEntity() is not a Form. This would give us a stack trace.

An other possible improvement is to not throw an exception, but just return $formId->getSerialization() when the EntityId is not a FormId. This would make this code work in all situations, even when the type of a property got changed from wikibase-item to wikibase-form, but the database still contains some item values that now end in the FormId formatter.TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, thiemowmdeCc: Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a comment.
Locally reproduceable on WB+WBL masters

Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testLexemeLanguage
Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testLexemeLexicalCategory
Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testGrammaticalFeatures
Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testFormStatements
Wikibase\Lexeme\Tests\MediaWiki\Specials\LexemeSpecialWhatLinksHereTest::testSenseStatementsTASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201928: VisualEditor welcome dialog pops up on Wikibase entity undo page

2018-08-15 Thread Addshore
Addshore added a comment.
If T201901 is an UBN for the team working on ContentTranslation and this ticket is the correct fix for the issue then this should probably also be UBN? or at least high?TASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Deskana, Pablo-WMDE, Esanders, Aklapper, Jakob_WMDE, iamjessklein, marcella, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, Srdjan_m, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Addshore
Addshore added a comment.
Another comment tagging T200508 as the reason this appeared (so everything is linked together in a wonderful web of tickets)TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, AddshoreCc: Addshore, WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration5.
TASK DETAILhttps://phabricator.wikimedia.org/T201988EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations()

2018-08-15 Thread Pablo-WMDE
Pablo-WMDE created this task.Pablo-WMDE added a project: Lexicographical data.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONWed Aug 15 08:01:19 2018] [hphp] [6572:7f9a3e6ce200:0:02] [] 
08:01:19 Fatal error: Call to undefined method Wikibase\DataModel\Entity\Item::getRepresentations() in /home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/extensions/WikibaseLexeme/src/PropertyType/FormIdHtmlFormatter.php on line 71

https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-composer-jessie/15806/console for https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ArticlePlaceholder/+/440821/TASK DETAILhttps://phabricator.wikimedia.org/T201988WORKBOARDhttps://phabricator.wikimedia.org/project/board/2292/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: WMDE-leszek, thiemowmde, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread Addshore
Addshore added a comment.

In T201901#4504210, @WMDE-leszek wrote:
Re merging I am note sure. Could be done, although there is some "conceptual" difference, as I tried to say in the last sentence in the row above. If merging tasks makes it easier to manage and figure out what should be fixed (and by whom), than let's do it!


I agree they shouldn't be merged, there are multiple ways to solve this immediate blocking CI issue, we could stop running lexeme tests with Content Translation again for example, but we really don't want to, or add a hack to dismiss the popup that should not be there. But of course the dream would be for T201928 to be solved within VE.TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, AddshoreCc: WMDE-leszek, Deskana, gerritbot, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Addshore, TerraCodes, Liuxinyu970226, Nikerabbit, iamjessklein, marcella, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Necroarcano, Darkminds3113, Bsandipan, Lordiis, Robinma, GoranSMilovanovic, Adik2382, chapulina, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Wess, Nizil, Srdjan_m, Ixocactus, Jrf, Husun1297, Wikidata-bugs, aude, Amire80, Swainr, Jsahleen, Darkdadaah, Arrbee, santhosh, KartikMistry, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T201831: Deploy item/property link formatter that uses cache instead of wb_terms DB table

2018-08-15 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[ ] 2018-08-1522: T201832
[ ] 2018-08-1623: T201833
[ ] 2018-08-207: T201834
[ ] 2018-08-218: T201835
[ ] 2018-08-229: T201837
[ ] 2018-08-229: T201838TASK DETAILhttps://phabricator.wikimedia.org/T201831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aleksey_WMDE, WMDE-leszek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201831: Deploy item/property link formatter that uses cache instead of wb_terms DB table

2018-08-15 Thread WMDE-leszek
WMDE-leszek added a comment.
everything pushed a week forward as no deployments in the week of 2018-08-15...TASK DETAILhttps://phabricator.wikimedia.org/T201831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aleksey_WMDE, WMDE-leszek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread WMDE-leszek
WMDE-leszek added a comment.
@Deskana I believe we hope the other one. I.e. that fixing T201928 would also fix this one :) Basically T201928 is a bug, and what this task covers is more of the influence of this bug.

Re merging I am note sure. Could be done, although there is some "conceptual" difference, as I tried to say in the last sentence in the row above. If merging tasks makes it easier to manage and figure out what should be fixed (and by whom), than let's do it!TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, WMDE-leszekCc: WMDE-leszek, Deskana, gerritbot, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Addshore, TerraCodes, Liuxinyu970226, Nikerabbit, iamjessklein, marcella, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Necroarcano, Darkminds3113, Bsandipan, Lordiis, Robinma, GoranSMilovanovic, Adik2382, chapulina, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Wess, Nizil, Srdjan_m, Ixocactus, Jrf, Husun1297, Wikidata-bugs, aude, Amire80, Swainr, Jsahleen, Darkdadaah, Arrbee, santhosh, KartikMistry, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201226: Investigate whether Wikidata.org extension can be merged into other extensions

2018-08-15 Thread Legoktm
Legoktm added a comment.
Confusingly, Wikidata.org and WikimediaBadges have very similarly named images (resources/images/wb-badges-notproofread.png vs resources/images/badge-notproofread.png) except they're totally different.TASK DETAILhttps://phabricator.wikimedia.org/T201226EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Aklapper, Addshore, Legoktm, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201983: Persistently high maxlag on wikidata.beta.wmflabs.org

2018-08-15 Thread Legoktm
Legoktm added a project: Wikidata.Legoktm added a comment.
Based on https://wikidata.beta.wmflabs.org/wiki/Special:DispatchStats it looks like dispatch hasn't run for 12 days?TASK DETAILhttps://phabricator.wikimedia.org/T201983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Legoktm, pywikibot-bugs-list, Aklapper, Dalba, Lahi, Gq86, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, Rxy, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs