[Wikidata-bugs] [Maniphest] [Created] T222995: Decide which prefixes to use for MediaInfo RDF

2019-05-10 Thread Smalyshev
Smalyshev created this task.
Smalyshev added projects: Wikidata, Commons, SDC General, 
Wikidata-Query-Service, WikibaseMediaInfo, User-Smalyshev.

TASK DESCRIPTION
  Right now the code that generates RDF for wikibase uses hardcoded prefixes 
for entities and other nodes - `wdata:`, `wd:`, `wdt:` etc. However, this may 
be confusing when used with MediaInfo/commons, for several reasons:
  
  1. MediaInfo entities (`M1234`) are not Wikidata, and `wd:` kind of implies 
Wikidata.
  2. If `wd:` prefix is linked to commons entity URI 
(http://commons.wikimedia.org/entity/) it can not be used for Wikidata 
entities, because these use http://www.wikida.org/entity/), so writing queries 
using these items will be confusing as another prefix should be used for those.
  3. Doing federated queries against Wikidata data set would be even more 
confusing since it won't be clear which `wd:` means what where.
  
  Same is true for some measure for other prefixes too, but `wd:` is most 
important, since Commons does not have now it's own properties, so all 
predicates still can use Wikidata ones, and `wds:` predicate which is used with 
statements is rarely used in queries (though it needs to be taken into account 
too).
  
  Thus, we have the following option:
  
  A. Leave everything as is and try to deal with the confusion by education and 
writing smarter queries, etc.
  
  B. Choose different prefixes for SDC/Mediainfo, e.g. `sdc:`, `sdcdata:`, etc. 
Not sure whether is makes sense to also change statement and value/reference 
ones, since it is not very likely they'd refer to each other, and Commons is 
not even using them currently.
  
  C. Use prefix-suffix system, like `c-wd:`, for all Commons prefixes.
  
  D. Something else?
  
  Note that this is distinct issue from T222306 
 - we know which full URI will be in 
the database, but this is the question how it would be represented in export 
formats that use prefixes to be human-readable - like TTL - and how the queries 
and query service configuration (which includes default prefixes) would be set 
up.
  
  Also note that, strictly speaking, prefixes in TTL format do not need to 
match prefixes in query (they are internally resolved to full URIs anyway), so 
we can do different approaches in different areas, though it again will be 
somewhat confusing if we take this road.

TASK DETAIL
  https://phabricator.wikimedia.org/T222995

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Mholloway, Cparle, daniel, Lucas_Werkmeister_WMDE, Salgo60, MB-one, Tpt, 
Addshore, Jarekt, Ramsey-WMF, Tgr, Lydia_Pintscher, Aklapper, Steinsplitter, 
Poyekhali, WMDE-leszek, Smalyshev, darthmon_wmde, alaa_wmde, Nandana, JKSTNK, 
Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, 
Silverfish, _jensen, rosalieper, Jonas, Xmlizer, Susannaanas, Wong128hk, 
Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, 
Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, Ricordisamoa, Wesalius, 
Fabrice_Florin, Raymond, Jdforrester-WMF, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T217430: Add support for all Sámi languages

2019-05-10 Thread Yupik
Yupik added a comment.


  Hate to come back to this, but it is still not possible to use sju, sjd, sjt 
or sia with labels or descriptions in Wikidata. sju I don't need right now, but 
I do need to be able to input labels and descriptions in the other three. 
Towards the end of the summer, at the latest, I will also need sju.
  
  Other languages that are missing are all but one of the Romani languages, 
five of which are considered national minority languages in Sweden. As is Kven 
(fkv).

TASK DETAIL
  https://phabricator.wikimedia.org/T217430

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jhsoby-WMNO, Yupik
Cc: Yupik, Nikki, jhsoby-WMNO, jhsoby, Nikerabbit, Mbch331, Aklapper, 
Susannaanas, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, 
Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Amire80, 
Gryllida, Shizhao, Arrbee, santhosh, KartikMistry, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T222985: Provide wikidata JSON dumps compressed with zstd

2019-05-10 Thread bennofs
bennofs created this task.
bennofs added projects: Wikidata, Dumps-Generation.
Restricted Application added a subscriber: Liuxinyu970226.

TASK DESCRIPTION
  At this time, wikidata provides JSON dumps compressed with gzip or bzip2.  
However, neither are not optimal:
  
  - the gzip dump is quite big (about 100% larger than bzip2)
  - the bzip2 dump takes a lot of time to decompress (estimated 7h on my laptop)
  
  As a consumer of these dumps, it would be nice to have a format that 
compresses well but also has good decompression speeds. I tested Zstandard 
 and it performs much better than either of 
those two variants:
  
  - decompression (with default compression level settings) is //much// faster: 
takes about 15 minutes on my laptop (CPU bound) (this might even be faster than 
gzip, I didn't have enough SSD space to test how well gzip performs)
  - the size at default settings is very close to bzip2 (37.7 GB compared to 
~35 GB that bzip2 produces)
  
  This directly affects processing speed of tools operating on these dumps.

TASK DETAIL
  https://phabricator.wikimedia.org/T222985

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bennofs
Cc: Liuxinyu970226, bennofs, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, rosalieper, gnosygnu, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T222861: Add the different constraint statuses in RDF

2019-05-10 Thread abian
abian added a comment.


  In T222861#5169845 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > We could define three new predicates to link statements to constraints only 
if the constraint status matches that predicate, either in addition to the 
existing `wikibase:hasViolationForConstraint` predicate (which would continue 
to link statements to constraints for violations of any status), or replacing 
it (though this would break existing queries).
  >
  > I’m struggling to find a good name for the middle predicate, though, 
because I don’t think we have a good name for the default status. The items are 
“mandatory constraint”, (none) and “suggestion constraint”; internally, the 
statuses are `violation`, `warning` and `suggestion`, but if we use `violation` 
directly that collides with the existing predicate.
  >
  > `wikibase:has{MandatoryViolation,Warning,Suggestion}ForConstraint` would 
work, but feels odd to me. Thoughts?
  
  
  Related: T220028#5095253 . 
Please feel free to copy/move/adapt/discuss/reject anything.

TASK DETAIL
  https://phabricator.wikimedia.org/T222861

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: abian
Cc: abian, Smalyshev, Harmonia_Amanda, Lucas_Werkmeister_WMDE, Aklapper, 
Lea_Lacroix_WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222861: Add the different constraint statuses in RDF

2019-05-10 Thread Smalyshev
Smalyshev added a comment.


  Where constraint type is specified? If it's a property of constraint itself, 
there should be a way to query it already. Or is it stored outside the 
constraint statement? I am not completely familiar with this part, would 
appreciate explanations or reference to the docs.

TASK DETAIL
  https://phabricator.wikimedia.org/T222861

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Smalyshev, Harmonia_Amanda, Lucas_Werkmeister_WMDE, Aklapper, 
Lea_Lacroix_WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T222861: Add the different constraint statuses in RDF

2019-05-10 Thread Smalyshev
Smalyshev triaged this task as "Normal" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T222861

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Smalyshev, Harmonia_Amanda, Lucas_Werkmeister_WMDE, Aklapper, 
Lea_Lacroix_WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222471: {"Accept": "application/ld+json"} causes 500 errors for LDF pages

2019-05-10 Thread Lexie_23Kr
Lexie_23Kr added a comment.


  Thank you @Smalyshev !

TASK DETAIL
  https://phabricator.wikimedia.org/T222471

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, Lexie_23Kr
Cc: Gehel, Krenair, Aklapper, Lexie_23Kr, darthmon_wmde, alaa_wmde, Nandana, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221701: implement clean up logic in MW DBAL store

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 507984 abandoned by Lucas Werkmeister (WMDE):
  WIP: Add MediaWikiNormalizedTermCleaner
  
  Reason:
  Now at https://github.com/wmde/mediawiki-term-store/pull/10
  
  https://gerrit.wikimedia.org/r/507984

TASK DETAIL
  https://phabricator.wikimedia.org/T221701

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: JeroenDeDauw, Aklapper, Addshore, Ladsgroup, sarhan.alaa, alaa_wmde, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T221380: Wikidata: Special:Contributions times out for many high-activity users

2019-05-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE assigned this task to Anomie.
Lucas_Werkmeister_WMDE added a comment.


  Seems to be resolved now.

TASK DETAIL
  https://phabricator.wikimedia.org/T221380

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Tgr, Pigsonthewing, Ammarpad, Tagishsimon, 
WMDE-leszek, Tarrow, Yann, Lea_Lacroix_WMDE, Marostegui, Anomie, Daimona, 
matej_suchanek, MisterSynergy, Framawiki, TerraCodes, Liuxinyu970226, Aklapper, 
Jc86035, darthmon_wmde, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Banyek, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, 
Lordiis, Lsherwinforone, GoranSMilovanovic, Adik2382, Jayprakash12345, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Sethakill, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Volker_E, Wong128hk, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Declined] T221649: Add WikibaseSchema submodule to 1.34.0-wmf.1 branch of mediawiki/core.git

2019-05-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Declined".
Lucas_Werkmeister_WMDE added a comment.


  Yeah, probably.

TASK DETAIL
  https://phabricator.wikimedia.org/T221649

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lydia_Pintscher, Aklapper, Ifygal3, Lucas_Werkmeister_WMDE, 
darthmon_wmde, pdehaye, alaa_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T216957: deploy WikibaseSchema to beta

2019-05-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T221649: Add WikibaseSchema submodule to 
1.34.0-wmf.1 branch of mediawiki/core.git as Declined.

TASK DETAIL
  https://phabricator.wikimedia.org/T216957

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ifygal3, Aklapper, Lydia_Pintscher, darthmon_wmde, pdehaye, alaa_wmde, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Jonas, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T222965: P373 in a Wikidata item connected to a Commons category causes a link to Commons to appear in the Commons sidebar

2019-05-10 Thread Mike_Peel
Mike_Peel created this task.
Mike_Peel added projects: Commons, Wikidata, SDC General.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  At https://commons.wikimedia.org/wiki/Category:South_Pole_Telescope there is 
currently a link to 'Wikimedia Commons' in the sidebar, under 'In other 
projects'. That's not much use, given that the user is already on Commons!
  
  Removing the value of P373  from the 
linked Wikidata item ( 
https://www.wikidata.org/w/index.php?title=Q1513315=938513067=919250761
 ) removes the link, so this is to do with P373 
 rather than the sitelink.
  
  The same behaviour was also present at 
https://commons.wikimedia.org/wiki/Category:Albert_Einstein - which was 
resolved by this edit: 
https://www.wikidata.org/w/index.php?title=Q7213562=938511809=938511640
  
  If a quick fix is possible for this, that would be good. A general fix would 
be to stop using P373  in the sidebar 
now, given that most Commons categories are now sitelinked either directly in 
the topic item, or indirectly through the corresponding category item.

TASK DETAIL
  https://phabricator.wikimedia.org/T222965

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mike_Peel
Cc: Aklapper, Lydia_Pintscher, Mike_Peel, darthmon_wmde, alaa_wmde, Nandana, 
JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, 
SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, Poyekhali, _jensen, rosalieper, Susannaanas, Wong128hk, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145279: Interwiki links to articles in other projects from Commons categories via Wikidata

2019-05-10 Thread Mike_Peel
Mike_Peel added a comment.


  I think this is basically solved now, barring cleanup? Following from the 
general switch to using the sitelinks for Commons over the last year, the 
interwiki links now appear on Commons through the sitelinks in most cases. 
Where the category is linked to a category item, {{Interwiki from Wikidata}} 
and {{Wikidata Infobox}} sort out the relevant links. So I think this task can 
now be closed?

TASK DETAIL
  https://phabricator.wikimedia.org/T145279

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mike_Peel
Cc: Mike_Peel, zhuyifei1999, Ghouston, MisterSynergy, Quiddity, 
Lydia_Pintscher, hoo, Josve05a, xcombelle, Dereckson, Nemo_bis, Aklapper, 
Poyekhali, Acer, darthmon_wmde, alaa_wmde, DannyS712, Nandana, JKSTNK, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, 
matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Fabrice_Florin, Raymond, Jackmcbarn, Steinsplitter, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unassigned] T215913: mediawiki - node: log (failed) connections

2019-05-10 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T215913

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Tarrow, Danmichaelo, Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T221644: Port WikibaseLexeme forms.feature Selenium tests from Ruby to Node.js

2019-05-10 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).

TASK DETAIL
  https://phabricator.wikimedia.org/T221644

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, ReleaseTaggerBot
Cc: Michael, WMDE-leszek, Lydia_Pintscher, Aklapper, zeljkofilipin, thiemowmde, 
Addshore, Lucas_Werkmeister_WMDE, darthmon_wmde, alaa_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Darkdadaah, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221650: Add WikibaseSchema to wmf-config/extension-list

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 505813 abandoned by Jforrester:
  Add WikibaseSchema to extension-list
  
  Reason:
  Replaced by Icb07f8d0.
  
  https://gerrit.wikimedia.org/r/505813

TASK DETAIL
  https://phabricator.wikimedia.org/T221650

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Aklapper, Ifygal3, Lucas_Werkmeister_WMDE, darthmon_wmde, 
pdehaye, alaa_wmde, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, YULdigitalpreservation, 
LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T213704: Wikidata Tours don't load correctly

2019-05-10 Thread Mrjohncummings
Mrjohncummings added a comment.


  @WMDE-leszek if it is easier to have a call about this to discuss with myself 
and @NavinoEvans please let us know, we are both in the UK.

TASK DETAIL
  https://phabricator.wikimedia.org/T213704

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mrjohncummings
Cc: WMDE-leszek, thiemowmde, Jakob_WMDE, MartinPoulter, Ladsgroup, Addshore, 
Sebastian_Berlin-WMSE, Lydia_Pintscher, johl, Jopparn, Alicia_Fagerving_WMSE, 
Tarrow, NavinoEvans, Ragesoss, Pasleim, Aklapper, Mrjohncummings, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222695: Create buttons

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509440 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [wikibase/termbox@master] storybook: introduce to allow for upfront component 
dev
  
  https://gerrit.wikimedia.org/r/509440

TASK DETAIL
  https://phabricator.wikimedia.org/T222695

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, gerritbot
Cc: Tarrow, Jakob_WMDE, Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE, 
Hanna_Petruschat_WMDE, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509356 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Retry inputs in Lexeme header 
browser tests
  
  https://gerrit.wikimedia.org/r/509356

TASK DETAIL
  https://phabricator.wikimedia.org/T222449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Ladsgroup, Michael, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Darkdadaah, zeljkofilipin, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221650: Add WikibaseSchema to wmf-config/extension-list

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509437 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [operations/mediawiki-config@master] Add EntitySchema to extension-list
  
  https://gerrit.wikimedia.org/r/509437

TASK DETAIL
  https://phabricator.wikimedia.org/T221650

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Aklapper, Ifygal3, Lucas_Werkmeister_WMDE, darthmon_wmde, 
pdehaye, alaa_wmde, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, YULdigitalpreservation, 
LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221649: Add WikibaseSchema submodule to 1.34.0-wmf.1 branch of mediawiki/core.git

2019-05-10 Thread Michael
Michael added a comment.


  Can this be closed as we are going the `make-wmf-branch/config.json` route?
  
  See https://gerrit.wikimedia.org/r/508339

TASK DETAIL
  https://phabricator.wikimedia.org/T221649

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: Michael, Lydia_Pintscher, Aklapper, Ifygal3, Lucas_Werkmeister_WMDE, 
darthmon_wmde, pdehaye, alaa_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T218086: Ability to disable user-specific SSR

2019-05-10 Thread Jakob_WMDE
Jakob_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T218086

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, Jakob_WMDE
Cc: Aklapper, Tarrow, Jakob_WMDE, Lea_WMDE, Pablo-WMDE, darthmon_wmde, 
alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221644: Port WikibaseLexeme forms.feature Selenium tests from Ruby to Node.js

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 508816 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Rewrite basic form section 
browser test in nodejs
  
  https://gerrit.wikimedia.org/r/508816

TASK DETAIL
  https://phabricator.wikimedia.org/T221644

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Michael, WMDE-leszek, Lydia_Pintscher, Aklapper, zeljkofilipin, thiemowmde, 
Addshore, Lucas_Werkmeister_WMDE, darthmon_wmde, alaa_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Darkdadaah, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread alaa_wmde
alaa_wmde added a comment.


  @thiemowmde that's great .. let's hope now one have caught it and relied on 
it since then :)

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, WMDE-leszek, thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, 
RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, 
darthmon_wmde, MattLongCT, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, 
QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, 
SimmeD, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T222951: [Maintenance] Do not bind against LabelsProvider in ChangeOps

2019-05-10 Thread alaa_wmde
alaa_wmde renamed this task from "[Maintenance] Move validations outside apply" 
to "[Maintenance] Do not bind against LabelsProvider in ChangeOps".
alaa_wmde updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T222951

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T220402: Introduce wikidata termbox SSR to kubernetes

2019-05-10 Thread akosiaris
akosiaris added a comment.


  @Tarrow , @WMDE-leszek I 've noticed 3 things while working on the above
  
  - The service seems to be configurable to reach directly out to the wikidata 
endpoint. e.g. `WIKIBASE_REPO: 
'{env(WIKIBASE_REPO,https://www.wikidata.org/w)}'`. Since, in the general case, 
this goes via the edge caches (possibly polluting them with artificial 
requests, and limits operational flexibility, e.g. in the case of a datacenter 
switchover we can't really switch the app without switching the edge layer, we 
've been defaulting to talking to internal endpoints and sending a `Host: ` 
HTTP for the identification of the exact project. Would it be possible to add 
that functionality? (or guide me on how this is achieved if it is already 
implemented).
  
  - There was no `x-amples` stanza to `/termbox` endpoint. We need this for 
monitoring checks so I went ahead and added one in 
https://gerrit.wikimedia.org/r/#/c/wikibase/termbox/+/509391. Lemme know what 
you think.
  
  - The app does not emit statsd metrics for requests (it does however emit 
nodejs heap and GC stats). This should be rather easy to add as service-runner 
wraps it very nicely. See 
https://github.com/wikimedia/service-runner#metric-reporting
  
  What exactly you want to do for that is up to you, but up to now services 
have been using 
https://github.com/wikimedia/service-template-node/blob/master/lib/util.js#L107 
to wrap the route handlers which provides them out of the box with requests 
rates per endpoints, latencies per endpoint, errors and so on. I highly suggest 
that.
  
  For service specific stats, e.g. how many time language=de has been passed as 
a request, `options.metrics.increment` is what has been used up to now as they 
have invariably been of a counter nature.
  
  Overall I think we are ready to deploy to staging, production will have to 
wait a bit until we solve at least the first 2 items. The 3rd is not a hard 
blocker but I am willing to bet you want stats :-)
  
  I also think we should schedule a training session for how deployers deploy 
code in the pipeline/kubernetes environment.

TASK DETAIL
  https://phabricator.wikimedia.org/T220402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: akosiaris
Cc: fsero, mobrovac, Matthias_Geisler_WMDE, Pablo-WMDE, Dzahn, Addshore, 
Tarrow, Lea_WMDE, WMDE-leszek, Jakob_WMDE, Aklapper, akosiaris, darthmon_wmde, 
alaa_wmde, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, 
thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Zppix, 
Maathavan, _jensen, rosalieper, Liudvikas, Wong128hk, Eevans, thcipriani, 
Hardikj, Wikidata-bugs, aude, Lydia_Pintscher, dduvall, faidon, 
Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread thiemowmde
thiemowmde added a comment.


  In case you are referring to the documentation in 
docs/change-op-serializations.wiki 
,
 note I wrote this very late (in 2017), based on experiments and information I 
was able to extract directly from the code at this time. I simply missed the 
special case that ignores an empty list of aliases. Otherwise that special case 
would have become part of the documentation.
  
  I still agree we should continue as if it is a bug. The fact it did not made 
it in any documentation is helpful now. ;-)

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, thiemowmde
Cc: alaa_wmde, WMDE-leszek, thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, 
RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, 
darthmon_wmde, MattLongCT, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, 
QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, 
SimmeD, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread alaa_wmde
alaa_wmde claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, WMDE-leszek, thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, 
RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, 
darthmon_wmde, MattLongCT, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, 
QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, 
SimmeD, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread alaa_wmde
alaa_wmde added a comment.


  The documentation does not explicitly mention the current behavior, neither 
it would be implicitly concluded from that documentation. This is a bug that 
need to be fixed.
  
  Though, it can be that some api users found out about it by coincidence and 
used it to achieve some shortcut implementation for some case they have.

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, WMDE-leszek, thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, 
RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, 
darthmon_wmde, MattLongCT, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, 
QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, 
SimmeD, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread alaa_wmde
alaa_wmde moved this task from Ready to go to Needs Work on the 
Wikidata-Campsite board.
alaa_wmde added a comment.


  Check the logs for such calls (where `{ ... aliases: { 'lang': [] } } ... }` 
, i.e on a single language) to get a better feeling whether this might been 
used as a feature

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, WMDE-leszek, thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, 
RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, 
darthmon_wmde, MattLongCT, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, 
QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, 
SimmeD, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T220402: Introduce wikidata termbox SSR to kubernetes

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509391 had a related patch set uploaded (by Alexandros Kosiaris; 
owner: Alexandros Kosiaris):
  [wikibase/termbox@master] Add x-amples to termbox openapi.json
  
  https://gerrit.wikimedia.org/r/509391

TASK DETAIL
  https://phabricator.wikimedia.org/T220402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: fsero, mobrovac, Matthias_Geisler_WMDE, Pablo-WMDE, Dzahn, Addshore, 
Tarrow, Lea_WMDE, WMDE-leszek, Jakob_WMDE, Aklapper, akosiaris, darthmon_wmde, 
alaa_wmde, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, 
thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Zppix, 
Maathavan, _jensen, rosalieper, Liudvikas, Wong128hk, Eevans, thcipriani, 
Hardikj, Wikidata-bugs, aude, Lydia_Pintscher, dduvall, faidon, 
Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T220402: Introduce wikidata termbox SSR to kubernetes

2019-05-10 Thread akosiaris
akosiaris added a comment.


  @WMDE-leszek. Yes I did.
  
  Using https://locust.io/, wrote P8511 
 and benchmarked the service locally 
on my minikube instance. A rough howto (minus the locust part) is at 
https://wikitech.wikimedia.org/wiki/User:Alexandros_Kosiaris/Benchmarking_kubernetes_apps.
  
  Below are graphs with the results from the benchmarks
  
  CPU
  F29003763: termbox_cpu_usage.png 
  
  Memory
  F29003768: termbox_mem_usage.png 
  
  Requests:
  F29003766: termbox_locust_stats.png 

  
  So a single worker termbox installation uses some 1cpu max, ~235MB memory and 
is able to serve  ~16 req/s. When idling we are at ~140MB and 0 cpu usage. 
Those numbers should be used as a driver to gauge how many instances of the app 
we will need. I 've updated the chart with those numbers and will proceed with 
merging it.

TASK DETAIL
  https://phabricator.wikimedia.org/T220402

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: akosiaris
Cc: fsero, mobrovac, Matthias_Geisler_WMDE, Pablo-WMDE, Dzahn, Addshore, 
Tarrow, Lea_WMDE, WMDE-leszek, Jakob_WMDE, Aklapper, akosiaris, darthmon_wmde, 
alaa_wmde, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, 
thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Zppix, 
Maathavan, _jensen, rosalieper, Liudvikas, Wong128hk, Eevans, thcipriani, 
Hardikj, Wikidata-bugs, aude, Lydia_Pintscher, dduvall, faidon, 
Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread alaa_wmde
alaa_wmde updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, WMDE-leszek, thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, 
RazShuty, Lea_WMDE, Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, 
darthmon_wmde, MattLongCT, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, 
QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, 
SimmeD, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T222951: [Maintenance] Move validations outside apply

2019-05-10 Thread alaa_wmde
alaa_wmde created this task.
alaa_wmde added projects: Wikidata-Campsite, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION


TASK DETAIL
  https://phabricator.wikimedia.org/T222951

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Raised Priority] T50047: client watchlist shows more than just the last change on the item

2019-05-10 Thread stjn
stjn raised the priority of this task from "Normal" to "Unbreak Now!".
stjn added a comment.
Restricted Application added a subscriber: Liuxinyu970226.


  Will anything be done to this? Watchlisting any big item (such as ones for 
any country) completely breaks my watchlist with multitudes of edits to the 
same articles, why is this completely neglected? This is a default 
configuration, not some option, why is no one working on the fix?

TASK DETAIL
  https://phabricator.wikimedia.org/T50047

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel, stjn
Cc: Liuxinyu970226, stjn, Aklapper, Legoktm, Denny, Snaterlicious, wctaiwan, 
Lydia_Pintscher, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T222697: Implement generic overlay capability

2019-05-10 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T222697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE, gerritbot
Cc: Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222697: Implement generic overlay capability

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509372 had a related patch set uploaded (by Jakob; owner: Jakob):
  [wikibase/termbox@master] Introduce generic modal component
  
  https://gerrit.wikimedia.org/r/509372

TASK DETAIL
  https://phabricator.wikimedia.org/T222697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE, gerritbot
Cc: Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509374 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Revert "Revert "Use 
LabelDescriptionNotEqualValidator in TermValidatorFactory""
  
  https://gerrit.wikimedia.org/r/509374

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509373 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Do not validate against same label and 
description when change is noop
  
  https://gerrit.wikimedia.org/r/509373

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Raised Priority] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread alaa_wmde
alaa_wmde raised the priority of this task from "Low" to "Normal".
alaa_wmde added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, RazShuty, Lea_WMDE, 
Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, darthmon_wmde, 
MattLongCT, alaa_wmde, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, Lahi, 
Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, QZanden, 
LawExplorer, _jensen, rosalieper, D3r1ck01, Jonas, MuhammadShuaib, SimmeD, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Ladsgroup
Ladsgroup added a comment.


  I dug deep into the issue and it's really interesting, first, if you try to 
edit another language, it doesn't fail using wbeditentity. This is an example I 
got:
  
{
"entity": {
"aliases": {},
"claims": {},
"descriptions": {
"de": {
"language": "de",
"value": "foo"
},
"en": {
"language": "en",
"value": "foo0"
}
},
"id": "Q29",
"labels": {
"de": {
"language": "de",
"value": "nfoo"
},
"en": {
"language": "en",
"value": "foo0"
}
},
"lastrevid": 111,
"sitelinks": {},
"type": "item"
},
"success": 1
}
  
  (I added de using httpie and wbeditentity later)
  
  It also doesn't fail if instead of `{ "labels": { "en":{"language": "en", 
"value": "foo"} }, "descriptions": { "en":{"language": "en", "value": "NOTfoo"} 
} }`, you set `'{ "labels": { "en":{"language": "en", "value": "NOTfoo"} }, 
"descriptions": { "en":{"language": "en", "value": "foo"} } }` which gives away 
why it's happening, the changeOps are atomic, the system tries to apply the 
changeOp that doesn't change anything (in our case label, and it fails. If you 
apply the description first, the entity is untangled and then you can simply 
apply the empty changeop. I can add a basic sanity check to shorten out and 
don't try to apply an empty change op and that would fix our very funny edge 
case.

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.
thiemowmde moved this task from incoming to needs discussion or investigation 
on the Wikidata board.
thiemowmde added a project: good first bug.
thiemowmde added a comment.


  Here is the line of code that is responsible for the current behavior: 
https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/ChangeOp/Deserialization/AliasesChangeOpDeserializer.php$125.
  
  counterexample
if ( $aliasesToSet !== [] ) {
  
  This file exists since https://gerrit.wikimedia.org/r/334142 (not linked to a 
Phabricator ticket), mostly copied from the EditEntity class.
  
  In EditEntity the line was originally introduced in 2013 via 
https://gerrit.wikimedia.org/r/73322, bug T52983 
. The bug was about the UI 
accidentally removing all aliases when it shouldn't. This means:
  
  - No, the fact an empty list of aliases is ignored is not an intentional 
product feature. It was a bugfix for a misbehavior.
  - As long as we can make sure the bug does not come back, I believe we can 
remove the special case and allow users to pass an empty list of aliases to the 
API.
  
  Proposed fix:
  
if ( $aliasesChangeOps->getChangeOps() === [] || $aliasesToSet !== [] ) {

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

WORKBOARD
  https://phabricator.wikimedia.org/project/board/71/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, RazShuty, Lea_WMDE, 
Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, darthmon_wmde, 
MattLongCT, alaa_wmde, DannyS712, Nandana, Kieubinhtb, Asad_Ali_Palijo, Lahi, 
Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, JakeTheDeveloper, QZanden, 
LawExplorer, _jensen, rosalieper, D3r1ck01, MuhammadShuaib, SimmeD, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-10 Thread Lea_WMDE
Lea_WMDE added subscribers: Matthias_Geisler_WMDE, Pablo-WMDE, thiemowmde.
Lea_WMDE added a comment.


  @Tarrow @Jakob_WMDE @Pablo-WMDE @Matthias_Geisler_WMDE after talking to 
@thiemowmde: He also doesn't see a reason why the behavior should be kept this 
way, but suggests making a git bisect to understand since when the behavior 
exists and to see if this was maybe introduced as a fail save.

TASK DETAIL
  https://phabricator.wikimedia.org/T203337

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: thiemowmde, Pablo-WMDE, Matthias_Geisler_WMDE, RazShuty, Lea_WMDE, 
Jakob_WMDE, Liuxinyu970226, Tarrow, Aklapper, Danmichaelo, darthmon_wmde, 
alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Tarrow
Tarrow added a comment.


  Thanks for digging into it so much. Seems perhaps somehow I wandered into a 
very edge case set-up by mistake :(. As I mentioned I only found it by testing 
our new termbox on a random item on beta; seems impossibly bad/good luck that I 
ran into it with the first request I made.

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Tarrow
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T222804: Feature: Hovers and hyperlinks on Wikidata query service graph views

2019-05-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE edited projects, added Wikidata Query UI; removed 
Wikidata-Query-Service.

TASK DETAIL
  https://phabricator.wikimedia.org/T222804

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, pdehaye, Aklapper, darthmon_wmde, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, 
Salgo60, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222804: Feature: Hovers and hyperlinks on Wikidata query service graph views

2019-05-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  If you select an IRI as a `?variable` and a string as a `?variableLabel` 
(example 
),
 then the node will be made a hyperlink to the IRI with the string as the text 
(double-click to follow the link).

TASK DETAIL
  https://phabricator.wikimedia.org/T222804

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, pdehaye, Aklapper, darthmon_wmde, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, 
_jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509356 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/WikibaseLexeme@master] Retry inputs in Lexeme header 
browser tests
  
  https://gerrit.wikimedia.org/r/509356

TASK DETAIL
  https://phabricator.wikimedia.org/T222449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Ladsgroup, Michael, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Darkdadaah, zeljkofilipin, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Ladsgroup
Ladsgroup added a comment.


  I was able to reproduce the issue, I needed to remove clear= bit. I double 
check where this is coming from

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Ladsgroup
Ladsgroup added a comment.


  @alaa_wmde and I tested it with wmf.4 and master and with all the given 
acceptance criteria, also followed your steps to reproduce (did the API call 
using API sandbox though but it shouldn't make any difference) and still we 
can't reproduce it :'(

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222200: Run browser tests as part of "npm test" of wikidata/query/gui

2019-05-10 Thread zeljkofilipin
zeljkofilipin added a comment.


  - I will be at #wikimedia-hackathon-2019 
 next week, if 
anybody wants to pair on this.
  - The convention is to have Selenium tests (including `wdio.conf.js`) in 
`tests/selenium`, if possible. See Selenium/Node.js#write-tests 
 for examples.
  - I don't think CI supports running Selenium tests in Firefox 
(wdio.conf.js#33 
).
 All other repositories use Chrome.
  - There is no need for selenium-standalone (Gruntfile.js#273 
).
 Use Chromedriver instead. It should be available in CI.

TASK DETAIL
  https://phabricator.wikimedia.org/T00

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin
Cc: hashar, zeljkofilipin, noarave, alaa_wmde, WMDE-leszek, Aklapper, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221644: Port WikibaseLexeme forms.feature Selenium tests from Ruby to Node.js

2019-05-10 Thread gerritbot
gerritbot added a comment.


  Change 509347 had a related patch set uploaded (by Rosalie Perside (WMDE); 
owner: Rosalie Perside (WMDE)):
  [mediawiki/extensions/WikibaseLexeme@master] Removed already ported test from 
the forms.feature file
  
  https://gerrit.wikimedia.org/r/509347

TASK DETAIL
  https://phabricator.wikimedia.org/T221644

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Michael, WMDE-leszek, Lydia_Pintscher, Aklapper, zeljkofilipin, thiemowmde, 
Addshore, Lucas_Werkmeister_WMDE, darthmon_wmde, alaa_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Darkdadaah, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-10 Thread Tarrow
Tarrow added a comment.


  Sorry for the lack of explicit reproduction :/. The steps below use `httpie` 
and the mediawiki-docker-dev setup.
  
  > I didn't test anything in API, I tested everything in desktop GUI
  
  I think in desktop GUI different endpoints are used (wbsetlabel, 
wbsetdescription) not wbeditentity. Here is are steps to reproduce; sorry that 
they weren't clearly there before.
  
  1. in Wikibase `git checkout 336207887deea6ad3644c222124233a132db7f58` At the 
time of writing this is: origin/wmf/1.34.0-wmf.4
  2. make a new item e.g. `http -f POST 
default.web.mw.localhost:8080/mediawiki/api.php action==wbeditentity new==item 
data=='{ "labels": { "en":{"language": "en", "value": "foo"} }, "descriptions": 
{ "en":{"language": "en", "value": "foo"} } }' token='+\'`
  3. Apply the reverted patch `git cherry-pick  
b71b5b2af611e593816bbe6b949e216b88e1dcf8`
  4. try and change the duplicated terms: `http -f POST 
default.web.mw.localhost:8080/mediawiki/api.php action==wbeditentity id=Q314 
data=='{ "labels": { "en":{"language": "en", "value": "foo"} }, "descriptions": 
{ "en":{"language": "en", "value": "NOTfoo"} } }' token='+\'`
  5. Get returned error with info `Label and description for language code en 
can not have the same value.`

TASK DETAIL
  https://phabricator.wikimedia.org/T222621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Tarrow
Cc: alaa_wmde, thcipriani, Jdforrester-WMF, Jakob_WMDE, Aklapper, 
Liuxinyu970226, Tarrow, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T172937: Cursor jumping to next field and overlapping of menus

2019-05-10 Thread Lea_Lacroix_WMDE
Lea_Lacroix_WMDE added a comment.


  @Nikki @Envlh Thanks for your feedback. We will take the opportunity of this 
revert to consider other options.

TASK DETAIL
  https://phabricator.wikimedia.org/T172937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, Lea_Lacroix_WMDE
Cc: Lucas_Werkmeister_WMDE, Sjoerddebruin, thiemowmde, Jonas, Liuxinyu970226, 
SharkD, Envlh, Nikki, Greta_Doci_WMDE, Lydia_Pintscher, Aklapper, Jan_Dittrich, 
Lea_Lacroix_WMDE, PokestarFan, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs