[Wikidata-bugs] [Maniphest] [Edited] T219549: Simplify WikibaseRepo "mw.config.values.wbSiteDetails" module and use content versioning

2019-03-28 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T219549

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Addshore, Krinkle, Aklapper, alaa_wmde, Nandana, Imarlier, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T219549: Simplify WikibaseRepo "mw.config.values.wbSiteDetails" module and use content versioning

2019-03-28 Thread Krinkle
Krinkle created this task.
Krinkle added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, 
Performance-Team (Radar).
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  This is a bit of minor tech debt to simplify the code and use newer 
ResourceLoader mechanisms.
  
  Follows-up:
  
  - T127275: Wikibase RL module mw.config.values.wbSiteDetails repeatedly 
flapping <https://phabricator.wikimedia.org/T127275>
  
  I attempted this previously with 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/496622/, but 
this led to a regression (T219452 <https://phabricator.wikimedia.org/T219452>). 
This task is placeholder for:
  
  - Figuring out what went wrong.
  - Improve the tests.
  - Do it again :)

TASK DETAIL
  https://phabricator.wikimedia.org/T219549

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Addshore, Krinkle, Aklapper, alaa_wmde, Nandana, Imarlier, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T219549: Simplify WikibaseRepo "mw.config.values.wbSiteDetails" module and use content versioning

2019-03-28 Thread Krinkle
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) 
board.
Krinkle added a comment.


  With the help of @Addshore I was able to get Wikibase set up locally with the 
sites table populated from the WMF site matrix.
  
  The issue is with the suggestions that appear when inserting a new site link 
statement.
  
  F28500617: Screenshot 2019-03-28 at 19.46.59.png 
<https://phabricator.wikimedia.org/F28500617>
  
  With the patch applied, there are no suggestions (but also no errors; not in 
PHP, JS, nor on the network).
  
  Comparing the module output reveals the issue:
  
  F28500628: export.png <https://phabricator.wikimedia.org/F28500628>
  
  The data structure has the correct size, keys and urls. But, the groups and 
display names are all for `aawiki`. I assume the suggestion system only uses 
the display names, and so except for "aa", there are no suggestions.

TASK DETAIL
  https://phabricator.wikimedia.org/T219549

WORKBOARD
  https://phabricator.wikimedia.org/project/board/2923/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Addshore, Krinkle, Aklapper, alaa_wmde, Nandana, Imarlier, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T207235: PHP error from ArticlePlaceholder hook on SpecialSearch

2019-03-28 Thread Krinkle
Krinkle moved this task from Meta to Regressed longer ago on the 
Wikimedia-production-error board.
Krinkle added a comment.


  Still seen.
  
  Request ID: `XJ1gwApAAC4AADrz5ZIAAABC`
  
PHP Notice: Undefined index: Q157…


#0 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/ArticlePlaceholder/includes/ItemNotabilityFilter.php(85):
 MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(238):
 ArticlePlaceholder\ItemNotabilityFilter->getNotableEntityIds(array)
#2 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(182):
 ArticlePlaceholder\SearchHookHandler->renderTermSearchResults(array)
#3 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(170):
 ArticlePlaceholder\SearchHookHandler->addToSearch(SpecialSearch, OutputPage, 
string)
#4 /srv/mediawiki/php-1.33.0-wmf.23/includes/Hooks.php(174): 
ArticlePlaceholder\SearchHookHandler::onSpecialSearchResultsAppend(SpecialSearch,
 OutputPage, string)
#5 /srv/mediawiki/php-1.33.0-wmf.23/includes/Hooks.php(202): 
Hooks::callHook(string, array, array, NULL)
#6 
/srv/mediawiki/php-1.33.0-wmf.23/includes/specials/SpecialSearch.php(490): 
Hooks::run(string, array)
#7 
/srv/mediawiki/php-1.33.0-wmf.23/includes/specials/SpecialSearch.php(176): 
SpecialSearch->showResults(string)
#8 
/srv/mediawiki/php-1.33.0-wmf.23/includes/specialpage/SpecialPage.php(569): 
SpecialSearch->execute(NULL)
#9 
/srv/mediawiki/php-1.33.0-wmf.23/includes/specialpage/SpecialPageFactory.php(558):
 SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(288): 
MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(867): 
MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(517): 
MediaWiki->main()
#13 /srv/mediawiki/php-1.33.0-wmf.23/index.php(42): MediaWiki->run()

TASK DETAIL
  https://phabricator.wikimedia.org/T207235

WORKBOARD
  https://phabricator.wikimedia.org/project/board/1055/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Lydia_Pintscher, Addshore, Ladsgroup, Krinkle, Aklapper, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, jayvdb, Ricordisamoa, zeljkofilipin, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-03-28 Thread Krinkle
Krinkle created this task.
Krinkle added projects: Wikimedia-production-error (Shared Build Failure), 
Lexicographical data, Wikidata.

TASK DESCRIPTION
  counterexample
1) Special:RecentChanges shows lemmas in title links to lexemes:
false == true
running chrome
AssertionError: false == true
at Context.it 
(/workspace/src/extensions/WikibaseLexeme/tests/selenium/specs/special/recentchanges.js:38:3)
at Promise.F 
(/workspace/src/node_modules/core-js/library/modules/_export.js:36:28)
  
  
  
  - Build output 
<https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/42199/console>
  - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/499946/

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3298/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, alaa_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219663: Merge blocker: TypeError: Cannot read property 'Infobar' of undefined

2019-03-29 Thread Krinkle
Krinkle added a comment.


  ~~This presumably started with rCICF53185ed59d05: Add ArticlePlaceholder to 
Wikibase Tests 
<https://phabricator.wikimedia.org/rCICF53185ed59d05395e8c841c7e0e4e9de6a09e2450>
 / https://gerrit.wikimedia.org/r/#/c/integration/config/+/485753/.~~
  
  ~~Zuul config for ContentTranslation installs Wikibase, which in turn, as of 
the above change, also installs ArticlePlaceholder.~~
  
  Actually, no, it started with 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ArticlePlaceholder/+/444936/.
  
  That job passed because ContentTranslation commits install 
Wikibase+ArticlePlaceholder. But commits for ArticlePlaceholder do not install 
ContentTranslation.

TASK DETAIL
  https://phabricator.wikimedia.org/T219663

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, TerraCodes, Liuxinyu970226, Aklapper, Nikerabbit, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, chapulina, QZanden, cmadeo, 
LawExplorer, _jensen, rosalieper, Nizil, Ixocactus, Wikidata-bugs, aude, 
Amire80, jayvdb, Ricordisamoa, Jsahleen, Arrbee, santhosh, KartikMistry, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T219359: lang attribute of page title is empty

2019-03-29 Thread Krinkle
Krinkle closed this task as "Resolved".
Krinkle claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T219359

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Thibaut120094, matmarex, PerfektesChaos, Volker_E, Fomafix, 
Lucas_Werkmeister_WMDE, Aklapper, Michael, alaa_wmde, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
Orienteerix, LawExplorer, Flycatchr, EHCliffe, Lewizho99, Zppix, Maathavan, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, 
Isarra, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219359: lang attribute of page title is empty

2019-03-29 Thread Krinkle
Krinkle edited projects, added Regression; removed Patch-For-Review.
Krinkle added a comment.


  This was a regression from https://gerrit.wikimedia.org/r/493093 due to a 
typo in the variable name. Now fixed, and backported.

TASK DETAIL
  https://phabricator.wikimedia.org/T219359

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Thibaut120094, matmarex, PerfektesChaos, Volker_E, Fomafix, 
Lucas_Werkmeister_WMDE, Aklapper, Michael, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, Orienteerix, LawExplorer, 
Flycatchr, EHCliffe, Zppix, _jensen, rosalieper, Jonas, Wong128hk, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Isarra, Mbch331, Jay8g, 
CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T124196: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB)

2019-03-29 Thread Krinkle
Krinkle renamed this task from "Notice: Unable to unserialize job_params in 
some CirrusSearch jobs (when using JobQueueDB)" to "Fatal "cannot perform this 
operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB)".

TASK DETAIL
  https://phabricator.wikimedia.org/T124196

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: aaron, Krinkle, Rudloff, Physikerwelt, GFXDude2010, Zoglun, hoo, aude, 
Aklapper, alaa_wmde, ET4Eva, Nandana, Lahi, Gq86, Darkminds3113, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, 
rosalieper, FloNight, Wikidata-bugs, jayvdb, Jdforrester-WMF, Mbch331, Jay8g, 
Krenair, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T124196: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB)

2019-03-29 Thread Krinkle
Krinkle merged a task: T218943: Fatal "cannot perform this operation with 
arrays" from Job/ElasticaWrite.php.
Krinkle added subscribers: EBernhardson, debt, GTirloni.

TASK DETAIL
  https://phabricator.wikimedia.org/T124196

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: GTirloni, debt, EBernhardson, aaron, Krinkle, Rudloff, Physikerwelt, 
GFXDude2010, Zoglun, hoo, aude, Aklapper, alaa_wmde, ET4Eva, Nandana, Lahi, 
Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, 
Gehel, _jensen, rosalieper, FloNight, Wikidata-bugs, jayvdb, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T124196: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB)

2019-03-29 Thread Krinkle
Krinkle added a comment.


  Still seen. Causing some search jobs to fail for wikitech.wikimedia.org.
  
  counterexample, name=error
[c032e62f71eb06fbe34c1b7a] /srv/mediawiki/multiversion/MWScript.php   PHP 
Fatal Error from line 79 of 
/srv/mediawiki/php-1.33.0-wmf.22/extensions/CirrusSearch/includes/Job/ElasticaWrite.php:
 Invalid operand type was used: cannot perform this operation with arrays
  
  name=trace
#0 [internal function]: MWExceptionHandler::handleFatalError()
#1 {main}

TASK DETAIL
  https://phabricator.wikimedia.org/T124196

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: GTirloni, debt, EBernhardson, aaron, Krinkle, Rudloff, Physikerwelt, 
GFXDude2010, Zoglun, hoo, aude, Aklapper, alaa_wmde, ET4Eva, Nandana, Lahi, 
Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, 
Gehel, _jensen, rosalieper, FloNight, Wikidata-bugs, jayvdb, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T124196: Fatal "cannot perform this operation with arrays" from CirrusSearch/ElasticaWrite (using JobQueueDB)

2019-03-29 Thread Krinkle
Krinkle added a comment.


  In T218943#5067284 <https://phabricator.wikimedia.org/T218943#5067284>, 
@EBernhardson wrote:
  
  > The two available fixes are a complete rewrite of the cirrussearch indexing 
retry pipeline, or changing the job queue to use a non-size limited field type 
[..]
  
  
  Those are two ways to actually build the behaviour that the code currently 
pretends exists. That's cool, but the immediate fix is to not produce a fatal 
error.
  
  A fatal error signifies that the code is broken, raises our error levels, and 
may abort a deployment, or trigger Ops pages.
  
  In this case, however, it is known that this ability doesn't exist. Until 
this ability exists, the code either needs to be disabled (e.g. not deployed on 
Wikitech), or the code needs to handle this error and respond in some way. E.g. 
avoid queuing updates of this type or this size (possibly configurable), or run 
them differently, or to try it as today and then catch/suppress the failure - 
maybe logging a warning in its stead.

TASK DETAIL
  https://phabricator.wikimedia.org/T124196

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: GTirloni, debt, EBernhardson, aaron, Krinkle, Rudloff, Physikerwelt, 
GFXDude2010, Zoglun, hoo, aude, Aklapper, alaa_wmde, ET4Eva, Nandana, Lahi, 
Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, 
Gehel, _jensen, rosalieper, FloNight, Wikidata-bugs, jayvdb, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T219663: Merge blocker: TypeError: Cannot read property 'Infobar' of undefined

2019-04-01 Thread Krinkle
Krinkle closed this task as "Resolved".
Krinkle claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T219663

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Tarrow, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, Nikerabbit, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, chapulina, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, cmadeo, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Nizil, Ixocactus, Wikidata-bugs, aude, Amire80, 
jayvdb, Ricordisamoa, Jsahleen, Arrbee, santhosh, KartikMistry, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219663: Merge blocker: TypeError: Cannot read property 'Infobar' of undefined

2019-04-01 Thread Krinkle
Krinkle added a project: Performance-Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T219663

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Tarrow, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, Nikerabbit, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
chapulina, Th3d3v1ls, Ramalepe, Liugev6, QZanden, cmadeo, LawExplorer, 
Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Nizil, Ixocactus, 
Wikidata-bugs, aude, Amire80, jayvdb, Ricordisamoa, Jsahleen, Arrbee, santhosh, 
KartikMistry, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Declined] T94589: [Bug] Fix "Unknown dependency: jquery.ui.EditableTemplatedWidget" error

2019-04-02 Thread Krinkle
Krinkle closed this task as "Declined".
Krinkle added a comment.


  This was due to certain directories not being exposed in production. That's 
fine, and for that reason and several other reasons, we've long since disabled 
"Special:JavaScriptTest" on test2wiki.

TASK DETAIL
  https://phabricator.wikimedia.org/T94589

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: thiemowmde, Tobi_WMDE_SW, WMDE-Fisch, aude, hoo, Krinkle, Aklapper, 
alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reopened] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page

2019-04-02 Thread Krinkle
Krinkle reopened this task as "Open".
Krinkle added a comment.


  In T97891#1274336 <https://phabricator.wikimedia.org/T97891#1274336>, 
@gerritbot wrote:
  
  > Change 209870 had a related patch set uploaded (by Florianschmidtwelzow):
  >  Don't output an empty h1 element
  >
  > https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/209870/
  
  
  This was effectively reverted  in d56792addb 
<https://phabricator.wikimedia.org/rSVECd56792addb8464997772b566db71a78c39e5cf30>
 (change 500805 
<https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/500805/>) to fix 
T219864 <https://phabricator.wikimedia.org/T219864>.
  
  I think the original use case of allowing extensions to control part of the 
skin layout is interesting and worth exploring still. Having said that, it 
seems Flow, Echo and Wikibase no longer use this feature (and Gather was 
undeployed). I wasn't able to find a use of it in Codesearch, but maybe I 
missed it?
  
  I'd be interested in re-considering this feature with a specific use case in 
mind to see how we can best balance the need for flexibility, and the 
maintenance cost + developer usability involved. There are also other ways to 
do this, such as through a Skin method, or through a documented CSS class. It 
might then also make sense to tailer the interface to a more specific semantic 
intent so that the skin can respond in some way rather than just leaving a gap 
in its design. The notion of "Don't render the h 1"  seems rather specific and 
hard to accommodate universally in all designs. Not to mention the impact on 
other extensions and gadgets from a central element missing on the page.

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Florian, Krinkle
Cc: Krinkle, gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, 
Aklapper, Jdlrobson, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T206966: Wikibase does not support database table prefix

2019-04-02 Thread Krinkle
Krinkle removed a project: MediaWiki-Database.

TASK DETAIL
  https://phabricator.wikimedia.org/T206966

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: lucamauri, Addshore, Aklapper, KitsuneSolar, alaa_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331, Banyek, Rayssa-, Dinoguy1000, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-03 Thread Krinkle
Krinkle added a comment.


  In T97891#5080051 <https://phabricator.wikimedia.org/T97891#5080051>, 
@Jdlrobson wrote:
  
  > @krinkle I think the broken "0" page is much less of a concern than the 
current situation we find ourselves in.
  
  
  What exactly is the problem at https://en.wikivoyage.org/wiki/Singapore?
  
  F28571332: Screenshot 2019-04-03 at 17.57.40.png 
<https://phabricator.wikimedia.org/F28571332>

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, 
adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, alaa_wmde, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, 
Luke081515, Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g, Niedzielski
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-03 Thread Krinkle
Krinkle added a comment.


  OK. Looks like it's still Varnish cached for most pages. But I see when 
logged-in now. I've hot-fixed for now by hiding it with CSS 
<https://en.wikivoyage.org/wiki/MediaWiki:Vector.css>.
  
  It's been visible on Minerva/MobileFrontend for years without issue, but it's 
less obvious there given Minerva's heading element neatly merges with the 
surrounding elements when empty (no forced margin or border).
  F28571360: Screenshot 2019-04-03 at 18.05.26.png 
<https://phabricator.wikimedia.org/F28571360>
  
  In terms of medium/long strategy, it seems to me like the obvious way forward 
is for there not to be two headings. Rather then trying to suppress one, and 
insert another (neither for which the WPB extension controls the position or 
layout) - would it make sense to instead replace the existing one? The skin 
method behind this supports HTML (nor just text), which we can make use of.

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, 
adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, alaa_wmde, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, 
Luke081515, Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g, Niedzielski
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Lowered Priority] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-03 Thread Krinkle
Krinkle lowered the priority of this task from "Unbreak Now!" to "High".
Krinkle added a comment.


  The unintended regression from Wikivoyage was only live for a few hours and 
is now mitigated.
  
  @Johan If we want to highlight the "title 0" bug in Tech-News (which was live 
4-8 days, depending on the wiki), the conversation about that is mainly at 
T219864 <https://phabricator.wikimedia.org/T219864>. I would summarise it as: A 
regression in last weeks' branch caused the Vector skin to no longer show the 
top heading for pages with the title "0". This was fixed on Tuesday for all 
wikis.

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, 
adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, alaa_wmde, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, 
Luke081515, Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-03 Thread Krinkle
Krinkle added a comment.


  In T97891#5082437 <https://phabricator.wikimedia.org/T97891#5082437>, 
@Jdlrobson wrote:
  
  > > OK. Looks like it's still Varnish cached for most pages. But I see when 
logged-in now. I've hot-fixed for now by hiding it with CSS.
  >
  > What about all the other Wikivoyage projects? Are we confident this (having 
2 h1s in the page in the heading) is not having a negative impact on SEO for 
Wikivoyage?
  
  
  The SEO case isn't relevant. Similar to T198947 
<https://phabricator.wikimedia.org/T198947>. In part because crawlers don't 
care whether there are multiple same-level headings on a page. I've yet to see 
evidence indicating that the document structure is in any way considered. If 
there were headings at all, that might pose a problem, but that's not the case 
here.
  
  Between WMF sites and Google in particular, our web views aren't actually 
indexed. Parsoid is used instead.

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, 
adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, alaa_wmde, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, 
Luke081515, Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-03 Thread Krinkle
Krinkle added a comment.


  In T97891#5082509 <https://phabricator.wikimedia.org/T97891#5082509>, 
@Jdlrobson wrote:
  
  > It's still on Russian Wikivoyage 
https://ru.wikivoyage.org/wiki/%D0%A3%D0%BF%D0%BF%D1%81%D0%B0%D0%BB%D0%B0
  
  
  I was still going through them :)
  
  Found floating headline and fixed it: en, bn, es, fi, fr, he, it, ps, ro, ru, 
uk, vi, zh.
  Appear unaffected: de, el, fa, pl, nl, pt, sv.
  Broken for unrelated reasons (and fixed): hi.

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, 
adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, alaa_wmde, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, 
Luke081515, Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist

2019-04-05 Thread Krinkle
Krinkle added a project: WikimediaEditorTasks.
Restricted Application added a project: Reading-Infrastructure-Team-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T220153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, MarcoAurelio, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist

2019-04-05 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T220153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, MarcoAurelio, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist

2019-04-05 Thread Krinkle
Krinkle added a parent task: T206679: 1.33.0-wmf.25 deployment blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T220153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, MarcoAurelio, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist

2019-04-05 Thread Krinkle
Krinkle added a comment.


  Tentatively marking as blocking next week's branch. If this is indeed due to 
config or code changes, then this weeks' post-Tuesday state in Beta would 
become part of wmf.25.

TASK DETAIL
  https://phabricator.wikimedia.org/T220153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, MarcoAurelio, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-07 Thread Krinkle
Krinkle added a comment.


  In T97891#5083116 <https://phabricator.wikimedia.org/T97891#5083116>, 
@Jdlrobson wrote:
  
  > > t's been visible on Minerva/MobileFrontend for years without issue,
  >
  > @krinkle that's not true. Your patch 
https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/500814/1/includes/skins/SkinMinerva.php
 is why the h1 is present on Minerva.
  
  
  No, it's not. Take another look and explain where the previous code results 
in the Minerva method not returning an `` element.

TASK DETAIL
  https://phabricator.wikimedia.org/T97891

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, 
adrianheine, Florian, Aklapper, Jdlrobson, alaa_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, Luke081515, 
Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-07 Thread Krinkle
Krinkle triaged this task as "High" priority.
Krinkle added a subscriber: Pablo-WMDE.
Krinkle added a comment.


  Ping @Pablo-WMDE
  
  - 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/439951/
  - T191600: Showing the lemma in recent changes 
<https://phabricator.wikimedia.org/T191600>

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Pablo-WMDE, Liuxinyu970226, Krinkle, alaa_wmde, Nandana, Mringgaard, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Raised Priority] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-09 Thread Krinkle
Krinkle raised the priority of this task from "High" to "Unbreak Now!".
Krinkle added a project: ContentTranslation.

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, TerraCodes, hashar, Nikerabbit, greg, KartikMistry, WMDE-leszek, 
Pablo-WMDE, Liuxinyu970226, Krinkle, alaa_wmde, Nandana, Mringgaard, Lahi, 
Gq86, GoranSMilovanovic, chapulina, QZanden, LawExplorer, _jensen, rosalieper, 
Nizil, Ixocactus, Wikidata-bugs, aude, Amire80, Jsahleen, Darkdadaah, Arrbee, 
santhosh, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T220229: Merge Blocker: Test failures in WikibaseLexeme: Special:RecentChanges shows lemmas in title links to lexemes

2019-04-09 Thread Krinkle
Krinkle closed this task as a duplicate of T219584: Flaky wdio test 
"RecentChanges shows lemmas in title links".
Restricted Application removed a subscriber: Liuxinyu970226.

TASK DETAIL
  https://phabricator.wikimedia.org/T220229

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: greg, Nikerabbit, hashar, TerraCodes, Aklapper, KartikMistry, alaa_wmde, 
Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, chapulina, QZanden, 
LawExplorer, _jensen, rosalieper, Nizil, Jonas, Ixocactus, thcipriani, 
Wikidata-bugs, aude, Amire80, Lydia_Pintscher, Jsahleen, Darkdadaah, Arrbee, 
santhosh, Mbch331, Jay8g, Liuxinyu970226
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-09 Thread Krinkle
Krinkle merged a task: T220229: Merge Blocker: Test failures in WikibaseLexeme: 
Special:RecentChanges shows lemmas in title links to lexemes.
Krinkle added subscribers: KartikMistry, greg, Nikerabbit, hashar, TerraCodes, 
Aklapper.

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, TerraCodes, hashar, Nikerabbit, greg, KartikMistry, WMDE-leszek, 
Pablo-WMDE, Liuxinyu970226, Krinkle, alaa_wmde, Nandana, Mringgaard, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-09 Thread Krinkle
Krinkle added a comment.


  In T220229#5099579 <https://phabricator.wikimedia.org/T220229#5099579>, @greg 
wrote:
  
  > Is there reason to believe this is a CI-Infra issue?
  
  
  No, I don't think so :)

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, TerraCodes, hashar, Nikerabbit, greg, KartikMistry, WMDE-leszek, 
Pablo-WMDE, Liuxinyu970226, Krinkle, alaa_wmde, Nandana, Mringgaard, Lahi, 
Gq86, GoranSMilovanovic, chapulina, QZanden, LawExplorer, _jensen, rosalieper, 
Nizil, Ixocactus, Wikidata-bugs, aude, Amire80, Jsahleen, Darkdadaah, Arrbee, 
santhosh, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-09 Thread Krinkle
Krinkle added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, TerraCodes, hashar, Nikerabbit, greg, KartikMistry, WMDE-leszek, 
Pablo-WMDE, Liuxinyu970226, Krinkle, alaa_wmde, Nandana, Mringgaard, Lahi, 
Gq86, GoranSMilovanovic, chapulina, QZanden, LawExplorer, _jensen, rosalieper, 
Nizil, Jonas, Ixocactus, Wikidata-bugs, aude, Amire80, Lydia_Pintscher, 
Jsahleen, Darkdadaah, Arrbee, santhosh, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T220153: Beta Wikidata: Error: 1146 Table 'wikishared.wikimedia_editor_tasks_keys' doesn't exist

2019-04-09 Thread Krinkle
Krinkle closed this task as "Resolved".
Krinkle added a comment.


  Yep. Got fixed before the branch cut.
  
  F28599651: capture.png <https://phabricator.wikimedia.org/F28599651>

TASK DETAIL
  https://phabricator.wikimedia.org/T220153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway, Krinkle
Cc: Jdforrester-WMF, mmodell, Tgr, Mholloway, Krinkle, Aklapper, MarcoAurelio, 
alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Wikidata-bugs, bearND, aude, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-10 Thread Krinkle
Krinkle added a comment.


  Please disable the test and figure it out later :)

TASK DETAIL
  https://phabricator.wikimedia.org/T219584

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Jakob_WMDE, Aklapper, TerraCodes, hashar, Nikerabbit, greg, KartikMistry, 
WMDE-leszek, Pablo-WMDE, Liuxinyu970226, Krinkle, alaa_wmde, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, chapulina, QZanden, LawExplorer, 
_jensen, rosalieper, Nizil, Jonas, Ixocactus, Wikidata-bugs, aude, Amire80, 
Lydia_Pintscher, Jsahleen, Darkdadaah, Arrbee, santhosh, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189333: Changing Kibana filters is ridiculously slow

2019-04-10 Thread Krinkle
Krinkle added a comment.


  @alaa_wmde This is still contributing to making Logstash nearly unusable 
(beyond short-term fire fighting).
  
  I'm helping various teams get visibility into the production state of their 
software, but Logstash responsiveness is making that quite difficult to get to 
work for dashboards about specific services and teams, due to all interaction 
with filters either timing out (Safari), crashing the browser (Firefox) or 
taking 30s to a minute (Chrome). (//based on sparse anecdotal evidence, YMMV//).
  
  Let me know if I can help in some way. I don't know Wikibase very well, but 
if the data in question isn't monitored in a Logstash query, it should be 
straight-forward to omit from logging and/or reformat in a way that uses a 
finite number of keys.

TASK DETAIL
  https://phabricator.wikimedia.org/T189333

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: alaa_wmde, kostajh, Addshore, Krinkle, ssastry, tstarling, Aklapper, Tgr, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Mbch331, fgiunchedi, jeremyb, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T197667: Parsoid/Restbase in Wikibase development containers for VisualEditor

2019-04-12 Thread Krinkle
Krinkle renamed this task from "Integrate visual editor" to "Parsoid/Restbase 
in Wikibase development containers for VisualEditor".

TASK DETAIL
  https://phabricator.wikimedia.org/T197667

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Nikerabbit, Aklapper, Addshore, despens, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-04-15 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-04-15 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-04-15 Thread Krinkle
Krinkle removed a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-04-15 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-04-17 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T212550: Implement support for ChronologyProtection in RDF export

2019-04-18 Thread Krinkle
Krinkle added a project: Performance-Team.
Krinkle added a comment.


  Another question for @aaron as well - If we start storing this 
chronologyprotector field in kafka etc. that means it can survive longer and no 
longer has an expiry like we do for cookies. I vaguely recall an issue in the 
past where clients that kept the value too long caused subsequent requests to 
stall for many seconds as MW mistook the unknown value for a value that hasn't 
appeared yet.
  
  It may've been mitigated already, but if not, we'll need to sort that out 
before this goes live.

TASK DETAIL
  https://phabricator.wikimedia.org/T212550

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Ottomata, Aklapper, Smalyshev, aaron, alaa_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, 
Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221295: Wikidata changes doesn't appear in recent changes

2019-04-20 Thread Krinkle
Krinkle added a comment.


  For the record, the issue with the job queue only affected test wikis and 
mediawiki.org. As a precaution we paused the job queue for all wikis (including 
Wikidata and Wikipedia).
  
  When the job queue was started again, all waiting jobs were executed first. 
This means all pending updates should now be visible. If you find that updates 
were lost, please re-open the task. Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T221295

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, mobrovac, Lydia_Pintscher, Nirmos, Aklapper, eranroz, alaa_wmde, 
Nandana, kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T216956: deploy WikibaseSchema to test

2019-04-23 Thread Krinkle
Krinkle added a comment.


  I don't know where to leave this feedback, but I'll place it here for now:
  
  - This extension registers a generically called namespace named "Schema", 
this overlaps with at least one other extension already (EventLogging). I 
recommend choosing a more specific name.
  - This extension registers two generically called special pages, 
"Special:NewSchema" and "Special:SchemaText". I don't know what they though. 
Knowing Wikidata from a user perspective mainly, I would expect the name to be 
more clear and specific about what it is for.
  - It's unclear to me why this is going through the costly overhead of yet 
another Wikibase* MediaWiki extension. If the code is meant to be re-usable, 
perhaps publish it as a Composer library installed into Wikibase via vendor or 
gitmodule? Is that now how other parts of Wikibase are organised? What end-user 
product story is the extension offering on its own? (It appears none, but I 
don't know for sure.)

TASK DETAIL
  https://phabricator.wikimedia.org/T216956

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Lucas_Werkmeister_WMDE, Tarrow, Ifygal3, Aklapper, 
Lydia_Pintscher, pdehaye, alaa_wmde, Michael, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, 
_jensen, rosalieper, Jonas, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T222346: [Bug] Drop-down doesn't appear when typing in the Wikidata search box

2019-05-04 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T222346

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Nikki, Pigsonthewing, debt, Moebeus, Michael, Lucas_Werkmeister_WMDE, 
jhsoby, Infovarius, Smalyshev, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, 
alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-05-06 Thread Krinkle
Krinkle removed projects: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 
Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
Agabi10, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair, joker88john, CucyNoiD, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!

2019-05-06 Thread Krinkle
Krinkle moved this task from Found during 1.33-wmf.19 to Resolved on the 
Wikimedia-production-error board.
Krinkle added a comment.


  No longer seen in production as of April 18.
  F28943449: Screenshot 2019-05-06 at 19.04.35.png 
<https://phabricator.wikimedia.org/F28943449>

TASK DETAIL
  https://phabricator.wikimedia.org/T217285

WORKBOARD
  https://phabricator.wikimedia.org/project/board/1055/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Jdforrester-WMF, greg, Addshore, WMDE-leszek, Ladsgroup, 
matthiasmullie, TerraCodes, Liuxinyu970226, Stashbot, gerritbot, Aklapper, 
hashar, alaa_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Jonas, 
Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-05-06 Thread Krinkle
Krinkle added a comment.


  @ArielGlenn Is this resolved?

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
Agabi10, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T222090: UnexpectedValueException when clearing Lexeme via wbeditentity without providing new language

2019-05-07 Thread Krinkle
Krinkle removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T222090

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, Krinkle
Cc: Tarrow, Lucas_Werkmeister_WMDE, darthmon_wmde, alaa_wmde, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair, joker88john, CucyNoiD, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T222090: UnexpectedValueException when clearing Lexeme via wbeditentity without providing new language

2019-05-08 Thread Krinkle
Krinkle moved this task from In progress to Resolved on the 
Wikimedia-production-error (Shared Build Failure) board.
Krinkle added a comment.


  Is this resolved?

TASK DETAIL
  https://phabricator.wikimedia.org/T222090

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3298/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, Krinkle
Cc: Krinkle, Tarrow, Lucas_Werkmeister_WMDE, darthmon_wmde, alaa_wmde, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T219452: Cannot add a Wikidata sitelink [2019-03-27]

2019-05-09 Thread Krinkle
Krinkle added a comment.


  Re-applied as of d17c7e68afa5b7acdfff5aba53e7155acf8c3f76 
<https://phabricator.wikimedia.org/rEWBAd17c7e68afa5b7acdfff5aba53e7155acf8c3f76>
 / https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/499920/

TASK DETAIL
  https://phabricator.wikimedia.org/T219452

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, Krinkle
Cc: Arch2all, Krinkle, Lea_Lacroix_WMDE, Pamputt, MisterSynergy, 
Marshallsumter, Mholloway, Lucas_Werkmeister_WMDE, Smalyshev, dcausse, 
Addshore, abian, IKhitron, Ymblanter, Fnielsen, Lydia_Pintscher, Mike_Peel, 
Jdforrester-WMF, TerraCodes, Liuxinyu970226, MarcoAurelio, jhsoby, Amire80, 
Aklapper, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Blocker] T68051: Implement Lua alternative to {{int:Lang}} / wgUserLanguage

2019-05-09 Thread Krinkle
Krinkle changed the status of subtask T4085: Add a {{USERLANGUAGE}} magic word 
from "Open" to "Stalled".

TASK DETAIL
  https://phabricator.wikimedia.org/T68051

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: daniel, Ricordisamoa, Capankajsmilyo, zhuyifei1999, Jackmcbarn, 
Liuxinyu970226, Rama, Jarekt, Multichill, Aklapper, Rical, Nemo_bis, Anomie, 
He7d3r, tstarling, wikibugs-l-list, vvv, darthmon_wmde, alaa_wmde, Nandana, 
Lahi, Gq86, Baloch007, Xinbenlv, GoranSMilovanovic, QZanden, LawExplorer, 
SundanceRaphael, _jensen, rosalieper, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Arrbee, KartikMistry, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-05-09 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, darthmon_wmde, 
alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T223085: ErrorException from line 155 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php:

2019-05-13 Thread Krinkle
Krinkle added a comment.


  Seems like something Phan should have caught easily?
  
  Caused by 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/506867/.

TASK DETAIL
  https://phabricator.wikimedia.org/T223085

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T223085: ErrorException from line 155 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: PHP

2019-05-13 Thread Krinkle
Krinkle created this task.
Krinkle added projects: Wikimedia-production-error, 
MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  Request URL: /w/api.php
  Request ID: `XNlL4gpAIDUAABDN9i0AAABE `
  
  name=message
ErrorException from line 155 of 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php:
 PHP Notice: Undefined variable: rlModulesArr
  
  name=trace
#0 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php(155):
 MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php(89):
 Wikibase\Lib\CachingKartographerEmbeddingHandler->getMapframeInitJS(string, 
array, array)
#2 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/GlobeCoordinateKartographerFormatter.php(78):
 
Wikibase\Lib\CachingKartographerEmbeddingHandler->getPreviewHtml(DataValues\Geo\Values\GlobeCoordinateValue,
 LanguageAr)
#3 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/DispatchingValueFormatter.php(75):
 
Wikibase\Lib\GlobeCoordinateKartographerFormatter->format(DataValues\Geo\Values\GlobeCoordinateValue)
#4 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/PropertyValueSnakFormatter.php(148):
 
Wikibase\Lib\Formatters\DispatchingValueFormatter->formatValue(DataValues\Geo\Values\GlobeCoordinateValue,
 string)
#5 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/PropertyValueSnakFormatter.php(117):
 
Wikibase\Lib\PropertyValueSnakFormatter->formatValue(DataValues\Geo\Values\GlobeCoordinateValue,
 string)
#6 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/DispatchingSnakFormatter.php(151):
 
Wikibase\Lib\PropertyValueSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak)
#7 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/ErrorHandlingSnakFormatter.php(68):
 
Wikibase\Lib\DispatchingSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak)
#8 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/repo/includes/Api/FormatSnakValue.php(115):
 
Wikibase\Lib\Formatters\ErrorHandlingSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak)
#9 
/srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/repo/includes/Api/FormatSnakValue.php(92):
 Wikibase\Repo\Api\FormatSnakValue->formatValue(array, 
DataValues\Geo\Values\GlobeCoordinateValue, NULL)
#10 /srv/mediawiki/php-1.34.0-wmf.4/includes/api/ApiMain.php(1593): 
Wikibase\Repo\Api\FormatSnakValue->execute()
#11 /srv/mediawiki/php-1.34.0-wmf.4/includes/api/ApiMain.php(531): 
ApiMain->executeAction()
#12 /srv/mediawiki/php-1.34.0-wmf.4/includes/api/ApiMain.php(502): 
ApiMain->executeActionWithErrorHandling()
#13 /srv/mediawiki/php-1.34.0-wmf.4/api.php(87): ApiMain->execute()
#14 /srv/mediawiki/w/api.php(3): include(string)
  
  
  
  Impact
  --
  
  Notes
  -

TASK DETAIL
  https://phabricator.wikimedia.org/T223085

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T223085: ErrorException from line 155 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: PHP N

2019-05-13 Thread Krinkle
Krinkle closed this task as "Resolved".
Krinkle claimed this task.
Krinkle removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T223085

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair, joker88john, CucyNoiD, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reassigned] T223085: ErrorException from line 155 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: P

2019-05-13 Thread Krinkle
Krinkle reassigned this task from Krinkle to Jdforrester-WMF.
Krinkle added a project: Performance-Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T223085

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF, Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, alaa_wmde, Nandana, Imarlier, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T221127: URL shortener widget is hard to copy

2019-05-17 Thread Krinkle
Krinkle claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T221127

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Theklan, Multichill, Pigsonthewing, Jheald, Smalyshev, Ladsgroup, 
Nemo_bis, Aklapper, darthmon_wmde, alaa_wmde, Ferenczy, sarhan.alaa, 
Samuditha24, IM3847, Dinadineke, Nandana, kostajh, tabish.shaikh91, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, Soteriaspace, Jayprakash12345, 
Chicocvenancio, JakeTheDeveloper, MichaelSchoenitzer_WMDE, QZanden, EBjune, 
merbst, LawExplorer, Framawiki, Salgo60, Jogi_don, _jensen, rosalieper, 
D3r1ck01, Jonas, Xmlizer, Samwilson, jkroll, Wikidata-bugs, Jdouglas, 
Jdlrobson, aude, Tobias1984, Manybubbles, Lydia_Pintscher, TheDJ, Mbch331, Rxy, 
Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T207235: PHP error from ArticlePlaceholder hook on SpecialSearch

2019-05-18 Thread Krinkle
Krinkle added a comment.


  Still seen, several hundred times per day. User impact remains undetermined 
and unknown.
  
  - Request: GET `/w/index.php?title=Special%3ASearch&search= … &go=OK`
  - ID: `XN-hfApAADoAACZ-PJ4AAAFJ`
  
PHP Notice: Undefined index: Q22668172
0 
/srv/mediawiki/php-1.34.0-wmf.5/extensions/ArticlePlaceholder/includes/ItemNotabilityFilter.php(85):
 MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 
/srv/mediawiki/php-1.34.0-wmf.5/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(238):
 ArticlePlaceholder\ItemNotabilityFilter->getNotableEntityIds(array)
#2 
/srv/mediawiki/php-1.34.0-wmf.5/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(182):
 ArticlePlaceholder\SearchHookHandler->renderTermSearchResults(array)
#3 
/srv/mediawiki/php-1.34.0-wmf.5/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(170):
 ArticlePlaceholder\SearchHookHandler->addToSearch(SpecialSearch, OutputPage, 
string)
#4 /srv/mediawiki/php-1.34.0-wmf.5/includes/Hooks.php(174): 
ArticlePlaceholder\SearchHookHandler::onSpecialSearchResultsAppend(SpecialSearch,
 OutputPage, string)
#5 /srv/mediawiki/php-1.34.0-wmf.5/includes/Hooks.php(202): 
Hooks::callHook(string, array, array, NULL)
#6 
/srv/mediawiki/php-1.34.0-wmf.5/includes/specials/SpecialSearch.php(477): 
Hooks::run(string, array)
#7 
/srv/mediawiki/php-1.34.0-wmf.5/includes/specials/SpecialSearch.php(173): 
SpecialSearch->showResults(string)
#8 
/srv/mediawiki/php-1.34.0-wmf.5/includes/specialpage/SpecialPage.php(570): 
SpecialSearch->execute(NULL)
#9 
/srv/mediawiki/php-1.34.0-wmf.5/includes/specialpage/SpecialPageFactory.php(575):
 SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(288): 
MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(865): 
MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.34.0-wmf.5/includes/MediaWiki.php(515): 
MediaWiki->main()
#13 /srv/mediawiki/php-1.34.0-wmf.5/index.php(42): MediaWiki->run()

TASK DETAIL
  https://phabricator.wikimedia.org/T207235

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Smalyshev, Lydia_Pintscher, Addshore, Ladsgroup, Krinkle, Aklapper, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
cmadeo, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, jayvdb, 
Ricordisamoa, zeljkofilipin, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T221127: URL shortener widget is hard to copy

2019-05-19 Thread Krinkle
Krinkle closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T221127

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Fuzheado, Krinkle, Theklan, Multichill, Pigsonthewing, Jheald, Smalyshev, 
Ladsgroup, Nemo_bis, Aklapper, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Ferenczy, sarhan.alaa, Samuditha24, IM3847, joker88john, Dinadineke, DannyS712, 
CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, tabish.shaikh91, Adrian1985, Cpaulf30, Lahi, 
Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, 
GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Chicocvenancio, 
Th3d3v1ls, JakeTheDeveloper, Ramalepe, MichaelSchoenitzer_WMDE, Liugev6, 
QZanden, EBjune, merbst, LawExplorer, Framawiki, Salgo60, WSH1906, Lewizho99, 
Maathavan, Jogi_don, _jensen, rosalieper, D3r1ck01, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, Jdlrobson, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, TheDJ, Mbch331, Rxy, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T221127: URL shortener widget is hard to copy

2019-05-19 Thread Krinkle
Krinkle removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T221127

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Fuzheado, Krinkle, Theklan, Multichill, Pigsonthewing, Jheald, Smalyshev, 
Ladsgroup, Nemo_bis, Aklapper, darthmon_wmde, alaa_wmde, Ferenczy, sarhan.alaa, 
Samuditha24, IM3847, Dinadineke, DannyS712, Nandana, kostajh, tabish.shaikh91, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Soteriaspace, 
Jayprakash12345, Chicocvenancio, JakeTheDeveloper, MichaelSchoenitzer_WMDE, 
QZanden, EBjune, merbst, LawExplorer, Framawiki, Salgo60, Jogi_don, _jensen, 
rosalieper, D3r1ck01, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, 
Jdlrobson, aude, Tobias1984, Manybubbles, Lydia_Pintscher, TheDJ, Mbch331, Rxy, 
Legoktm, E.S.A-Sheild, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T223310: Investigate increase in tx bandwidth usage for mc1033

2019-05-20 Thread Krinkle
Krinkle added a subscriber: Tarrow.
Krinkle added projects: Wikidata-Campsite, Growth-Team.
Restricted Application added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T223310

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: elukey, Krinkle
Cc: Tarrow, alaa_wmde, Catrope, kostajh, Joe, Krinkle, aaron, jijiki, Aklapper, 
akosiaris, elukey, Addshore, darthmon_wmde, Legado_Shulgin, Nandana, thifranc, 
AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, 
Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Vali.matei, Zppix, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, faidon, 
Mbch331, Jay8g, fgiunchedi, Dzahn
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T223310: Investigate increase in tx bandwidth usage for mc1033

2019-05-21 Thread Krinkle
Krinkle added a project: Wikimedia-Incident.

TASK DETAIL
  https://phabricator.wikimedia.org/T223310

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: elukey, Krinkle
Cc: Tarrow, alaa_wmde, Catrope, kostajh, Joe, Krinkle, aaron, jijiki, Aklapper, 
akosiaris, elukey, Addshore, E.S.A-Sheild, darthmon_wmde, joker88john, 
Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, thifranc, AndyTan, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, 
Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, 
LawExplorer, Vali.matei, WSH1906, Lewizho99, Zppix, Maathavan, _jensen, 
rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, ArielGlenn, 
Lydia_Pintscher, faidon, He7d3r, Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi, 
Dzahn
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T223310: Investigate increase in tx bandwidth usage for mc1033

2019-05-21 Thread Krinkle
Krinkle removed a project: Wikimedia-Incident.

TASK DETAIL
  https://phabricator.wikimedia.org/T223310

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: elukey, Krinkle
Cc: Tarrow, alaa_wmde, Catrope, kostajh, Joe, Krinkle, aaron, jijiki, Aklapper, 
akosiaris, elukey, Addshore, E.S.A-Sheild, darthmon_wmde, joker88john, 
Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, thifranc, AndyTan, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, 
Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, 
LawExplorer, Vali.matei, WSH1906, Lewizho99, Zppix, Maathavan, _jensen, 
rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, faidon, Mbch331, Jay8g, fgiunchedi, Dzahn, ArielGlenn, He7d3r, 
Jdforrester-WMF
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T223310: Investigate increase in tx bandwidth usage for mc1033

2019-05-21 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache.

TASK DETAIL
  https://phabricator.wikimedia.org/T223310

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: elukey, Krinkle
Cc: Tarrow, alaa_wmde, Catrope, kostajh, Joe, Krinkle, aaron, jijiki, Aklapper, 
akosiaris, elukey, Addshore, E.S.A-Sheild, darthmon_wmde, joker88john, 
Legado_Shulgin, CucyNoiD, Nandana, NebulousIris, thifranc, AndyTan, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, 
Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, 
LawExplorer, Vali.matei, WSH1906, Lewizho99, Zppix, Maathavan, _jensen, 
rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, faidon, Mbch331, Jay8g, fgiunchedi, Dzahn
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T224270: Exception in Production when trying to diff two different Entity types

2019-05-24 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T224270

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Michael, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T224030: Exception in Production when trying to undo a change on a merged item

2019-05-24 Thread Krinkle
Krinkle moved this task from Untriaged to Found during 1.34-wmf.5 on the 
Wikimedia-production-error board.
Krinkle added a comment.


  @Michael If you want, there is a template you can use for this kind of task. 
Via "Create Task > Report Error Code", or via #wikimedia-production-error 
<https://phabricator.wikimedia.org/tag/wikimedia-production-error/> → "Report 
Error".

TASK DETAIL
  https://phabricator.wikimedia.org/T224030

WORKBOARD
  https://phabricator.wikimedia.org/project/board/1055/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, Michael, darthmon_wmde, Premeditated, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T224303: Wikibase Repo prevents page moves in NS 0 on Commons

2019-05-25 Thread Krinkle
Krinkle added a comment.


  Smells like Incident 20190328-commons 
<https://wikitech.wikimedia.org/wiki/Incident_documentation/20190328-commons> / 
T219450: "wikitext" content is not allowed on page … in slot "Main" 
<https://phabricator.wikimedia.org/T219450>.

TASK DETAIL
  https://phabricator.wikimedia.org/T224303

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Reedy, Simetrical, 4nn1l2, Clpo13, Aklapper, JuTa, darthmon_wmde, 
Premeditated, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
Jayprakash12345, QZanden, V4switch, LawExplorer, Poyekhali, _jensen, 
rosalieper, Jonas, Wong128hk, Wikidata-bugs, matthiasmullie, aude, El_Grafo, 
Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Jdforrester-WMF, 
Steinsplitter, Matanya, Mbch331, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T224024: Fatal Error on Commons from Special:EntityData with n3 format (Argument to addEntityRedirect must be EntityId, null given)

2019-05-26 Thread Krinkle
Krinkle renamed this task from "Fatal Error on commons wiki from 
Special:EntityData with n3 format" to "Fatal Error on Commons from 
Special:EntityData with n3 format (Argument to addEntityRedirect must be 
EntityId, null given)".

TASK DETAIL
  https://phabricator.wikimedia.org/T224024

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Smalyshev, 20038011003, MarkTraceur, Aklapper, Michael, darthmon_wmde, 
Premeditated, Edtadros, Nandana, JKSTNK, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, rosalieper, Jonas, 
Wong128hk, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, 
Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope

2019-05-27 Thread Krinkle
Krinkle added a comment.


  I'm seeing this consistently when saving edits to test2.wikipedia.org Sandbox 
(when add or removing a transclusion):
  
type: mediawiki
channel: DBPerformance
level: ERROR

Wikimedia\Rdbms\LBFactory::commitAndWaitForReplication: 
LinksUpdate::incrTableUpdate does not have outer scope.

#0 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/LinksUpdate.php(494): 
Wikimedia\Rdbms\LBFactory->commitAndWaitForReplication('LinksUpdate::in...', 
NULL, Array)
#1 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/LinksUpdate.php(282): 
LinksUpdate->incrTableUpdate('templatelinks', 'tl', Array, Array)
#2 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/LinksUpdate.php(189): 
LinksUpdate->doIncrementalUpdate()
#3 
/srv/mediawiki/php-1.34.0-wmf.6/includes/Storage/DerivedPageDataUpdater.php(1622):
 LinksUpdate->doUpdate()
#4 
/srv/mediawiki/php-1.34.0-wmf.6/includes/Storage/DerivedPageDataUpdater.php(1429):
 MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(Array)
#5 
/srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/MWCallableUpdate.php(34): 
MediaWiki\Storage\DerivedPageDataUpdater->MediaWiki\Storage\{closure}()
#6 
/srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/DeferredUpdates.php(274): 
MWCallableUpdate->doUpdate()
#7 
/srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/DeferredUpdates.php(219): 
DeferredUpdates::runUpdate(Object(MWCallableUpdate), 
Object(Wikimedia\Rdbms\LBFactoryMulti), 'run', 2)
#8 
/srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/DeferredUpdates.php(143): 
DeferredUpdates::execute(Array, 'run', 2)
#9 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(907): 
DeferredUpdates::doUpdates('run')
#10 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(731): 
MediaWiki->restInPeace('normal', false)
#11 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(754): 
MediaWiki->{closure}()
#12 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(548): 
MediaWiki->doPostOutputShutdown('normal')
#13 /srv/mediawiki/php-1.34.0-wmf.6/index.php(42): MediaWiki->run()
  
  I don't know if it is the same issue or not, but core updates being broken 
definitely seems like a regression. If this is the same issue as reported in 
this task, I'd like to ask again whether we can identify what caused this 
regression recently and focus on separately from the "Retry failed 
DeferredUpdates" refactor, so as to reduce risk and to allow that to ride the 
train and beta phases normally. (In addition to currently being incompatible 
with Wikibase, and thus blocked).

TASK DETAIL
  https://phabricator.wikimedia.org/T221577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: WMDE-leszek, alaa_wmde, Ladsgroup, Lydia_Pintscher, daniel, akosiaris, 
JTannerWMF, Krinkle, Jdforrester-WMF, Marostegui, aaron, TerraCodes, 
Liuxinyu970226, Aklapper, jcrespo, E.S.A-Sheild, darthmon_wmde, Premeditated, 
joker88john, CucyNoiD, Nandana, NebulousIris, Banyek, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Rayssa-, Lahi, 
Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, V4switch, LawExplorer, 
Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wong128hk, Niharika, Wikidata-bugs, matthiasmullie, aude, Dinoguy1000, 
Fabrice_Florin, MaxSem, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T223310: Investigate increase in tx bandwidth usage for mc1033

2019-05-27 Thread Krinkle
Krinkle closed this task as "Resolved".
Krinkle reassigned this task from elukey to aaron.
Krinkle removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T223310

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: Nikerabbit, Krenair, Tarrow, alaa_wmde, Catrope, kostajh, Joe, Krinkle, 
aaron, jijiki, Aklapper, akosiaris, elukey, Addshore, darthmon_wmde, 
Premeditated, Legado_Shulgin, Nandana, thifranc, AndyTan, Davinaclare77, 
Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, 
LawExplorer, Vali.matei, Zppix, _jensen, rosalieper, Taiwania_Justo, Jonas, 
Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, faidon, Mbch331, Jay8g, 
fgiunchedi, Dzahn, E.S.A-Sheild, joker88john, CucyNoiD, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Ramalepe, Liugev6, WSH1906, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

2019-05-27 Thread Krinkle
Krinkle added a comment.


  Recovery:
  F29260036: Screenshot 2019-05-27 at 19.47.29.png 
<https://phabricator.wikimedia.org/F29260036>

TASK DETAIL
  https://phabricator.wikimedia.org/T223310

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: Nikerabbit, Krenair, Tarrow, alaa_wmde, Catrope, kostajh, Joe, Krinkle, 
aaron, jijiki, Aklapper, akosiaris, elukey, Addshore, darthmon_wmde, 
Premeditated, Legado_Shulgin, Nandana, thifranc, AndyTan, Davinaclare77, 
Qtn1293, Imarlier, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, 
LawExplorer, Vali.matei, Zppix, _jensen, rosalieper, Taiwania_Justo, Jonas, 
Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, faidon, Mbch331, Jay8g, 
fgiunchedi, Dzahn
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T224488: PHP Fatal Error: Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found

2019-05-28 Thread Krinkle
Krinkle created this task.
Krinkle added projects: Wikimedia-production-error, 
MediaWiki-extensions-WikibaseClient, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Error
  -
  
  Request URL: `/wiki/{Page_title}` (Wikipedias, page views)
  Request ID: `XO1PdApAADkAAHQOESkB`
  
  name=message
[{exception_id}] {exception_url}   PHP Fatal Error from line 29 of 
/srv/mediawiki/php-1.34.0-wmf.6/vendor/wikibase/data-model/src/Entity/Item.php: 
Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found
  
  name=trace
#0 [internal function]: MWExceptionHandler::handleFatalError()
#1 {main}
  
  
  
  Impact
  --
  
  Users in the PHP 7 traffic bucket, are sometimes unable to view pages. They 
are instead getting a fatal error due to a Wikibase class being undefined.
  
  These result in a generic system error page, which leave users stranded. The 
HTTP responses (status code 500) are not cached.
  
  Notes
  -
  
  It seems there is no useful stacktrace. Ping T187147 
<https://phabricator.wikimedia.org/T187147>.

TASK DETAIL
  https://phabricator.wikimedia.org/T224488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T224488: PHP Fatal Error: Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found

2019-05-28 Thread Krinkle
Krinkle closed this task as a duplicate of T224491: PHP error: "Undefined 
index: userlangattributes" from QuickTemplate.php.

TASK DETAIL
  https://phabricator.wikimedia.org/T224488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T224488: PHP Fatal Error: Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found

2019-05-28 Thread Krinkle
Krinkle added a comment.


  False alarm. These are limited to a single server only (`mw1262`) and PHP 7, 
which suggests to me it is a problem with the opcache or something else 
operational like Scap, and not Wikibase. See T224491 
<https://phabricator.wikimedia.org/T224491>.

TASK DETAIL
  https://phabricator.wikimedia.org/T224488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope

2019-05-28 Thread Krinkle
Krinkle renamed this task from 
"Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: 
GeoData\Hooks::doLinksUpdate does not have outer scope" to 
"Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not 
have outer scope".

TASK DETAIL
  https://phabricator.wikimedia.org/T221577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: kchapman, DannyS712, WMDE-leszek, alaa_wmde, Ladsgroup, Lydia_Pintscher, 
daniel, akosiaris, JTannerWMF, Krinkle, Jdforrester-WMF, Marostegui, aaron, 
TerraCodes, Liuxinyu970226, Aklapper, jcrespo, E.S.A-Sheild, darthmon_wmde, 
Premeditated, joker88john, CucyNoiD, Nandana, NebulousIris, Banyek, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, 
Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, 
V4switch, LawExplorer, Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Jonas, Wong128hk, Niharika, Wikidata-bugs, matthiasmullie, aude, 
Dinoguy1000, Fabrice_Florin, MaxSem, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope

2019-05-28 Thread Krinkle
Krinkle merged a task: T223933: Database error when moving pages: 
LinksUpdate::updateCategoryCounts does not have outer scope..
Krinkle added subscribers: DannyS712, kchapman.

TASK DETAIL
  https://phabricator.wikimedia.org/T221577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: kchapman, DannyS712, WMDE-leszek, alaa_wmde, Ladsgroup, Lydia_Pintscher, 
daniel, akosiaris, JTannerWMF, Krinkle, Jdforrester-WMF, Marostegui, aaron, 
TerraCodes, Liuxinyu970226, Aklapper, jcrespo, E.S.A-Sheild, darthmon_wmde, 
Premeditated, joker88john, CucyNoiD, Nandana, NebulousIris, Banyek, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, 
Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, 
V4switch, LawExplorer, Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Jonas, Wong128hk, Niharika, Wikidata-bugs, matthiasmullie, aude, 
Dinoguy1000, Fabrice_Florin, MaxSem, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T200906

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Lucas_Werkmeister_WMDE, darthmon_wmde, Premeditated, Nandana, Mringgaard, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T200906

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Lucas_Werkmeister_WMDE, darthmon_wmde, Premeditated, Nandana, Mringgaard, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle added a comment.


  If the functionality in question is unfinished or not something we can 
currently support, please consider a short-term fix that disables it gracefully 
in a way that doesn't produce signals analogous to system instability (which 
make monitoring hard (and can abort deployments mid-way in confusing ways), and 
that can be cached (e.g. an error message printed from a catch handler over 
HTTP 200).

TASK DETAIL
  https://phabricator.wikimedia.org/T200906

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Lucas_Werkmeister_WMDE, darthmon_wmde, Premeditated, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle added a comment.


  > Do you mean items or entities?
  
  As a user, I am unable to make a distinction between entities and items. 
Maybe they are items, I don't know.
  
  > And why permalinks?
  
  It appears to me that Special:EntityPage is a standard way to create a link 
to an entity (or item?) based on its identifier. Perhaps similar to 
Special:Diff and Special:Redirect. I don't know what it's actual use case is, 
however. But I assume they are used in urls, and that those urls are used by 
links that users use in a web browser (eg. not an API-like special page for 
exporting data). I refer to those as permalinks, but perhaps there's a better 
term.

TASK DETAIL
  https://phabricator.wikimedia.org/T200906

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Lucas_Werkmeister_WMDE, darthmon_wmde, Premeditated, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-05-29 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T203696

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, E.S.A-Sheild, 
darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Imarlier, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

2019-05-29 Thread Krinkle
Krinkle added a comment.


  @kostajh To confirm, the build is passing for core, CentralAuth, MassMessage 
and WikibaseLexeme. But the build is failing for commits to GrowthExperiments, 
for which these gates tests also run. Is that right?
  
  I don't see any changes in `core:/includes/api` last 24 hours that appear 
related to `apierror-writeapidenied`  or `CentralAuthIdLookupTest`.  Might be 
hard to find someone to start investigating without narrowing it down first.
  
  When was the last passing build for this repo in Gerrit?

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Sario528, Liuxinyu970226, kostajh, darthmon_wmde, Premeditated, 
DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wong128hk, Wikidata-bugs, Snowolf, aude, 
Darkdadaah, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T224605: MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."

2019-05-29 Thread Krinkle
Krinkle renamed this task from "mwselenium-quibble-docker job fails with PHP 
notice:  Failed to map interlanguage prefix es to a global site ID." to 
"MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map 
interlanguage prefix es to a global site ID."".

TASK DETAIL
  https://phabricator.wikimedia.org/T224605

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: pmiazga, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T224605: MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."

2019-05-29 Thread Krinkle
Krinkle triaged this task as "Unbreak Now!" priority.
Restricted Application added a subscriber: Liuxinyu970226.

TASK DETAIL
  https://phabricator.wikimedia.org/T224605

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Liuxinyu970226, pmiazga, Aklapper, darthmon_wmde, Premeditated, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Declined] T99088: [RFC] Evolving our content platform: Content adaptability, structured data and caching

2019-05-29 Thread Krinkle
Krinkle closed this task as "Declined".

TASK DETAIL
  https://phabricator.wikimedia.org/T99088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: AfroThundr3007730, kchapman, Niedzielski, jmadler, Bianjiang, LikeLifer, 
Mholloway, MZMcBride, RobLa-WMF, StudiesWorld, Qgil, Tgr, JanZerebecki, RobLa, 
cscott, Dbrant, Smalyshev, greg, bearND, JKatzWMF, Gilles, Ltrlg, Fhocutt, 
Jhernandez, Joe, BBlack, Tnegrin, mark, faidon, Tfinc, TrevorParscal, damons, 
Anomie, bd808, dr0ptp4kt, daniel, BGerstle-WMF, tstarling, ssastry, mobrovac, 
Catrope, ori, brion, GWicke, darthmon_wmde, Premeditated, Nandana, kostajh, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
D3r1ck01, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, santhosh, 
Jdforrester-WMF, Ladsgroup, Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Lowered Priority] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

2019-05-30 Thread Krinkle
Krinkle moved this task from Untriaged to Resolved on the 
Wikimedia-production-error (Shared Build Failure) board.
Krinkle lowered the priority of this task from "Unbreak Now!" to "High".
Krinkle added a comment.


  @kostajh I assume that means CI is now unblocked. Undo if now :)

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3298/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, Krinkle
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T224605: MinervaNeue wdio build fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."

2019-05-30 Thread Krinkle
Krinkle renamed this task from "MinervaNeue wdio test fails with PHP error from 
Wikibase "Failed to map interlanguage prefix es to a global site ID."" to 
"MinervaNeue wdio build fails with PHP error from Wikibase "Failed to map 
interlanguage prefix es to a global site ID."".

TASK DETAIL
  https://phabricator.wikimedia.org/T224605

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: nray, Niedzielski, Liuxinyu970226, pmiazga, Aklapper, darthmon_wmde, 
Premeditated, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
zeljkofilipin, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-06-05 Thread Krinkle
Krinkle added a comment.


  Still seen on 1.34-wmf.8.
  
  - XPam4gpAICsAAEeT0uER
  - GET testwikidatawiki /w/index.php?title=Q193394&redirect=no
  
  Fatal exception: `MWContentSerializationException from line 299 of 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php:
 $entityId and $targetId can not be the same.`

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, darthmon_wmde, WDoranWMF, Premeditated, EvanProdromou, Nandana, 
Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Agabi10, Pchelolo, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX

2019-06-05 Thread Krinkle
Krinkle closed this task as a duplicate of T207235: PHP error from 
ArticlePlaceholder hook on SpecialSearch.

TASK DETAIL
  https://phabricator.wikimedia.org/T224094

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: hashar, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, jayvdb, Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g, 
Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch

2019-06-05 Thread Krinkle
Krinkle renamed this task from "PHP error from ArticlePlaceholder hook on 
SpecialSearch" to "PHP error "Undefined index: Q…" from ArticlePlaceholder hook 
on SpecialSearch".

TASK DETAIL
  https://phabricator.wikimedia.org/T207235

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: hashar, WMDE-leszek, Smalyshev, Lydia_Pintscher, Addshore, Ladsgroup, 
Krinkle, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, jayvdb, Ricordisamoa, zeljkofilipin, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Merged] T207235: PHP error from ArticlePlaceholder hook on SpecialSearch

2019-06-05 Thread Krinkle
Krinkle merged a task: T224094: [ArticlePlaceHolder] on test.wikidata.org, 
searches cause PHP Notice: Undefined index: QX.
Krinkle added a subscriber: hashar.

TASK DETAIL
  https://phabricator.wikimedia.org/T207235

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: hashar, WMDE-leszek, Smalyshev, Lydia_Pintscher, Addshore, Ladsgroup, 
Krinkle, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, jayvdb, Ricordisamoa, zeljkofilipin, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-06-05 Thread Krinkle
Krinkle created this task.
Krinkle added projects: Wikimedia-production-error, 
MediaWiki-extensions-WikibaseClient, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  Request ID: `f7f077eba5e5e71650bb10e8`
  
  name=message
DBTransactionError:

MediaWiki::restInPeace: transaction round 
'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running.
  
  name=trace
#0 /srv/mediawiki/php-1.34.0-wmf.7/includes/MediaWiki.php(895): 
Wikimedia\Rdbms\LBFactory->commitMasterChanges(string)
#1 /srv/mediawiki/rpc/RunSingleJob.php(94): MediaWiki->restInPeace()
#2 {main}
  
  
  
  Impact
  --
  
  (To be determined by product owner.)
  
  Notes
  -
  
  This has started today. Not seen in 30 days prior.

TASK DETAIL
  https://phabricator.wikimedia.org/T225098

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-06-05 Thread Krinkle
Krinkle updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T225098

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-06-05 Thread Krinkle
Krinkle added a comment.


  Tasks that mention InjectRCRecordsJob which may be related:
  
  - T171370: ERROR: "LBFactory::getEmptyTransactionTicket: 
WikiPageUpdater::injectRCRecords does not have outer scope" 
<https://phabricator.wikimedia.org/T171370>
  - T224532: WD within WP watchlists: Allow hiding new language versions of 
articles <https://phabricator.wikimedia.org/T224532>

TASK DETAIL
  https://phabricator.wikimedia.org/T225098

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T225104: Various Wikibase APIs can fatal with "Call to hasSlot() on null" (from WikiPageEntityRevisionLookup.php)

2019-06-05 Thread Krinkle
Krinkle created this task.
Krinkle added projects: Wikimedia-production-error, 
MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Error
  -
  
  Request URL: POST www.wikidata.org  `/w/api.php`
  Request ID: `XOVStQpAMEIAAFu6vqEAAABM`
  
  name=message
BadMethodCallException:
Call to a member function hasSlot() on a non-object (null)
  
  name=trace for Api/ModifyEntity
#0 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(132):
 Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->loadEntity(stdClass, 
string)
#1 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59):
 
Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId,
 integer, string)
#2 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(55):
 
Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId,
 integer, string)
#3 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(192):
 
Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId,
 integer, string)
#4 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/repo/includes/Api/EditEntity.php(252):
 
Wikibase\Repo\Api\ModifyEntity->applyChangeOp(Wikibase\Repo\ChangeOp\ChangeOps, 
Wikibase\DataModel\Entity\Item)
#5 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(298):
 Wikibase\Repo\Api\EditEntity->modifyEntity(Wikibase\DataModel\Entity\Item, 
Wikibase\Repo\ChangeOp\ChangeOps, array)
#6 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMain.php(1595): 
Wikibase\Repo\Api\ModifyEntity->execute()
#7 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMain.php(531): 
ApiMain->executeAction()
#8 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMain.php(502): 
ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.34.0-wmf.8/api.php(87): ApiMain->execute()
#10 /srv/mediawiki/w/api.php(3): include(string)
  
  name=trace for Api/SetClaim
0 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(132):
 Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->loadEntity(stdClass, 
string)
#1 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59):
 
Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId,
 integer, string)
#2 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(55):
 
Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId,
 integer, string)
#3 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(235):
 
Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId,
 integer, string)
#4 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(662):
 Wikibase\Repo\EditEntity\MediawikiEditEntity->getLatestRevision()
#5 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php(73):
 
Wikibase\Repo\EditEntity\MediawikiEditEntity->attemptSave(Wikibase\DataModel\Entity\Item,
 string, integer, string, boolean)
#6 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(351):
 
Wikibase\Repo\EditEntity\StatsdSaveTimeRecordingEditEntity->attemptSave(Wikibase\DataModel\Entity\Item,
 string, integer, string)
#7 
/srv/mediawiki/php-1.34.0-wmf.6/extensions/Wikibase/repo/includes/Api/SetClaim.php(137):
 
Wikibase\Repo\Api\EntitySavingHelper->attemptSaveEntity(Wikibase\DataModel\Entity\Item,
 string)
#8 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(1593): 
Wikibase\Repo\Api\SetClaim->execute()
#9 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(531): 
ApiMain->executeAction()
#10 /srv/mediawiki/php-1.34.0-wmf.6/includes/api/ApiMain.php(502): 
ApiMain->executeActionWithErrorHandling()
#11 /srv/mediawiki/php-1.34.0-wmf.6/api.php(87): ApiMain->execute()
#12 /srv/mediawiki/w/api.php(3): include(string)
#13 {main}
  
  
  
  Impact
  --
  
  Some actions that API users are trying to perform are aborted with this fatal 
error.
  
  The rate is relatively low, which suggests it might be due to being specific 
to certain pages or certain users only.
  
  Notes
  -
  
  Since since at least 1.34-wmf.3.

TASK DETAIL
  ht

[Wikidata-bugs] [Maniphest] [Updated] T225104: Various Wikibase APIs can fatal with "Call to hasSlot() on null" (from WikiPageEntityRevisionLookup.php)

2019-06-05 Thread Krinkle
Krinkle added a comment.


  May be related:
  
  - T112658: [Task] WikiPageEntityRevisionLookup::getLatestRevisionId() should 
throw an UnsersolvedRedirectException when encountering a redirect.  
<https://phabricator.wikimedia.org/T112658>
  - T213349: wbgetentities BadMethodCallException  when mediainfo entity is for 
a redirect page <https://phabricator.wikimedia.org/T213349>
  - T223995: BadMethodCallException wbgetentities when getting Lexeme 
subentities (forms, senses) <https://phabricator.wikimedia.org/T223995>

TASK DETAIL
  https://phabricator.wikimedia.org/T225104

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198557: Remove support for legacy pre-MCR schema

2019-06-08 Thread Krinkle
Krinkle added a comment.


  @daniel Given 1.33 has already been cut and scheduled to be released this 
month, is this something we should defer to the MW 1.34 milestone instead? Or 
do we have reason to backport it to 1.33 with limited testing? (Or perhaps has 
this already been resolved?)

TASK DETAIL
  https://phabricator.wikimedia.org/T198557

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, 
darthmon_wmde, WDoranWMF, Premeditated, holger.knust, EvanProdromou, Nandana, 
Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, JJMC89, 
_jensen, rosalieper, Agabi10, Pchelolo, MGChecker, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225246: Flaky test "I select item in menu - the item is added to the widget"

2019-06-11 Thread Krinkle
Krinkle added a comment.


  From the Jenkins build 
<https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/22469/consoleFull>,
 there are some uncaught errors earlier in the output that are likely related.
  
WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined', 
'TypeError: Cannot read property 'id' of undefined
at deserializeSense (…)
at 
at mightThrow (…)
at process (…jquery)
WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined', 
'TypeError: Cannot read property 'id' of undefined
at Object.deserializeSense (…)
at …
at mightThrow (…)
at process (…jquery)
  
  Which appears to be coming from 
WikibaseLexeme:/resources/serialization/LexemeDeserializer.js#67 
<https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseLexeme/+/6d97243d623ab6d064c40d5729e4215a7cffd1fc/resources/serialization/LexemeDeserializer.js#67>
  
  (Note: The output can be confusing at times because the browser's console 
output and Karma's result printer are not aware of each other.)

TASK DETAIL
  https://phabricator.wikimedia.org/T225246

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, kostajh, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Darkdadaah, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


  1   2   3   4   5   6   7   8   9   10   >