[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread Krinkle
Krinkle added a comment. I would prefer the stacktrace be unmodified from the original. I don't think an extra field is needed because the "error" as reported concept does not have a version. The stack trace is a sample from any of the 100s of instances there are in Logsta

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread Krinkle
Krinkle added a comment. @mmodell Can you restore the file paths in the future? This makes it very hard to tell which branch the error happened on, especially around deployments. Ignoring the version for hashing purposes seems fine, but the raw data sent here should be unmodified (except to

[Wikidata-bugs] [Maniphest] [Closed] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-09-12 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. Not seen in WMF Logstash for 30 days. TASK DETAIL https://phabricator.wikimedia.org/T225098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jony, Aklappe

[Wikidata-bugs] [Maniphest] [Commented On] T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle

2019-09-09 Thread Krinkle
Krinkle added a comment. I've often found it a sign of technical debt and think it's worth taking this one slow (could even undo the deprecation warning for now). From a quick scan it looks like nothing should need it on regular page views before interaction, in which case mw.

[Wikidata-bugs] [Maniphest] [Merged] T216877: PHP timeout when opening Special:EditWatchlist with 14k pages on the Watchlist on Wikidata

2019-09-08 Thread Krinkle
Krinkle closed this task as a duplicate of T41510: Editing large watchlists via Special:EditWatchlist fails due to a server timeout. TASK DETAIL https://phabricator.wikimedia.org/T216877 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo

2019-09-07 Thread Krinkle
Krinkle removed a project: MediaWiki-extensions-CentralAuth. TASK DETAIL https://phabricator.wikimedia.org/T225195 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Umherirrender, Legoktm, Ottomata, AndyRussG, awight

[Wikidata-bugs] [Maniphest] [Updated] T231089: WikibaseClient.php: PHP Notice: Undefined index:

2019-09-05 Thread Krinkle
Krinkle added a comment. Smells like T229433 <https://phabricator.wikimedia.org/T229433>. Which is also about `''` array index, and PHP 7.2. It's obviously a bug in PHP 7.2, but I've not been able to find evidence that it is due to opcache/T224491 <https://phab

[Wikidata-bugs] [Maniphest] [Triaged] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-03 Thread Krinkle
Krinkle triaged this task as "Unbreak Now!" priority. Krinkle added a comment. Restricted Application added a subscriber: Liuxinyu970226. Users are consistently unable to view this file description page on Commons: https://commons.wikimedia.org/wiki/File:Rockstar_San_Diego_Lo

[Wikidata-bugs] [Maniphest] [Merged] T231795: RevisionBasedEntityLookup.php: Call to a member function getTargetId() on a non-object (null)

2019-09-03 Thread Krinkle
Krinkle closed this task as a duplicate of T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null). TASK DETAIL https://phabricator.wikimedia.org/T231795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Updated] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-03 Thread Krinkle
Krinkle merged a task: T231795: RevisionBasedEntityLookup.php: Call to a member function getTargetId() on a non-object (null). Krinkle added a subscriber: Pablo-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Reassigned] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-09-02 Thread Krinkle
Krinkle reassigned this task from Addshore to Ladsgroup. Krinkle added a subscriber: Addshore. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle merged a task: T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle removed a subtask: T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle

[Wikidata-bugs] [Maniphest] [Updated] T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle removed a parent task: T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] [Merged] T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle closed this task as a duplicate of T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T226976: Convert linkitem module to use OOUI, instead of jQuery UI

2019-08-28 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T226976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: stjn, Pablo-WMDE, WMDE-leszek, Lydia_Pintscher, Aklapper, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Closed] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-08-28 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Ladsgroup, Krinkle, Aklappe

[Wikidata-bugs] [Maniphest] [Reassigned] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-08-28 Thread Krinkle
Krinkle reassigned this task from Krinkle to Addshore. Krinkle removed a project: Performance. Restricted Application added a project: User-Addshore. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-08-26 Thread Krinkle
Krinkle added a subscriber: Ladsgroup. Krinkle added a comment. I vaguely recall you doing some work on this, but I'm not sure if it was this class or something else with a similar name. Can you check if this has been improved since? TASK DETAIL https://phabricator.wikimedia.org/T2

[Wikidata-bugs] [Maniphest] [Retitled] T231198: Wikibase and WikibaseLexeme tests now take more than 1 hour

2019-08-26 Thread Krinkle
Krinkle renamed this task from "Wikibase and WikibaseLexeme tests now take more than 1 hour in php7.2" to "Wikibase and WikibaseLexeme tests now take more than 1 hour". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231198 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin

2019-08-06 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T227121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Liuxinyu970226, Krinkle, Michael, noarave, Pablo-WMDE, Aklapper, Jdlrobson, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Raised Priority] T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin

2019-08-06 Thread Krinkle
Krinkle moved this task from Resolved to Untriaged on the Wikimedia-production-error (Shared Build Failure) board. Krinkle raised the priority of this task from "High" to "Unbreak Now!". Krinkle added a comment. Restricted Application added a subscriber: Liuxinyu97022

[Wikidata-bugs] [Maniphest] [Commented On] T229634: Flaky selenium tests block merging to Wikibase

2019-08-05 Thread Krinkle
Krinkle added a comment. Does not seem to affect other repositories, thus untagging from cross-repo tag for shared build failures. TASK DETAIL https://phabricator.wikimedia.org/T229634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T229634: Flaky selenium tests block merging to Wikibase

2019-08-05 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T229634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Smalyshev, darthmon_wmde, DannyS712, Nandana, Mringgaard

[Wikidata-bugs] [Maniphest] [Updated] T229634: Flaky selenium tests block merging to Wikibase

2019-08-05 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T229634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Smalyshev, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Updated] T228739: Jenkins runs Scribunto tests in Wikibase patches

2019-08-05 Thread Krinkle
Krinkle edited projects, added Wikidata, Continuous-Integration-Config; removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T228739 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope

2019-08-05 Thread Krinkle
Krinkle added a comment. Higher level issue of re-trying LinksUpdate now tracked at T206283 <https://phabricator.wikimedia.org/T206283>. TASK DETAIL https://phabricator.wikimedia.org/T221577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-08-02 Thread Krinkle
Krinkle added a comment. From Grafana: WebPageReplay dashboard <https://grafana.wikimedia.org/d/00572/webpagereplay-drilldown?orgId=1&from=156449880&to=156475080&var-wiki=enwiki&var-device=desktop&var-browser=chrome&var-latency=100&var-page=Swed

[Wikidata-bugs] [Maniphest] [Updated] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-08-02 Thread Krinkle
Krinkle added a project: Performance-Team-publish. TASK DETAIL https://phabricator.wikimedia.org/T203696 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: WMDE-leszek, alaa_wmde, Jakob_WMDE, Ladsgroup, gerritbot, Addshore

[Wikidata-bugs] [Maniphest] [Updated] T229221: Reduce usages of wikibase.entityPage.entityLoaded hook in frontend code

2019-07-31 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed Performance. TASK DETAIL https://phabricator.wikimedia.org/T229221 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lea_Lacroix_WMDE, Lucas_Werkmeister_WMDE, alaa_wmde

[Wikidata-bugs] [Maniphest] [Created] T229450: EntityIdSearchHelper.php: PHP Notice: Uninitialized string offset: 0

2019-07-31 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request ID: `XUHMHQpAIDMAAC-xEd0AAABA` Request URL: w

[Wikidata-bugs] [Maniphest] [Updated] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-07-27 Thread Krinkle
Krinkle removed a project: MediaWiki-ResourceLoader. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Catrope, Liuxinyu970226, darthmon_wmde, DannyS712, Nandana

[Wikidata-bugs] [Maniphest] [Updated] T85499: wbEntity shouldn't be served on every page load

2019-07-23 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed Performance. TASK DETAIL https://phabricator.wikimedia.org/T85499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: Lea_Lacroix_WMDE, Addshore

[Wikidata-bugs] [Maniphest] [Updated] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2019-07-17 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T228293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Created] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2019-07-17 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request URL: api.php Request ID: `uApAICoAAJLcp3kX` name=message

[Wikidata-bugs] [Maniphest] [Updated] T207926: Label freshness (cache delay)

2019-07-15 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache. TASK DETAIL https://phabricator.wikimedia.org/T207926 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Liuxinyu970226, Aklapper, VladimirAlexiev, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T221433: Category filled with pages which should not be there

2019-07-15 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache. TASK DETAIL https://phabricator.wikimedia.org/T221433 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jack_who_built_the_house, SerDIDG, Aklapper, darthmon_wmde, Nandana, OlegCinema, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Reopened] T183993: Investigate & Fix "According to a SiteLinkLookup Q47013093 is linked to frwiki while it is not or it does not exist" in logs

2019-07-11 Thread Krinkle
Krinkle reopened this task as "Open". Krinkle added a comment. Seen again in prod today: - Request ID: `XSeYmwpAAD0AAFX9ZwwAAADG` - Request URL: GET en.wikipedia.org `/wiki/ (some page title)` name=message PHP Warning: According to a SiteLinkLookup Q--- is linked

[Wikidata-bugs] [Maniphest] [Commented On] T183993: Investigate & Fix "According to a SiteLinkLookup Q47013093 is linked to frwiki while it is not or it does not exist" in logs

2019-07-11 Thread Krinkle
Krinkle added a comment. In T183993#4001382 <https://phabricator.wikimedia.org/T183993#4001382>, @daniel wrote: > This can happen every now and then due to replag. We should not worry unless this happens a LOT. If this isn't a problem with the code that needs an obv

[Wikidata-bugs] [Maniphest] [Updated] T227814: [Regression wmf.13] Wikidata localisation is broken

2019-07-11 Thread Krinkle
Krinkle added a parent task: T220738: 1.34.0-wmf.13 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T227814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: thcipriani, Krinkle, Jdforrester-WMF, Aklapper, Mormegil

[Wikidata-bugs] [Maniphest] [Updated] T227815: Message wikibase-sitelinks-wikipedia missing from wikidata.org

2019-07-11 Thread Krinkle
Krinkle removed a parent task: T220738: 1.34.0-wmf.13 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T227815 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Mormegil, Jdforrester-WMF, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T227815: Message wikibase-sitelinks-wikipedia missing from wikidata.org

2019-07-11 Thread Krinkle
Krinkle added a parent task: T220738: 1.34.0-wmf.13 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T227815 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Mormegil, Jdforrester-WMF, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T227815: Message wikibase-sitelinks-wikipedia missing from wikidata.org

2019-07-11 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed MediaWiki-ResourceLoader, Performance-Team. Krinkle added a comment. The messages don't work via the normal MediaWiki interface urls, such as https://www.wikidata.org/wiki/MediaWiki:Wikibase-sitelinks-wikipedia and

[Wikidata-bugs] [Maniphest] [Updated] T227699: Creating a Commons gallery page incorrectly states "This entity does not exist."

2019-07-10 Thread Krinkle
Krinkle added projects: Multimedia, StructuredDataOnCommons, MediaWiki-extensions-WikibaseRepository. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T227699 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T226818: Diff when updating wbc_entity_usage

2019-07-09 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T226818 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: alaa_wmde, Krinkle, Aklapper, Marostegui, Addshore, hoo, jcrespo

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

2019-07-09 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T225814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, WMDE

[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-07-04 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T203696 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, Daryl-TTMG, RomaAmorRoma, 0010318400

[Wikidata-bugs] [Maniphest] [Updated] T189333: Changing Kibana filters is ridiculously slow

2019-07-02 Thread Krinkle
Krinkle added a subscriber: ema. Krinkle added a comment. per @ema, the `request-{}` and `response-{}` lines is due to T224994 <https://phabricator.wikimedia.org/T224994>, which was recently enabled. TASK DETAIL https://phabricator.wikimedia.org/T189333 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T224030: Fatal when saving "Undo" edit on merged Wikidata item

2019-07-01 Thread Krinkle
Krinkle added a comment. Still seen on 1.34-wmf.11: - Request URL: `/w/index.php?title= Q… &action=edit&undoafter= … &undo= … ` - Request ID: `XReOdQpAAEIAAEDJ-ZkF` name=message Diff\Patcher\PatcherException: EntityContent must not contain Entity data

[Wikidata-bugs] [Maniphest] [Retitled] T224030: Fatal when saving "Undo" edit on merged Wikidata item

2019-07-01 Thread Krinkle
Krinkle renamed this task from "Exception in Production when trying to undo a change on a merged item" to "Fatal when saving "Undo" edit on merged Wikidata item". TASK DETAIL https://phabricator.wikimedia.org/T224030 EMAIL PREFERENCES https://phabricato

[Wikidata-bugs] [Maniphest] [Updated] T215616: Improve interlingual links across wikis through Wikidata IDs

2019-06-27 Thread Krinkle
Krinkle added a project: MediaWiki-General-or-Unknown. Krinkle added a comment. (Does this appear to be an issue with the wikimedia-rdbms PHP library, and not a bug or specific feature request for the MediaWiki core schema.) TASK DETAIL https://phabricator.wikimedia.org/T215616 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T215616: Improve interlingual links across wikis through Wikidata IDs

2019-06-27 Thread Krinkle
Krinkle removed a project: MediaWiki-Database. TASK DETAIL https://phabricator.wikimedia.org/T215616 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: mforns, Marostegui, Isaac, Tbayer, jcrespo, EBernhardson, Halfak, Nuria, JAllemandou

[Wikidata-bugs] [Maniphest] [Commented On] T189333: Changing Kibana filters is ridiculously slow

2019-06-24 Thread Krinkle
Krinkle added a comment. It's looking much better than last year, there are now //only// 7,665 unique log field names. The biggest offenders are: - 2000+ field names for `err_headers_***` and `err_headers_***.raw` name=err_headers_*** err_headers_accept-r

[Wikidata-bugs] [Maniphest] [Retitled] T226329: QueryService UI test build fails on CI

2019-06-24 Thread Krinkle
Krinkle renamed this task from "UI test build fails on CI" to "QueryService UI test build fails on CI". TASK DETAIL https://phabricator.wikimedia.org/T226329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lu

[Wikidata-bugs] [Maniphest] [Updated] T185404: Two talk pages (Talk:沙溪兴教寺 and User talk:Yuriy kosygin) shown in Special:Shortpages and Special:Unconnectedpages on zh.wikipedia

2019-06-24 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseClient; removed MediaWiki-Special-pages. TASK DETAIL https://phabricator.wikimedia.org/T185404 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: jcrespo, Anomie, Bugreporter

[Wikidata-bugs] [Maniphest] [Updated] T151678: Add a checkbox in Special:Import to automatically add new sitelinks to the corresponding Wikidata item

2019-06-24 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseClient; removed MediaWiki-Special-pages. TASK DETAIL https://phabricator.wikimedia.org/T151678 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: matej_suchanek, Florian, abian

[Wikidata-bugs] [Maniphest] [Retitled] T163046: New special page for listing all Wikibase entities (PrefixIndex with nat-sorted Q-ids)

2019-06-24 Thread Krinkle
Krinkle renamed this task from "List all entities in a Wikibase installation ordered numerically by ID" to "New special page for listing all Wikibase entities (PrefixIndex with nat-sorted Q-ids)". TASK DETAIL https://phabricator.wikimedia.org/T163046 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T163046: List all entities in a Wikibase installation ordered numerically by ID

2019-06-24 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository; removed MediaWiki-Special-pages. TASK DETAIL https://phabricator.wikimedia.org/T163046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, abian

[Wikidata-bugs] [Maniphest] [Updated] T205506: UnconnectedPages should know Wikidata's Exclusion criteria (such as category redicts) and ignore those pages

2019-06-24 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseClient; removed MediaWiki-Special-pages. TASK DETAIL https://phabricator.wikimedia.org/T205506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Pasleim, Bencemac, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T96040: Wikibase special pages (tracking)

2019-06-23 Thread Krinkle
Krinkle removed a project: MediaWiki-Special-pages. TASK DETAIL https://phabricator.wikimedia.org/T96040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: PokestarFan, Luke081515, Liuxinyu970226, aude, Aklapper, darthmon_wmde, Nickleh

[Wikidata-bugs] [Maniphest] [Commented On] T226084: Wikidata server slow

2019-06-20 Thread Krinkle
Krinkle added a comment. @Magnus It is well-known currently that MediaWiki exposes many powerful API that we do not support to perform well, but allow regardless as a convenience service. If we were stricter about response times for all features, we'd probably just turn many of them of

[Wikidata-bugs] [Maniphest] [Commented On] T226084: Wikidata server slow

2019-06-19 Thread Krinkle
Krinkle added a comment. In T226084#5268060 <https://phabricator.wikimedia.org/T226084#5268060>, @Magnus wrote: > Response header from one of the slow requests: > > HTTP/2.0 200 OK > [..] > server: mw1341.eqiad.wmnet > [..] >

[Wikidata-bugs] [Maniphest] [Commented On] T226084: Wikidata server slow

2019-06-19 Thread Krinkle
Krinkle added a comment. See also Grafana: API requests breakdown (wbgetentities) <https://grafana.wikimedia.org/d/00559/api-requests-breakdown?refresh=5m&orgId=1&from=now-7d&to=now&var-metric=p75&var-module=wbgetentities>. TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Updated] T225796: Wikibase and Lexeme browser tests are failing with `failed-save: The save has failed.`

2019-06-17 Thread Krinkle
Krinkle added a project: Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T225796 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: WMDE-leszek, zeljkofilipin, hashar, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Updated] T225796: Wikibase and Lexeme browser tests are failing with `failed-save: The save has failed.`

2019-06-17 Thread Krinkle
Krinkle removed projects: MW-1.31-release-notes, MW-1.33-notes, MW-1.32-notes, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18). TASK DETAIL https://phabricator.wikimedia.org/T225796 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: WMDE-leszek

[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-06-17 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T203696 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, Daryl-TTMG, RomaAmorRoma, 0010318400

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-06-17 Thread Krinkle
Krinkle added a comment. I think it would be best suited as a skinStyle that WikidataPageBanner adds for specific skins it knows how to handle. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] [Updated] T214308: Force usage of MCR aware database schema

2019-06-14 Thread Krinkle
Krinkle removed a project: MW-1.33-release. Krinkle added a comment. Per T198557#5247134 <https://phabricator.wikimedia.org/T198557#5247134>, no longer aimed at MW 1.33. (Not adding MW 1.34, because the parent task tracks that already.) TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Updated] T225500: Decrease EntityUsageTable addUsage batch size to 100

2019-06-14 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T225500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Krinkle Cc: Aklapper, Michael, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Closed] T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch

2019-06-12 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T207235 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: WMDE-leszek, Smalyshev, Lydia_Pintscher, Addshore, Ladsgroup, Krinkle,

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

2019-06-11 Thread Krinkle
Krinkle added a comment. In T225212#5241912 <https://phabricator.wikimedia.org/T225212#5241912>, @hoo wrote: > > Notice: Undefined variable: wmgWBRepoConceptBaseUri in /srv/mediawiki/wmf-config/Wikibase.php on line 149 > > This is because the default was set

[Wikidata-bugs] [Maniphest] [Commented On] T225246: Flaky test "I select item in menu - the item is added to the widget"

2019-06-11 Thread Krinkle
Krinkle added a comment. (QUnit tests are not "browser tests", which for us is what we call our selenium integration tests. Perhaps that tag should be renamed. Generally issues with tests are filed under the same component as the subject source code, so no additional tag is need

[Wikidata-bugs] [Maniphest] [Updated] T225246: Flaky test "I select item in menu - the item is added to the widget"

2019-06-11 Thread Krinkle
Krinkle removed a project: Browser-Tests. TASK DETAIL https://phabricator.wikimedia.org/T225246 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, kostajh, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T225246: Flaky test "I select item in menu - the item is added to the widget"

2019-06-11 Thread Krinkle
Krinkle added a comment. From the Jenkins build <https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/22469/consoleFull>, there are some uncaught errors earlier in the output that are likely related. WARN: 'jQuery.Deferred exception: Cannot read prope

[Wikidata-bugs] [Maniphest] [Commented On] T198557: Remove support for legacy pre-MCR schema

2019-06-08 Thread Krinkle
Krinkle added a comment. @daniel Given 1.33 has already been cut and scheduled to be released this month, is this something we should defer to the MW 1.34 milestone instead? Or do we have reason to backport it to 1.33 with limited testing? (Or perhaps has this already been resolved?) TASK

[Wikidata-bugs] [Maniphest] [Updated] T225104: Various Wikibase APIs can fatal with "Call to hasSlot() on null" (from WikiPageEntityRevisionLookup.php)

2019-06-05 Thread Krinkle
Krinkle added a comment. May be related: - T112658: [Task] WikiPageEntityRevisionLookup::getLatestRevisionId() should throw an UnsersolvedRedirectException when encountering a redirect. <https://phabricator.wikimedia.org/T112658> - T213349: wbgetentities BadMethodCallException

[Wikidata-bugs] [Maniphest] [Created] T225104: Various Wikibase APIs can fatal with "Call to hasSlot() on null" (from WikiPageEntityRevisionLookup.php)

2019-06-05 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request URL: POST www.wikidata.org `/w/api.php

[Wikidata-bugs] [Maniphest] [Updated] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-06-05 Thread Krinkle
Krinkle added a comment. Tasks that mention InjectRCRecordsJob which may be related: - T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope" <https://phabricator.wikimedia.org/T171370> - T224532: WD with

[Wikidata-bugs] [Maniphest] [Created] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-06-05 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - Request ID

[Wikidata-bugs] [Maniphest] [Edited] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-06-05 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T225098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Merged] T207235: PHP error from ArticlePlaceholder hook on SpecialSearch

2019-06-05 Thread Krinkle
Krinkle merged a task: T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QX. Krinkle added a subscriber: hashar. TASK DETAIL https://phabricator.wikimedia.org/T207235 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Retitled] T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch

2019-06-05 Thread Krinkle
Krinkle renamed this task from "PHP error from ArticlePlaceholder hook on SpecialSearch" to "PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch". TASK DETAIL https://phabricator.wikimedia.org/T207235 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] [Merged] T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX

2019-06-05 Thread Krinkle
Krinkle closed this task as a duplicate of T207235: PHP error from ArticlePlaceholder hook on SpecialSearch. TASK DETAIL https://phabricator.wikimedia.org/T224094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hashar, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-06-05 Thread Krinkle
Krinkle added a comment. Still seen on 1.34-wmf.8. - XPam4gpAICsAAEeT0uER - GET testwikidatawiki /w/index.php?title=Q193394&redirect=no Fatal exception: `MWContentSerializationException from line 299 of /srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/S

[Wikidata-bugs] [Maniphest] [Retitled] T224605: MinervaNeue wdio build fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."

2019-05-30 Thread Krinkle
Krinkle renamed this task from "MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."" to "MinervaNeue wdio build fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a g

[Wikidata-bugs] [Maniphest] [Lowered Priority] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

2019-05-30 Thread Krinkle
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (Shared Build Failure) board. Krinkle lowered the priority of this task from "Unbreak Now!" to "High". Krinkle added a comment. @kostajh I assume that means CI is now unblocked. Undo if

[Wikidata-bugs] [Maniphest] [Declined] T99088: [RFC] Evolving our content platform: Content adaptability, structured data and caching

2019-05-29 Thread Krinkle
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T99088 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: AfroThundr3007730, kchapman, Niedzielski, jmadler, Bianjiang, LikeLifer, Mholloway,

[Wikidata-bugs] [Maniphest] [Triaged] T224605: MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."

2019-05-29 Thread Krinkle
Krinkle triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T224605 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Liuxinyu97022

[Wikidata-bugs] [Maniphest] [Retitled] T224605: MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID."

2019-05-29 Thread Krinkle
Krinkle renamed this task from "mwselenium-quibble-docker job fails with PHP notice: Failed to map interlanguage prefix es to a global site ID." to "MinervaNeue wdio test fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID.&quo

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

2019-05-29 Thread Krinkle
Krinkle added a comment. @kostajh To confirm, the build is passing for core, CentralAuth, MassMessage and WikibaseLexeme. But the build is failing for commits to GrowthExperiments, for which these gates tests also run. Is that right? I don't see any changes in `core:/includes/api`

[Wikidata-bugs] [Maniphest] [Edited] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-05-29 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T203696 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, Addshore, Aklapper, Krinkle, Jdforrester-WMF, E.S.A-Sheild, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle added a comment. > Do you mean items or entities? As a user, I am unable to make a distinction between entities and items. Maybe they are items, I don't know. > And why permalinks? It appears to me that Special:EntityPage is a standard way to create a link t

[Wikidata-bugs] [Maniphest] [Commented On] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle added a comment. If the functionality in question is unfinished or not something we can currently support, please consider a short-term fix that disables it gracefully in a way that doesn't produce signals analogous to system instability (which make monitoring hard (and can

[Wikidata-bugs] [Maniphest] [Edited] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T200906 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, darthmon_wmde, Premeditated, Nandana, Mringgaard, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

2019-05-29 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T200906 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, darthmon_wmde, Premeditated, Nandana, Mringgaard, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Merged] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope

2019-05-28 Thread Krinkle
Krinkle merged a task: T223933: Database error when moving pages: LinksUpdate::updateCategoryCounts does not have outer scope.. Krinkle added subscribers: DannyS712, kchapman. TASK DETAIL https://phabricator.wikimedia.org/T221577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Retitled] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope

2019-05-28 Thread Krinkle
Krinkle renamed this task from "Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope" to "Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope". TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] [Updated] T224488: PHP Fatal Error: Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found

2019-05-28 Thread Krinkle
Krinkle added a comment. False alarm. These are limited to a single server only (`mw1262`) and PHP 7, which suggests to me it is a problem with the opcache or something else operational like Scap, and not Wikibase. See T224491 <https://phabricator.wikimedia.org/T224491>. TASK

[Wikidata-bugs] [Maniphest] [Merged] T224488: PHP Fatal Error: Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found

2019-05-28 Thread Krinkle
Krinkle closed this task as a duplicate of T224491: PHP error: "Undefined index: userlangattributes" from QuickTemplate.php. TASK DETAIL https://phabricator.wikimedia.org/T224488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Created] T224488: PHP Fatal Error: Interface 'Wikibase\DataModel\Statement\StatementListHolder' not found

2019-05-28 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseClient, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request URL: `/wiki/{Page_title}` (Wikipedias, page views) Request ID

<    1   2   3   4   5   6   7   8   9   10   >