[Wikidata-bugs] [Maniphest] [Created] T162153: client-side memory leak in query service
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added a project: Discovery. TASK DESCRIPTIONThere seems to be a client-side memory leak in the query service. If you keep running new queries, memory usage of the tab sometimes continues to increase, even if the currently displayed query has very few results. (However, other times memory usage seems to stay the same.) According to the Task Manager Firefox extension, the excess memory is mostly in JS Strings, JS Objects, and DOM (in that order).TASK DETAILhttps://phabricator.wikimedia.org/T162153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, QZanden, EBjune, merbst, Salgo60, Avner, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T115554: Allow inserting a reference for a new statement with the DuplicateReferences gadget without reloading the page
Lucas_Werkmeister_WMDE added a comment. The current revision ID isn’t synced back to the config, but stored in the RevisionStore – per claim. That’s why you get that warning even during normal editing when adding new statements: the RevisionStore doesn’t have a revision ID for that claim yet (it’s new), so it falls back to the base revision, which was initialized from wgCurRevisionId. When you e. g. add a reference to an existing statement, on the other hand, the RevisionStore knows that statement’s revision ID, so it can make the edit with the correct ID and there’s no warning. The gadget currently creates its own RevisionStore, which of course isn’t updated when the main UI adds statements. If I instead set its model._revisionStore to the main UI’s RevisionStore, pasting the reference works. The question is just – how do we get that RevisionStore? It’s somewhere deeply buried…TASK DETAILhttps://phabricator.wikimedia.org/T115554EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, 2015.ww, Jonas, Sjoerddebruin, Aklapper, Nikki, Jrbranaa, QZanden, dachary, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T159240: Document how to set up federated Wikibase instances
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a subscriber: LucasWerkmeister. TASK DETAILhttps://phabricator.wikimedia.org/T159240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: LucasWerkmeister, gerritbot, aude, daniel, Lydia_Pintscher, WMDE-leszek, Aklapper, QZanden, Salgo60, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T159240: Document how to set up federated Wikibase instances
Lucas_Werkmeister_WMDE added a comment.
I tried to create a federated setup using the provided documentation, to see if it’s sufficient. I eventually succeeded, but there were some problems. Here are my main takeaways:
I had no idea how to set up interwiki links, and the first documentation I found was outdated. Is the usual consumer of this documentation assumed to be familiar with this? (In the end it’s just a single SQL statement, so I’d say we could include it anyways.)
I was not sure what I should put in the foreignRepositories config. What are entity types ('item' (correct) or 'Item' (namespace, incorrect))? Is a symbolic database name the same as a normal database name? What’s the base URI for? (I still don’t know the answer to the last question – the link to the remote item comes from the interwiki URL, not this base URI.)
(It’s possible that this, too, is assumed to be clear to the usual reader, and that I’m just unusually unfamiliar with these terms.)
I first tried to have local and remote items and properties, and got this error:
> Using same entity types on multiple repositories is not supported yet. "item" has already be defined for repository ""
This is, in my opinion, a very severe restriction. As far as I can tell, this effectively means that a federated setup without the WikibaseMediaInfo extension, or some other extension providing entity types beyond item and property, does not make sense – you need local items (otherwise you don’t have anything to put statements on), so the only thing you can take from the remote repository is properties. The documentation should definitely mention that.
At one point, I got a really weird error ($wgContLang was null) when I had two entries in the foreignRepositories config. Are multiple entries supported?
Attempting to configure a repo with no local entities at all ($wgWBRepoSettings['entityNamespaces'] = [];) resulted in an error message in the setup scripts. I assume the interpretation of “empty array ≈ unset variable” is unintentional.
You can also read the full adventure here (CommonMark; paste here to render): F7505963: federation.mdTASK DETAILhttps://phabricator.wikimedia.org/T159240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: LucasWerkmeister, gerritbot, aude, daniel, Lydia_Pintscher, WMDE-leszek, Aklapper, QZanden, Salgo60, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T163343: Extremely slow query (P31/P279* of “entity”) is very fast when run via VALUES clause
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added a project: Discovery.
TASK DESCRIPTIONI was playing around with WDQS’ performance when checking very large subclass hierarchies, for example up to “entity” (Q35120), and discovered this weird difference when you move the class into a VALUES clause.
This query (link) runs very quickly (~250 ms):
SELECT * WHERE {
VALUES ?class { wd:Q35120 0 }
wd:Q3244512 wdt:P31/wdt:P279* ?class.
}
This almost identical query (link) times out:
SELECT * WHERE {
VALUES ?class { wd:Q35120 }
wd:Q3244512 wdt:P31/wdt:P279* ?class.
}
What’s the difference? In the second query, I removed a 0 from the VALUES clause. The 0 doesn’t contribute to the results, but apparently it makes BlazeGraph choose a faster execution path.
Adding a LIMIT 1, or disabling the optimizer, does not make a difference. Adding a class that does contribute to the results instead of 0 still makes the query run fast. Inlining the VALUES clause to wd:Q3244512 wdt:P31/wdt:P279* wd:Q35120 is just as slow as the version with the single-value VALUES clause.
I’d report this at BlazeGraph’s JIRA myself, but unfortunately I can’t currently sign up there since their CAPTCHA endpoint returns 500 Internal Server Error (“java.io.IOException: No space left on device”).TASK DETAILhttps://phabricator.wikimedia.org/T163343EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T163343: Extremely slow query (P31/P279* of “entity”) is very fast when run via VALUES clause
Lucas_Werkmeister_WMDE added a comment. Thanks, that helps.TASK DETAILhttps://phabricator.wikimedia.org/T163343EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, Lucas_Werkmeister_WMDECc: Smalyshev, Aklapper, Lucas_Werkmeister_WMDE, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T163465: WikibaseChangeNotification change has no statement, description and alias diffs
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: MediaWiki-extensions-WikibaseRepository, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThe function called by the WikibaseChangeNotification hook gets a change object, but the diff in the change is empty. This is because EntityChangeFactory “minimizes” the entities it receives before diffing them – that is to say, it wipes them clear: Hack: Don't include statement, description and alias diffs, since those are unused and not helpful performance-wise to the dispatcher and change handling. Saying those diffs are “unused” is a bold claim when we offer a hook that exposes these change objects to third-party extensions :) at the very least, this should be documented in doc/hooks.txt. Related tasks: Minimization originally introduced in T110996. minimizeEntityForDiffing documentation mentions T113468, but if I understand that task correctly, the change still won’t contain a full diff when that’s implemented, just a summary, so that still needs to be documented in the hook documentation. (My use case: the WikibaseQualityConstraints extension will soon extract constraints from statements on properties, instead of from templates on the properties’ talk pages. I’d like to do that only when there have been changes to the “property constraint” statement on the property, and not do anything when a change only affects labels or other statements.)TASK DETAILhttps://phabricator.wikimedia.org/T163465EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T159240: Document how to set up federated Wikibase instances
Lucas_Werkmeister_WMDE added a comment. Thanks, it’s much better with the new change. This is interesting. Can you reproduce it again? It seems to be related to my wiki2 database – it occurs even when I only configure that one wiki in the foreign repositories. I can send you an SQL dump of the database if you’re interested.TASK DETAILhttps://phabricator.wikimedia.org/T159240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, LucasWerkmeister, gerritbot, aude, daniel, Lydia_Pintscher, WMDE-leszek, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T163683: Only check per-item constraints once, instead of with each statement
Lucas_Werkmeister_WMDE added a parent task: T103228: Improve performance of constraint check. TASK DETAILhttps://phabricator.wikimedia.org/T163683EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, QZanden, Izno, abian, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T103228: Improve performance of constraint check
Lucas_Werkmeister_WMDE added a subtask: T163683: Only check per-item constraints once, instead of with each statement. TASK DETAILhttps://phabricator.wikimedia.org/T103228EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Aklapper, Jonaskeutel, QZanden, Izno, abian, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172007: $itemId must be either ItemId or string
Lucas_Werkmeister_WMDE added a comment. I guess we’ll leave this task open until the fix is deployed and we can tell whether the log errors vanish?TASK DETAILhttps://phabricator.wikimedia.org/T172007EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, PokestarFan, Lucas_Werkmeister_WMDE, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T169326: Type constraints still report false violations
Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board.Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T169326WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, PokestarFan, Esc3300, Lydia_Pintscher, Agabi10, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171263: Wikidata Dispatcher and Job Queue is overflowed
Lucas_Werkmeister_WMDE added a comment. Stalest wiki now more than one day behind again. Median is fine, but as the stalest wiki is enwiki, that’s not a great consolation.TASK DETAILhttps://phabricator.wikimedia.org/T171263EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Addshore, matej_suchanek, MisterSynergy, Liuxinyu970226, daniel, Esc3300, XXN, Ladsgroup, Lydia_Pintscher, hoo, Bugreporter, Sjoerddebruin, Magnus, Emijrp, Mr.Ibrahem, Wikidata, Aklapper, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Volker_E, Izno, Wikidata-bugs, aude, GWicke, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T172007: $itemId must be either ItemId or string
Lucas_Werkmeister_WMDE moved this task from Proposed to Doing on the Wikidata-Sprint board.Lucas_Werkmeister_WMDE added a project: Wikibase-Quality. TASK DETAILhttps://phabricator.wikimedia.org/T172007WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, PokestarFan, Lucas_Werkmeister_WMDE, Ladsgroup, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T172007: $itemId must be either ItemId or string
Lucas_Werkmeister_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T172007EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, PokestarFan, Lucas_Werkmeister_WMDE, Ladsgroup, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172127: Include constraint parameters in reports for exceptions
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...I’m going to remove the TODO in the course of the giant T171743 refactoring, so I’m just recording it here. Doing this probably requires itself a big refactoring of how constraint parameters are parsed (or, alternatively: check the constraint and only afterwards change the status, but that’s bad because the constraint check is just wasted time then). (Also, the “This entity is a known exception…” message should really be translatable.)TASK DETAILhttps://phabricator.wikimedia.org/T172127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T172134: Proposal: Create "number of values" constraint type and replace "single value"/"multi value"
Lucas_Werkmeister_WMDE added a subscriber: Ivan_A_Krestinin.Lucas_Werkmeister_WMDE added a comment. If you want to replace “multi value” with this, then “at least”/“at most” is necessary, it seems to me. But we already have properties for those: “minimum quantity”/“maximum quantity”, used for “range” and “difference within range” (including semantics for half-open ranges, which “multi value” is). So I think using those would be very natural, and we wouldn’t even have to create a new “count” property. (Under the hood, both SingleValueChecker and MultiValueChecker already use a ValueCountHelper and then check the count, so this would be very easy to implement.)TASK DETAILhttps://phabricator.wikimedia.org/T172134EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172134: Proposal: Create "number of values" constraint type and replace "single value"/"multi value"
Lucas_Werkmeister_WMDE added a comment. Note: even if we do remove the “single value” and “multi value” constraint types, we should keep the messages and use them if the allowed range is [1, 1] or [2, ∞), which will probably still be the most common cases.TASK DETAILhttps://phabricator.wikimedia.org/T172134EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172129: New constraint type for type of snak
Lucas_Werkmeister_WMDE added a project: Wikibase-Quality. TASK DETAILhttps://phabricator.wikimedia.org/T172129EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172130: Don’t imply custom value requirement in constraint types that use the valuel
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added subscribers: PokestarFan, Aklapper. TASK DESCRIPTIONCurrently, constraint checkers that use the value (value type, target required claim, …) report a violation if the statement is a somevalue/novalue statement. Once we have T172129: New constraint type for type of snak, we should remove this implicit constraint.TASK DETAILhttps://phabricator.wikimedia.org/T172130EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Nikki, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172130: Don’t imply custom value requirement in constraint types that use the valuel
Lucas_Werkmeister_WMDE added a subtask: T172129: New constraint type for type of snak. TASK DETAILhttps://phabricator.wikimedia.org/T172130EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Nikki, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T172130: Don’t imply custom value requirement in constraint types that use the value
Lucas_Werkmeister_WMDE renamed this task from "Don’t imply custom value requirement in constraint types that use the valuel" to "Don’t imply custom value requirement in constraint types that use the value". TASK DETAILhttps://phabricator.wikimedia.org/T172130EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Nikki, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172129: New constraint type for type of snak
Lucas_Werkmeister_WMDE added a parent task: T172130: Don’t imply custom value requirement in constraint types that use the valuel. TASK DETAILhttps://phabricator.wikimedia.org/T172129EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172127: Include constraint parameters in reports for exceptions
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added subscribers: PokestarFan, Aklapper.
TASK DESCRIPTIONThere’s a TODO in DelegatingConstraintChecker:
if ( in_array( $entityId, $exceptions ) ) {
$result[] = new CheckResult(
$entityId,
$statement,
$constraint,
// TODO: Display parameters anyway.
[],
CheckResult::STATUS_EXCEPTION,
'This entity is a known exception for this constraint and has been marked as such.'
);
continue;
}
I’m going to remove the TODO in the course of the giant T171743 refactoring, so I’m just recording it here. Doing this probably requires itself a big refactoring of how constraint parameters are parsed (or, alternatively: check the constraint and only afterwards change the status, but that’s bad because the constraint check is just wasted time then).TASK DETAILhttps://phabricator.wikimedia.org/T172127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T172127: Include constraint parameters in reports for exceptions
Lucas_Werkmeister_WMDE triaged this task as "Lowest" priority. TASK DETAILhttps://phabricator.wikimedia.org/T172127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172130: Don’t imply custom value requirement in constraint types that use the value
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONCurrently, constraint checkers that use the value (value type, target required claim, …) report a violation if the statement is a somevalue/novalue statement. Once we have {T172129}, we should remove this implicit constraint.
The full list of checkers that emit a `wbqc-violation-message-value-needed` message is: Commons link, diff within range, format, inverse, range, symmetric, target required claim, value type.TASK DETAILhttps://phabricator.wikimedia.org/T172130EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Nikki, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T171285: Show constraint types as human-readable strings in Grafana
Lucas_Werkmeister_WMDE moved this task from Done to Blocked External on the Wikidata-Sprint board.Lucas_Werkmeister_WMDE added a comment. Currently waiting for deployment; once the change is deployed and we have some statsd entries in the new format, Jonas can reconfigure the Grafana board.TASK DETAILhttps://phabricator.wikimedia.org/T171285WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, PokestarFan, Aklapper, Jonas, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T171281: Log details of long-running constraint checks
Lucas_Werkmeister_WMDE moved this task from Review to Blocked External on the Wikidata-Sprint board.Lucas_Werkmeister_WMDE added a comment. Okay, now we’re waiting someone to +2 the log channel addition (change).TASK DETAILhttps://phabricator.wikimedia.org/T171281WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, gerritbot, Jonas, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171586: Mandatory / non-mandatory constraint UI
Lucas_Werkmeister_WMDE added a comment. Currently, we have the following distinctions: Statement with violations of non-mandatory constraints: “info” F8915840: image.png Statement with violations of mandatory constraints (and also non-mandatory ones): “alert” F8915837: image.png Invalid constraint statement on a property: “alert, warning” F8915843: image.png We could also consider using the “info” icon for non-mandatory constraints (just like we currently do – see first screenshot), “notice” for mandatory ones (same size as “info”, but with inverted color scheme and an exclamation mark instead of an “i”), and reserve “alert” (exclamation mark in triangle – see second and third screenshot) for just invalid constraint statements. (Wikimedia UI does not seem to have any other variations for “alert” besides “warning”, so I think the difference between screenshots 2 and 3 is all the nuance we have for a single icon.)TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, daniel, Aklapper, Jan_Dittrich, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170374: Format constraint UX
Lucas_Werkmeister_WMDE added a comment. Yeah, let’s use messages like this: The value for local dialing code (123/456) should match “string combining digits, spaces, - (All else excluded, such as: ,/;()+ )” (regex: [\d\- ]+). or, if there’s no syntax clarification: The value for local dialing code (123/456) should match the regex [\d\- ]+. (This includes a change from “pattern” to “regex”.)TASK DETAILhttps://phabricator.wikimedia.org/T170374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Nikki, PokestarFan, Lucas_Werkmeister_WMDE, Jan_Dittrich, Aklapper, Esc3300, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172113: ConcurrentModificationException on non-grouping query with aggregates in SELECT
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Discovery.
TASK DESCRIPTIONThe following query (link) results in an exception:
SELECT (COUNT(*) AS ?a) (COUNT(?x) AS ?b) (?b/?a AS ?r) {}
java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
at com.bigdata.rdf.sparql.ast.StaticAnalysis.gatherVarsToMaterialize(StaticAnalysis.java:2058)
at com.bigdata.rdf.sparql.ast.StaticAnalysis.gatherVarsToMaterialize(StaticAnalysis.java:2009)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.addAggregation(AST2BOpUtility.java:4679)
at com.bigdata.rdf.sparql.ast.AST2BOpUtility.convertQueryBaseWithScopedVars(AST2BOpUtility.java:534)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convert(AST2BOpUtility.java:287)
at com.bigdata.rdf.sparql.ast.eval.ASTEvalHelper.optimizeQuery(ASTEvalHelper.java:426)
…
I think the query is legal, according to SPARQL, because GROUP BY is not a requirement for using aggregates (“By default a solution set consists of a single group, containing all solutions.”). If you remove the last projection (?b/?a AS ?r), it works.
Here’s the non-reduced query where I found the error: ratio of mandatory constraints
SELECT (COUNT(*) AS ?total) (COUNT(?status) AS ?mandatory) (?mandatory/?total AS ?ratio) WHERE {
?property p:P2302 ?statement.
OPTIONAL { ?statement pq:P2316 ?status. }
}TASK DETAILhttps://phabricator.wikimedia.org/T172113EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T107595: [RFC] Multi-Content Revisions
Lucas_Werkmeister_WMDE removed a project: Wikidata-Sprint.Herald added a subscriber: PokestarFan. TASK DETAILhttps://phabricator.wikimedia.org/T107595EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: brion, Lucas_Werkmeister_WMDECc: PokestarFan, Rical, Ayack, -jem-, Deskana, SBisson, Izno, Pppery, Alsee, Florian, Liuxinyu970226, WMDE-leszek, Mholloway, Scott_WUaS, Niharika, MGChecker, LikeLifer, Elitre, Glaisher, JJMC89, RobLa-WMF, Yurik, ArielGlenn, APerson, TomT0m, Krenair, intracer, Tgr, Tobi_WMDE_SW, Lydia_Pintscher, cscott, PleaseStand, awight, Ricordisamoa, GWicke, waldyrious, Legoktm, Aklapper, Jdforrester-WMF, Ltrlg, brion, Spage, MZMcBride, daniel, GoranSMilovanovic, QZanden, Marostegui, Luke081515, Wikidata-bugs, aude, jayvdb, fbstj, Anomie, santhosh, Mbch331, Rxy, Jay8g, bd808___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170374: Format constraint UX
Lucas_Werkmeister_WMDE added a comment. Yes, there can be multiple format constraints (see e. g. ISBN-10).TASK DETAILhttps://phabricator.wikimedia.org/T170374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Nikki, PokestarFan, Lucas_Werkmeister_WMDE, Jan_Dittrich, Aklapper, Esc3300, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172259: SPARQL2 query examples don’t appear on query.wikidata.org
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Discovery. TASK DESCRIPTIONIt looks like all the query examples using the SPARQL2 template are missing from the list of examples on query.wikidata.org, at least since yesterday. Investigating.TASK DETAILhttps://phabricator.wikimedia.org/T172259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T172259: SPARQL2 query examples don’t appear on query.wikidata.org
Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board.Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T172259WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Jonas, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T172130: Don’t imply custom value requirement in constraint types that use the value
Lucas_Werkmeister_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T172130EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Nikki, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171636: Some areas of Query Service are not translatable
Lucas_Werkmeister_WMDE added a subtask: T168655: Query service UI editor placeholder is not translated. TASK DETAILhttps://phabricator.wikimedia.org/T171636EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: TerraCodes, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Lea_Lacroix_WMDE, PokestarFan, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, EBjune, merbst, Avner, debt, Gehel, Abbe98, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Gryllida, Shizhao, Arrbee, TheDJ, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T168655: Query service UI editor placeholder is not translated
Lucas_Werkmeister_WMDE added a parent task: T171636: Some areas of Query Service are not translatable. TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Aklapper, Jonas, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages
Lucas_Werkmeister_WMDE added a comment.Herald added a subscriber: PokestarFan. Currently, the following roles are defined: subject, the subject (item or property) of a statement predicate, the predicate (property) of a statement object, the object (value) of a statement constraint-property, the property that introduced a constraint qualifier-predicate, the predicate (property) of a qualifier constraint-parameter-property, the property for a constraint parameter constraint-parameter-value, the value for a constraint parameter constraint-type-item, the constraint type item They each correspond to a CSS class wbqc-role-$role on a span surrounding the element. That span also has a class wbqc-role, so common styles (e. g. border radius, padding) can go there and the individual pill styles only need to define colors.TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, gerritbot, Lydia_Pintscher, Jan_Dittrich, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172259: SPARQL2 query examples don’t appear on query.wikidata.org
Lucas_Werkmeister_WMDE added a comment. The attached change fixes this, but also (I think) removes support for the old form of the SPARQL2 template, so the steps are: temporarily revert SPARQL2 template – done by @Jonas merge and deploy the fix ASAP after the previous step, but not before: unrevert the SPARQL2 template Between steps 2 and 3, SPARQL2 examples will be gone again.TASK DETAILhttps://phabricator.wikimedia.org/T172259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Jonas, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171291: Remove support for constraint templates
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint.Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board.Herald added a subscriber: PokestarFan. TASK DETAILhttps://phabricator.wikimedia.org/T171291WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Liuxinyu970226, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T169532: Better treatment of constraint parameters
Lucas_Werkmeister_WMDE removed a project: Wikidata-Sprint.Lucas_Werkmeister_WMDE lowered the priority of this task from "Normal" to "Low".Lucas_Werkmeister_WMDE added a comment. No longer in DOING/Sprint, this is mostly done and the remaining task T170811: Check constraint parameters after constraint statement is saved is lower priority IMO.TASK DETAILhttps://phabricator.wikimedia.org/T169532EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Jonas, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172380: Query constraint violations with WDQS
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONNow that the constraints are machine-readable on property pages, it is a charming idea to query constraint violations on the fly using the Wikidata Query Service. It should be possible to identify items based on various criteria, such as: * 1. French painters with any type of constraint violation on any claim * 2. French painters with a specific constraint violation (e.g. single values constraint) on any claim * 3. French painters with any type of constraint violation on a claim of a specific property (e.g. P569) * 4. French painters with a specific constraint violation (e.g. single values constraint) on a claim of a specific property (e.g. P569) * 5. And so on…...TASK DETAILhttps://phabricator.wikimedia.org/T172380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Esc3300, Aklapper, PokestarFan, MisterSynergy, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103257: [Bug] Fix mark as exception toggle on Special Page Violations
Lucas_Werkmeister_WMDE added a comment.Herald added a subscriber: PokestarFan. Is this for WBQEV? WBQC has no such toggle as far as I’m aware.TASK DETAILhttps://phabricator.wikimedia.org/T103257EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Lucas_Werkmeister_WMDE, Aklapper, Tamslo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T171291: Remove support for constraint templates
Lucas_Werkmeister_WMDE created subtask T172407: Remove ConstraintsFromTemplates?. TASK DETAILhttps://phabricator.wikimedia.org/T171291EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Liuxinyu970226, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172407: Remove ConstraintsFromTemplates?
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints. TASK DESCRIPTIONOnce support for constraint templates is completely removed, what do we do with ConstraintsFromTemplates? I don’t suppose we should completely delete the repository… is it enough to just put a big notice “you don’t need this anymore” at the top of the README? (Regardless of what we do – T136081: Wikibase Quality scripts UpdateConstraintsTable should not have wikidata.org hardcoded can probably be closed as “declined” once support for constraint statements is gone.)TASK DETAILhttps://phabricator.wikimedia.org/T172407EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Liuxinyu970226, PokestarFan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T105416: Item-datatype values should link to target item
Lucas_Werkmeister_WMDE closed this task as "Declined".Lucas_Werkmeister_WMDE added a comment.Herald added a subscriber: PokestarFan. Does that cover this issue, @Yair_rand? Closing, since I heard nothing to the contrary. Grafana clearly shows that the gadget is used much more than the special page anyways, so having the clickable link in the violation message on the special page is good enough.TASK DETAILhttps://phabricator.wikimedia.org/T105416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Lucas_Werkmeister_WMDE, MisterSynergy, Mbch331, StudiesWorld, Yair_rand, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168532: Check constraints on qualifiers and references
Lucas_Werkmeister_WMDE added a comment. Yeah, it’s on the wikidata-quality Grafana board – I agree that a simple solution is probably good enough.TASK DETAILhttps://phabricator.wikimedia.org/T168532EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T88968: [Task] Composite Constraints
Lucas_Werkmeister_WMDE added a comment. I see, thank you… but that template was subst only before this issue was even opened, so if I understand correctly there’d be no difference between composite constraints and regular ones except when you added them.TASK DETAILhttps://phabricator.wikimedia.org/T88968EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Esc3300, Mbch331, Izno, PokestarFan, Lucas_Werkmeister_WMDE, Dimitri.schmidt, Andreasburmeister, Lydia_Pintscher, Aklapper, Jonas.keutel, GoranSMilovanovic, QZanden, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172007: $itemId must be either ItemId or string
Lucas_Werkmeister_WMDE added a comment. Fix was deployed and the link in the task description no longer errors out. @Ladsgroup, do you want to check the logs for any new messages (deployment was a few minutes ago, apparently)?TASK DETAILhttps://phabricator.wikimedia.org/T172007EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, PokestarFan, Lucas_Werkmeister_WMDE, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172007: $itemId must be either ItemId or string
Lucas_Werkmeister_WMDE added a comment. Aaaand Wikidata was rolled back again :( https://tools.wmflabs.org/sal/log/AV2pyg6aF4fsM4DBcx5sTASK DETAILhttps://phabricator.wikimedia.org/T172007EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, PokestarFan, Lucas_Werkmeister_WMDE, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T169326: Type constraints still report false violations
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a comment. Okay, the change was finally deployed (it was delayed for a while, not sure why), and it seems to work – no more violations on The Private Life of Genghis Khan and on the Hestskjær Lighthouse.TASK DETAILhttps://phabricator.wikimedia.org/T169326EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: waldyrious, Stashbot, gerritbot, PokestarFan, Esc3300, Lydia_Pintscher, Agabi10, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172007: $itemId must be either ItemId or string
Lucas_Werkmeister_WMDE added a comment. Agreed. We could backport the fix to wmf.10 if it’s urgent (I don’t think it is), but apart from that there’s nothing to do here except hope that the Wikidata build isn’t blocked for too long.TASK DETAILhttps://phabricator.wikimedia.org/T172007EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, PokestarFan, Lucas_Werkmeister_WMDE, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172380: Query constraint violations with WDQS
Lucas_Werkmeister_WMDE added a comment. @Smalyshev I don’t think the lack of grouping support in MWAPI is a big problem here – constraint checks are just expensive at the moment, so I expect such queries would take a long time regardless of whether the actual API requests are grouped or not.TASK DETAILhttps://phabricator.wikimedia.org/T172380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Smalyshev, Esc3300, Aklapper, PokestarFan, MisterSynergy, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169326: Type constraints still report false violations
Lucas_Werkmeister_WMDE added a comment. Unfortunately, the Wikidata deployment was rolled back due to unrelated problems in Wikibase itself, so the false violations are back for the time being. If the build problem persists, I might try to get the fix backported, otherwise we’ll just have to wait it out – sorry.TASK DETAILhttps://phabricator.wikimedia.org/T169326EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: waldyrious, Stashbot, gerritbot, PokestarFan, Esc3300, Lydia_Pintscher, Agabi10, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE added parent tasks: T168240: WBQC test improvements, T171291: Remove support for constraint templates. TASK DETAILhttps://phabricator.wikimedia.org/T172378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint.Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T172378WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171291: Remove support for constraint templates
Lucas_Werkmeister_WMDE added a subtask: T172378: Migrate tests to constraint statement parameters. TASK DETAILhttps://phabricator.wikimedia.org/T171291EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: PokestarFan, Liuxinyu970226, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T168240: WBQC test improvements
Lucas_Werkmeister_WMDE added a subtask: T172378: Migrate tests to constraint statement parameters. TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE moved this task from Proposed to Doing on the Wikidata-Sprint board.Lucas_Werkmeister_WMDE triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T172378WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T88968: [Task] Composite Constraints
Lucas_Werkmeister_WMDE closed this task as "Invalid".Lucas_Werkmeister_WMDE added a comment. Closing, since there’s no one around anymore who knows what this task means. If it’s a real problem, someone can open a new task.TASK DETAILhttps://phabricator.wikimedia.org/T88968EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Mbch331, Izno, PokestarFan, Lucas_Werkmeister_WMDE, Dimitri.schmidt, Andreasburmeister, Lydia_Pintscher, Aklapper, Jonas.keutel, GoranSMilovanovic, QZanden, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172380: Query constraint violations with WDQS
Lucas_Werkmeister_WMDE added a project: Wikibase-Quality. TASK DETAILhttps://phabricator.wikimedia.org/T172380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, PokestarFan, MisterSynergy, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173409: Tidy up @covers/@uses annotations in WikibaseQualityConstraints tests
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONI haven’t really been paying much attention to the @covers/@uses annotations when changing the tests, and by now I suspect a lot of them are out of date: there are probably @uses annotations for classes that aren’t actually used anymore, as well as plenty of missing @uses annotations. I’m not sure how to systematically fix this, because it seems adding --strict-coverage has no effect, at least not for the way I usually run the tests.TASK DETAILhttps://phabricator.wikimedia.org/T173409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173243: UnsupportedOperationException on BIND + EXISTS + MINUS + property path
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata-Query-Service, Wikidata.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Discovery.
TASK DESCRIPTIONMinimal query:
SELECT * { BIND(EXISTS { MINUS { ?a p:1/p:2 ?c. } } AS ?t) }
Caused by: java.lang.UnsupportedOperationException: child:
PropertyPathNode(VarNode(a), com.bigdata.rdf.sparql.ast.PathNode(PathAlternative), VarNode(c)) [scope=DEFAULT_CONTEXTS]
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertJoinGroup(AST2BOpUtility.java:3383)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertJoinGroupOrUnion(AST2BOpUtility.java:2586)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.addSubgroup(AST2BOpUtility.java:4352)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertJoinGroup(AST2BOpUtility.java:3342)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertJoinGroupOrUnion(AST2BOpUtility.java:2586)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.addExistsSubqueryFast(AST2BOpUtility.java:2426)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.addExistsSubquery(AST2BOpUtility.java:2253)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertJoinGroup(AST2BOpUtility.java:3296)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertJoinGroupOrUnion(AST2BOpUtility.java:2586)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convertQueryBaseWithScopedVars(AST2BOpUtility.java:474)
at com.bigdata.rdf.sparql.ast.eval.AST2BOpUtility.convert(AST2BOpUtility.java:287)
at com.bigdata.rdf.sparql.ast.eval.ASTEvalHelper.optimizeQuery(ASTEvalHelper.java:426)
at com.bigdata.rdf.sparql.ast.eval.ASTEvalHelper.evaluateTupleQuery(ASTEvalHelper.java:212)
…
Looks like a bug to me (almost certainly upstream).
Here’s the unreduced query:
# % of unsourced religion statements by religion
SELECT ?religion ?religionLabel ?count ?anyReferencedCount ?realReferencedCount (100*?anyReferencedCount/?count AS ?anyPercent) (100*?realReferencedCount/?count AS ?realPercent) WITH {
SELECT ?religion (COUNT(?statement) AS ?count) (SUM(?anyeferences) AS ?anyReferencedCount) (SUM(?realReferences) AS ?realReferencedCount) WHERE {
?item p:P140 ?statement.
?statement ps:P140 ?religion.
BIND(IF(EXISTS { ?statement prov:wasDerivedFrom ?reference. }, 1, 0) AS ?anyReferences)
BIND(IF(EXISTS { ?statement prov:wasDerivedFrom ?reference. MINUS { ?reference pr:P143/wdt:P31 wd:Q10876391. } }, 1, 0) AS ?realReferences)
}
GROUP BY ?religion
} AS %results WHERE {
INCLUDE %results.
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
ORDER BY DESC(?count)TASK DETAILhttps://phabricator.wikimedia.org/T173243EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173248: Convert blank nodes to “unknown value” in label service
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Discovery.
TASK DESCRIPTIONTake, for example, the following query:
SELECT ?type ?typeLabel WHERE {
wd:Q302 wdt:P1853 ?type.
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
The results are:
wd:Q19831455AB
t505463773t505463773
t505463773 is the string representation of an RDF blank node, which in this context means unknown value. Since we don’t use blank nodes anywhere else in the Wikibase RDF export format, I think it would be a nice idea for the label service to display this as “unknown value”.
(Slight complication: ideally, “unknown value” should of course be localized, but as far as I can tell the entire query service doesn’t yet have any i18n infrastructure.)TASK DETAILhttps://phabricator.wikimedia.org/T173248EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173368: Update SparqlHelper timeout detection
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata-Sprint.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIt looks like for whatever reason, the error message in case of query timeout changed within the past week or two – instead of a custom QueryTimeoutException, we now get a generic TimeoutException, and it’s no longer wrapped in five other exceptions either. Since we track timeouts on Grafana, we need to update the detection to cope with that.TASK DETAILhttps://phabricator.wikimedia.org/T173368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172925: Label service in subquery and outer query causes NotMaterializedException
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Discovery.
TASK DESCRIPTIONSELECT ?aLabel ?bLabel WHERE {
{
SELECT ?a ?aLabel WHERE {
BIND(wd:Q1 AS ?a)
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
}
BIND(wd:Q2 AS ?b)
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
…
Caused by: org.openrdf.query.QueryEvaluationException: com.bigdata.rdf.internal.NotMaterializedException: TermId(20445L)
at com.bigdata.rdf.sail.Bigdata2Sesame2BindingSetIterator.hasNext(Bigdata2Sesame2BindingSetIterator.java:188)
at info.aduna.iteration.IterationWrapper.hasNext(IterationWrapper.java:68)
at org.openrdf.query.QueryResults.report(QueryResults.java:155)
at org.openrdf.repository.sail.SailTupleQuery.evaluate(SailTupleQuery.java:76)
at com.bigdata.rdf.sail.webapp.BigdataRDFContext$TupleQueryTask.doQuery(BigdataRDFContext.java:1713)
at com.bigdata.rdf.sail.webapp.BigdataRDFContext$AbstractQueryTask.innerCall(BigdataRDFContext.java:1569)
at com.bigdata.rdf.sail.webapp.BigdataRDFContext$AbstractQueryTask.call(BigdataRDFContext.java:1534)
at com.bigdata.rdf.sail.webapp.BigdataRDFContext$AbstractQueryTask.call(BigdataRDFContext.java:747)
... 4 more
Caused by: com.bigdata.rdf.internal.NotMaterializedException: TermId(20445L)
at com.bigdata.rdf.internal.impl.AbstractIV.getValue(AbstractIV.java:993)
at com.bigdata.rdf.sail.Bigdata2Sesame2BindingSetIterator.getBindingSet(Bigdata2Sesame2BindingSetIterator.java:298)
at com.bigdata.rdf.sail.Bigdata2Sesame2BindingSetIterator.hasNext(Bigdata2Sesame2BindingSetIterator.java:140)
... 11 more
Workaround: explicitly instruct the outer label service that we only need ?b rdfs:label ?bLabel, or remove label service and ?aLabel from the subquery.
Here’s a further reduced query that results in the same error:
SELECT ?aLabel ?bLabel WHERE {
{ SELECT (wd:Q1 AS ?a) ?aLabel {} }
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}
Removing ?a or ?aLabel from the subquery, or removing the binding from ?a (SELECT ?a … without any AS), all remove the error.TASK DETAILhttps://phabricator.wikimedia.org/T172925EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, PokestarFan, Smalyshev, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172916: [Task] Remove as much unused and obsolete JavaScript code as possible from all Wikibase code bases
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/370811...TASK DETAILhttps://phabricator.wikimedia.org/T172916EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, PokestarFan, Aleksey_WMDE, Lydia_Pintscher, hoo, aude, Jonas, thiemowmde, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172916: [Task] Remove as much unused and obsolete JavaScript code as possible from all Wikibase code bases
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://github.com/wmde/DataValuesJavaScript/pull/120TASK DETAILhttps://phabricator.wikimedia.org/T172916EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, PokestarFan, Aleksey_WMDE, Lydia_Pintscher, hoo, aude, Jonas, thiemowmde, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173248: Convert blank nodes to “unknown value”
Lucas_Werkmeister_WMDE added a comment. Isn’t the label service a kind of GUI-like thing already? Tools that process data should primarily look at the value itself, not at the label, and the same goes for tools that are actually interested in the bnode’s identity: they can all still select the regular variable (in the example query, ?type) and continue to use it as before. In fact, any tool that looks at the label to distinguish bnodes, or to decide that t\d+ must mean “unknown value”, is broken already, since any regular entity can also have such a label.TASK DETAILhttps://phabricator.wikimedia.org/T173248EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173248: Convert blank nodes to “unknown value”
Lucas_Werkmeister_WMDE added a comment. Yes, but the point of the label isn’t to be unambiguous anyways.TASK DETAILhttps://phabricator.wikimedia.org/T173248EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T173243: UnsupportedOperationException on property path in EXISTS
Lucas_Werkmeister_WMDE renamed this task from "UnsupportedOperationException on BIND + EXISTS + MINUS + property path" to "UnsupportedOperationException on property path in EXISTS".Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...SELECT * WHERE { BIND(EXISTS { MINUS {S { ?a p:1/p:2 ?cb. } } AS ?t) }...TASK DETAILhttps://phabricator.wikimedia.org/T173243EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T173243: UnsupportedOperationException on property path in EXISTS
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...SELECT * WHERE { BIND(EXISTS { ?a p:1/p:2 ?b. } AS ?t) }...TASK DETAILhttps://phabricator.wikimedia.org/T173243EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Smalyshev, Lucas_Werkmeister_WMDE, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T173368: Update SparqlHelper timeout detection
Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T173368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE added a subscriber: Jonas.Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONMany of the constraint checker tests still use template-style parameters, e. g. `[ 'property' => 'P2' ]`. Before we can remove support for constraint templates, we’ll have to migrate those tests to use statement-style parameters. This can be done with helper methods in the `ConstraintParameter` trait, like the existing methods `propertyParameter`, `propertiesParameter`, `rangeParameter`, `namespaceParameter`, and `formatParameter`. Changes: - [ ] [type checkers](https://gerrit.wikimedia.org/r/#/c/362395/) - [ ] [range checker](https://gerrit.wikimedia.org/r/#/c/369909/) - [ ] [connection checkers](https://gerrit.wikimedia.org/r/#/c/369914/) - [ ] [one of checker](https://gerrit.wikimedia.org/r/#/c/369917/) - [x] [mandatory qualifiers checker](https://gerrit.wikimedia.org/r/#/c/369946/) - [x] [constraint status](https://gerrit.wikimedia.org/r/#/c/369955/) - [ ] [`DelegatingConstraintchecker`](https://gerrit.wikimedia.org/r/#/c/372162/) - [ ] [special page](https://gerrit.wikimedia.org/r/#/c/372171/)TASK DETAILhttps://phabricator.wikimedia.org/T172378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [`DelegatingConstraintcChecker`](https://gerrit.wikimedia.org/r/#/c/372162/)...TASK DETAILhttps://phabricator.wikimedia.org/T172378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Changes: - [ - [x] [type checkers](https://gerrit.wikimedia.org/r/#/c/362395/)...TASK DETAILhttps://phabricator.wikimedia.org/T172378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172378: Migrate tests to constraint statement parameters
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [type checkers](https://gerrit.wikimedia.org/r/#/c/362395/) - [ - [x] [range checker](https://gerrit.wikimedia.org/r/#/c/369909/)...TASK DETAILhttps://phabricator.wikimedia.org/T172378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173495: Update Wikidata Query GUI timeout detection
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Query UI.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThe query service currently returns a generic TimeoutException instead of a QueryTimeoutException on timeout. The GUI needs to be updated to still show the right message on timeouts. (See T173368: Update SparqlHelper timeout detection for a related change in the WikibaseQualityConstraints extension.)TASK DETAILhttps://phabricator.wikimedia.org/T173495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, EBjune, merbst, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T173495: Update Wikidata Query GUI timeout detection
Lucas_Werkmeister_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T173495EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, EBjune, merbst, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T173495: Update Wikidata Query GUI timeout detection
Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board.Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T173495WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, EBjune, merbst, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T173495: Update Wikidata Query GUI timeout detection
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint board. TASK DETAILhttps://phabricator.wikimedia.org/T173495WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Jonas, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, Lewizho99, Maathavan, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T170395: Ignore deprecated statements when checking “difference within range” constraints
Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board.Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T170395WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170374: Format constraint UX
Lucas_Werkmeister_WMDE added a comment. @Jan_Dittrich your suggestions are very difficult to implement – figuring out how to “fix” a string so that it matches a regular _expression_ is a hard problem. And we don’t have a short description of the constraint (“a URL”). @Esc3300 I wasn’t aware of that property, sounds nice… but currently it’s only used on four “Wikidata property example” statements and 302 “format as a regular _expression_” statements, never on constraint statements. But I think it could make sense to display this qualifier in general, for any constraint type.TASK DETAILhttps://phabricator.wikimedia.org/T170374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Jan_Dittrich, Aklapper, Esc3300, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170374: Format constraint UX
Lucas_Werkmeister_WMDE added a comment. we would have a Regex, but it carries no context what it would do? Yup. Could we use capture groups and see which does (not) capture? I don’t see how – all we get back from the query service is “matches” or “doesn’t match”, and doing anything not on the query service opens us up to DoS attacks via expensive regexes.TASK DETAILhttps://phabricator.wikimedia.org/T170374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Jan_Dittrich, Aklapper, Esc3300, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T170403: Consider rank when checking “unique value” constraint
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTION“unique value” constraint checks should take the rank of the other found statements into account – but how exactly should they do that? Should they ignore deprecated statements, or any statement that isn’t best rank (including normal-rank statements when a preferred-rank statement exists)?TASK DETAILhttps://phabricator.wikimedia.org/T170403EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T167653: Consider ranks in constraint checks
Lucas_Werkmeister_WMDE created subtask T170403: Consider rank when checking “unique value” constraint. TASK DETAILhttps://phabricator.wikimedia.org/T167653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Esc3300, thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T170391: Don’t check constraints on deprecated statements
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T170391EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T170398: Ignore deprecated statements when checking “inverse”, “symmetric”, “item requires claim”, and “value requires claim” constraints?
Lucas_Werkmeister_WMDE renamed this task from "Ignore deprecated statements when checking “inverse”, “symmetric”, and “value requires claim” constraints?" to "Ignore deprecated statements when checking “inverse”, “symmetric”, “item requires claim”, and “value requires claim” constraints?".Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONIf a property requires a certain statement on the targetan item, and that statement exists but is deprecated… should that be reported as a constraint violation? I’m not sure, because it seems to me that there’s no good fix for this violation (there’s probably a good reason the statement is deprecated, and undeprecating it or adding a normal-rank copy is probably not the right thing to do).TASK DETAILhttps://phabricator.wikimedia.org/T170398EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T167653: Consider ranks in constraint checks
Lucas_Werkmeister_WMDE created subtask T170398: Ignore deprecated statements when checking “inverse” and “symmetric” constraints?. TASK DETAILhttps://phabricator.wikimedia.org/T167653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Esc3300, thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T170395: Ignore deprecated statements when checking “difference within range” constraints
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThe “difference within range” constraint usually only takes the first referenced statement into account (e. g. for a “difference [with date of birth] within range” constraint on “date of death”, only the first “date of birth” statement is considered), but it probably makes sense to skip deprecated statements there.TASK DETAILhttps://phabricator.wikimedia.org/T170395EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T167653: Consider ranks in constraint checks
Lucas_Werkmeister_WMDE created subtask T170395: Ignore deprecated statements when checking “difference within range” constraints. TASK DETAILhttps://phabricator.wikimedia.org/T167653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Esc3300, thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T167653: Consider ranks in constraint checks
Lucas_Werkmeister_WMDE added a comment. Okay, I created a bunch of subtasks where we can discuss the details (based on my earlier comment). Especially the tasks without assignee could do with some more input.TASK DETAILhttps://phabricator.wikimedia.org/T167653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Esc3300, thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T170398: Ignore deprecated statements when checking “inverse”, “symmetric”, and “value requires claim” constraints?
Lucas_Werkmeister_WMDE renamed this task from "Ignore deprecated statements when checking “inverse” and “symmetric” constraints?" to "Ignore deprecated statements when checking “inverse”, “symmetric”, and “value requires claim” constraints?".Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONIf a property requires a symmetric or inversecertain statement on the target item, and that statement exists but is deprecated… should that be reported as a constraint violation? I’m not sure, because it seems to me that there’s no good fix for this violation (there’s probably a good reason the statement is deprecated, and undeprecating it or adding a normal-rank copy is probably not the right thing to do).TASK DETAILhttps://phabricator.wikimedia.org/T170398EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T170398: Ignore deprecated statements when checking “inverse” and “symmetric” constraints?
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIf a property requires a symmetric or inverse statement on the target item, and that statement exists but is deprecated… should that be reported as a constraint violation? I’m not sure, because it seems to me that there’s no good fix for this violation (there’s probably a good reason the statement is deprecated, and undeprecating it or adding a normal-rank copy is probably not the right thing to do).TASK DETAILhttps://phabricator.wikimedia.org/T170398EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T167653: Consider ranks in constraint checks
Lucas_Werkmeister_WMDE created subtask T170391: Don’t check constraints on deprecated statements. TASK DETAILhttps://phabricator.wikimedia.org/T167653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Esc3300, thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T170391: Don’t check constraints on deprecated statements
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThe following constraint types should all not be checked on deprecated statements: conflicts with, difference within range, inverse, item requires claim, mandatory qualifier, multi value, one of, allowed qualifiers, range, single value, symmetric, value requires claim, type, unique value, value type. Rationale: all of these constraint types are “logical” or “semantical” constraints, not “technical” ones, and the deprecated rank already marks the statement as logically / semantically incorrect. Does anyone disagree?TASK DETAILhttps://phabricator.wikimedia.org/T170391EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T167653: Consider ranks in constraint checks
Lucas_Werkmeister_WMDE created subtask T170401: Ignore deprecated statements when checking “type” and “value type” constraints?. TASK DETAILhttps://phabricator.wikimedia.org/T167653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, Esc3300, thiemowmde, Pigsonthewing, Lydia_Pintscher, Ivan_A_Krestinin, Lucas_Werkmeister_WMDE, Nikki, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T170401: Ignore deprecated statements when checking “type” and “value type” constraints?
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIf a property requires a certain type on an item, and a matching “instance of” or “subclass of” statement exists but is deprecated… should that be reported as a constraint violation? (Note: the current implementation ignores rank when checking the type in PHP but then uses wdt: triples in the SPARQL fallback, so one of the two definitely needs to be updated.)TASK DETAILhttps://phabricator.wikimedia.org/T170401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T169647: Enable constraint statements on Wikidata
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION~~We want to do this next Wednesday, 2017-07-12.~~ Rescheduled to Thursday, 2017-07-20, since there was no deployment on the week of July 10th (build problems). Steps:...TASK DETAILhttps://phabricator.wikimedia.org/T169647EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Agabi10, gerritbot, Ivan_A_Krestinin, Jonas, aude, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
