[Wikidata-bugs] [Maniphest] T355168: [SW] [LEX] Stop hiding warnings in new-lexeme-special-page tests
Lucas_Werkmeister_WMDE renamed this task from "[LEX] Stop hiding warnings in new-lexeme-special-page tests" to "[SW] [LEX] Stop hiding warnings in new-lexeme-special-page tests". TASK DETAIL https://phabricator.wikimedia.org/T355168 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T355168: [LEX] Stop hiding warnings in new-lexeme-special-page tests
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | | --- | | | production / end users | ✘| | monitoring | ✘| | development efforts | ✔| | onboarding efforts | ✔| | additional stakeholders | ✘| TASK DETAIL https://phabricator.wikimedia.org/T355168 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306293: [SW] [LEX] Lexeme header formats Lemma using non-HTML language code
Lucas_Werkmeister_WMDE renamed this task from "[LEX] Lexeme header formats Lemma using non-HTML language code" to "[SW] [LEX] Lexeme header formats Lemma using non-HTML language code". TASK DETAIL https://phabricator.wikimedia.org/T306293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, LucasWerkmeister, Danny_Benjafield_WMDE, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, srishakatux, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306293: [LEX] Lexeme header formats Lemma using non-HTML language code
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | | --- | | | production / end users | ✔| | monitoring | ✘| | development efforts | ✘| | onboarding efforts | ✘| | additional stakeholders | ✘| TASK DETAIL https://phabricator.wikimedia.org/T306293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, LucasWerkmeister, Danny_Benjafield_WMDE, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, srishakatux, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346516: [SW] [LEX] Update WikibaseLexeme to use the new HookContainer/HookRunner system
Lucas_Werkmeister_WMDE renamed this task from "[LEX] Update WikibaseLexeme to use the new HookContainer/HookRunner system" to "[SW] [LEX] Update WikibaseLexeme to use the new HookContainer/HookRunner system". TASK DETAIL https://phabricator.wikimedia.org/T346516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346516: [LEX] Update WikibaseLexeme to use the new HookContainer/HookRunner system
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | | --- | | | production / end users | ✘| | monitoring | ✘| | development efforts | ✔| | onboarding efforts | ✔| | additional stakeholders | ✔| TASK DETAIL https://phabricator.wikimedia.org/T346516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T343737: [LEX] Searching for a Form-Id with `wbsearchentities` does not return "label" and "description" data for the results
Lucas_Werkmeister_WMDE moved this task from [DOT] Tech Backlog to Incoming on the Wikidata Dev Team board. Lucas_Werkmeister_WMDE added a comment. The result looks like this, by the way: F42570279: image.png <https://phabricator.wikimedia.org/F42570279> This seems like it should be prioritized by Product. TASK DETAIL https://phabricator.wikimedia.org/T343737 WORKBOARD https://phabricator.wikimedia.org/project/board/6016/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T246446: [SW] [LEX] WikibaseLexeme: Validate response structure
Lucas_Werkmeister_WMDE renamed this task from "[LEX] WikibaseLexeme: Validate response structure" to "[SW] [LEX] WikibaseLexeme: Validate response structure". TASK DETAIL https://phabricator.wikimedia.org/T246446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T246446: [LEX] WikibaseLexeme: Validate response structure
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | Notes | | --- | | --- | | production / end users | ✘| Potentially avoids future logspam / errors, but currently there are no such errors that we know of. | | monitoring | ✘| | | development efforts | ✔| | | onboarding efforts | ✘| | | additional stakeholders | ✘| | TASK DETAIL https://phabricator.wikimedia.org/T246446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T356402: [ES] Investigate OutOfMemory error in browser test, remove workaround
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | Notes | | --- | | - | | production / end users | ✔| Memory savings should help in production too. | | monitoring | ✘| | | development efforts | ✔| | | onboarding efforts | ✘| | | additional stakeholders | ✔| Affects shared CI environment. | TASK DETAIL https://phabricator.wikimedia.org/T356402 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Krinkle, hashar, Michael, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, KimKelting, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, thcipriani, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T356402: [ES] Investigate OutOfMemory error in browser test, remove workaround
Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Wikidata.org Slice). Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor. TASK DETAIL https://phabricator.wikimedia.org/T356402 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Krinkle, hashar, Michael, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, KimKelting, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, thcipriani, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353957: [SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)
Lucas_Werkmeister_WMDE renamed this task from "Wikibase secondary CI is broken and email sending is broken again (Dec 2023)" to "[SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)". TASK DETAIL https://phabricator.wikimedia.org/T353957 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353957: [SW] Wikibase secondary CI is broken and email sending is broken again (Dec 2023)
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | | --- | | | production / end users | ✘| | monitoring | ✘| | development efforts | ✔| | onboarding efforts | ✘| | additional stakeholders | ✔| | (Additional stakeholders: other Wikidata/Wikibase teams.) TASK DETAIL https://phabricator.wikimedia.org/T353957 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T351829: [SW] [GENERAL] Deprecate connecting senses prototype
Lucas_Werkmeister_WMDE renamed this task from "[GENERAL] Deprecate connecting senses prototype" to "[SW] [GENERAL] Deprecate connecting senses prototype". TASK DETAIL https://phabricator.wikimedia.org/T351829 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Bellucii32, Astuthiodit_1, karapayneWMDE, Invadibot, Devnull, maantietaja, Nintendofan885, Akuckartz, 94rain, Nandana, Namenlos314, skpuneethumar, Zylc, 1978Gage2001, Lahi, Operator873, Gq86, Bsandipan, GoranSMilovanovic, DSquirrelGM, Chicocvenancio, QZanden, Tbscho, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Jitrixis, aude, Gryllida, scfc, Mbch331, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T351829: [GENERAL] Deprecate connecting senses prototype
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | Notes | | --- | | - | | production / end users | ✔| Though we’re not sure if there are any end users. | | monitoring | ✘| | | development efforts | ✔| One less thing to worry about. | | onboarding efforts | ✔| One less thing to onboard people onto. | | additional stakeholders | ✘| | TASK DETAIL https://phabricator.wikimedia.org/T351829 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Bellucii32, Astuthiodit_1, karapayneWMDE, Invadibot, Devnull, maantietaja, Nintendofan885, Akuckartz, 94rain, Nandana, Namenlos314, skpuneethumar, Zylc, 1978Gage2001, Lahi, Operator873, Gq86, Bsandipan, GoranSMilovanovic, DSquirrelGM, Chicocvenancio, QZanden, Tbscho, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Jitrixis, aude, Gryllida, scfc, Mbch331, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase
Lucas_Werkmeister_WMDE added a comment. I think `NoBadUsageTestBase` would work for cases where we want to prevent PHP things (e.g. `DB_MASTER` instead of `DB_PRIMARY`), but for such a general check, I’m not convinced it’s worth checking automatically. TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, JArguello-WMF, toan, Aklapper, Reedy, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, Lydia_Pintscher, siebrand, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358975: wbremovequalifiers-update comment is not autoformatted
Lucas_Werkmeister_WMDE added subscribers: Arian_Bozorg, Lucas_Werkmeister_WMDE. Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team. Lucas_Werkmeister_WMDE added a comment. @Arian_Bozorg this is probably a relatively simple fix (define a few more i18n messages), do you want to put it on the product backlog? TASK DETAIL https://phabricator.wikimedia.org/T358975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Arian_Bozorg, Aklapper, matej_suchanek, Danny_Benjafield_WMDE, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358574: [MSMF] [TECH] Enable stylelint with using `stylelint-stylistic`
Lucas_Werkmeister_WMDE added a comment. | Impact Area | Affected | | --- | | | production / end users | ✘| | monitoring | ✘| | development efforts | ✔| | onboarding efforts | ✔| | additional stakeholders | ✘| TASK DETAIL https://phabricator.wikimedia.org/T358574 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, noarave, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T212645: JavaScript error on items with new maps in safemode: "Unknown dependency: ext.kartographer.site"
Lucas_Werkmeister_WMDE removed projects: MediaWiki-extensions-WikibaseRepository, wmde-wikidata-tech, Wikidata. Lucas_Werkmeister_WMDE added a comment. I don’t think this is a Wikibase problem at all; the non-interactive Kartographer map, and console error message, can also be reproduced on e.g. https://de.wikivoyage.org/wiki/Hallstatt?safemode=1. TASK DETAIL https://phabricator.wikimedia.org/T212645 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Celenduin, Michael, TheDJ, hoo, Aklapper, matej_suchanek, mrephabricator, Trngsh15, Mengs21, EgbeRef, Vaibhav0199, Alilje, Tinzawoo533, Nabetaro, Onmir, MSantos, Mh-3110, Looniverse, Sturm, Orienteerix, enigmaeth, rohitt, Ddproxy, JGirault, phabyogi, Dixtosa, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Dinoguy1000, awight, Yurik, Jay8g, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T251656: Replace if wrapping test class in Scribunto_LuaWikibaseLibraryTestCase
Lucas_Werkmeister_WMDE added a comment. > There's definitely better way than doing this... Do you have a suggestion? Because otherwise, as long as this doesn’t cause problems, I’d be fine to leave it as it is and close this task. The one problem I know is that the IDE can’t navigate to the class’ unique definition because there are two, but IMHO that’s only a minor annoyance. F42443213: image.png <https://phabricator.wikimedia.org/F42443213> TASK DETAIL https://phabricator.wikimedia.org/T251656 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Reedy, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T253966: sonar cloud + .vue files: 'import' and 'export' may appear only with 'sourceType: module'
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Blocked outside WMDE to Done on the User-Pablo-WMDE board. Lucas_Werkmeister_WMDE added a comment. The linked SonarQube issue <https://community.sonarsource.com/t/sonarqube-scanner-fails-to-analyze-vue-files-failed-to-parse-file-vue/17751/10> was apparently resolved in v8.7 (2021); a recent codehealth run for Wikibase <https://integration.wikimedia.org/ci/job/mwext-codehealth-master-non-voting/43740/consoleFull> shows some other analysis errors (`java.lang.NullPointerException: Cannot invoke "org.sonar.plugins.php.api.cache.PhpReadCache.readBytes(String)" because "" is null` on lots of PHP files), but no errors in Vue files. Let’s assume this is resolved. TASK DETAIL https://phabricator.wikimedia.org/T253966 WORKBOARD https://phabricator.wikimedia.org/project/board/5083/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, wiese, maantietaja, ItamarWMDE, Akuckartz, Michael, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage
Lucas_Werkmeister_WMDE added a project: TestMe. Lucas_Werkmeister_WMDE added a comment. I’m confused, why are we saying this is a bridge test? The pasted output says it was `repo/tests/selenium/specs/readmode.references.js`, which is something in repo unrelated to Bridge (which is in client). Either way – I don’t remember seeing this test fail. Has anyone else experienced this issue recently? TASK DETAIL https://phabricator.wikimedia.org/T264841 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, Lens0021, Nikerabbit, Aklapper, Daimona, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, TerraCodes, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention
Lucas_Werkmeister_WMDE added a comment. This is probably superseded by T359253: Migrate MediaWiki.$prefix.wikibase.client.scribunto.* to statslib <https://phabricator.wikimedia.org/T359253> now? TASK DETAIL https://phabricator.wikimedia.org/T292601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Krinkle, Aklapper, Danny_Benjafield_WMDE, LennardHofmann, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6
Lucas_Werkmeister_WMDE moved this task from Incoming to Ongoing on the wmde-wikidata-tech board. Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Wikidata.org Slice). TASK DETAIL https://phabricator.wikimedia.org/T353076 WORKBOARD https://phabricator.wikimedia.org/project/board/5864/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, simon04, SD0001, Jdlrobson, Novem_Linguae, Soda, Chlod, DannyS712, Aklapper, Jdforrester-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Hey_man_im_josh, Jersione, HuanNguyen, Hellket777, MPGuy2824, LisafBia6531, IAmChaos, Astuthiodit_1, STH, G1964j, 786, Zekwn, Sgs, Biggs657, karapayneWMDE, the0001, Invadibot, Zabe, Selby, AndreCstr, maantietaja, XeroS_SkalibuR, GhostInTheMachine, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, 94rain, CucyNoiD, Nandana, Mirahamira, Gaboe420, Jony, lucamauri, Giuliamocci, Force_Radical, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Flycatchr, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Izno, SBisson, Samwalton9-WMF, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T206973: Supporting Solar Hijri calendar model in Wikidata
Lucas_Werkmeister_WMDE added a project: MediaWiki-extensions-WikibaseRepository. Lucas_Werkmeister_WMDE moved this task from Incoming to Radar on the wmde-wikidata-tech board. TASK DETAIL https://phabricator.wikimedia.org/T206973 WORKBOARD https://phabricator.wikimedia.org/project/board/5864/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Huji, alaa, Helmoony, RolandUnger, Lucas_Werkmeister_WMDE, Yair_rand, Yamaha5, Mehdi, 4nn1l2, Aklapper, Doostdar, Danny_Benjafield_WMDE, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359071: Deploy new Termbox version in production
Lucas_Werkmeister_WMDE added a comment. **Prio Notes:** | Impact Area | Affected | | --- | | | production / end users | ✘| | monitoring | ✘| | development efforts | ✔| | onboarding efforts | ✘| | additional stakeholders | ✔ (PrPl) | | We’re prioritizing it fairly highly as it’s almost a chore-like task. TASK DETAIL https://phabricator.wikimedia.org/T359071 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359403: Wikibase apitests broken in CI: Invalid status: expected 500 to be within 200..299
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T359403 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, apaskulin, Nandana, Lahi, Gq86, Xinbenlv, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357499: [DOT] Perform necessary redirect after editing terms with wikidata-bridge
Lucas_Werkmeister_WMDE added a comment. Not much, I think; but T351968#9602082 <https://phabricator.wikimedia.org/T351968#9602082> might be relevant depending on how soon you’re planning to fix T354750 <https://phabricator.wikimedia.org/T354750>. TASK DETAIL https://phabricator.wikimedia.org/T357499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T351968: Update Wikidata-related extensions for IP Masking
Lucas_Werkmeister_WMDE added a comment. Most of the subtasks here are done, but I think there’s still a big open question about the rollout. In T343800 <https://phabricator.wikimedia.org/T343800>, we found that temporary accounts, once created on a wiki with IP Masking enabled, were also “logged in” and available on other wikis via CentralAuth, which worked well for us. But this has changed in the meantime (T342475 <https://phabricator.wikimedia.org/T342475>) – now, you’ll still be an IP on wikis that don’t have temporary accounts enabled. So what happens with cross-wiki edits now? - If IP Masking is enabled on Wikidata but not on a client wiki: Suppose an anonymous user makes an edit on Wikidata, with a temporary account. The edit affects a page on a client wiki, so it gets dispatched there, and added to the `recentchanges` table (type `RC_EXTERNAL`). Which actor do we assign this row to? - It can’t be the temporary account, because they’re not supposed to exist on the client wiki. - It can’t be the user’s IP address, because we don’t know it anymore (and shouldn’t leak it in any case). - I guess we could reassign all such edits to a system user or something? (But that still leaves the problem that it looks like a registered edit to the client wiki when it really isn’t, which IIUC was the main argument against just letting temporary accounts be shared via CentralAuth like they used to.) - Or some kind of special IP address(es), somewhere in a private network block? - If IP Masking is enabled on a client wiki but not on Wikidata: Suppose a user acquires a temporary account on a client wiki (e.g. with a normal edit), then edits Wikidata from the client wiki. What should happen? - I //think// there’s no actual scenario where this happens. The LinkItem widget is not available to unregistered users, including temporary accounts (see T351971 <https://phabricator.wikimedia.org/T351971>); the data bridge is currently broken (T354750 <https://phabricator.wikimedia.org/T354750>); some wikis have gadgets to edit Wikidata (e.g. WE-Framework <https://www.wikidata.org/wiki/Q22946134>), but temporary users won’t be able to enable them. - Even if there’s a way for anonymous users to edit Wikidata from a client wiki that I missed – it’s probably okay(ish) if the outcome is just “it doesn’t work”. Comparing these two alternatives, I wonder if we should just enable IP Masking on Wikidata last of all wikis, so that the first set of problems never applies… TASK DETAIL https://phabricator.wikimedia.org/T351968 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359191: Chore: Update dependencies in Wikidata-related extensions
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Wikidata Dev Team, Wikibase-Quality-Constraints, Wikidata.org, MediaWiki-extensions-WikimediaBadges, MediaWiki-extensions-PropertySuggester. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Update dependencies in the following extensions: [ ] WikibaseQualityConstraints [ ] Wikidata.org [ ] WikimediaBadges [ ] PropertySuggester There are no specific guidelines for these repositories, but you can compare the ones for WikibaseLexeme <https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseLexeme/+/master/README-dev.md#chore_dependency-updates>, EntitySchema <https://gerrit.wikimedia.org/g/mediawiki/extensions/EntitySchema#chore_updating-dependencies>, or new-lexeme-special-page <https://github.com/wmde/new-lexeme-special-page#chore-dependency-updates>. There are currently no known dependencies that should not be updated. If there are any issues, create a subtask. After all changes have been merged, this task can skip the Tech Verification column and be closed directly. This chore may also become obsolete once LibraryUpgrader (LibUp) works again. TASK DETAIL https://phabricator.wikimedia.org/T359191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359189: Chore: Update dependencies in new-lexeme-special-page.git
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Special:NewLexeme revival, Wikidata Lexicographical data, Wikidata Dev Team. TASK DESCRIPTION Update dependencies in **new-lexeme-special-page <https://github.com/wmde/new-lexeme-special-page>**. In the README you can find guidelines on how to update the dependencies <https://github.com/wmde/new-lexeme-special-page#chore-dependency-updates>. If there are any issues, create a subtask. If there are open dependabot PRs <https://github.com/wmde/new-lexeme-special-page/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+author%3Aapp%2Fdependabot> then either merge them, or close them, or create a task if they need more work and comment the Phabricator Task-ID there. After all changes have been merged, this task can skip the Tech Verification column and be closed directly. TASK DETAIL https://phabricator.wikimedia.org/T359189 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359190: Chore: Update dependencies in WikibaseLexeme
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Wikidata Lexicographical data, Wikidata Dev Team. TASK DESCRIPTION Update dependencies in the **WikibaseLexeme <https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseLexeme>** extension. In the developer README you can find guidelines on how to update the dependencies <https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseLexeme/+/master/README-dev.md#chore_dependency-updates>. If there are any issues, create a subtask. After all changes have been merged, this task can skip the Tech Verification column and be closed directly. TASK DETAIL https://phabricator.wikimedia.org/T359190 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359188: Chore: Update dependencies in EntitySchema
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, EntitySchema, Wikidata Dev Team. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Update dependencies in the **EntitySchema <https://gerrit.wikimedia.org/g/mediawiki/extensions/EntitySchema>** extension. In the README you can find guidelines on how to update the dependencies <https://gerrit.wikimedia.org/g/mediawiki/extensions/EntitySchema#chore_updating-dependencies>. If there are any issues, create a subtask. After all changes have been merged, this task can skip the Tech Verification column and be closed directly. TASK DETAIL https://phabricator.wikimedia.org/T359188 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Michael, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, KimKelting, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json
Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to "High". Lucas_Werkmeister_WMDE added a comment. Alright, tentatively lowering to High and removing parent task then. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel, Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Xinbenlv, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json
Lucas_Werkmeister_WMDE removed a parent task: T354439: 1.42.0-wmf.21 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel, Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Xinbenlv, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T135871: MUL - Language fallback not applied to item/property heading after editing terms
Lucas_Werkmeister_WMDE added a comment. In T135871#9116701 <https://phabricator.wikimedia.org/T135871#9116701>, @Manuel wrote: >> I don't think the page title should be updated while editing > > Thank you, @Nikki! I think this is a convincing argument, and it might even make the development easier. It doesn’t (automatic updating of the title is what currently happens), but I agree that the page title shouldn’t be updated while editing, it’s quite distracting. F42398530: Screencast from 2024-03-05 15-58-06.webm <https://phabricator.wikimedia.org/F42398530> But apart from that, I have something that seems to work well for this change (see above video :)), I’ll upload it soon. TASK DETAIL https://phabricator.wikimedia.org/T135871 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Sarai-WMDE, Lucas_Werkmeister_WMDE, Manuel, Jan_Dittrich, Lydia_Pintscher, daniel, Glorian_Yapinus, Nikki, Aklapper, Zppix, adrianheine, Danny_Benjafield_WMDE, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, Nandana, lucamauri, Mh-3110, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T135871: MUL - Language fallback not applied to item/property heading after editing terms
Lucas_Werkmeister_WMDE added a comment. I’m assuming we should also add fallback indicators in JS, under the same conditions as in PHP (i.e. not for variants of the same base language, and also not for mul). F42398419: Screenshot from 2024-03-05 14-56-22.png <https://phabricator.wikimedia.org/F42398419> F42398420: Screenshot from 2024-03-05 14-56-24.png <https://phabricator.wikimedia.org/F42398420> (The required language names are already available, see `wb.getLanguageNameByCodeForTerms()`.) Also, I just remembered that language fallback in PHP includes automatic transliteration; I don’t think we can do that in JS, so that part will just be missing. TASK DETAIL https://phabricator.wikimedia.org/T135871 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Sarai-WMDE, Lucas_Werkmeister_WMDE, Manuel, Jan_Dittrich, Lydia_Pintscher, daniel, Glorian_Yapinus, Nikki, Aklapper, Zppix, adrianheine, Danny_Benjafield_WMDE, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, Nandana, lucamauri, Mh-3110, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T355877: [CLIENT] Investigate potential references to wrong ParserOutput in WikibaseClient code
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE reassigned this task from Lucas_Werkmeister_WMDE to ArthurTaylor. Lucas_Werkmeister_WMDE moved this task from In Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board. TASK DETAIL https://phabricator.wikimedia.org/T355877 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: Aklapper, Michael, ItamarWMDE, hoo, ArthurTaylor, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T255706: [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock
Lucas_Werkmeister_WMDE closed subtask T355877: [CLIENT] Investigate potential references to wrong ParserOutput in WikibaseClient code as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, hoo, Lucas_Werkmeister_WMDE, ItamarWMDE, Ladsgroup, Krinkle, eprodromou, aaron, Michael, Aklapper, thcipriani, Ullasoff, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T355877: [CLIENT] Investigate potential references to wrong ParserOutput in WikibaseClient code
Lucas_Werkmeister_WMDE added a comment. I think we can just close this task and check back on T255706 <https://phabricator.wikimedia.org/T255706> in two weeks or so; @ArthurTaylor do you agree? TASK DETAIL https://phabricator.wikimedia.org/T355877 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Michael, ItamarWMDE, hoo, ArthurTaylor, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T135871: MUL - Language fallback not applied to item/property heading after editing terms
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board. TASK DETAIL https://phabricator.wikimedia.org/T135871 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Sarai-WMDE, Lucas_Werkmeister_WMDE, Manuel, Jan_Dittrich, Lydia_Pintscher, daniel, Glorian_Yapinus, Nikki, Aklapper, Zppix, adrianheine, Danny_Benjafield_WMDE, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, Nandana, lucamauri, Mh-3110, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T135871: MUL - Language fallback not applied to item/property heading after editing terms
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T135871 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Sarai-WMDE, Lucas_Werkmeister_WMDE, Manuel, Jan_Dittrich, Lydia_Pintscher, daniel, Glorian_Yapinus, Nikki, Aklapper, Zppix, adrianheine, Danny_Benjafield_WMDE, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, Nandana, lucamauri, Mh-3110, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. Seems to be working: https://github.com/wikimedia/mediawiki-extensions-Wikibase/actions/runs/8155752858 TASK DETAIL https://phabricator.wikimedia.org/T353961 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T351968: Update Wikidata-related extensions for IP Masking
Lucas_Werkmeister_WMDE closed subtask T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T351968 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json
Lucas_Werkmeister_WMDE added a comment.
This hack makes the `PATCH
/entities/items/{item_id}/statements/{statement_id}` test work again:
diff --git
a/repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php
b/repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php
index 76cfe52a94..615717b413 100644
--- a/repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php
+++ b/repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php
@@ -4,6 +4,7 @@
use MediaWiki\MediaWikiServices;
use MediaWiki\Rest\Handler;
+use MediaWiki\Rest\LocalizedHttpException;
use MediaWiki\Rest\RequestInterface;
use MediaWiki\Rest\Response;
use MediaWiki\Rest\ResponseInterface;
@@ -22,6 +23,7 @@
use Wikibase\Repo\RestApi\RouteHandlers\Middleware\MiddlewareHandler;
use
Wikibase\Repo\RestApi\RouteHandlers\Middleware\UserAgentCheckMiddleware;
use Wikibase\Repo\RestApi\WbRestApi;
+use Wikimedia\Message\MessageValue;
use Wikimedia\ParamValidator\ParamValidator;
/**
@@ -137,6 +139,23 @@ public function getParamSettings(): array {
];
}
+ public function parseBodyData( RequestInterface $request ): ?array {
+ if ( $request->getBodyType() ===
ContentTypeCheckMiddleware::TYPE_JSON_PATCH ) {
+ // copy+paste from the standard JSON case in the parent
method
+ $jsonStream = $request->getBody();
+ $parsedBody = json_decode( "$jsonStream", true );
+ if ( !is_array( $parsedBody ) ) {
+ throw new LocalizedHttpException(
+ // Fixme: missing parameter
+ new MessageValue(
'rest-json-body-parse-error', [ "" ] ),
+ 400
+ );
+ }
+ return $parsedBody;
+ }
+ return parent::parseBodyData( $request );
+ }
+
/**
* @inheritDoc
*/
But I’m not sure if it was intended in T358557
<https://phabricator.wikimedia.org/T358557> that all handlers should now have
to override `parseBodyData()` if they want to support content types other than
`application/x-www-form-urlencoded`, `multipart/form-data` and
`application/json`.
Also, this doesn’t seem to be a test problem, it’ll actually break JSON PATCH
requests in production when this rolls out with the train. So this should
probably be a train blocker?
TASK DETAIL
https://phabricator.wikimedia.org/T359149
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE,
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531,
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264,
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Hook696,
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30,
Lahi, Gq86, Af420, Xinbenlv, Bsandipan, GoranSMilovanovic, QZanden, KimKelting,
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS,
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json
Lucas_Werkmeister_WMDE added a comment.
Note: Though the error message looks identical, this doesn’t come from
Wikibase’s `ContentTypeCheckMiddleware`; with a debugger, I could instead see
that it comes from `\MediaWiki\Rest\Handler::parseBodyData()`:
/**
* @throws HttpException on failed check
*/
public function parseBodyData( RequestInterface $request ): ?array {
// Parse the body based on its content type
$contentType = $request->getBodyType();
switch ( $contentType ) {
case 'application/x-www-form-urlencoded':
case 'multipart/form-data':
return $request->getPostParams();
case 'application/json':
$jsonStream = $request->getBody();
$parsedBody = json_decode( "$jsonStream", true
);
if ( !is_array( $parsedBody ) ) {
throw new LocalizedHttpException(
// Fixme: missing parameter
new MessageValue(
'rest-json-body-parse-error', [ "" ] ),
400
);
}
return $parsedBody;
default:
throw new LocalizedHttpException( // <== HERE
new MessageValue(
'rest-unsupported-content-type', [ $contentType ?? '(null)' ] ),
415
);
}
}
TASK DETAIL
https://phabricator.wikimedia.org/T359149
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE,
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531,
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264,
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Hook696,
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30,
Lahi, Gq86, Af420, Xinbenlv, Bsandipan, GoranSMilovanovic, QZanden, KimKelting,
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS,
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, apaskulin, Nandana, Lahi, Gq86, Xinbenlv, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, ci-test-error (WMF-deployed
Build Failure), MediaWiki-REST-API.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Example build
<https://integration.wikimedia.org/ci/job/mediawiki-quibble-apitests-vendor-php74-docker/58907/console>:
1) PATCH statement tests
PATCH /entities/items/{item_id}/statements/{statement_id}
200 success response
allows content-type application/json-patch+json:
AssertionError:
7Response body: {
errorKey: 'rest-unsupported-content-type',
messageTranslations: { en: 'Unsupported Content-Type:
application/json-patch+json' },
httpCode: 415,
httpReason: 'Unsupported Media Type'
}8
Invalid status: expected 415 to equal 200
actual expected
415200
at module.exports.expect.expect
(tests/mocha/helpers/chaiHelper.js:26:27)
at Proxy.chainableMethodWrapper
(node_modules/chai/lib/chai/utils/addChainableMethod.js:113:49)
at assertValid200Response
(tests/mocha/api-testing/PatchItemStatementTest.js:71:32)
at Context.
(tests/mocha/api-testing/PatchItemStatementTest.js:123:6)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
2) PATCH statement tests
PATCH /statements/{statement_id}
200 success response
allows content-type application/json-patch+json:
AssertionError:
7Response body: {
errorKey: 'rest-unsupported-content-type',
messageTranslations: { en: 'Unsupported Content-Type:
application/json-patch+json' },
httpCode: 415,
httpReason: 'Unsupported Media Type'
}8
Invalid status: expected 415 to equal 200
actual expected
415200
at module.exports.expect.expect
(tests/mocha/helpers/chaiHelper.js:26:27)
at Proxy.chainableMethodWrapper
(node_modules/chai/lib/chai/utils/addChainableMethod.js:113:49)
at assertValid200Response
(tests/mocha/api-testing/PatchItemStatementTest.js:71:32)
at Context.
(tests/mocha/api-testing/PatchItemStatementTest.js:123:6)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
3) PATCH property statement
PATCH /statements/{statement_id}
200 success response
allows content-type application/json-patch+json:
AssertionError:
7Response body: {
errorKey: 'rest-unsupported-content-type',
messageTranslations: { en: 'Unsupported Content-Type:
application/json-patch+json' },
httpCode: 415,
httpReason: 'Unsupported Media Type'
}8
Invalid status: expected 415 to equal 200
actual expected
415200
at module.exports.expect.expect
(tests/mocha/helpers/chaiHelper.js:26:27)
at Proxy.chainableMethodWrapper
(node_modules/chai/lib/chai/utils/addChainableMethod.js:113:49)
at assertValid200Response
(tests/mocha/api-testing/PatchPropertyStatementTest.js:68:32)
at Context.
(tests/mocha/api-testing/PatchPropertyStatementTest.js:120:6)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
4) PATCH property statement
PATCH /entities/properties/{property_id}/statements/{statement_id}
200 success response
allows content-type application/json-patch+json:
AssertionError:
7Response body: {
errorKey: 'rest-unsupported-content-type',
messageTranslations: { en: 'Unsupported Content-Type:
application/json-patch+json' },
httpCode: 415,
httpReason: 'Unsupported Media Type'
}8
Invalid status: expected 415 to equal 200
actual expected
415200
at module.exports.expect.expect
(tests/mocha/helpers/chaiHelper.js:26:27)
at Proxy.chainableMethodWrapper
(node_modules/chai/lib/chai/utils/addChainableMethod.js:113:49)
at assertValid200Response
(tests/mocha/api-testing/PatchPropertyStatementTest.js:68:32)
at Context.
(tests/mocha/api-testing/PatchPropertyStatementTest.js:120:6)
at process.processTicksAndRejections
(node:internal/process/task_queues:95:5)
According to @Jakob_WMDE, this broke with the core change Rest router should
provide parsed body data to handler
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1006906>, though it’s not
yet clear why.
TASK DETAIL
https://phabricator.wikimedia.org/T359149
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE,
A
[Wikidata-bugs] [Maniphest] T359071: Deploy new Termbox version in production
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T359071 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T359071: Deploy new Termbox version in production
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Termbox, Wikidata Dev Team, wmde-wikidata-tech. TASK DESCRIPTION In T357269 <https://phabricator.wikimedia.org/T357269>, Termbox was updated from Vue 3.2 to 3.3; we should deploy the new version of the server-side rendering service in production. TASK DETAIL https://phabricator.wikimedia.org/T359071 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T355877: [CLIENT] Investigate potential references to wrong ParserOutput in WikibaseClient code
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. TASK DETAIL https://phabricator.wikimedia.org/T355877 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Michael, ItamarWMDE, hoo, ArthurTaylor, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE added a comment. In T353961#9595926 <https://phabricator.wikimedia.org/T353961#9595926>, @kostajh wrote: > Thanks. I added T359043 <https://phabricator.wikimedia.org/T359043> as a parent task, assuming that this task is also about fixing the CI errors when AutoCreateTempUser is enabled. The three errors I see (log <https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php74-docker/39519/consoleFull>): Those are the same three I saw, yes. In T353961#9595936 <https://phabricator.wikimedia.org/T353961#9595936>, @Daimona wrote: > Ideally, I think addDBDataOnce should be treated as a "seeding" method. You use it to define the initial state of the database for the test class, **and the database is brought back to that state after every test.** (Emphasis added.) Heh, I was about to write something similar ^^ but unfortunately, I assume some tests rely on having outer transaction scope, so we probably can’t implement this with a transaction in `MediaWikiIntegrationTestCase`. It would probably be possible by copying the affected tables around, but that might be prohibitively slow :( TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE added a comment. > The tests mostly work in secondary CI, and I think I managed to fix all of them Update: With this commit <https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/06ce15d63ccc205a3fa64034b86a6c863ec60440> (incorporating the fixes in Wikibase and the above patch to MediaWiki core), all the secondary CI runs are indeed green <https://github.com/wikimedia/mediawiki-extensions-Wikibase/actions/runs/8139893743> \o/ which would also be useful for T359043 <https://phabricator.wikimedia.org/T359043>, I assume. TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE added a comment. In T353961#9595560 <https://phabricator.wikimedia.org/T353961#9595560>, @Lucas_Werkmeister_WMDE wrote: > but I can’t really think of a better solution. To elaborate a bit: we could probably work around this in Wikibase (the easiest would be to move `createItems()` and `addBadgeMatcher()` from `addDBDataOnce()` to `setUp()`; we could also try to make `createItems()` use a temp user if temp users are enabled, to make sure that the `user_autocreate_serial` is also registered as used in `$dbDataOnceTables`, but that’d be a bit more annoying to implement), but IMHO that would just leave the door open for another test to run into the same problem. I’d prefer to fix it in core instead, for all tests with similar patterns. TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE added a subscriber: Daimona.
Lucas_Werkmeister_WMDE added a comment.
The tests mostly work in secondary CI, and I think I managed to fix all of
them, but one of the fixes is in core. `SpecialSetSiteLinkTest` has two tests
that end up creating temporary users, and it also has a `addDBDataOnce()`
method that makes some test edits, which involves creating (non-temporary) test
users. This means that the `user` table ends up in `$dbDataOnceTables`, and is
not cleared between tests, whereas `user_autocreate_serial` is cleared between
tests; as a result, the second test tries to create a temporary user with the
same name as the first test, and fails because the user already exists in the
non-cleared `user` table. Suggested fix:
diff --git a/tests/phpunit/MediaWikiIntegrationTestCase.php
b/tests/phpunit/MediaWikiIntegrationTestCase.php
index 4448f3ebc8..71b15fca92 100644
--- a/tests/phpunit/MediaWikiIntegrationTestCase.php
+++ b/tests/phpunit/MediaWikiIntegrationTestCase.php
@@ -689,6 +689,15 @@ private function maybeSetupDB(): void {
$this->addDBDataOnce();
static::$dbDataOnceTables =
ChangedTablesTracker::getTables( $this->db->getDomainID() );
ChangedTablesTracker::stopTracking();
+ if (
+ in_array( 'user', static::$dbDataOnceTables,
true )
+ && !in_array( 'user_autocreate_serial',
static::$dbDataOnceTables, true )
+ ) {
+ // if the user table will not be cleared
between tests,
+ // also preserve the temp user counter between
tests,
+ // otherwise later tests will try to recreate
temp users that already exist and fail
+ static::$dbDataOnceTables[] =
'user_autocreate_serial';
+ }
}
ChangedTablesTracker::startTracking();
Which is a bit of a shame, because @Daimona removed a bunch of inter-table
dependencies like this when introducing ChangedTablesTracker
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/946538> (it used to be
something like “if `slot_roles` is cleared then also clear `ip_changes`”,
yuck), and now we’d be reintroducing something similar again and go behind
`ChangedTablesTracker`’s back, so to speak :/ but I can’t really think of a
better solution. Any thoughts?
TASK DETAIL
https://phabricator.wikimedia.org/T353961
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael,
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS,
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team. Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. In T353961#9532074 <https://phabricator.wikimedia.org/T353961#9532074>, @kostajh wrote: > T355879: Create jobs that run PHPUnit, Selenium, and API testing tests with temp account feature flag enabled <https://phabricator.wikimedia.org/T355879> is also relevant, and would handle running CI tests for Wikibase with temp accounts enabled in WMF infrastructure. Yeah, that sounds like a good thing to have for browser and API tests (which we currently don’t run in secondary CI, as mentioned in the task description). But apart from that, I think it’s still a good idea to test IP masking in secondary CI too; we already have five secondary CI jobs, so I think we can just change some of them to enable IP masking (rather than add more jobs). I’ll try out whether the tests even work or not. TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357152: [DOT] Perform necessary redirect after creating new lexeme with Special:NewLexeme
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. (I think this is more Product than Tech Verification.) TASK DETAIL https://phabricator.wikimedia.org/T357152 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE moved this task from Parent Task to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. I //think// everything here is done and ready for product verification on Beta \o/ TASK DETAIL https://phabricator.wikimedia.org/T357020 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357151: [DOT] Perform necessary redirect after editing terms in termbox v2 / mobile termbox
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from In Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE reassigned this task from Lucas_Werkmeister_WMDE to ArthurTaylor. Lucas_Werkmeister_WMDE added a comment. I think we can close this directly and do the verification in the parent task. TASK DETAIL https://phabricator.wikimedia.org/T357151 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T357020 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE closed subtask T357151: [DOT] Perform necessary redirect after editing terms in termbox v2 / mobile termbox as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T357020 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357799: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in WikibaseLexeme editing APIs
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. I think we can close this directly, it’ll effectively be verified via T358323 <https://phabricator.wikimedia.org/T358323>. TASK DETAIL https://phabricator.wikimedia.org/T357799 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE closed subtask T357799: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in WikibaseLexeme editing APIs as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T357020 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357499: [DOT] Perform necessary redirect after editing terms with wikidata-bridge
Lucas_Werkmeister_WMDE added a comment. Once CI goes through, this should be testable on Beta on Data bridge <https://en.wikipedia.beta.wmflabs.org/wiki/Data_bridge>. (But not on Wikidata Bridge Showcase <https://en.wikipedia.beta.wmflabs.org/wiki/Wikidata_Bridge_Showcase>, due to T354750 <https://phabricator.wikimedia.org/T354750>.) TASK DETAIL https://phabricator.wikimedia.org/T357499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, Michael, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357799: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in WikibaseLexeme editing APIs
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T357799 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357149: [DOT] Perform necessary redirect after editing terms in legacy termbox
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor. Lucas_Werkmeister_WMDE added a comment. I think this is done and can be verified as part of the parent task. TASK DETAIL https://phabricator.wikimedia.org/T357149 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE closed subtask T357149: [DOT] Perform necessary redirect after editing terms in legacy termbox as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T357020 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357120: [DOT] Make Wikibase View editing interface redirect user for CentralAuth after edit creates temporary account
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE reassigned this task from Lucas_Werkmeister_WMDE to ArthurTaylor. Lucas_Werkmeister_WMDE added a comment. I think this is done and we can leave the verification to the parent task. TASK DETAIL https://phabricator.wikimedia.org/T357120 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE closed subtask T357120: [DOT] Make Wikibase View editing interface redirect user for CentralAuth after edit creates temporary account as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T357020 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357404: [DOT] Termbox v2 / mobile termbox anonymous edit warning for temp users
Lucas_Werkmeister_WMDE added a project: Wikidata-Termbox. TASK DETAIL https://phabricator.wikimedia.org/T357404 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358754: Special:NewLexeme no longer redirects to created lexeme (unless a temporary account was created)
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. I’ll try to add a test next, but I think this is ready for review already: https://github.com/wmde/new-lexeme-special-page/pull/641 TASK DETAIL https://phabricator.wikimedia.org/T358754 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358754: Special:NewLexeme no longer redirects to created lexeme (unless a temporary account was created)
Lucas_Werkmeister_WMDE added a comment. Ahaa, the problem is that `mw.util.getUrl()` returns a relative URL like `/wiki/Special:EntityPage/L123`, and passing that into `new URL()` is illegal unless you also pass in a base (e.g. `new URL( relativeUrl, window.location )`). TASK DETAIL https://phabricator.wikimedia.org/T358754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358754: Special:NewLexeme no longer redirects to created lexeme (unless a temporary account was created)
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team (Quality Tools "Sprint"). TASK DETAIL https://phabricator.wikimedia.org/T358754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358754: Special:NewLexeme no longer redirects to created lexeme (unless a temporary account was created)
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Lexicographical data, Wikidata Dev Team (Quality Tools "Sprint"). TASK DESCRIPTION Apparently, since this week’s train rollout, Special:NewLexeme no longer redirects you to the lexeme that it created – unless a temporary account was created. So we probably broke something accidentally as part of work on T357152 <https://phabricator.wikimedia.org/T357152> and related tasks. TASK DETAIL https://phabricator.wikimedia.org/T358754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357799: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in WikibaseLexeme editing APIs
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Ready for Development to In Development on the Wikidata Dev Team (Wikidata.org Slice) board. TASK DETAIL https://phabricator.wikimedia.org/T357799 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357120: [DOT] Make Wikibase View editing interface redirect user for CentralAuth after edit creates temporary account
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. TASK DETAIL https://phabricator.wikimedia.org/T357120 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358644: Invalid qualifier snak in Form preventing correct JSON serialization and editing
Lucas_Werkmeister_WMDE added a comment. By the way, my guess would be that it’s still possible to edit the lexeme via the API (e.g. remove that qualifier, or even the whole statement, via the API sandbox), but I’m not sure if I should try it out myself. TASK DETAIL https://phabricator.wikimedia.org/T358644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Infovarius, Lucas_Werkmeister_WMDE, Pintoch, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358644: Invalid qualifier snak in Form preventing correct JSON serialization and editing
Lucas_Werkmeister_WMDE added a subscriber: Infovarius. Lucas_Werkmeister_WMDE added a comment. Previously reported at https://www.wikidata.org/wiki/Wikidata_talk:Lexicographical_data#Broken_lexeme (though without much detail). @Infovarius: It would be good to know what data you sent to the API to create this lexeme. TASK DETAIL https://phabricator.wikimedia.org/T358644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Infovarius, Lucas_Werkmeister_WMDE, Pintoch, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358644: Invalid qualifier snak in Form preventing correct JSON serialization and editing
Lucas_Werkmeister_WMDE added a comment.
> In the JSON serialization of the entity
(https://www.wikidata.org/w/api.php?action=wbgetentities=L1259271), I see
the serialization of the qualifier as:
Apparently that’s how it was saved internally too? o_O
$ curl -s
'https://www.wikidata.org/w/api.php?action=query=2081476901=revisions=content=main=json=2'
| jq '.query.pages[0].revisions[0].slots.main.content | fromjson |
.forms[0].claims.P7243[0].qualifiers.P898[0]'
{
"snaktype": "value",
"property": "P898",
"hash": "e49ad5fcdc05da78bac23b8373d04a80fecf16aa",
"datavalue": {
"value": null,
"type": "string",
"error": "Can only construct StringValue from strings"
}
}
lucaswerkmeister-wmde@mwdebug2002:~$ mwscript getText wikidatawiki
Lexeme:L1259271 | jq '.forms[0].claims.P7243[0].qualifiers.P898[0]'
{
"snaktype": "value",
"property": "P898",
"hash": "e49ad5fcdc05da78bac23b8373d04a80fecf16aa",
"datavalue": {
"value": null,
"type": "string",
"error": "Can only construct StringValue from strings"
}
}
TASK DETAIL
https://phabricator.wikimedia.org/T358644
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Pintoch, Danny_Benjafield_WMDE, Astuthiodit_1,
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi,
Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321646: [LEX] [SW] [TECH] Test failure Wikibase\Lexeme\Tests\MediaWiki\Specials\SpecialMergeLexemesTest::testGivenMergeSucceeds_showsSuccessMessage
Lucas_Werkmeister_WMDE added a comment. In T321646#8346099 <https://phabricator.wikimedia.org/T321646#8346099>, @Lucas_Werkmeister_WMDE wrote: > We’ve seen this particular error (`mw-replace` absent – not sure if it was always the same test case) on a few other builds as well, including in our secondary CI (GitHub actions – example 1 <https://github.com/wikimedia/Wikibase/actions/runs/3320572304/jobs/5487111758>, 2 <https://github.com/wikimedia/Wikibase/actions/runs/3320572304/jobs/5487111449>). It seems to be random; so far, I don’t think we’ve looked into it (but we probably should, so thanks for filing this task ^^). I don’t remember seeing this error recently anymore. Is anyone else still experiencing this? If not, we should just close this task. TASK DETAIL https://phabricator.wikimedia.org/T321646 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ItamarWMDE, Michael, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T297381: [TECH] [SW] Wikibase CI broken: test:mwlibs can’t find MediaWiki core Vue version
Lucas_Werkmeister_WMDE added a comment. > This is an old task and I don't know much about the context here. Is this problem still happening? In a very broad sense, the problem is that we built a system to validate that we’re using the same Vue.js version as MediaWiki core, and that system broke with the move to Vue 3; we’re going to reevaluate (once this task makes it through our backlog) whether we still need that system at all or can just remove it. > The file you want is either `resources/lib/vue/vue.global.js` (for dev mode tooling) or `resources/lib/vue/vue.global.prod.js` (minified production build of the library). Yes, but neither file returns an object with a `.version` member, so this isn’t as simple as updating the path. We’d have to make @wmde/lib-version-check <https://www.npmjs.com/package/@wmde/lib-version-check> check the version on the `Vue` global instead, and the question is whether this is worth the extra complexity or not. TASK DETAIL https://phabricator.wikimedia.org/T297381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: egardner, ItamarWMDE, karapayneWMDE, Michael, Catrope, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357152: [DOT] Perform necessary redirect after creating new lexeme with Special:NewLexeme
Lucas_Werkmeister_WMDE moved this task from Product Verification to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. Sorry, I just realized the no-JS version of the special page can also create lexemes and should also do the redirect. TASK DETAIL https://phabricator.wikimedia.org/T357152 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T356149: Adjust Item and Property Special Pages to not leak IPs when editing and IP masking is enabled
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE removed ArthurTaylor as the assignee of this task. Lucas_Werkmeister_WMDE added a subscriber: ArthurTaylor. Lucas_Werkmeister_WMDE added a comment. Okay, I think this should be done and ready for verification… TASK DETAIL https://phabricator.wikimedia.org/T356149 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Lucas_Werkmeister_WMDE, Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358447: Issues pop-up partially hidden by other elements
Lucas_Werkmeister_WMDE added a comment. Hm, we’ve had issues with this before: T285694 <https://phabricator.wikimedia.org/T285694> TASK DETAIL https://phabricator.wikimedia.org/T358447 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348526: [COG] [TECH] Migrate Cognate to use a virtual database domain
Lucas_Werkmeister_WMDE added a comment. That’s too terse for me to understand, sorry – can you clarify what’s still missing? (Move CognateUpdater logic into CognateSchemaHooks <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cognate/+/1005063> was merged, but I also thought that was just an optional refactoring.) TASK DETAIL https://phabricator.wikimedia.org/T348526 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Lucas_Werkmeister_WMDE Cc: Ladsgroup, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Thibaut120094, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358325: Unsuppress Phan issues MediaWikiNoBaseException and MediaWikiNoEmptyIfDefined in Wikibase
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Technical-Debt. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION In build: Updating mediawiki/mediawiki-phan-config to 0.14.0 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1004777>, two Phan issue types were temporarily suppressed. We should actually fix our code according to the coding conventions (linked below) and remove these suppressions. [ ] `MediaWikiNoBaseException`: Don’t throw `\Exception`; see exception handling <https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Exception_handling>. [ ] `MediaWikiNoEmptyIfDefined`: Don’t use `empty()` on variables that are always set; see empty() <https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#empty()>. TASK DETAIL https://phabricator.wikimedia.org/T358325 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Lucas_Werkmeister_WMDE added a subtask: T358323: [DOT] Perform necessary redirect after editing lexeme data in view interface. TASK DETAIL https://phabricator.wikimedia.org/T357020 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358323: [DOT] Perform necessary redirect after editing lexeme data in view interface
Lucas_Werkmeister_WMDE added a parent task: T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions. TASK DETAIL https://phabricator.wikimedia.org/T358323 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358323: [DOT] Perform necessary redirect after editing lexeme data in view interface
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Wikidata Dev Team (Wikidata.org Slice), Wikidata Lexicographical data, Temporary accounts. TASK DESCRIPTION Once T357799 <https://phabricator.wikimedia.org/T357799> is done, the WikibaseLexeme APIs may return a `tempuserredirect` URL if a temporary user was created by an edit, the UI should follow that redirect. Also, when making the initial edit request, the UI should set at least the `returnto=` parameter (to the title of the current page), so that the user returns to that lexeme after the redirect is done. TASK DETAIL https://phabricator.wikimedia.org/T358323 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358310: Convert property form decomposition (P12493) from Item to lexeme
Lucas_Werkmeister_WMDE added a comment.
In T358310#9571351 <https://phabricator.wikimedia.org/T358310#9571351>, @Jony
wrote:
> @Bugreporter it’s possible, please see T220602
<https://phabricator.wikimedia.org/T220602>
That was a change between external identifier and string, which is the only
supported conversion according to Help:Data type § Changing datatype
<https://www.wikidata.org/wiki/Help:Data_type#Changing_datatype>. (Strictly
speaking, that page only says that changing //from// string //to// external
identifier is possible, while that task changed it the other way around;
changing from external identifier to string is just less common.) Other data
type changes behave differently, generally somewhere between “not useful” and
“completely broken”.
Changing between Item and Lexeme is on the “not useful” end of the spectrum,
in my opinion. You can technically do it and the software won’t completely blow
up (at least as far as I can tell – I haven’t tested all corner cases), but
there’s just no sensible interpretation of any existing statements that were
created with the old data type. I tried this out locally, and in the UI, it
gets shown as “Invalid value”:
F42060791: Screen Shot 2024-02-23 at 11.14.05.png
<https://phabricator.wikimedia.org/F42060791>
In the JSON, you get a very confusing combination of `datatype` and
`datavalue.value.entity-type`:
{
"datatype": "wikibase-lexeme",
"datavalue": {
"value": {
"entity-type": "item",
"numeric-id": 50,
"id": "Q50"
},
"type": "wikibase-entityid"
}
}
In RDF, you get values of both types, which would probably confuse some
external data reusers:
wd:P603 a wikibase:Property ;
wdt:P603 wd:Q50,
wd:L3 ;
I wouldn’t want to unleash mixed-value statements like that on Wikidata, so
IMHO the only safe situation where you could change a data type between Item
and Lexeme would be a property that isn’t used in //any// statements yet – not
even on itself – and in that case you might as well just delete and recreate
the property. So I completely agree with @matej_suchanek: let’s just recreate
the property.
TASK DETAIL
https://phabricator.wikimedia.org/T358310
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, matej_suchanek, Bugreporter, Aklapper, hoo, Jony,
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude,
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357404: [DOT] Termbox v2 / mobile termbox anonymous edit warning for temp users
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T357404 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348526: [COG] [TECH] Migrate Cognate to use a virtual database domain
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Waiting for Deployment Window to Done on the Wikidata Dev Team (Wikidata.org Slice) board. TASK DETAIL https://phabricator.wikimedia.org/T348526 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Lucas_Werkmeister_WMDE Cc: Ladsgroup, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Thibaut120094, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done
on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor.
Lucas_Werkmeister_WMDE added a comment.
The non-lexeme dump also looks good:
$ curl -sL
https://dumps.wikimedia.org/wikidatawiki/entities/latest-all.json.gz | gunzip |
grep -E --color=yes '"claims":[[{][]}]' | head -25
{"type":"item","id":"Q23678","labels":{"gl":{"language":"gl","value":"B-2C"},"en":{"language":"en","value":"B-2C"},"es":{"language":"es","value":"B-2C"},"de":{"language":"de","value":"B-2C"}},"descriptions":{"gl":{"language":"gl","value":"Motor
foguete desenvolvido polos Estados
Unidos."},"en":{"language":"en","value":"rocket
engine"},"es":{"language":"es","value":"nave
espacial"},"de":{"language":"de","value":"Raketentriebwerk"}},"aliases":{},"claims":{},"sitelinks":{"glwiki":{"site":"glwiki","title":"B-2C","badges":[]}},"pageid":27069,"ns":0,"title":"Q23678","lastrevid":73962379,"modified":"2013-10-01T16:58:46Z"},
{"type":"item","id":"Q56405","labels":{"zh":{"language":"zh","value":"\u683c\u66fc\u8bed"},"br":{"language":"br","value":"Midjoueg"},"gv":{"language":"gv","value":"Miju-Mishmish"}},"descriptions":{},"aliases":{"gv":[{"language":"gv","value":"Deng
Geman"},{"language":"gv","value":"Deng
Kaman"}]},"claims":{},"sitelinks":{"brwiki":{"site":"brwiki","title":"Midjoueg","badges":[]}},"pageid":59180,"ns":0,"title":"Q56405","lastrevid":16956037,"modified":"2013-03-30T11:03:14Z"},
{"type":"item","id":"Q282911","labels":{"hu":{"language":"hu","value":"Az
alkohol hat\u00e1sai"},"ro":{"language":"ro","value":"Efectele etanolului
asupra
organismului"}},"descriptions":{},"aliases":{},"claims":{},"sitelinks":{"rowiki":{"site":"rowiki","title":"Efectele
etanolului asupra
organismului","badges":[]},"huwiki":{"site":"huwiki","title":"Az alkohol
hat\u00e1sa az emberi
szervezetre","badges":[]}},"pageid":273471,"ns":0,"title":"Q282911","lastrevid":1396249191,"modified":"2021-04-05T09:52:56Z"},
There are some `"claims":{}` in there and no `"claims":[]`.
I think this is done \o/
TASK DETAIL
https://phabricator.wikimedia.org/T305660
WORKBOARD
https://phabricator.wikimedia.org/project/board/6751/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ArthurTaylor, Lucas_Werkmeister_WMDE
Cc: ArthurTaylor, Lydia_Pintscher, Milimetric, ArielGlenn, BTullis, xcollazo,
JEbe-WMF, Mohammed_Sadat_WMDE, Masssly, Michael, Arian_Bozorg,
Lucas_Werkmeister_WMDE, Ivan_A_Krestinin, Danny_Benjafield_WMDE, Stevemunene,
Busfault, Astuthiodit_1, Atieno, karapayneWMDE, Invadibot, maantietaja,
jannee_e, ItamarWMDE, Akuckartz, holger.knust, Nandana, Lahi, Gq86,
GoranSMilovanovic, Lunewa, Mahir256, QZanden, KimKelting, LawExplorer, _jensen,
rosalieper, Scott_WUaS, gnosygnu, Wikidata-bugs, aude, Mbch331, Hokwelum
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357024: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in Wikibase editing APIs
Lucas_Werkmeister_WMDE added a comment. This is done for most API modules; `wbcreateredirect` and `wbmergeitems` are being done as part of this Gerrit change <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1003799> for T356149 <https://phabricator.wikimedia.org/T356149>. TASK DETAIL https://phabricator.wikimedia.org/T357024 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Celenduin, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357157: [CHORE] Add strict-types to modified PHP files
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor. TASK DETAIL https://phabricator.wikimedia.org/T357157 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T58664: [Story] Clean up the code that formats Wikibase entries in recent changes
Lucas_Werkmeister_WMDE closed this task as "Invalid". Lucas_Werkmeister_WMDE added a comment. Closing, as it’s not clear what is left to be done here. It’s possible that the code can still be cleaned up and improved, but if so, we should track it under a new task with more details. TASK DETAIL https://phabricator.wikimedia.org/T58664 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, ArthurTaylor, Mattflaschen-WMF, Ricordisamoa, Aklapper, Liuxinyu970226, Wikidata-bugs, Tobi_WMDE_SW, aude, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T90435: [Epic] Wikidata watchlist improvements (client)
Lucas_Werkmeister_WMDE closed subtask T58664: [Story] Clean up the code that formats Wikibase entries in recent changes as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T90435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Manuel, Sdkb, Lectrician1, Tomastvivlaren, Amire80, Fuzheado, AfroThundr3007730, Yair_rand, Larske, Capankajsmilyo, stjn, Zache, Noella94, Elitre, PokestarFan, Tbayer, Aschroet, IKhitron, Esh77, TomT0m, Oliv0, abian, Daniel_Mietchen, Soisyc_Croisic, H4stings, Ricordisamoa, matej_suchanek, MGChecker, Sitic, JanZerebecki, Conny, Snaterlicious, Quiddity, Rschen7754, Ainali, MisterSynergy, Lydia_Pintscher, Aklapper, daniel, me, Danny_Benjafield_WMDE, Astuthiodit_1, BeautifulBold, Suran38, karapayneWMDE, Invadibot, caldera, maantietaja, GhostInTheMachine, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nickleh, Nandana, lucamauri, Gnoeee, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Dinoguy1000, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357152: [DOT] Perform necessary redirect after creating new lexeme with Special:NewLexeme
Lucas_Werkmeister_WMDE added a comment. Should be testable on Beta now. TASK DETAIL https://phabricator.wikimedia.org/T357152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T357024: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in Wikibase editing APIs
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. Sorry, one small follow-up that I just noticed while looking over the code again. TASK DETAIL https://phabricator.wikimedia.org/T357024 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, Celenduin, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
