from:"thiemowmde"

thiemowmde added a comment.

@Smalyshev wrote:
I don't see where term types are defined […]


That's exactly the issue I referred to. These "term types" being strings is mostly an implementation detail of how the wb_terms table is designed. The currently specified term types can be found in TermIndexEntry. Please use these constants to make it easier to find places working with these term types.


TermIndexEntry::TYPE_LABEL = "label"
TermIndexEntry::TYPE_ALIAS = "alias"
TermIndexEntry::TYPE_DESCRIPTION = "description"


but could there be more?

We played around with ideas to have other types for #lexicographical_data, but we are most probably not going to do this. So these 3 types are all that exist.

Is Elastic implementation supposed to support them […]

Please either return no result if a caller asks for an unknown term type, or throw an exception.

Also, there's an overlap of coverage - you can use getLabel or you can use getPrefetchedTerm(... 'label' ...).

This is just one of the many problems of this combination of older and newer interfaces. Please focus on the more narrow methods (everything without $termType) if possible.

code dealing with prefetching, buffering, resolving different repos […] should all this code be reimplemented for ElasticSearch implementation of prefetchTerms or can it be somehow reused? All that code relies on TermBuffer/TermIndex now.

We might need to split the existing implementations. But I believe it is easier to start over and not touch the existing implementations. For example, you can start by implementing nothing but a TermLookup. If this works, you can add a small TermBuffer implementation on top that allows for prefetching. Since TermBuffer alone is not very useful, you might need to use the PrefetchingTermLookup interface as a decorator instead:

class PrefetchingElasticTermLookup implements PrefetchingTermLookup {

	private $lookup;

	public function __construct( ElasticTermLookup $lookup ) {
		$this->lookup = $lookup;
	}

	public function prefetchTerms( array $entityIds, array $termTypes = null, array $languageCodes = null ) {
		/* TBD */
	}

	public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
		switch ( $termType ) {
			case TermIndexEntry::TYPE_LABEL:
return $this->getLabel( $entityId, $languageCode );
			case TermIndexEntry::TYPE_DESCRIPTION:
return $this->getDescription( $entityId, $languageCode );
			default:
throw new \InvalidArgumentException( "Not defined for \$termType \"$termType\"" );
		}
	}

	public function getLabel( EntityId $entityId, $languageCode ) {
		$this->lookup->getLabel( $entityId, $languageCode );
	}

	public function getLabels( EntityId $entityId, array $languageCodes ) {
		$this->lookup->getLabels( $entityId, $languageCodes );
	}

	public function getDescription( EntityId $entityId, $languageCode ) {
		$this->lookup->getDescription( $entityId, $languageCode );
	}

	public function getDescriptions( EntityId $entityId, array $languageCodes ) {
		$this->lookup->getDescriptions( $entityId, $languageCodes );
	}

}



TermLookup methods are supposed to be dealing with entities from federated repos too, and also working on the WikibaseClient side […]

This might indeed be needed. However, I suggest to not care for these for the moment. We can add such functionality later via dispatchers, decorators, and such.TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T188802: String values with leading/trailing whitespace are (inconsistently) reported as invalid

thiemowmde renamed this task from "Adding property field Property:P742 (pseudonym) needs to ignore leading spaces" to "String values with leading/trailing whitespace are (inconsistently) reported as invalid".
TASK DETAILhttps://phabricator.wikimedia.org/T188802EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lydia_Pintscher, Aklapper, Billinghurst, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188802: Adding property field Property:P742 (pseudonym) needs to ignore leading spaces

thiemowmde added projects: DataValues, MediaWiki-extensions-WikibaseRepository, Easy.thiemowmde triaged this task as "Low" priority.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a comment.
Labels, descriptions, aliases, as well as monolingual text values are trimmed. For monolingual text values this happens in the backend via MonolingualTextParser.

For string values this is not done. Instead a validator blocks strings with leading or trailing spaces, tabs, newlines, or any other vertical whitespace. The code for this can be seen in ValidatorBuilders::getCommonStringValidators.

We did not wanted to enforce trimming on string values because whitespace can be significant and meaningful. Think of https://www.wikidata.org/wiki/Property:P487, the string property holding a Unicode character. Shouldn't it be possible to add a statement to https://www.wikidata.org/wiki/Q380933 (the Item describing the space character) that holds the space character? Because of the validator this is currently not possible. I believe having this validator in place was a good thing. But nowadays we have plenty of alternatives, most notably constrain checks. Maybe it's time to lift the hard-coded limitation?TASK DETAILhttps://phabricator.wikimedia.org/T188802WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lydia_Pintscher, Aklapper, Billinghurst, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T186726: Security review WikibaseLexeme extension

thiemowmde triaged this task as "Normal" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

thiemowmde triaged this task as "Lowest" priority.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Legoktm, gerritbot, greg, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Scott_WUaS, abian, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema

thiemowmde triaged this task as "Lowest" priority.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T185609EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, Lucas_Werkmeister_WMDE, Umherirrender, Legoktm, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Scott_WUaS, abian, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from ready to go to in progress on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T186726WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

thiemowmde added a comment.
I uploaded fixes for two issues:


 https://gerrit.wikimedia.org/r/416406
 https://github.com/wmde/php-vuejs-templating/pull/6
 FormIdFormatter and SenseIdFormatter are dummy implementations. The escaping is fine. I created T188899: [Task] Remove hard-coded demo data from Lexeme code base to properly deal with these later.
 comma-separator is a message from core, and intentionally contains HTML (but no wiki syntax). As far as I can see we are using it correctly. Yes, we are aware messages with HTML are problematic, and we avoid it whenever possible.
 Click-jacking prevention is a general issue for all of #Wikidata and should have it's own ticket.
TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T188899: [Task] Remove hard-coded demo data from Lexeme code base

thiemowmde added a parent task: T168260: Deploy WikibaseLexeme extension on Wikimedia cluster.
TASK DETAILhttps://phabricator.wikimedia.org/T188899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: RazShuty, Ladsgroup, Jonas, Aleksey_WMDE, WMDE-leszek, Lydia_Pintscher, thiemowmde, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T168260: Deploy WikibaseLexeme extension on Wikimedia cluster

thiemowmde added a subtask: T188899: [Task] Remove hard-coded demo data from Lexeme code base.
TASK DETAILhttps://phabricator.wikimedia.org/T168260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T188899: [Task] Remove hard-coded demo data from Lexeme code base

thiemowmde created this task.thiemowmde added projects: Wikidata, Lexicographical data, Technical-Debt.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONIn T186726: Security review WikibaseLexeme extension the #security-reviews team stumbled across hard-coded demo data in the Lexeme code base. Before T168260: Deploy WikibaseLexeme extension on Wikimedia cluster these must all be removed, and possibly replaced with proper implementations:


Everything in the directory src/DemoData:
AskOut1Populator, AskOut2Populator, AskOut3Populator, HardLexemePopulator, LeiterLexemePopulator, and usages:
Currently exclusively used in LexemeContent.

Id.php is a set of constants.
Used in above populators.
Also directly used in LexemeContent.


FormIdFormatter.php and SenseIdFormatter.php are basically nothing but dummies with hard-coded demo-data.
resources/experts/Form.js and resources/experts/Sense.js contain the same demo data.

TASK DETAILhttps://phabricator.wikimedia.org/T188899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: RazShuty, Ladsgroup, Jonas, Aleksey_WMDE, WMDE-leszek, Lydia_Pintscher, thiemowmde, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Raised Priority] T188378: Error for some Lua modules "The time allocated for running scripts has expired"

thiemowmde raised the priority of this task from "Lowest" to "Normal".thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a project: Performance.thiemowmde added a comment.
What generally changed since November 2015 is:


The Items are all bigger now. Here are the diffs for two randomly picked example Items from the California maintenance list: https://www.wikidata.org/w/index.php?title=Q400522=626131991=310722154, https://www.wikidata.org/w/index.php?title=Q805375=594954459=275088526.
Way more pages use way more information from Wikidata, which means the available CPU resources need to be shared between way more processes often running at the same time.


The next step in this task should be to recreate an example use case on a local system, and profile the code involved to find bottlenecks. Maybe it's wb_terms again? Quite possible.TASK DETAILhttps://phabricator.wikimedia.org/T188378WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T74157: [Story] Use rc_source and drop RC_TYPE

thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from needs discussion or investigation to in progress on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T74157WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, gerritbot, PokestarFan, Liuxinyu970226, Ricordisamoa, Krenair, Lydia_Pintscher, aude, Aklapper, bd808, EBernhardson, Quiddity, Spage, Mattflaschen-WMF, DannyH, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Lewizho99, Maathavan, Trizek-WMF, SBisson, Wikidata-bugs, Gryllida, jeblad, Catrope, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T179793: Consider dropping the "wb_items_per_site.wb_ips_site_page" index

2018-03-04 Thread thiemowmde

thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from incoming to in progress on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T179793WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, thiemowmdeCc: jcrespo, Stashbot, Marostegui, Aklapper, Ladsgroup, Multichill, daniel, hoo, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Minhnv-2809, Maathavan, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T188182: Special:Nearby no longer shows descriptions on Wikidata

2018-03-04 Thread thiemowmde

thiemowmde added subscribers: pmiazga, Lea_Lacroix_WMDE.thiemowmde added a comment.
Looks like said MFEnableWikidataDescriptions flag was introduced via https://gerrit.wikimedia.org/r/402126 (T182362) and https://gerrit.wikimedia.org/r/408357 (T182217) some weeks ago. But since this is disabled by default and the configuration not updated, the feature was effectively disabled. Was this intentional? Why is one feature hidden behind two almost identical configuration flags now?TASK DETAILhttps://phabricator.wikimedia.org/T188182EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Lea_Lacroix_WMDE, pmiazga, Jdlrobson, thiemowmde, Lydia_Pintscher, aude, Aklapper, Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188182: Special:Nearby no longer shows descriptions on Wikidata

thiemowmde added subscribers: Lydia_Pintscher, thiemowmde.thiemowmde added projects: Regression, MobileFrontend, Wikidata.org.thiemowmde triaged this task as "Low" priority.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a comment.
The API query that runs at the moment looks like this: https://www.wikidata.org/w/api.php?action="">

Notice the parameter wbptterms=label does miss the …|description. The global configuration wgMFDisplayWikibaseDescriptions is supposed to enable this. See MobileFrontend/resources/mobile.search.util/extendSearchParams.js for the code responsible for this. As far as I can tell from what I see in the mediawiki-config repository it is currently enabled, but mw.config.get( 'wgMFDisplayWikibaseDescriptions' ) on wikidata.org shows it is not. Further investigation is needed to find this configuration bug.TASK DETAILhttps://phabricator.wikimedia.org/T188182WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lydia_Pintscher, aude, Aklapper, Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jrbranaa, QZanden, LawExplorer, Wong128hk, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T184948: limit page creation rate on Wikidata

thiemowmde triaged this task as "Normal" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T184948EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, Sjoerddebruin, Addshore, Ladsgroup, gerritbot, Aklapper, Lydia_Pintscher, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188629: Completely remove support for detail and detailHTML in wbcheckconstraints response

thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Technical-Debt.thiemowmde moved this task from incoming to ready to go on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T188629WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T150690: Special:Pages using property/P

thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T150690EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Mikey641, IKhitron, Aklapper, eranroz, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, Rafisamra2016, QZanden, Tal-WMIL, Zoranzoki21, LawExplorer, Avner, Tzafrir, Wikidata-bugs, aude, Amire80, TheDJ, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T134731: Mark changes to non-local sitelinks as minor

thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T134731EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, jeblad, Zppix, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188728: Replace claim with violation message in Special:ConstraintReport

thiemowmde added subscribers: Jan_Dittrich, Lydia_Pintscher, thiemowmde.thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: WMDE-Design.thiemowmde added a comment.Herald added a project: Design.
I'm very happy with the proposed change for multiple reasons:


The (in my opinion) misplaced question mark goes away.
The actual error becomes visible right away.
What the special page shows becomes much more similar to what can be seen on the Entity pages.
Removing the claim allows us to get rid of a lot of special-case code that exists only for this special page.


I would love to have a brief look by @Jan_Dittrich's #wmde-design team. Is this a good direction that fits to the designs previously done for #wikibase-quality-constraints?TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188722: Remove Moldovan Wikipedia from WDQS

thiemowmde added subscribers: daniel, thiemowmde, Addshore.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde triaged this task as "Low" priority.thiemowmde added a project: MediaWiki-extensions-WikibaseRepository.thiemowmde added a comment.
From what I see, the following conditions must be met for this triple to appear in a dump:


wikidata.org still contains an Item with a sitelink that actually points to a page on mo.wikipedia.org. Weirdly enough I can't find any: https://query.wikidata.org/#SELECT%20%3Fitem%20%3Fpage%20WHERE%20%7B%0A%3Fpage%20schema%3Aabout%20%3Fitem%3B%0Aschema%3AisPartOf%20%3Chttps%3A%2F%2Fmo.wikipedia.org%2F%3E%0A%7D%20LIMIT%2010
The wiki is still in the sites table.


The actual bug here seems to be that the Wikibase code still thinks "mowiki" is a valid wiki, while it is a redirect in reality. You can see that "mo" can still be found when trying to add a sitelink, but doesn't work properly.

There are 10 (!) calls to \SiteLookup::getSites in the Wikibase code, and they all have this issue. Unfortunately it seems the sites table does not contain the information if a domain is a redirect. Where is this stored?TASK DETAILhttps://phabricator.wikimedia.org/T188722WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Addshore, thiemowmde, daniel, Strainu, Aklapper, VIGNERON, WikidataFacts, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, Jonas, FloNight, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188381: Avoid joining three tables just to get the latest revision ID

thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, thiemowmdeCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T188735: Violation messages on Special:ConstraintReport don’t include links

thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde closed this task as "Resolved".thiemowmde moved this task from incoming to in progress on the Wikidata board.thiemowmde assigned this task to Lucas_Werkmeister_WMDE.
TASK DETAILhttps://phabricator.wikimedia.org/T188735WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, thiemowmdeCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188279: Investigate optimzing wb_terms

thiemowmde triaged this task as "Normal" priority.thiemowmde added a comment.

The term_entity_type is not needed any more in Wikibase code, as far as I'm aware of. Third parties can extract the entity type from the first letter of term_full_entity_id, if needed.
The mapping for term_type should live in code, in my opinion. E.g. as constants in the TermIndex interface.
I would not "normalize" term_lang further. It's a language code, it's short, and the allowed values potentially change constantly. If anything, this should be a primary key to the sites table. But the primary key there is also a string, and it's even longer, so there would be no benefit with regards of size.
TASK DETAILhttps://phabricator.wikimedia.org/T188279EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, WMDE-leszek, RazShuty, daniel, Lydia_Pintscher, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T143706: Implement TermLookup based on Elastic

thiemowmde edited subscribers, added: WMDE-leszek; removed: Rzuwig, JanZerebecki.thiemowmde added a comment.
Yea, there is an interface violation in WikibaseClient::getPrefetchingTermLookup as well as WikibaseRepo::getPrefetchingTermLookup. I uploaded https://gerrit.wikimedia.org/r/415816 as a reminder. For what this ticket here is about you should ignore this and the separate TermBuffer interface and only care about classes implementing PrefetchingTermLookup.

Please try to avoid fiddling with TermIndex, if possible. It is way to heavily bound to the wb_terms table. I feel it exposes to much of the wb_terms table structure, as well as details of the WHERE clause.

When looking at classes like BufferingTermLookup I have similar concerns. It is way to heavily bound to TermIndex, and not worth fiddling with.

I would recommend sticking to the PrefetchingTermLookup interface, and possibly creating a new caching layer that is different from BufferingTermLookup.

@daniel, what do you think?TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g, Rzuwig, JanZerebecki___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T186726: Security review WikibaseLexeme extension

thiemowmde added a comment.
I added the WIP originally. The only open dependency is a separate security review of https://github.com/wmde/php-vuejs-templating, which needs a separate #security-reviews ticket. Everything else is resolved, so this is ready to go from my point of view. :-)TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, EBjune, LawExplorer, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T71753: [Story] Wikibase / Wikidata support on Wikiquote

thiemowmde closed subtask T71752: Refactor EntityContent (tracking) as "Invalid".
TASK DETAILhttps://phabricator.wikimedia.org/T71753EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Yair_rand, PokestarFan, Liuxinyu970226, Micru, Ash_Crow, Nemo_bis, Ricordisamoa, Aklapper, Wikidata-bugs, Bene, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T71752: Refactor EntityContent (tracking)

thiemowmde closed this task as "Invalid".thiemowmde added a comment.
Yes and no. Refactoring EntityContent is an ongoing task that will never end. We don't need this ticket to do this, especially since this tickets description is quite vague and not really actionable.TASK DETAILhttps://phabricator.wikimedia.org/T71752EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Aklapper, GPHemsley, Bene, JeroenDeDauw, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T188599: Add monolingual language code sju

thiemowmde added a comment.
Adding language codes generally needs consensus by the language committee, which is a part of the community, as far as I'm aware of.

Yes, the patch is already uploaded – by a volunteer. Therefor the tag.TASK DETAILhttps://phabricator.wikimedia.org/T188599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: thiemowmde, Nikerabbit, gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Shizhao, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188378: Error for some Lua modules "The time allocated for running scripts has expired"

thiemowmde triaged this task as "Lowest" priority.thiemowmde added projects: Need-volunteer, MediaWiki-extensions-WikibaseClient.thiemowmde added a comment.
Scratching the limits is basically the point of these maintenance pages. Whenever something like this is done, it is pretty much guaranteed there will be a few extreme outliers. The first example provided loads 300+ Wikidata items, and for each:


Loads all labels in all languages
Checks if 13 specific properties are present, and filled in properly


The configuration for this can be seen in https://www.wikidata.org/wiki/Module:Roadtable/models.

The main code is in https://www.wikidata.org/wiki/Module:Roadtable. It contains a problematic mw.wikibase.getEntityObject that might be worth replacing with more specific methods like getBestStatements or the new getAllStatements (T166056).TASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T114903: Migrate wb_terms to using prefixed entity IDs instead of numeric IDs

thiemowmde removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T114903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, Stashbot, gerritbot, PokestarFan, Pasleim, Ricordisamoa, JanZerebecki, hoo, daniel, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Marostegui, LawExplorer, Minhnv-2809, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T114903: Migrate wb_terms to using prefixed entity IDs instead of numeric IDs

thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: Technical-Debt.
TASK DETAILhttps://phabricator.wikimedia.org/T114903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, Stashbot, gerritbot, PokestarFan, Pasleim, Ricordisamoa, JanZerebecki, hoo, daniel, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, LawExplorer, Lewizho99, Minhnv-2809, Maathavan, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T188534: [Bug] Format constraint incorrectly interprets regexes containing unwrapped "|"

thiemowmde renamed this task from "Format constraint incorrectly interprets regexes containing unwrapped "|"" to "[Bug] Format constraint incorrectly interprets regexes containing unwrapped "|"".thiemowmde added a subscriber: Jonas.
TASK DETAILhttps://phabricator.wikimedia.org/T188534EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, Agabi10, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188534: Format constraint incorrectly interprets regexes containing unwrapped "|"

thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: Easy.thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.thiemowmde added a comment.
Yea, simply add (?:…) around all regexes, no matter what they contain. This is always fine.

The code for this can be found in \WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\SparqlHelper::matchesRegularExpressionWithSparql.TASK DETAILhttps://phabricator.wikimedia.org/T188534WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, Agabi10, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188580: Add monolingual language code smn

thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Easy, Community-consensus-needed, Need-volunteer, MediaWiki-extensions-WikibaseRepository.
TASK DETAILhttps://phabricator.wikimedia.org/T188580EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Shizhao, Nikerabbit, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188579: Add monolingual language code sms

thiemowmde added projects: Easy, Community-consensus-needed, Need-volunteer, MediaWiki-extensions-WikibaseRepository.thiemowmde triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T188579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Shizhao, Nikerabbit, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188596: Add monolingual language code sjd

thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Need-volunteer, Easy, Community-consensus-needed, MediaWiki-extensions-WikibaseRepository.
TASK DETAILhttps://phabricator.wikimedia.org/T188596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: Nikerabbit, gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Shizhao, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T188599: Add monolingual language code sju

thiemowmde added a project: MediaWiki-extensions-WikibaseRepository.
TASK DETAILhttps://phabricator.wikimedia.org/T188599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: Nikerabbit, gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Shizhao, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T188599: Add monolingual language code sju

thiemowmde added projects: Community-consensus-needed, Easy, Need-volunteer.thiemowmde triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T188599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: Nikerabbit, gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Shizhao, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T139228: Better match language names when creating Wikidata items

thiemowmde added a comment.
Oh, absolutely right. Thanks! It's just an other approach: I was more thinking in the line of teaching all suggesters to understand word boundaries, no matter what the content of the suggester is. Reusing the ULS API when searching for languages is definitely worth looking into!TASK DETAILhttps://phabricator.wikimedia.org/T139228EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Nikerabbit, gerritbot, thiemowmde, Aklapper, Zppix, Nikola_Smolenski, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, JGirault, ferdbold, Wikidata-bugs, aude, Gryllida, Ricordisamoa, TheDJ, Jdforrester-WMF, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T139228: Better match language names when creating Wikidata items