[Wikidata-bugs] [Maniphest] T354730: Support creating items as not-logged-in user when TempAccounts is enabled
Tgr added a comment. There is also a chance that T348388: Use central login wiki for login (SUL3) <https://phabricator.wikimedia.org/T348388> will find a way to make central login in the background work, and then this would become a non-issue. I wouldn't bet on it though. TASK DETAIL https://phabricator.wikimedia.org/T354730 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg, Tgr Cc: Bugreporter, Tgr, Cparle, GMikesell-WMF, Lucas_Werkmeister_WMDE, dcausse, Tchanders, Michael, Lydia_Pintscher, Arian_Bozorg, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T354730: Support creating items as not-logged-in user when TempAccounts is enabled
Tgr added a comment. > But there’s a risk that the user will close the tab before finishing all the edits, and then the redirect never happens. Maybe we could build some way of tracking whether the session has been "merged" into a central session, and force a central login at the next opportunity if that isn't the case. Though it wouldn't help if they close the tab and then go to another wiki next. Also the way CentralAuth works, the "remember me" flag (which makes logins expire after a year, instead of after a day) is only set during central login - I'm not quite sure if that's the case for temp users, who are logged in locally in a special way, but we should check. If it does affect temp users then the UI messaging about the temp account after the edit will be very misleading. TASK DETAIL https://phabricator.wikimedia.org/T354730 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg, Tgr Cc: Bugreporter, Tgr, Cparle, GMikesell-WMF, Lucas_Werkmeister_WMDE, dcausse, Tchanders, Michael, Lydia_Pintscher, Arian_Bozorg, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Tgr added a comment. > - **Language code**. If using Title::getPageViewLanguage to associate page language outside a pageview perspective, it is likely incorrect. Consider using `Title->getPageLanguage()` instead. I'm not sure this is correct. I've just run into this in T353199: prop=description does not respect language variants properly <https://phabricator.wikimedia.org/T353199> which I think is caused by using `Title::getPageLanguage()` where `Title::getPageViewLanguage()` should have been used. Architecturally that method is terrible - it pretends that the language is derived from the title, when in reality it can depend on any number of things including site configuration, page configuration, user preferences, URL parameters or request headers (although to a lesser extent this is true of `Title::getPageLanguage()` as well) but functionally it's often going to be more correct. (I guess it depends on your definition of "pageview perspective", but if you include anything that's connected to a web request then you are left with very little that can actually be deprecated.) I think the more correct approach would be some kind of service that takes a title and a request context (or user identity + WebRequest) and looks up the language, so that the dependencies are made explicit. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353199: prop=description does not respect language variants properly
Tgr added a comment. Not sure which team that is, Wikibase is owned by WMDE and the past prop=description projects were one-offs. (It seems fairly easy though. If someone wants to try their hand at fixing it, they probably just need to add some variant handling to the language logic here <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/16b08f66043c5775aa15bd0fd7d2c0dd8ebd6719/client/includes/Store/DescriptionLookup.php#163>.) TASK DETAIL https://phabricator.wikimedia.org/T353199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: JTannerWMF, ABorbaWMF, matmarex, Aklapper, Tgr, Stang, cooltey, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Confetti68, ItamarWMDE, DAlangi_WMF, Akuckartz, Nandana, lucamauri, Lahi, Gq86, Sharvaniharan, scblr, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dbrant, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353199: prop=description does not respect language variants properly
Tgr added a comment. There are two implementations of prop=description: - fetching the description from the ParserOutput, used on enwiki only; in theory just need to make sure we are using the ParserOutput in the right language variant, but enwiki doesn't have variants so probably no point in worrying about this - loading the description from Wikidata, used on every other wiki; Wikidata doesn't have a separate concept of variants, so you just have to make sure you use the variant's language code when requesting the Wikidata description (you can check how `wgUserVariant` is set in OutputPage for an example) TASK DETAIL https://phabricator.wikimedia.org/T353199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: matmarex, Aklapper, Tgr, Stang, cooltey, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Confetti68, ItamarWMDE, DAlangi_WMF, Akuckartz, Nandana, lucamauri, Lahi, Gq86, Sharvaniharan, scblr, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dbrant, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353199: prop=description and prop=extract do not respect language variants properly
Tgr added a project: MediaWiki-extensions-WikibaseClient. Tgr added a comment. Extracts seem to work fine to me. extracts=100=1=1=zh-hk|https://zh.wikipedia.org/w/api.php?...=zh-hk <https://zh.wikipedia.org/w/api.php?action=query=json=2=%E5%AE%87%E5%AE%99=description> extracts=100=1=1=zh-sg|https://zh.wikipedia.org/w/api.php?...=zh-sg <https://zh.wikipedia.org/w/api.php?action=query=json=2=%E5%AE%87%E5%AE%99=description> "description": "行星、恆星、星系、所有物質和能量的總體" // hk; should be "一切空間、時間、物質和能量構成的總體" "description": "行星、恆星、星系、所有物質和能量的總體" // sg; should be "一切空间、时间、物质和能量构成的总体" "extract": "宇宙（英語：universe，拉丁語：universus）是所有的時間、空間與其包含的內容物所構成的統一體，宇是指空間，而宙是指時間；它包含了行星、恆星、星系、星系際空間、亞原子粒子以及所有的物質與能量..." // hk "extract": "宇宙（英语：universe，拉丁语：universus）是所有的时间、空间与其包含的内容物所构成的统一体，宇是指空间，而宙是指时间；它包含了行星、恒星、星系、星系际空间、亚原子粒子以及所有的物质与能量..." //sg (Although FWIW `prop=extract` is deprecated because #page_content_service <https://phabricator.wikimedia.org/tag/page_content_service/> provides better quality.) TASK DETAIL https://phabricator.wikimedia.org/T353199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: matmarex, Aklapper, Tgr, Stang, cooltey, Confetti68, ItamarWMDE, DAlangi_WMF, Akuckartz, lucamauri, Sharvaniharan, scblr, Wikidata-bugs, Dbrant ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T225814: m.wikidata: login status not detected
Tgr added subscribers: Anomie, Tgr. Tgr closed this task as "Resolved". Tgr claimed this task. Tgr added a comment. The specific issue described in the reproduction steps is working as intended - we cannot share login state between www.wikidata.org and m.wikidata.org because they do not have a shared parent domain that's safe for cookie sharing (wikidata.org isn't because query.wikidata.org, a non-MediaWiki application, also has access to the cookies). In T225814#5992589 <https://phabricator.wikimedia.org/T225814#5992589>, @Anomie wrote: > This has nothing directly to do with CentralAuth. The logic that mangles URLs for mobile domains belongs to #MobileFrontend <https://phabricator.wikimedia.org/tag/mobilefrontend/>, specifically it's in `MobileContext::getMobileUrl()` and its downstream methods. This has been fixed in rEMFRee049b8e45e0: Handle mobile URLs for other wikis <https://phabricator.wikimedia.org/rEMFRee049b8e45e0a968cc6a7e0e730a228037a7085a>. It wasn't related to the exact issue described in the reproduction steps, but did cause other login problems, such as edge login not working for Wikidata (see Extension:CentralAuth/authentication#Central_session <https://www.mediawiki.org/wiki/Extension:CentralAuth/authentication#Central_session> for the explanation of the various login types). Nothing actionable left here, I think. TASK DETAIL https://phabricator.wikimedia.org/T225814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Anomie, Pogieme10, XanonymusX, JAnD, Tacsipacsi, Zabe, ovasileva, darthmon_wmde, Jdlrobson, aude, WDoranWMF, Stryn, Reedy, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, Danny_Benjafield_WMDE, Uata1122, Astuthiodit_1, karapayneWMDE, Invadibot, wiese, maantietaja, ItamarWMDE, Akuckartz, CptViraj, wildly_boy, Nandana, lucamauri, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Agabi10, Scott_WUaS, Wong128hk, Myst, Wikidata-bugs, Snowolf, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T318138: Cannot manually log in on mobile Wikidata (real or test)
Tgr added a comment. In T318138#8754764 <https://phabricator.wikimedia.org/T318138#8754764>, @Lucas_Werkmeister_WMDE wrote: > Is this the same as T49647 <https://phabricator.wikimedia.org/T49647> for a different wiki? We have a hack (actually, a “hack” and a “better hack”) for that issue in production, for Commons and Meta, but not any Wikidata. Maybe we need to add it? (I happened to see that hack while working on T333926 <https://phabricator.wikimedia.org/T333926>.) No, that issue is for *.wikimedia.org wikis, where we don't want to set cookies on wikimedia.org since it's used for other things than wikis, but setting cookies on the exact domain means x.wikimedia.org and x.m.wikimedia.org cannot share. For wikidata the cookies are set on wikidata.org so www.wikidata.org and www.m.wikidata.org can share them. It probably does break things for other wikimedia.org wikis (wikimania etc) though. TASK DETAIL https://phabricator.wikimedia.org/T318138 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Jdlrobson, TheresNoTime, Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Uata1122, Astuthiodit_1, karapayneWMDE, Invadibot, Zabe, maantietaja, ItamarWMDE, Akuckartz, CptViraj, taavi, wildly_boy, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Myst, Wikidata-bugs, Snowolf, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348526: [SW] [COG] [TECH] Migrate Cognate to use a virtual database domain
Tgr added a parent task: T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain. TASK DETAIL https://phabricator.wikimedia.org/T348526 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Thibaut120094, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T253280: Per-file control for some thumbnail generation parameters
Tgr added a comment. In T253280#8516612 <https://phabricator.wikimedia.org/T253280#8516612>, @matthiasmullie wrote: > @Tgr does that match your view? In general, yes. Specifically for the DPI task, I'm not sure if that's something that needs to be configured per-file (vs. just using different thumbnailing options in ProofreadPage). Can't the software just guess the right DPI? Another alternative, mentioned in T256959 <https://phabricator.wikimedia.org/T256959>, is to take the value from some ProofreadPage-managed metadata, which I think is conceptually the equivalent of having per-thumbnail parameters. Whether per-file or per-thumnail is better depends on the use case (does the value depend on something file-specific like the file format or the color scheme, or something context-specific like the size in which the image is displayed?), not sure which is the better in this case. If it does need to be configured per-file though, I'd do it the way you said. And yes, that would solve a fairly generic problem with lots of potential use cases. TASK DETAIL https://phabricator.wikimedia.org/T253280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vlad.shapik, Tgr Cc: matthiasmullie, Antanana, Ladsgroup, Tgr, hnowlan, GFontenelle_WMF, AntiCompositeNumber, Aklapper, 26081981, Astuthiodit_1, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, WDoranWMF, EvanProdromou, Nandana, JKSTNK, jijiki, Jony, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Susannaanas, Ixocactus, SBisson, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Gilles, TheDJ, Steinsplitter, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T253280: Per-file control for some thumbnail generation parameters
Tgr added a comment. T325948: Provide an API for accessing alt text (and possibly other structured data) stored with MediaWiki file uploads <https://phabricator.wikimedia.org/T325948> and T325949: Allow access to (some) structured image metadata across wikis <https://phabricator.wikimedia.org/T325949> is my vague idea of how to access Commons structured file metadata during thumbnail rendering. (The use case I'm personally interested in is alt text, but as I said above I think it is a fairly generic problem.) TASK DETAIL https://phabricator.wikimedia.org/T253280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vlad.shapik, Tgr Cc: Antanana, Ladsgroup, Tgr, hnowlan, GFontenelle_WMF, AntiCompositeNumber, Aklapper, 26081981, Astuthiodit_1, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, WDoranWMF, EvanProdromou, Nandana, JKSTNK, jijiki, Jony, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Susannaanas, Ixocactus, SBisson, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Gilles, TheDJ, Steinsplitter, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available
Tgr added a subscriber: TheDJ. Tgr added a comment. Some good points from another task: In T166094#8310375 <https://phabricator.wikimedia.org/T166094#8310375>, @TheDJ wrote: > 1. Having a default alt tag, will increase the size of an img transclusion on pages, which seems something to keep an eye on. > 2. Review... In much the same way as default content from wikidata was a problem for en.wp, I suspect that default content for alt tags from Commons might be a problem for that community. It would be the first text content from Commons that by default becomes part of wp articles, sourced by search engines etc. There is a vandalism angle possible there, and they may argue that Commons' review processes are not setup to detect that, so that might become a conflict point. TASK DETAIL https://phabricator.wikimedia.org/T213585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: TheDJ, CBogen, Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper, Astuthiodit_1, karapayneWMDE, bwang, Invadibot, Mooeena, GFontenelle_WMF, maantietaja, FRomeo_WMF, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Volker_E, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325948: Provide an API for accessing alt text (and possibly other structured data) stored with MediaWiki file uploads
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang, Invadibot, Mooeena, GFontenelle_WMF, Zabe, Selby, AndreCstr, maantietaja, Y.ssk, XeroS_SkalibuR, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Mirahamira, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Markhalsey, GoranSMilovanovic, Jayprakash12345, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325948: Provide an API for accessing alt text (and possibly other structured data) stored with MediaWiki file uploads
Tgr added a comment. Because of T325949: Allow access to (some) structured image metadata across wikis <https://phabricator.wikimedia.org/T325949>, there are two orthogonal directions of abstraction here: - how the alt text is stored (Wikibase property, or inside wikitext, or something else) - whether it is stored on this wiki, or another wiki in the same database cluster, or another wiki only accessible via API. Because of that, we probably want two layers: - The aforementioned hook or service, for getting alt text for a file in the local DB cluster; - a File method for getting the data, which would invoke the service for a `LocalFile`, invoke the web API for a `ForeignAPIFile`, and handle `ForeignDBFile` somehow. This one is less clear but there are multiple possible strategies: - Just call the API, add a WAN cache layer on top. (Not great, but more or less how it's done for GetExtendedMetadata, except the "API" there is the file description page itself, so it gets purged from edge cacges on edit and can be more aggressively cached because of that). - Make the service work with an arbitrary database which might not be the DB for the current wiki (a long-term architectural goal for much of MediaWiki, but hard because configuration differences between the wikis need to be accounted for). - Put the data in some dedicated place in the local wiki (`page_props`?) and do a cross-wiki read for that. TASK DETAIL https://phabricator.wikimedia.org/T325948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang, Invadibot, Mooeena, GFontenelle_WMF, Zabe, Selby, AndreCstr, maantietaja, Y.ssk, XeroS_SkalibuR, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Mirahamira, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Markhalsey, GoranSMilovanovic, Jayprakash12345, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325948: Provide an API for accessing alt text (and possibly other structured data) stored with MediaWiki file uploads
Tgr renamed this task from "Provide an API for accessing alt text stored with MediaWiki file uploads" to "Provide an API for accessing alt text (and possibly other structured data) stored with MediaWiki file uploads". Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang, Invadibot, Mooeena, GFontenelle_WMF, Zabe, Selby, AndreCstr, maantietaja, Y.ssk, XeroS_SkalibuR, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Mirahamira, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Markhalsey, GoranSMilovanovic, Jayprakash12345, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325948: Provide an API for accessing alt text stored with MediaWiki file uploads
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang, Invadibot, Mooeena, GFontenelle_WMF, Zabe, Selby, AndreCstr, maantietaja, Y.ssk, XeroS_SkalibuR, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Mirahamira, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Markhalsey, GoranSMilovanovic, Jayprakash12345, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325948: Provide an API for accessing alt text stored with MediaWiki file uploads
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang, Invadibot, Mooeena, GFontenelle_WMF, Zabe, Selby, AndreCstr, maantietaja, Y.ssk, XeroS_SkalibuR, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Mirahamira, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Markhalsey, GoranSMilovanovic, Jayprakash12345, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T325948: Provide an API for accessing alt text stored with MediaWiki file uploads
Tgr created this task. Tgr added projects: Accessibility, SDC General, Commons, MediaWiki-General. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Wikimedia Commons stores alt text in the form of WikibaseMediaInfo claims (see T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages <https://phabricator.wikimedia.org/T166094>). We don't want clients to access that directly because 1. the Wikibase APIs are complex and not that developer-friendly; 2. we want to provide stability guarantees for APIs and community-owned ontology makes that difficult; 3. as much as possible we want to hide ontology changes and keep the API the same (e.g. if a migration happens because of T325944: Use a multlingual Wikibase property for storing alt text on Commons <https://phabricator.wikimedia.org/T325944>); 4. we want to make alt-text features available on developer setups and third-party MediaWiki setups without forcing a Wikibase / WikibaseMediaInfo dependency. So, there should be an internal PHP API (presumably a core hook or service, maybe along the lines of the GetExtendedMetadata <https://mediawiki.org/wiki/Manual:Hooks/GetExtendedMetadata> hook) that WikibaseMediaInfo implements by looking up the relevant Wikibase property, but other extensions can implement in different ways; and there should probably also be a web API exposing the same functionality. Some considerations: - there should be a way to get the alt text for a specific file in a specific language (probably with language fallback?) - there should be a way to get the alt text for all files on a page and/or a batch of images (for the InstantCommons <https://www.mediawiki.org/wiki/InstantCommons> use case) - is there a use case for getting all languages for a file? - the web API should probably be cacheable for a short time TASK DETAIL https://phabricator.wikimedia.org/T325948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, G1964j, Zekwn, the0001, bwang, Mooeena, GFontenelle_WMF, Zabe, Selby, AndreCstr, Y.ssk, XeroS_SkalibuR, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, JKSTNK, Mirahamira, Lahi, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Markhalsey, Jayprakash12345, Orienteerix, Tramullas, Acer, Flycatchr, Salgo60, Zppix, Silverfish, Taiwania_Justo, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, Daniel_Mietchen, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: TheDJ, Chidgk1, El_Grafo, Metamorforme42, SyntaxTerror, Nikki, DrMel, Sdkb, Base, FRomeo_WMF, Multichill, CBogen, Conny, putnik, KH32, Ainali, Michael, Abbe98, Pigsonthewing, Bugreporter, Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, Astuthiodit_1, karapayneWMDE, bwang, Invadibot, Mooeena, GFontenelle_WMF, maantietaja, Y.ssk, Muchiri124, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, matthiasmullie, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr added a comment. Filed T325944: Use a multlingual Wikibase property for storing alt text on Commons <https://phabricator.wikimedia.org/T325944> for eventually replacing with a multilingual property. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: TheDJ, Chidgk1, El_Grafo, Metamorforme42, SyntaxTerror, Nikki, DrMel, Sdkb, Base, FRomeo_WMF, Multichill, CBogen, Conny, putnik, KH32, Ainali, Michael, Abbe98, Pigsonthewing, Bugreporter, Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, Astuthiodit_1, karapayneWMDE, bwang, Invadibot, Mooeena, GFontenelle_WMF, maantietaja, Y.ssk, Muchiri124, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, matthiasmullie, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T86517: [Story] Add a new datatype for multilingual text
Tgr added a parent task: T325944: Use a multlingual Wikibase property for storing alt text on Commons. TASK DETAIL https://phabricator.wikimedia.org/T86517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: KH32, mxn, DannyS712, Yurik, Wostr, Lucas_Werkmeister_WMDE, Stryn, Marsupium, Bugreporter, Esc3300, Susannaanas, Laddo, Agabi10, Thibaut120094, MGChecker, Sannita, Snipre, Candalua, Ricordisamoa, Rits, Liuxinyu970226, Aklapper, Lydia_Pintscher, daniel, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr closed this task as "Resolved". Tgr claimed this task. Tgr added a comment. The Wikidata property proposal was accepted: P11265 (alt text) <https://www.wikidata.org/wiki/Property:P11265>. Note that pending T86517: [Story] Add a new datatype for multilingual text <https://phabricator.wikimedia.org/T86517> it is monolingual text, not multilingual text; as mentioned above, the standard workaround is to have multiple monolingual claims instead of one multilingual claim. As noted above, the Commons community already supports <https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals/Archive/2022/05#Adding_alt_texts_through_structured_data> structured alt text, but since the Wikidata property proposal took such a long time, I have left a new notice: Commons:Village pump#Alt text for Commons images as structured data <https://commons.wikimedia.org/wiki/Commons:Village_pump#Alt_text_for_Commons_images_as_structured_data>. With that, I think this task is resolved (although some of the comments still hold valuable insights and concerns, and we should find the right place for those); I will file new tasks for making use of the data. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: TheDJ, Chidgk1, El_Grafo, Metamorforme42, SyntaxTerror, Nikki, DrMel, Sdkb, Base, FRomeo_WMF, Multichill, CBogen, Conny, putnik, KH32, Ainali, Michael, Abbe98, Pigsonthewing, Bugreporter, Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, Astuthiodit_1, karapayneWMDE, bwang, Invadibot, Mooeena, GFontenelle_WMF, maantietaja, Y.ssk, Muchiri124, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, matthiasmullie, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T174022: Implement multi-content revisions
Tgr added a subtask: T324910: Slot-aware action 'raw'. TASK DETAIL https://phabricator.wikimedia.org/T174022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Magol, Lokal_Profil, AfroThundr3007730, Agabi10, Liuxinyu970226, TomT0m, Smalyshev, -jem-, Aklapper, daniel, Astuthiodit_1, BeautifulBold, Suran38, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, Naike, Peteosx1x, NavinRizwi, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, eprodromou, DannyS712, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T253280: Per-file control for some thumbnail generation parameters
Tgr added a comment. I can see two approaches: - encode the information in the thumbnail URL (similar to how e.g. the thumnail URL of a low-quality JPG would be something like `qlow-123px-Example.jpg`) - encode the information in Swift headers Encoding in the URL has the benefit that - it works in vanilla MediaWiki (which stores thumbnails in a file so it cannot store headers) and thus works on third-party installations and is easier for Wikimedia developers to work with locally; - there is no need to invalidate old thumbails; - there is no state stored outside MediaWiki that could get out of sync and cause hard-to-debug errors; - the code interfaces for it are well-established; - and it also naturally enables overriding these parameters on a per-thumbnail basis (which I guess you can see as a good or bad thing depending on how much you worry about it getting misused) and providing different settings for e.g. in-article thumbnails vs. MediaViewer vs. download. Using Swift has the benefit that you don't need to worry about old not-relevant-anymore thumbnails littering Swift and possibly requiring a custom cleanup script. Also, changing image properties could have an instantaneous effect, if you go the extra effort and purge the old thumbnails from Varnish; if not than the URL-based approach will be the more testable one (as you can change file properties and then purge some HTML page to update it to the new URLs, which is something editors already know how to do). On the whole, I'd go with URLs. If you go with URLs, it would look something like this: - Provide an interface in MediaWiki core for structured image metadata, as core cannot depend on the WikibaseMediaInfo extension. It also needs to be able to access Commons structured data on other wikis which use a Commons file (ie. the ForeignApiRepo and ForeignDbRepo classes no to handle fetching the data from Commons). A similar example is how the GetExtendedMetadata <https://www.mediawiki.org/wiki/Manual:Hooks/GetExtendedMetadata> hook was created so core does not have to depend on the CommonsMetadata extension. This is not a small task but very valuable beyond this specific use case - e.g. it would allow replacing CommonsMetadata (which is an ugly pre-Wikibase hack where Commons templates output metadata as HTML and the file handling logic extracts it), and it's also needed for T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available <https://phabricator.wikimedia.org/T213585> - In JpegHandler & co modify the `makeParamString()` method to access this data and add it to the URL, and modify `normaliseParams()`, `validateParam()` and `parseParamString()` to expect this parameter. Preferably make the default implementation use the new parameter (e.g. have `JpegHandler::transformImageMagick()` pass the appropriate option to ImageMagick) although this is not strictly required. - Optionally define a magic word for the parameter and add it to `getParamMap()` - this will allow overriding the value in wikitext on a per-thumbnail basis. - Update Thumbor to do the same string decoding as `makeParamString()` and modify the output appropriately. If you go with headers, your plan sounds right, with the caveat that there might be many thumbnails for a given file (maybe unlikely but certainly possible) so purging them might need to be an async operation (maybe? I have no idea how fast it is to do mass deletions in Swift; in any case this is also needed for image deletion or reupload so the mechanism probably already exists). I once tried to add Swift file headers based on some MediaWiki property (but did not go through with it in the end), maybe that's useful although the code is pretty old now: T167400: Disable serving unpatrolled new files to Wikipedia Zero users <https://phabricator.wikimedia.org/T167400> T66214: Define an official thumb API <https://phabricator.wikimedia.org/T66214> would be nice but it's an entirely orthogonal problem. TASK DETAIL https://phabricator.wikimedia.org/T253280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vlad.shapik, Tgr Cc: Tgr, hnowlan, GFontenelle_WMF, AntiCompositeNumber, Aklapper, 26081981, Astuthiodit_1, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, WDoranWMF, EvanProdromou, Nandana, JKSTNK, jijiki, Jony, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Susannaanas, Ixocactus, SBisson, Wong128hk, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, El_Grafo, Dinoguy
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr added a comment. A new, similar CI break: 18:24:47 1) Wikibase\Repo\Tests\Hooks\Formatters\EntityLinkFormatterFactoryTest::testGivenNotArrayOfCallbacks_throwsException with data set #0 (array(null)) 18:24:47 Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! JobQueueGroupFactory -> MainWANObjectCache -> UserNameUtils -> TitleParser -> _MediaWikiTitleCodec -> InterwikiLookup -> MainWANObjectCache The dependency circle is different but it is again caused by `Session::__destruct()` being invoked at some random place (here <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/includes/debug/logger/LegacyLogger.php#267>, apparently, which makes even less sense than the previous instance). TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, IdtrA, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr added a comment. I guess the nice thing to would be to properly dependency-inject UserNameInfo into SessionBackend, so what dependency loading order we end with does not depend on when session saving happens to be triggered. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr added a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr added a comment. Also, why is this affecting a single testcase in a single test file <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/23868774558b7e4f33ca8d375390f9535c6595cc/repo/tests/phpunit/includes/Hooks/Formatters/EntityLinkFormatterFactoryTest.php#51>? It doesn't seem to be doing anything special, and plenty of other tests call `Language::factory` without breaking. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr added a comment. What a mess. The test calls `Language::factory`, which needs NamespaceInfo, which tries to initialize a bunch of configuration settings. Somehow something inside `new ServiceOptions( NamespaceInfo::CONSTRUCTOR_OPTIONS, $services->getMainConfig() )` triggers session handling (no idea how that would happen, and the stack trace doesn't tell anything about that). When exiting the method, the session destructor is called. The session is dirty (which I think shouldn't happen at this point, but then this is a unit test so who knows how many components behave in unusual ways) and validates the user's name, which requires UserNameUtils, which needs the content language, which would be created by the language factory. Why does that standard-looking ServiceOptions call trigger session handling, when a pretty much identical call in the LanguageFactory wiring doesn't? And what does any of it have to with the GrowthExperiments extension? Seems mystical to me. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr added a comment. So it seems EarlyLifeCycleHooks is somehow causing this or contributing to it. Presumably because it adds a UserOptionsLookup dependency to language-related things (more specifically anything that would do message loading during initialization), but then why doesn't UserOptionsLookup appear in the dependency chain? And none of the constructors of the services indicated in the error do anything that would trigger the MessageCache__get hook. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, 786, Sgs, Biggs657, caldera, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, kostajh, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Gq86, Af420, Bsandipan, Nattes, Lewizho99, Maathavan, Iniquity, Taiwania_Justo, Neuronton, Wikidata-bugs, geraki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
Tgr created this task. Tgr added projects: MediaWiki-extensions-WikibaseRepository, GrowthExperiments. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Growth-Team. TASK DESCRIPTION Breaks CI for all patches in GrowthExperiments at least. Example: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php73-noselenium-docker/56960/console 10:26:38 1) Wikibase\Repo\Tests\Hooks\Formatters\EntityLinkFormatterFactoryTest::testGivenSameTypeAndLanguage_getLinkFormatterCachesResult 10:26:38 Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory 10:26:38 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:435 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 10:26:38 /workspace/src/includes/MediaWikiServices.php:299 10:26:38 /workspace/src/includes/MediaWikiServices.php:1117 10:26:38 /workspace/src/includes/ServiceWiring.php:450 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 10:26:38 /workspace/src/includes/MediaWikiServices.php:299 10:26:38 /workspace/src/includes/MediaWikiServices.php:853 10:26:38 /workspace/src/includes/ServiceWiring.php:2047 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 10:26:38 /workspace/src/includes/MediaWikiServices.php:299 10:26:38 /workspace/src/includes/MediaWikiServices.php:1922 10:26:38 /workspace/src/includes/session/SessionBackend.php:765 10:26:38 /workspace/src/includes/session/SessionBackend.php:236 10:26:38 /workspace/src/includes/session/Session.php:75 10:26:38 /workspace/src/includes/ServiceWiring.php:1131 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 10:26:38 /workspace/src/includes/MediaWikiServices.php:299 10:26:38 /workspace/src/includes/MediaWikiServices.php:1320 10:26:38 /workspace/src/includes/ServiceWiring.php:803 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 10:26:38 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 10:26:38 /workspace/src/includes/MediaWikiServices.php:299 10:26:38 /workspace/src/includes/MediaWikiServices.php:1117 10:26:38 /workspace/src/includes/language/Language.php:299 10:26:38 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/Formatters/EntityLinkFormatterFactoryTest.php:59 10:26:38 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:498 At a glance patches for other extensions seem to be passing so maybe this is somehow specific to GrowthExperiments. It is possible for one extension to interfere with another's tests via hooks, but it's not obvious to be how this would be happening here. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, Sgs, caldera, NavinRizwi, ItamarWMDE, Akuckartz, kostajh, lucamauri, Gq86, Nattes, Iniquity, Taiwania_Justo, Wikidata-bugs, geraki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022
Tgr added a parent task: T298283: composer 2.2 requires plugins to be allowed to run code. TASK DETAIL https://phabricator.wikimedia.org/T311812 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Tgr Cc: TheresNoTime, Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, bd808 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release
Tgr removed a project: Growth-Team. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Tgr Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Nishu02, 786, fenpedia, Suran38, Biggs657, toberto, bwang, Invadibot, LaMagiaaa, Lalamarie69, Zabe, MPhamWMF, Asartea, Florian_COLLIN, R4356th, maantietaja, Wilmanbeno, Juan90264, Rost_WMDE, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Dzaky17, Hook696, CptViraj, Erdinc_Ciftci_WMDE, darthmon_wmde, WDoranWMF, Majavah, Kent7301, EvanProdromou, joker88john, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Gaboe420, Jony, Patriccck, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, mojoaxel, Bsandipan, Daimona, Gboyers, GoranSMilovanovic, ihojose, QZanden, EBjune, LawExplorer, Winter, Litanwei, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, XanonymusX, Neuronton, Scott_WUaS, Cirdan, Pchelolo, Wong128hk, Luke081515, Nirmos, Unapersona, Zache, Wikidata-bugs, Snowolf, WMDE-Fisch, aude, Nullzero, Huji, Dinoguy1000, jeblad, jayvdb, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, jeremyb, caldera, NavinRizwi, kostajh, Nattes, Taiwania_Justo, geraki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release
Tgr removed a project: GrowthExperiments. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Tgr Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Nishu02, 786, fenpedia, Suran38, Biggs657, toberto, bwang, Invadibot, LaMagiaaa, Lalamarie69, Zabe, MPhamWMF, Asartea, Florian_COLLIN, R4356th, caldera, maantietaja, Wilmanbeno, Juan90264, Rost_WMDE, Alter-paule, NavinRizwi, Beast1978, CBogen, Un1tY, Akuckartz, Dzaky17, Hook696, CptViraj, Erdinc_Ciftci_WMDE, darthmon_wmde, WDoranWMF, Majavah, Kent7301, EvanProdromou, joker88john, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, kostajh, Gaboe420, Jony, Patriccck, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, mojoaxel, Bsandipan, Daimona, Gboyers, GoranSMilovanovic, ihojose, Nattes, QZanden, EBjune, LawExplorer, Winter, Litanwei, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, XanonymusX, Taiwania_Justo, Neuronton, Scott_WUaS, Cirdan, Pchelolo, Wong128hk, Luke081515, Nirmos, Unapersona, Zache, Wikidata-bugs, Snowolf, WMDE-Fisch, aude, Nullzero, Huji, geraki, Dinoguy1000, jeblad, jayvdb, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, jeremyb, Sgs, DrMel ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release
Tgr added a subtask: T300346: Fix uses of (error|success|warning|message)box in Growth extensions. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Tgr Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Nishu02, 786, Sgs, fenpedia, Suran38, Biggs657, toberto, DrMel, bwang, Invadibot, LaMagiaaa, Lalamarie69, Zabe, MPhamWMF, Asartea, Florian_COLLIN, R4356th, caldera, maantietaja, Wilmanbeno, Juan90264, Rost_WMDE, Alter-paule, NavinRizwi, Beast1978, CBogen, Un1tY, Akuckartz, Dzaky17, Hook696, CptViraj, Erdinc_Ciftci_WMDE, darthmon_wmde, WDoranWMF, Majavah, Kent7301, EvanProdromou, joker88john, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, kostajh, Gaboe420, Jony, Patriccck, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, mojoaxel, Bsandipan, Daimona, Gboyers, GoranSMilovanovic, ihojose, Nattes, QZanden, EBjune, LawExplorer, Winter, Litanwei, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, XanonymusX, Taiwania_Justo, Neuronton, Scott_WUaS, Cirdan, Pchelolo, Wong128hk, Luke081515, Nirmos, Unapersona, Zache, Wikidata-bugs, Snowolf, WMDE-Fisch, aude, Nullzero, Huji, geraki, Dinoguy1000, jeblad, jayvdb, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist
Tgr added a comment. You are right, that was clearly meant to be a URL. (Which is the same as the production one so the beta config can just be discarded.) TASK DETAIL https://phabricator.wikimedia.org/T296712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Krinkle, dom_walden, Aklapper, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist
Tgr added a comment. Wikibase's own documentation also says <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/be728a4541dd9382218edd006781d0ce3c3e406d/docs/topics/options.md#Echo> `path` should be relative to the extensions directory. So the simplest fix is to just prefix the path with `Wikibase`. TASK DETAIL https://phabricator.wikimedia.org/T296712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Krinkle, dom_walden, Aklapper, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]
Tgr added a comment. In T231084#7152005 <https://phabricator.wikimedia.org/T231084#7152005>, @Krinkle wrote: > In fact, MediaWiki generally doesn't allow you to change content models of a page except from/to content modelse that have a common base type or otherwise have a way to be transformed, and thus compared. You can do creative things with deletion/undeletion and page move, but in practice, yeah, it's unlikely to happen. Anyway, it is certainly the case that > There is no productive outcome expected here. Rendering an error seems fine here from a product perspective. Probably the low-effort fix is to throw an ErrorPageError instead of an assertion error. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Zabe, marcella, LClightcat, Sunny00217, AnYiLin, Xiplus, thcipriani, Krinkle, WMDE-leszek, Ladsgroup, Addshore, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, NebulousIris, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Liudvikas, Scott_WUaS, Verdy_p, Wikidata-bugs, WMDE-Fisch, aude, Gryllida, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279829: Enable magic word SHORTDESC on German-language Wikipedia
Tgr changed the task status from "Invalid" to "Declined". TASK DETAIL https://phabricator.wikimedia.org/T279829 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Luke081515, Ameisenigel, Tgr, MisterSynergy, Carn, Schniggendiller, Urbanecm, Majavah, FriedhelmW, Ghilt, DannyH, Bugreporter, Count_Count, RhinosF1, Aklapper, XanonymusX, Zabe, Invadibot, maantietaja, Akuckartz, CptViraj, Dibya, 94rain, DannyS712, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, SimmeD, Wikidata-bugs, Snowolf, Base, aude, Dcljr, Addshore, Matanya, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase
Tgr added a comment. Yeah I think this should be a core hook, not a skin hook. There are several uses for a short article description (I'd avoid "tagline" which is more about where it is displayed than what it contains), e.g. currently VisualEditor is using it for link suggestions, or the mobile apps use it via an API. Whether it makes sense to also have a hook in MobileFrontend to determine what the tagline should be (which would then invoke the core hook), or just hardcode it to always show the short description, I'm not sure. Can you envision a wiki where the tagline is not a short description of the article but something different? TASK DETAIL https://phabricator.wikimedia.org/T225529 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, alistair3149, Ammarpad, Masumrezarock100, Jdlrobson, pmiazga, Aklapper, Invadibot, maantietaja, Akuckartz, Demian, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T282744: Wikibase\...\EditFilterHookRunnerTest: Context should not be altered
Tgr added a project: MediaWiki-extensions-WikibaseRepository. Tgr added a subscriber: kostajh. Tgr added a comment. @kostajh pointed out that the error only occurs in wmf.4 where that hook did call that. (Was removed in rEGREa3226bd368ea: Change validation in ConfigHooks to use ConfigValidatorFactory <https://phabricator.wikimedia.org/rEGREa3226bd368ea91b65c0daf2745f484fc42a4616b>.) That test is a bad idea though, it invokes hooks, it cannot expect that nothing will access RequestContext getters. TASK DETAIL https://phabricator.wikimedia.org/T282744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: kostajh, Jdforrester-WMF, Aklapper, Tgr, OTichonova, caldera, IdtrA, NavinRizwi, Akuckartz, 94rain, DannyS712, lucamauri, Gq86, Pablo-WMDE, Iniquity, Taiwania_Justo, Wikidata-bugs, geraki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279829: Enable magic word SHORTDESC on German-language Wikipedia
Tgr added a comment. In T279829#7060056 <https://phabricator.wikimedia.org/T279829#7060056>, @XanonymusX wrote: > I am pretty sure that the short description will work in the same way as the sort key does right now; thus we of course need to review the revision (in the wikitext), but the description the page uses will come from the latest revision, even if not reviewed. That is of course not the ideal behaviour (same for DEFAULTSORT), but with the current status of the FlaggedRevs extension it is to be expected. Yes, anything that is needed outside of the HTML presentation of the page (and the goal of the short description is to be used in all kinds of JS widgets and external tools / apps, so it needs to be available independently of the HTML) needs to live somewhere else than the parser output for the page, and FlaggedRevs's alternative storage for stable revisions only extends to the parser output, so stable versions of short descriptions are not supported and cannot easily be supported, no matter what source the descriptions are pulled from. TASK DETAIL https://phabricator.wikimedia.org/T279829 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Luke081515, Tgr Cc: Tgr, MisterSynergy, Carn, Schniggendiller, Urbanecm, Majavah, FriedhelmW, Ghilt, DannyH, Bugreporter, Count_Count, RhinosF1, Aklapper, XanonymusX, Zabe, Invadibot, maantietaja, Akuckartz, CptViraj, Dibya, 94rain, DannyS712, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, DatGuy, Devwaker, Niklitov, _jensen, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, Base, aude, Dcljr, Addshore, Matanya, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr added a comment. Not a great solution though - it would be pretty confusing to have a description structured data field and a description template field, with completely different semantics. The obvious role for the description field would be to be a plaintext equivalent of the description in the info template. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: FRomeo_WMF, Multichill, CBogen, Conny, putnik, KH32, Ainali, Michael, Abbe98, Pigsonthewing, Bugreporter, Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, Mooeena, GFontenelle_WMF, Muchiri124, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, abian, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Steinsplitter, Mbch331, Jay8g, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T267758: Use MediaInfo caption as the HTML title of the file page
Tgr created this task. Tgr added projects: WikibaseMediaInfo, SDC General, Commons. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Currently, the HTML title (ie. the `` tag, ie. the text seen at the very top of the browser window; NOT the `` tag which is shown as a large text towards the top of the page) is simply the file name. This is not terribly useful - Wikimedia wikis at least don't attempt to have descriptive file names, it is entirely up to the author whether to use one (at least partially because the software does not make file name changes simple). It is particularly problematic in search results such as Google Image Search, which prominently displays the document title (and in all likelihood prominently uses it for ranking as well, so images with generic titles are less likely to be found). According to the HTML spec <https://html.spec.whatwg.org/multipage/semantics.html#the-title-element>, //The title element represents the document's title or name. Authors should use titles that identify their documents even when they are used out of context, for example in a user's history or bookmarks, or in search results. The document's title is often different from its first heading, since the first heading does not have to stand alone when taken out of context.// - we don't quite fulfill that. A better way, at least on Wikimedia Commons (and other MediaInfo wikis in the future) would be to use the caption from the structured data as the HTML title. The caption, unlike the file name, can easily be improved over time, and is meant for exactly such purposes (it's a short but descriptive plaintext explanation of what's shown on the image). Images with no caption (or more precisely, no caption in the site's default content language, ie. English) would still fall back to the image name. TASK DETAIL https://phabricator.wikimedia.org/T267758 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, CBogen, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh
Tgr added a comment. The title of the task made me think it's about refreshing the edited page (ie. the page itself containing outdated/inconsistent data after the edit), but I guess it's actually about refreshing the category page (ie. recursive links update)? Those are different things. I think the patch should have fixed the first, I am unsure about the second. TASK DETAIL https://phabricator.wikimedia.org/T237991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Ramsey-WMF, AntiCompositeNumber, Tgr, Addshore, Jarekt, Aklapper, CBogen, Akuckartz, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh
Tgr added a comment. Can you confirm whether this has been fixed? TASK DETAIL https://phabricator.wikimedia.org/T237991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Addshore, Jarekt, Aklapper, CBogen, Akuckartz, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T264926: Wikibase Selenium tests are flaky
Tgr added a comment.
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632685
16:31:51 [Chrome 73.0.3683.75 linux #0-3] 1) Wikitext Editor (Makes actual
saves) Redirects
16:31:51 [Chrome 73.0.3683.75 linux #0-3] element (".overlay
.wikitext-editor") still not existing after 1ms
16:31:51 [Chrome 73.0.3683.75 linux #0-3] Error: element (".overlay
.wikitext-editor") still not existing after 1ms
16:31:51 [Chrome 73.0.3683.75 linux #0-3] at
iSeeTheWikitextEditorOverlay
(/workspace/src/skins/MinervaNeue/tests/selenium/features/step_definitions/editor_steps.js:12:55)
16:31:51 [Chrome 73.0.3683.75 linux #0-3] at Context.it
(/workspace/src/skins/MinervaNeue/tests/selenium/specs/editor_wikitext_saving.js:27:3)
so maybe something is wrong with the framework and not Wikibase specifically?
TASK DETAIL
https://phabricator.wikimedia.org/T264926
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: hashar, Aklapper, Tgr, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T248457: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles
Tgr added a comment. In T248457#6435718 <https://phabricator.wikimedia.org/T248457#6435718>, @TheDJ wrote: > I find the lack of action on this ticket stunning. FWIW, there is some discussion on this on https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(WMF)#Update:_Scheduled_shutdown_of_Wikidata_descriptions_on_EnWiki which gives the impression that there is some activity, just not very well tracked. TASK DETAIL https://phabricator.wikimedia.org/T248457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: mdaniels5757, TheDJ, eprodromou, Pigsonthewing, GhostInTheMachine, Iniquity, DannyH, ppelberg, MichaelMaggs, Dreamy_Jazz, Majavah, kaldari, Certes, Xeriphas1994, Mathglot, Bencemac, Galobtter, Tgr, Trialpears, Jonesey95, RexxS, QEDK, Pppery, Lydia_Pintscher, JJMC89, DannyS712, Aklapper, Alsee, Liuxinyu970226, Naike, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T248457: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles
Tgr added a comment. @Iniquity this is not a good place to have this argument. If you want to convince the English Wikipedia community that Wikidata descriptions do not conflict with their policies, or that they should be used regardless of whether they conflict with their policies, you need to do that on English Wikipedia. TASK DETAIL https://phabricator.wikimedia.org/T248457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Iniquity, DannyH, ppelberg, MichaelMaggs, Dreamy_Jazz, Majavah, kaldari, Certes, Xeriphas1994, Mathglot, Bencemac, Galobtter, Tgr, Trialpears, Jonesey95, RexxS, QEDK, Pppery, Lydia_Pintscher, JJMC89, DannyS712, Aklapper, Alsee, Liuxinyu970226, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T254202: Special:OAuth not able to retain log in
Tgr added a comment. I have a hard time making sense of this bug report. What is the page where you should have been logged in but weren't, and how is that related to the OAuth server? TASK DETAIL https://phabricator.wikimedia.org/T254202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Aklapper, Epidosis, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Rxy, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T254202: Special:OAuth not able to retain log in
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Epidosis, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Rxy, Krenair, Tgr ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T206645: Come up with a single-call API mechanism to fetch the captions (and other structured data) of a given file
Tgr added a comment. Ideally, `wbgetentities` should be a prop module. That would be useful for both SDC/MediaInfo and for Wikidata, and in general fits with API conventions better. TASK DETAIL https://phabricator.wikimedia.org/T206645 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, JeanFred, Abbe98, Jdforrester-WMF, Aklapper, CBogen, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T252826: Whitelist x-wikimedia-debug header field (currently not allowed by Access-Control-Allow-Headers in preflight response)
Tgr edited projects, added Discovery-Search, Wikidata-Query-Service, RESTBase-API; removed Operations, Traffic. Tgr added a comment. Restricted Application added a project: Wikidata. Yeah, this is probably due to the lack of `Access-Control-Allow-Headers: X-Wikimedia-Debug` in RESTBase and in WDQS. (See also T249107: CORS errors on commons on debug servers <https://phabricator.wikimedia.org/T249107> which was the action API version of this bug.) TASK DETAIL https://phabricator.wikimedia.org/T252826 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, RLazarus, Aklapper, mobrovac, Jseddon, Naike, CBogen, eprodromou, darthmon_wmde, Nandana, Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, GWicke, Manybubbles, Mbch331, Legado_Shulgin, Davinaclare77, Qtn1293, Techguru.pc, Th3d3v1ls, Hfbn0, Zppix, Wong128hk, faidon, Rxy, Jay8g, fgiunchedi ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr added a project: User-Tgr. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Michael, Abbe98, Pigsonthewing, Bugreporter, Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available
Tgr added a project: User-Tgr. TASK DETAIL https://phabricator.wikimedia.org/T213585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper, CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Volker_E, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T147946: Display banners on diff pages
Tgr added a comment. The page title is set in `DifferenceEngine::showDiffPage`, you'd have to factor out that part into something that can be sanely overridden. Or, I guess, change the title from the DifferenceEngineOldHeaderNoOldRev and DifferenceEngineOldHeader hooks, although that's a rather ugly hack. TASK DETAIL https://phabricator.wikimedia.org/T147946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, Andyrom75, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Adidsone1, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, DannyS712, CucyNoiD, NebulousIris, Gaboe420, Phukettaxigroup, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Winter, WSH1906, Lewizho99, Maathavan, Jdrewniak, Wikidata-bugs, Lydia_Pintscher, Rxy ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T216356: Allow access to the page's short description via the title object
Tgr added a project: good first task. Tgr added a comment. Short description handling currently lives in Wikibase, so mw.wikibase makes sense nevertheless. This should be reasonably easy, there's a service to return the description, it just needs some scaffolding to make it available to Lua. TASK DETAIL https://phabricator.wikimedia.org/T216356 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Anomie, Reedy, Gonnym, Aklapper, Soda, Chaytanya, darthmon_wmde, wiki-helenatxu, DannyS712, Nandana, Kieubinhtb, Tks4Fish, lucamauri, Mh-3110, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, srishakatux, LawExplorer, SundanceRaphael, _jensen, rosalieper, D3r1ck01, Scott_WUaS, MuhammadShuaib, Tmalhotra, SimmeD, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T191531: Create Lua module to expose local short descriptions of pages to Lua
Tgr added a comment. This is unlikely to happen for the same reasons T243931: Allow a module to load (require) another module from a global module repository wiki <https://phabricator.wikimedia.org/T243931> didn't. TASK DETAIL https://phabricator.wikimedia.org/T191531 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, RexxS, TheDJ, Aklapper, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]
Tgr added a comment. MediaWiki automatically wraps the entire request in a transaction if it encounters a write which does not do its own transaction handling. So something unrelated to saving could have started the transaction, like AbuseFilter taking an action, or a session refresh (although I would expect either to show up in Logstash). TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Agusbou2015, Pchelolo, daniel, DannyS712, Jdforrester-WMF, Krinkle, Marostegui, Liuxinyu970226, brennen, Bugreporter, LarsWirzenius, Hogue, Aklapper, Naike, eprodromou, darthmon_wmde, Nandana, Banyek, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T585: Finalize high-level API
Tgr added a comment. This has not been resolved. Declined, maybe? TASK DETAIL https://phabricator.wikimedia.org/T585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Cparle, Abbe98, Ramesh2744, MarkTraceur, Abit, Ramsey-WMF, atgo, Matanya, Nemo_bis, Ricordisamoa, Kelson, Gilles, JanZerebecki, Aklapper, Fabrice_Florin, Tgr, MingleTerminator, daniel, CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T157651: sql.php runs LoadExtensionSchemaUpdates
Tgr added a comment.
I would suggest the opposite: keep `sql.php`, drop `patchSql.php`. I don't
think many people are familiar with the latter (compare patchSql
<https://www.mediawiki.org/w/index.php?title=Special:Search=500=0=1=1=1=1=1=1=%22patchSql.php%22={}>
vs sql
<https://www.mediawiki.org/w/index.php?title=Special:Search=500=0=1=1=1=1=1=1=%22sql.php%22={}>
docs for example) and I don't think it's terribly useful - passing a file path
is more user-friendly than passing a patch name. And it does not even replace
the schema vars, meaning it's actively harmful to anyone who uses table
prefixes or non-default table settings.
So, IMO
- keep `mysql.php` which is indeed widely used at least in Wikimedia
production for debugging, more user-friendly than sql.php (which channels query
output through PHP which does weird things to it) and not problematic (it
already requires a write flag for performing any changes - although that relies
on a master/slave distinction so that could be improved, cf T249683#6039238
<https://phabricator.wikimedia.org/T249683#6039238> - and does not accidentally
run updares).
- kill `patchSql.php` which is IMO pretty useless. (Probably worth a wikitech
question to ensure it is indeed not used.)
- keep `sql.php` manual debugging mode, which is the only way to debug a
non-MySQL server, but require an explicit `--debug` flag used. Do not invoke
the updater (not even for variable transformations) when that's used, it seems
pointless and just extra code path exposure (cf the fatal error it gave during
the incident).
- keep `sql.php` for running scripts but require a `--write` flag like
`mysql.php` does for scripts that change data. (I would even separate an admin
mode for schema changes and a write mode for data changes via a restricted
user.)
- if `sql.php` is invoked with no script file and `--debug` flag just exit
with an error (and without creating a DatabaseUpdater or doing anything else
nontrivial).
TASK DETAIL
https://phabricator.wikimedia.org/T157651
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Jdforrester-WMF, kostajh, WMDE-leszek, Addshore, Anomie, alaa_wmde, daniel,
Ladsgroup, Pablo-WMDE, kchapman, Krinkle, Catrope, Reception123, gerritbot,
aaron, Aklapper, Tgr, Oblanco79, Alter-paule, NavinRizwi, Beast1978, Un1tY,
Demian, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez,
darthmon_wmde, Kent7301, Meekrab2012, joker88john, 94rain, CucyNoiD, Nandana,
Lens0021, NebulousIris, jijiki, Gaboe420, Jony, Versusxo, Majesticalreaper22,
Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Af420, Darkminds3113,
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Jayprakash12345,
Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, EnricoCNC, LawExplorer,
Vali.matei, WSH1906, Lewizho99, Minhnv-2809, Maathavan, elukey, _jensen,
rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, SBisson, Wong128hk,
Wikidata-bugs, aude, Dcljr, Bawolff, Gryllida, jeblad, ArielGlenn, He7d3r,
Mbch331, Rxy, Jay8g, Krenair, akosiaris
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views
Tgr added a comment. I guess the impact is a 20-min outage for requests not served from Varnish + missing sitelinks / descriptions / infoboxes / other info from wikidata for pages which have been edited since the end of the outage? Plus potentially some automated editing tools getting wrong information and acting erroneously. TASK DETAIL https://phabricator.wikimedia.org/T249565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Tgr Cc: NickK, Sakretsu, Urbanecm, MisterSynergy, Christian75, Fuzheado, Emaus, RexxS, Paladox, MaxSem, BRPever, AntiCompositeNumber, Coffeeandcrumbs, ppelberg, Catrope, Esanders, Jdforrester-WMF, MMiller_WMF, Jdlrobson, Piramidion, kolbert, Pigsonthewing, Wittylama, AntonierCH, PKM, Erutuon, Moebeus, Zoranzoki21, MusikAnimal, Thibaut120094, Pcoombe, RoySmith, Bugreporter, Addshore, Miraclepine, Ladsgroup, Can_I_Log_In, Krenair, Ahmad252, Dreamy_Jazz, Tgr, Koavf, DannyS712, Aklapper, Oblanco79, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, jijiki, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, LawExplorer, WSH1906, Lewizho99, Minhnv-2809, Maathavan, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wong128hk, Wikidata-bugs, aude, Bawolff, ArielGlenn, Lydia_Pintscher, He7d3r, Mbch331, Rxy, Jay8g, akosiaris ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views
Tgr added a comment.
I'd guess someone triggered T157651: sql.php runs LoadExtensionSchemaUpdates
<https://phabricator.wikimedia.org/T157651>. I actually made the same mistake
while trying to figure out what's broken:
tgr@mwmaint1002:~$ mwscript sql.php huwiki
> describe wb_items_per_site;
Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you
forget to run your application's database schema updater after upgrading?
Query: describe wb_items_per_site;
Function: Wikimedia\Rdbms\DBConnRef::query
Error: 1146 Table 'huwiki.wb_items_per_site' doesn't exist (10.64.16.104)
in
/srv/mediawiki/php-1.35.0-wmf.26/includes/libs/rdbms/database/Database.php:1619
Stack trace:
#0
/srv/mediawiki/php-1.35.0-wmf.26/includes/libs/rdbms/database/Database.php(1603):
Wikimedia\Rdbms\Database->getQueryException('Table 'huwiki.w...', 1146,
'describe wb_ite...', 'Wikimedia\\Rdbms...')
#1
/srv/mediawiki/php-1.35.0-wmf.26/includes/libs/rdbms/database/Database.php(1580):
Wikimedia\Rdbms\Database->getQueryExceptionAndLog('Table 'huwiki.w...', 1146,
'describe wb_ite...', 'Wikimedia\\Rdbms...')
#2
/srv/mediawiki/php-1.35.0-wmf.26/includes/libs/rdbms/database/Database.php(1159):
Wikimedia\Rdbms\Database->reportQueryError('Table 'huwiki.w...', 1146,
'describe wb_ite...', 'Wikimedia\\Rdbms...', false)
#3
/srv/mediawiki/php-1.35.0-wmf.26/includes/libs/rdbms/database/DBConnRef.php(68):
Wikimedia\Rdbms\Database->query('describe wb_ite...', 'Wikimedia\\Rdbms...', 0)
#4
/srv/mediawiki/php-1.35.0-wmf.26/includes/libs/rdbms/database/DBConnRef.php(286):
Wikimedia\Rdbms\DBConnRef->__call('query', Array)
#5 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/sql.php(174):
Wikimedia\Rdbms\DBConnRef->query('describe wb_ite...')
#6 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/sql.php(156):
MwSql->sqlDoQuery(Object(Wikimedia\Rdbms\MaintainableDBConnRef), 'describe
wb_ite...', false)
#7 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/doMaintenance.php(99):
MwSql->execute()
#8 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/sql.php(230):
require_once('/srv/mediawiki/...')
#9 /srv/mediawiki/multiversion/MWScript.php(101):
require_once('/srv/mediawiki/...')
#10 {main}
> ^D
tgr@mwmaint1002:~$ mwscript sql.php wikidatawiki
...wb_items_per_site doesn't exist.
...wb_items doesn't exist.
...wb_aliases doesn't exist.
...wb_texts_per_lang doesn't exist.
[655bbded702c8c60f392c5ee] [no req] Error from line 290 of
/srv/mediawiki/php-1.35.0-wmf.26/extensions/GlobalPreferences/includes/Hooks.php:
Call to undefined method
MediaWiki\Preferences\DefaultPreferencesFactory::setUser()
Backtrace:
#0
/srv/mediawiki/php-1.35.0-wmf.26/extensions/GlobalPreferences/includes/Hooks.php(43):
GlobalPreferences\Hooks::getPreferencesFactory(User)
#1 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(174):
GlobalPreferences\Hooks::onUserLoadOptions(User, array)
#2 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(202):
Hooks::callHook(string, array, array, NULL)
#3 /srv/mediawiki/php-1.35.0-wmf.26/includes/user/User.php(5135):
Hooks::run(string, array)
#4 /srv/mediawiki/php-1.35.0-wmf.26/includes/user/User.php(2889):
User->loadOptions()
#5
/srv/mediawiki/php-1.35.0-wmf.26/includes/parser/ParserOptions.php(1177):
User->getOption(string)
#6 /srv/mediawiki/php-1.35.0-wmf.26/includes/parser/ParserOptions.php(986):
ParserOptions->initialiseFromUser(User, LanguageEn)
#7
/srv/mediawiki/php-1.35.0-wmf.26/includes/parser/ParserOptions.php(1011):
ParserOptions->__construct(User)
#8
/srv/mediawiki/php-1.35.0-wmf.26/includes/Storage/DerivedPageDataUpdater.php(1433):
ParserOptions::newFromUser(User)
#9 /srv/mediawiki/php-1.35.0-wmf.26/includes/page/WikiPage.php(2068):
MediaWiki\Storage\DerivedPageDataUpdater->doUpdates()
#10
/srv/mediawiki/php-1.35.0-wmf.26/extensions/Wikibase/repo/includes/Store/Sql/SqlStore.php(336):
WikiPage->doEditUpdates(MediaWiki\Revision\RevisionStoreRecord, User)
#11
/srv/mediawiki/php-1.35.0-wmf.26/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php(89):
Wikibase\Repo\Store\Sql\SqlStore->rebuild()
#12
/srv/mediawiki/php-1.35.0-wmf.26/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php(61):
Wikibase\Repo\Store\Sql\DatabaseSchemaUpdater->doSchemaUpdate(MysqlUpdater)
#13 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(174):
Wikibase\Repo\Store\Sql\DatabaseSchemaUpdater::onSchemaUpdate(MysqlUpdater)
#14 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(202):
Hooks::callHook(string, array, array, NULL)
#15
/srv/mediawiki/php-1.35.0-wmf.26/includes/installer/DatabaseUpdater.php(129):
Hooks::run(string, array)
#16
/srv/mediawiki/php-1.35.0-wmf.26/includes/installer/DatabaseUpdater.php(195):
DatabaseUpdater->__construct(Wikimedia\Rdbms
[Wikidata-bugs] [Maniphest] [Updated] T249565: Unable to open some pages on multiple wikis - DBQueryError
Tgr added a project: MediaWiki-extensions-WikibaseRepository. TASK DETAIL https://phabricator.wikimedia.org/T249565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Ahmad252, Dreamy_Jazz, Tgr, Liuxinyu970226, Koavf, DannyS712, Aklapper, Iflorez, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Marostegui, LawExplorer, Minhnv-2809, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T246751: SUPPORT: wikidata/wikibase edits via oauth
Tgr added a comment. > api.php?action=query=userinfo=json via OAuth to retrive the username of the user That works but it's not necessarily safe. You should use the OAuth identify endpoint <https://www.mediawiki.org/wiki/OAuth/For_Developers#Identifying_the_user> instead (or the equivalent OAuth 2 endpoint). > Please never post your token on Phabricator or other public forums. I think this one isn’t too bad – OAuth sessions seem to get separate tokens from web sessions, as far as I can tell – but don’t do it again. (I probably should’ve made that more clear in my previous comment.) You should certainly avoid posting any tokens anywhere, as a best practice. CSRF tokens are not that dangerous though (the attacker would have to trick you into visiting their website with a browser that has the same session open before it is abusable). And OAuth sessions are separate from normal sessions, as you say. (OAuth CSRF tokens are kind of pointless, you need the OAuth keys to be able to make an OAuth request and if you have them you can get tokens as well. CSRF handling was just to deeply embedded in the API to be possible to disable for OAuth.) In T246751#5943349 <https://phabricator.wikimedia.org/T246751#5943349>, @Aklapper wrote: > I'm wondering if @Tgr might have an idea here, as this issue is related to OAuth? (Sorry if I am wrong, feel free to share better ideas.) Thanks! Provide exact timestamps for the attempts, we can look up in the permission check logs what exactly failed. TASK DETAIL https://phabricator.wikimedia.org/T246751 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Gabinguo, Lucas_Werkmeister_WMDE, DD063520, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T245845: Wikibase doesn't seem to set itself up correctly
Tgr added a comment. Did you have both the wikidata and machinevision roles enabled? I'm not sure that's supported. TASK DETAIL https://phabricator.wikimedia.org/T245845 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Luke081515, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]
Tgr added a comment. In T231084#5839574 <https://phabricator.wikimedia.org/T231084#5839574>, @Addshore wrote: > With canDiffRevisions being implemented in DifferenceEngine which would see if the 2 contents say they can be diffed with each other? How would DifferenceEngine know that? It has the same dependency on page type as the slots. > I mean, when would it ever make sense to even try and diff wikitext and a wikibase entity? It probably doesn't. It would still be nice if Wikibase could make that call. Anyway the immediate solution is to just throw a UserPageError instead of the assertion error, and have it tell the user that incompatible revisions are being compared (and maybe tell the content models). In the longer term, what if you compare a (wikitext, foo) MCR record with a (wikibase, foo) one? Does it still make sense to at least the foo part diffed? If so, DifferenceEngine would probably need its own error handling, which turns the exception into part of the diff HTML. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Addshore, Umherirrender, Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T241914: Use SDC caption in MediaViewer
Tgr created this task. Tgr added projects: MediaViewer, SDC General. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION MediaViewer has a caption and description area (above and below the fold, respectively) with the following logic: - caption: thumbnail caption; if missing or not viewing a thumbnail, description from the Information template on the file page; if also missing, file name - description: description from the Information template on the file page, unless it's already shown as a caption; otherwise empty. Now that we have captions via Structured Data on Comons <https://commons.wikimedia.org/wiki/Commons:File_captions>, we should pass those along and the logic for the caption should probably be something like: thumbnail caption; if missing or not viewing a thumbnail, caption from structured data; if also missing (*), description from the Information template on the file page; if also missing, file name (*) language fallbacks for similar languages could be applied here, since captions are multilingual, but probably better not to try that. We don't do it for descriptions either. This is a bit more complicated than it seems and would probably involve figuring out a way to fetch the caption for each of the `File` subclasses. See T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available <https://phabricator.wikimedia.org/T213585> which describes the same problem for a different structured data field. TASK DETAIL https://phabricator.wikimedia.org/T241914 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Volker_E, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Volker_E, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available
Tgr added a comment. Seems pretty clear there is no support for using the caption that way (correctly, in my opinion), so rewrote the task to be agnostic of specifically how the alt text is stored. (But it will probably be a dedicated Wikidata property, see T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages <https://phabricator.wikimedia.org/T166094>.) That's the easy part; passing it around internally, in a way that works with our file repo architecture, seems surprisingly complex. See especially the `ForeignDBFile` part in the task description. TASK DETAIL https://phabricator.wikimedia.org/T213585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Volker_E, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T213585: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available
Tgr renamed this task from "Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data caption as alt text when available" to "Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data alt text when available". Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Volker_E, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T86517: [Story] Add a new datatype for multilingual text
Tgr added a parent task: T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages. TASK DETAIL https://phabricator.wikimedia.org/T86517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: DannyS712, Yurik, Wostr, Lucas_Werkmeister_WMDE, Stryn, Marsupium, Bugreporter, Esc3300, Susannaanas, Laddo, Agabi10, Thibaut120094, MGChecker, Sannita, Snipre, Candalua, Ricordisamoa, Rits, Liuxinyu970226, Aklapper, Lydia_Pintscher, daniel, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr added a subtask: T86517: [Story] Add a new datatype for multilingual text. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr added a comment. Repurposed this to be SDC-specific. The next step would be to write a property proposal (and do it better than the rejected past attempts, which were not very well written). TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T166094: Allow editors to provide default alt text on Wikimedia Commons file description pages
Tgr renamed this task from "Please include suggested alt text for images" to "Allow editors to provide default alt text on Wikimedia Commons file description pages". Tgr added a project: Commons. Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T166094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing-WMF, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Orienteerix, Tramullas, Acer, LawExplorer, Flycatchr, EHCliffe, Salgo60, Zppix, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Volker_E, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]
Tgr added a comment. (See also T202763: Update extensions which customize content diff rendering <https://phabricator.wikimedia.org/T202763>.) DifferenceEngine calls the renderer of the right-hand item (so if you compare wikibase item to wikitext, it will call TextSlotDiffRenderer, if you compare wikitext to wikibase item, it will call EntityContentDiffView). That's not great, extensions should be able to provide wikitext diffing logic without having to override the wikitext diff renderer class. I'm not sure what would be the sane way to achieve that, though. If you compare A and B and the diff renderer for A throws an exception, catch and call the renderer for B? That feels very dirty; even if we replace exception catching with some kind of capability detection mechanism, it seems fragile. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Umherirrender, Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null
Tgr added a comment. In T231084#5554961 <https://phabricator.wikimedia.org/T231084#5554961>, @Tgr wrote: > From a distance, the simple solution would be to create a UserPageError subclass describing the situation and throw that instead of the assertion error. One thing to keep in mind though is that the slot diff renderers are low-level code which is invoked in all kinds of contexts, not just diff pages. Sometimes in contexts where replacing the diff with an error message would be much better than killing the request altogether. Still, it seems strictly less bad than the current behavior. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, zeljkofilipin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null
Tgr added a comment. The diff logic leaves it to the SlotDiffRenderer implementation to handle incompatible types. Sorry about that, it's a bit shoddy. I don't remember if there was some specific reason for not turning it into a user error, or it was merely rushed. From a distance, the simple solution would be to create a UserPageError subclass describing the situation and throw that instead of the assertion error. All SlotDiffRenderer subclasses would still have to implement the check but with a helper method that's just a one-liner and we don't want to preclude a differ's ability to provide special handling for different content types (even if there's another wart there, that depending on which content is on the left and which on the right side, you'll probably end up calling a different slot diff renderer implementation). TextSlotDiffRenderer can compare any two TextContent subclasses. I don't think there's a real example today of a SlotDiffRenderer doing anything with a "foreign" content type, but there are use cases where it seems reasonable, especially when the page can be converted between the various types (e.g. wikitext <-> Flow <-> LiquidThreads). TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, zeljkofilipin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T234897: Bad value for parameter $oldContent: must be a TextContent|null
Tgr added a comment. That's a duplicate of T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null <https://phabricator.wikimedia.org/T231084> (minus the pentesting aspect, which I would not be worried about). TASK DETAIL https://phabricator.wikimedia.org/T234897 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Ladsgroup, Aklapper, Michael, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T230862: Create a way to filter only WB-related changes from Commons recentchanges
Tgr added a comment. In T230862#5503781 <https://phabricator.wikimedia.org/T230862#5503781>, @Cparle wrote: > So say we add a 'structured-data-mediainfo' tag to every revision that has a `mediainfo` slot - would that be adequate? @EBernhardson ? Given that this is a functionality that will be needed for pretty much every new MCR role, maybe worth the effort to come up with a generic solution instead of having to work twice? TASK DETAIL https://phabricator.wikimedia.org/T230862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, Tgr Cc: EBernhardson, Cparle, dcausse, Anomie, daniel, Aklapper, Lydia_Pintscher, Tgr, Ramsey-WMF, Addshore, Tpt, Lucas_Werkmeister_WMDE, Smalyshev, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Sethakill, Salgo60, WSH1906, Lewizho99, Maathavan, Silverfish, dg711, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Jonas, Xmlizer, Susannaanas, Ixocactus, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, jayvdb, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Keegan, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T228503: vagrant wikibase cirrus role not working / should set $wgWBCSUseCirrus = true; to enable
Tgr added a comment. Thanks for lookig into it! These should be folded into the Vagrant role settings. I can do that in a few weeks; if you want to do it before that, the `mediainfo` role has an example of how to create Wikibase properties/entities (that should probably be moved to the wikidata and wikibase_repo roles so it's always available), JVM options are in `puppet/modules/elasticsearch/files/jvm.options` and most of the configuration should probably happen via the `mediawiki::extension` resource in the `wikibasecirrussearch` role. The reindexing should be in theory handled by the `cirrussearch` role if the other settings are correct. TASK DETAIL https://phabricator.wikimedia.org/T228503 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dcausse, Tgr Cc: Tgr, Smalyshev, Aklapper, Mvolz, darthmon_wmde, ET4Eva, DannyS712, Nandana, Lahi, jgleeson, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, rosalieper, FloNight, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T231534: Vagrant first provision with wikibase and CirrusSearch causes 1146 Table 'wikidatawiki.wb_items_per_site' doesn't exist
Tgr added a comment. IIRC this happens when Wikibase server code is loaded for a client wiki. I tried to sort that apart in gerrit 524617 <https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/524617> but maybe didn't fully succeed. (Note that enabling roles before the very first provisioning of a new Vagrant box is not really supported, in that almost no one ever tests it.) TASK DETAIL https://phabricator.wikimedia.org/T231534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, dcausse, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T230862: Create a way to filter only WB-related changes from Commons recentchanges
Tgr added a comment. In T230862#5443414 <https://phabricator.wikimedia.org/T230862#5443414>, @Anomie wrote: > That has been proposed and opposed by various people for a long time. I think it's worth revisiting, and there was unanimous agreement on that at last TechConf's relevant session <https://www.mediawiki.org/wiki/Wikimedia_Technical_Conference/2018/Session_notes/Choosing_installation_methods_and_environments_for_3rd_party_users>. It's probably a conversation better left to another task, though (my bad for derailing) - for now, the filter has to deal with SQL as @Smalyshev says. TASK DETAIL https://phabricator.wikimedia.org/T230862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Anomie, daniel, Aklapper, Lydia_Pintscher, Tgr, Ramsey-WMF, Addshore, Tpt, Lucas_Werkmeister_WMDE, Smalyshev, darthmon_wmde, WDoranWMF, DannyS712, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Sethakill, Salgo60, Silverfish, dg711, Poyekhali, _jensen, rosalieper, Morgankevinj, Taiwania_Justo, Jonas, Xmlizer, Susannaanas, Ixocactus, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, jayvdb, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T230862: Create a way to filter only WB-related changes from Commons recentchanges
Tgr added a comment. In T230862#5442416 <https://phabricator.wikimedia.org/T230862#5442416>, @Anomie wrote: > OTOH, that would break it for any MediaWiki wikis not using Elastic... IMO we'll have to bite that bullet at some point and change MediaWiki from a PHP-based application to a container-based one, so we can package ElasticSearch, Node.js, BlazeGraph, Lua etc. with it. (I'm hoping to start some conversation about that at TechConf which seems thematically well-aligned.) And yeah, recentchanges is fundamentally poorly suited to being in SQL. TASK DETAIL https://phabricator.wikimedia.org/T230862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Anomie, daniel, Aklapper, Lydia_Pintscher, Tgr, Ramsey-WMF, Addshore, Tpt, Lucas_Werkmeister_WMDE, Smalyshev, darthmon_wmde, WDoranWMF, DannyS712, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Sethakill, Salgo60, Silverfish, dg711, Poyekhali, _jensen, rosalieper, Morgankevinj, Taiwania_Justo, Jonas, Xmlizer, Susannaanas, Ixocactus, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, jayvdb, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T230862: Create a way to filter only WB-related changes from Commons recentchanges
Tgr added a comment. In theory it would be something like `recentchanges JOIN revision ON rc_this_oldid = rev_id JOIN slots ON slot_revision_id = rev_id AND slot_role_id = whatever AND slot_origin = rev_id`. Except slot_origin is not used consistently that way; this would miss rollbacks, for example. TASK DETAIL https://phabricator.wikimedia.org/T230862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: daniel, Aklapper, Lydia_Pintscher, Tgr, Ramsey-WMF, Addshore, Tpt, Lucas_Werkmeister_WMDE, Smalyshev, darthmon_wmde, WDoranWMF, DannyS712, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Sethakill, Salgo60, Silverfish, dg711, Poyekhali, _jensen, rosalieper, Morgankevinj, Taiwania_Justo, Jonas, Xmlizer, Susannaanas, Ixocactus, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, jayvdb, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Anomie, Steinsplitter, Mbch331, Keegan, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T230862: Create a way to filter only WB-related changes from Commons recentchanges
Tgr added a project: Multi-Content-Revisions. Tgr added a comment. This is a special case of being able to filter by MCR slot type, which we'll surely need in the long term. TASK DETAIL https://phabricator.wikimedia.org/T230862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Lydia_Pintscher, Tgr, Ramsey-WMF, Addshore, Tpt, Lucas_Werkmeister_WMDE, Smalyshev, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Sethakill, Salgo60, JJMC89, Silverfish, dg711, Poyekhali, _jensen, rosalieper, Agabi10, Morgankevinj, Taiwania_Justo, Pchelolo, Jonas, Xmlizer, Susannaanas, Ixocactus, Wong128hk, Jane023, jkroll, Wikidata-bugs, Jdouglas, Base, matthiasmullie, aude, Tobias1984, El_Grafo, Dinoguy1000, Manybubbles, jayvdb, Ricordisamoa, Wesalius, Fabrice_Florin, Raymond, Anomie, Jdforrester-WMF, Steinsplitter, Mbch331, Ltrlg, Keegan, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159924: Create Vagrant role for creating a set of wikis with Wikibase enabled
Tgr added a comment. rMWVA695fe0c8803c: Make wikidata and wikibase_repo roles work together <https://phabricator.wikimedia.org/rMWVA695fe0c8803c2a5f10428b295249a4f63e97905c> did this for Wikibase (in a very hacky way but I can't see any better one), you should be able to generalize from that if you want. TASK DETAIL https://phabricator.wikimedia.org/T159924 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, dcausse, WMDE-leszek, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T222009: Vagrant mediainfo role incompatible with wikidata
Tgr closed this task as "Resolved". Tgr claimed this task. Tgr added a comment. Fixed, see T228428#5399031 <https://phabricator.wikimedia.org/T228428#5399031>. (Although as mentioned there, the mediainfo role doesn't actually work. That was already the case before the fix, even when installed standalone.) TASK DETAIL https://phabricator.wikimedia.org/T222009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, daniel, Aklapper, Smalyshev, darthmon_wmde, DannyS712, Nandana, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T228593: Wikibase on Vagrant: composer-merge-plugin does not install wikibase/data-model anymore
Tgr closed this task as "Resolved". Tgr claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T228593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Mholloway, Agabi10, WMDE-leszek, Aklapper, Tgr, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, jgleeson, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Djdungti, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, bd808, jeremyb, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T228593: Wikibase on Vagrant: composer-merge-plugin does not install wikibase/data-model anymore
Tgr added a comment. Actually it does get installed when I run Composer manually. So this is probably just an ordering issue, with composer update running before the merge-plugin fragment is added. TASK DETAIL https://phabricator.wikimedia.org/T228593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Mholloway, Agabi10, WMDE-leszek, Aklapper, Tgr, darthmon_wmde, Nandana, Sario528, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, bd808, jeremyb, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T228593: Wikibase on Vagrant: composer-merge-plugin does not install wikibase/data-model anymore
Tgr added a comment. Core's `composer.json` has an extra/merge-plugin entry for `composer.local.json` which has one for `../settings.d/composer/*.json` which includes a file created by the wikidata role which has a merge-plugin entry for `extensions/Wikibase/composer.json`. Maybe recursive merge declarations are broken somehow? TASK DETAIL https://phabricator.wikimedia.org/T228593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, darthmon_wmde, Nandana, Sario528, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, bd808, jeremyb, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T228593: Wikibase on Vagrant: composer-merge-plugin does not install wikibase/data-model anymore
Tgr created this task. Tgr added projects: MediaWiki-Vagrant, Wikidata, Composer. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Wikibase does not use extension registration (T88258 <https://phabricator.wikimedia.org/T88258>) and it does not load the Composer autoloader (505e4860cc72 <https://phabricator.wikimedia.org/rEWBA505e4860cc720e1a5098fd3272268448d3342074>) which breaks its usage on Vagrant (dependencies do not get autoloaded, resulting in a `Class 'Wikibase\DataModel\Entity\ItemId' not found` error). This was worked around in T201615 <https://phabricator.wikimedia.org/T201615> / 6254e72 <https://phabricator.wikimedia.org/rMWVA6254e72ffc34e597ed8d7b88284c0dee93d72992> by using composer-merge-plugin to make MediaWiki core install the Wikibase dependencies, but now it seems broken again (the same error is raised, and core's `composer.lock` / `installed.json` does not contain ẇikibase/data-model`). TASK DETAIL https://phabricator.wikimedia.org/T228593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, darthmon_wmde, Nandana, Sario528, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, bd808, jeremyb, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found
Tgr closed this task as "Resolved". Tgr added a comment. This seems to be a composer-merge-plugin failure. Probably better to open a separate task: T228593: Wikibase on Vagrant: composer-merge-plugin does not install wikibase/data-model anymore <https://phabricator.wikimedia.org/T228593> TASK DETAIL https://phabricator.wikimedia.org/T201615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, Tgr Cc: Mvolz, Jdforrester-WMF, gerritbot, ArielGlenn, Agabi10, Jdlrobson, bd808, Smalyshev, WMDE-leszek, Aklapper, Tgr, darthmon_wmde, Nandana, Sario528, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found
Tgr updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T201615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, Tgr Cc: Mvolz, Jdforrester-WMF, gerritbot, ArielGlenn, Agabi10, Jdlrobson, bd808, Smalyshev, WMDE-leszek, Aklapper, Tgr, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, Giuliamocci, Adrian1985, Cpaulf30, Lahi, jgleeson, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T209216: Wikibase cannot find a class on REL1_32
Tgr added a comment. This is a problem on Vagrant, but that has its own task already: T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found <https://phabricator.wikimedia.org/T201615>. Shouldn't be a problem in a manual Wikibase install in theory. TASK DETAIL https://phabricator.wikimedia.org/T209216 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Tgr, Addshore, D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, darthmon_wmde, Nandana, Urfiner, Sario528, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, MGChecker, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T228589: Wikidata vagrant role is broken
Tgr closed this task as a duplicate of T201615: Wikibase on Vagrant: Class Wikibase\DataModel\Entity\ItemId not found. TASK DETAIL https://phabricator.wikimedia.org/T228589 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, Tgr, darthmon_wmde, Nandana, Sario528, Lahi, jgleeson, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reopened] T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found
Tgr reopened this task as "Open". Tgr added a comment. Seems to have regressed at some point. TASK DETAIL https://phabricator.wikimedia.org/T201615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, Tgr Cc: Mvolz, Jdforrester-WMF, gerritbot, ArielGlenn, Agabi10, Jdlrobson, bd808, Smalyshev, WMDE-leszek, Aklapper, Tgr, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, Giuliamocci, Adrian1985, Cpaulf30, Lahi, jgleeson, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found
Tgr merged a task: T228589: Wikidata vagrant role is broken. TASK DETAIL https://phabricator.wikimedia.org/T201615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, Tgr Cc: Mvolz, Jdforrester-WMF, gerritbot, ArielGlenn, Agabi10, Jdlrobson, bd808, Smalyshev, WMDE-leszek, Aklapper, Tgr, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, Giuliamocci, Adrian1985, Cpaulf30, Lahi, jgleeson, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
