[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-11 Thread gerritbot 
gerritbot added a comment.
Change 347349 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Prepare SiteLinkSetsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347349TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-10 Thread gerritbot 
gerritbot added a comment.
Change 347167 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Prepare EntityTermsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347167TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-10 Thread gerritbot 
gerritbot added a comment.
Change 347349 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Prepare SiteLinkSetsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347349TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-08 Thread gerritbot 
gerritbot added a comment.
Change 347167 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Prepare EntityTermsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347167TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-07 Thread gerritbot 
gerritbot added a comment.
Change 346753 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/346753TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-06 Thread gerritbot 
gerritbot added a comment.
Change 346753 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/346753TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, QZanden, enigmaeth, rohitt, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-05 Thread Krinkle 
Krinkle added a comment.

In T158941#3149925, @gerritbot wrote:
Change 344405 merged by Hoo man:
 [mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/344405





In T158941#3158377, @Jdforrester-WMF wrote:
What's outstanding here?


From commenets on https://gerrit.wikimedia.org/r/344405:


@Jonas wrote:
@Krinkle this is what you need for all Wikibase tests right?





@Krinkle wrote:
LGTM, but there are a few more failures remaining still at https://gerrit.wikimedia.org/r/#/c/322812/
 11 FAILURES:


wikibase.entityChangers.EntityTermsChanger save performs correct API calls for new label
..8 similar failures
wikibase.entityChangers.SiteLinkSetsChanger save performs correct API call FAILED
wikibase.entityChangers.SiteLinkSetsChanger save performs correct API call for removal FAILED






@Jonas wrote:
I just wanted to check if that is the fix you need, before I fix all the places needed [..]


So, similar to the first patch, this converted a few tests but there are still a handful left using the unsupported format.

FAILED TESTS:
  wikibase.entityChangers.EntityTermsChanger
✖ save performs correct API calls for new label
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for changed label
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for removed label
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for new description
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for changed description
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for removed description
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for new aliases
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for changed aliases
failed, expected argument to be truthy, was: false

✖ save performs correct API calls for removed aliases
failed, expected argument to be truthy, was: false

  wikibase.entityChangers.SiteLinkSetsChanger
✖ save performs correct API call
failed, expected argument to be truthy, was: false

✖ save performs correct API call for removal
failed, expected argument to be truthy, was: false

  jquery.wikibase.entitytermsforlanguagelistview
✖ Create & destroy
afterEach failed on Create & destroy: Unfinished animations: 2
Error: Unfinished animations: 2

✖ setError()
afterEach failed on setError(): Unfinished animations: 2
Error: Unfinished animations: 2TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, KrinkleCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-05 Thread Jdforrester-WMF 
Jdforrester-WMF added a comment.
What's outstanding here?TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Jdforrester-WMFCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-04-03 Thread gerritbot 
gerritbot added a comment.
Change 344405 merged by Hoo man:
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/344405TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-03-23 Thread gerritbot 
gerritbot added a comment.
Change 344405 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/344405TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, QZanden, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-03-08 Thread gerritbot 
gerritbot added a comment.
Change 323445 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Don't assume synchronous jQuery.Deferred in QUnit tests

https://gerrit.wikimedia.org/r/323445TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lydia_Pintscher, gerritbot, Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred

2017-02-23 Thread gerritbot 
gerritbot added a comment.
Change 323445 had a related patch set uploaded (by Krinkle):
Don't assume synchronous jQuery.Deferred in QUnit tests

https://gerrit.wikimedia.org/r/323445TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs