[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

gerritbot added a comment. Change 607051 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Reenable upstream tests for SimpleCacheWithBagOfStuff https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /607051 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Michael added a comment. In T237164#6234226 , @Addshore wrote: > I think "Just copy the test code we need and ditch the library." Did that with the version currently in the HEAD of their master branch, but I'm getting test

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

gerritbot added a comment. Change 607051 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] Reenable upstream tests for SimpleCacheWithBagOfStuff https://gerrit.wikimedia.org/r/607051 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Ladsgroup added a comment. In T237164#6234226 , @Addshore wrote: > In T237164#6192621 , @Ladsgroup wrote: > >> which option shall we pursue? Any preference? > > I think "Just

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Addshore added a comment. In T237164#6192621 , @Ladsgroup wrote: > which option shall we pursue? Any preference? I think "Just copy the test code we need and ditch the library." TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Ladsgroup added a comment. which option shall we pursue? Any preference? TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Ladsgroup added a comment. In T237164#5954747 , @Addshore wrote: > See T237164#5896034 > > In T237164#5896034 , @Addshore wrote:

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Addshore added a comment. See T237164#5896034 In T237164#5896034 , @Addshore wrote: > So to move forward this would have to be re added, pinned at the specific version too. >

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Ladsgroup added a comment. In T237164#5893896 , @Daimona wrote: > Also, the library is currently broken: its public interface is using symfony/phpunit-bridge, but it's listed in `require-dev` instead of `require`, see

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Daimona added a comment. In T237164#5896034 , @Addshore wrote: > It looks like that was removed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to this ticket. Ah, thanks, I forgot about that step.

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Daimona added a comment. For some reason, cache/integration-tests is not being installed, see https://integration.wikimedia.org/ci/job/wikibase-repo-docker/11815/console. This used to work before the test was disabled. Also, the library is currently broken: its public interface is using

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

gerritbot added a comment. Change 572923 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): [mediawiki/extensions/Wikibase@master] Revert "Disable a broken test" https://gerrit.wikimedia.org/r/572923 TASK DETAIL https://phabricator.wikimedia.org/T237164

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

gerritbot added a comment. Change 572904 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use HEAD of cache/integration-tests https://gerrit.wikimedia.org/r/572904 TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

gerritbot added a comment. Change 572904 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Use HEAD of cache/integration-tests https://gerrit.wikimedia.org/r/572904 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

thiemowmde added a comment. Thanks a lot for the detailed response! However, I feel my main point got lost. My question really is what the benefit of an isolated unit test for "being compatible with PSR-16" is? It's not like the class SimpleCacheWithBagOStuff is used in isolation. It's not

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Addshore added a comment. In T237164#5889530 , @thiemowmde wrote: > Wasn't this what @MaxSem tried already in https://gerrit.wikimedia.org/r/547911? Yes it looks like it, and that seemed to pass CI > What's the point of this

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

thiemowmde added a comment. Wasn't this what @MaxSem tried already in https://gerrit.wikimedia.org/r/547911? What's the point of this library anyway? As far as I can tell it's used in a single (!) file: SimpleCacheWithBagOStuffTest. What does it do? What do we loose when we get rid of

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Addshore added a comment. Option #3 point to a specific commit hash in composer.json Lets do this one! TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Daimona,

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Ladsgroup added a comment. In T237164#5827895 , @Addshore wrote: > Disabling this test looks fine for now until upstream releases Apparently the latest release of this library just had its second anniversary. I think we should drop

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Addshore added a comment. Disabling this test looks fine for now until upstream releases TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Daimona, Jdforrester-WMF,

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Daimona added a comment. In T237164#5827203 , @Jdforrester-WMF wrote: > Is this going anywhere, or are we just going to leave it disabled forever? I guess it's going to sit in the bitrot limbo until a new version is released

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

Jdforrester-WMF added a comment. Is this going anywhere, or are we just going to leave it disabled forever? TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: Jdforrester-WMF,