[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 432618 abandoned by Jdlrobson: Show banner that is loaded from cache https://gerrit.wikimedia.org/r/432618TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson,

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Krinkle
Krinkle added a comment. @Jdlrobson Yes, there is some form of sandboxing at the level of module loading. Which means that if you define module "a" and "b" as a.js and b.js, and load them separately but in the same request with "a" before "b", then even if "a" throws an exception during

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread gerritbot
gerritbot added a comment. Change 437716 merged by jenkins-bot: [mediawiki/extensions/RelatedArticles@master] Correctly remove node without exception https://gerrit.wikimedia.org/r/437716TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread gerritbot
gerritbot added a comment. Change 437716 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/RelatedArticles@master] Correctly remove node without exception https://gerrit.wikimedia.org/r/437716TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL