[Wikidata-bugs] [Maniphest] [Commented On] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-12-10 Thread MichaelSchoenitzer
MichaelSchoenitzer added a comment.

In T153685#4810420, @Mvolz wrote:

In T153685#4810151, @Jan_Dittrich wrote:
Although this ticket actually conflicts with my own ideas about how the button should work.

We would need to review the solution/UI (separately of the code) anyway before we merge it.


I mean, that's dependant on the process being under WMDE control, but the repo is on Katie's personal github and she's no longer with WMDE (I think!) - should the repo be moved to the WMDE org?


Yes, also now there exist already 3 different versions, that will be really hard to merge. Mvolz and I did a lot of work twofold without knowing of each.  A typical wikimedia-userscript fail and showing how badly broken the hole system is – especially at wikidata where nothing works without using dozens of gadgets scripts and tool…
We should clean up this mess and get it into a gadget so that people can finally use it and that we will finally get some proper sources into Wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelSchoenitzerCc: Mvolz, MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-12-10 Thread Mvolz
Mvolz added a comment.

In T153685#4810151, @Jan_Dittrich wrote:
Although this ticket actually conflicts with my own ideas about how the button should work.

We would need to review the solution/UI (separately of the code) anyway before we merge it.


I mean, that's dependant on the process being under WMDE control, but the repo is on Katie's personal github and she's no longer with WMDE - should the repo be moved to the WMDE org?TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MvolzCc: Mvolz, MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-12-10 Thread Jan_Dittrich
Jan_Dittrich added a comment.
Although this ticket actually conflicts with my own ideas about how the button should work.

We would need to review the solution/UI (separately of the code) anyway before we merge it.TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: Mvolz, MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-12-10 Thread Mvolz
Mvolz added a comment.

In T153685#4809614, @Jan_Dittrich wrote:
Can the improvements be reviewed and merged back?


Theoretically yes :). You can open a pull request here: https://github.com/filbertkm/wikidata-citetool/pulls

Although this ticket actually conflicts with my own ideas about how the button should work. The button popping into existence when you select the type (doi/reference url) is bad UI; it should be grayed out and just be activated/enabled. However if we do it that way then having the title depend on the type selected (doi/reference url) doesn't work because the button will already exist before selection.TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MvolzCc: Mvolz, MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-12-10 Thread Jan_Dittrich
Jan_Dittrich added a comment.
Can the improvements be reviewed and merged back?TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Mvolz, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-12-09 Thread MichaelSchoenitzer
MichaelSchoenitzer added a comment.
This is fixed in my fork of CiteTool:
https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool

May/Should I close this ticket?TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelSchoenitzerCc: MichaelSchoenitzer, Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, D3r1ck01, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Mvolz, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs