[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. Thank you @Jdlrobson for not giving up.TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, PhysikerweltCc: WMDE-leszek, Agabi10, gerritbot, Physikerwelt, Krinkle, brion,

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Niedzielski added a comment. The latest Barack Obama CSS size graph: F24976898: grafana.wikimedia.org_dashboard_db_mobile-2g_panelId=90=1.pngTASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc:

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. I can't seem to replicate the issue anymore on the beta cluster. Hopefully graphs will stabilise from a week tomorrow (16th)! Yay! Thanks all!TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 441508 abandoned by Jdlrobson: Add Math styles and scripts in BeforePageDisplay hook https://gerrit.wikimedia.org/r/441508TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 442738 abandoned by Jdlrobson: Limit wgMathEnableWikibaseDataType to wikidata Reason: Doesn't look like this will be needed anymore https://gerrit.wikimedia.org/r/442738TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. @WMDE-leszek thank you. Yes. My local wikibase copy was not up to date when I created the change (cf. Patch set 1).TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

WMDE-leszek added a comment. However, I wonder how this could be merged without failing tests. That's the very good point, and I was wondering the same. It seems that Wikibase quibble/phpunit jobs do not pull in Math extension, so that code path was never reached. Will try to get this fixed

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. @WMDE-leszek thanks for fixing. However, I wonder how this could be merged without failing tests. Right after the change was merged, all subsequent unit tests failed. Why did I not see the error message when I tested the change on Jul 24th?TASK

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 450978 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fixed the use of MathDataUpdater in parser output generation https://gerrit.wikimedia.org/r/450978TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

WMDE-leszek added a comment. Merging https://gerrit.wikimedia.org/r/447621 was apparently a mistake, as it caused errors on each item page, when Math extension is enabled, like to be noticed on beta (see below) F24643823: mathzonk.png https://gerrit.wikimedia.org/r/450978 fixes itTASK

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 450978 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Fixed the use of MathDataUpdater in parser output generation https://gerrit.wikimedia.org/r/450978TASK

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 442725 abandoned by Physikerwelt: Remove unnecessary addModule and addModuleStyle calls Reason: this commit is a subset of I0e24bbb53e6e01d549f534744780ca1afc49fdd7 https://gerrit.wikimedia.org/r/442725TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 447621 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Load MathDataUpdater to format math https://gerrit.wikimedia.org/r/447621TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 443941 merged by jenkins-bot: [mediawiki/extensions/Math@master] Add math related styles and script via appropriate hook https://gerrit.wikimedia.org/r/443941TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 447621 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt): [mediawiki/extensions/Wikibase@master] Load MathDataUpdater to format math https://gerrit.wikimedia.org/r/447621TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 443941 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt): [mediawiki/extensions/Math@master] Add math related styles and script via appropriate hook https://gerrit.wikimedia.org/r/443941TASK

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. Thanks @Physikerwelt! From my understanding the problem is not wikidata but wikibase If this is the case i suspect we can disable the config flag on wikipedia's: https://gerrit.wikimedia.org/r/442738 I'll check in with you Wednesday if there is any issues with swatting

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. @Jdlrobson I am currently traveling until Wednesday From my understanding the problem is not wikidata but wikibase. Thus the styles need to be added somewhere using a wikibase hook.TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. And also, Math itself: MathHooks.php#mathTagHook. This is why I think https://gerrit.wikimedia.org/r/#/c/442725/is the right solution here. Please please please review? :)TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Krinkle added a comment. In T173949#4312026, @Physikerwelt wrote: I think a good solution is that the Math extension follows the standard procedure for all tag extensions that require custom CSS and js for their content. Is there a good example of such an extension? Yes. SyntaxHighlighter:

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 442738 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [operations/mediawiki-config@master] Limit wgMathEnableWikibaseDataType to wikidata https://gerrit.wikimedia.org/r/442738TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 442725 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/Math@master] Remove unnecessary addModule and addModuleStyle calls https://gerrit.wikimedia.org/r/442725TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. @Jdlrobson yes. The (only) other way I am aware of is using properties of type mathematical formula from wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. So from what i understand https://github.com/wikimedia/mediawiki-extensions-Math/blob/master/src/MathHooks.php#L202 uses the parser hook but there are other ways to add math to a page? If that's understood I think I've got this.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. @Jdlrobson I agree that global should be avoided. Any other solution is highly appreciated, I am just unaware of one. However, whenever math is displayed the associated CSS and js classes should be loaded. I think a good solution is that the math extension follows the

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. @Physikerwelt can you explain to me why https://en.wikipedia.beta.wmflabs.org/wiki/Module:T173949 causes the loading of unnecessary Math styles/scripts on desktop/mobileeven though they are not needed to render the page? The fact desktop and mobile parser output is not

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Physikerwelt added a comment. @Jdlrobson The patch you are proposing would prevent math from being properly displayed if its used in a lua module. See https://en.wikipedia.org/wiki/Module:ShowMath for an example. I would not consider this as a bug. I currently don't understand why it's only

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. ^ @Physikerwelt can you take a look at this patch? This should remedy the problem with Math styles showing up where they shouldn't be. It looks like this impacts any page using the scribunto formatPropertyValues function. I'm pretty sure we can also remove the

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

gerritbot added a comment. Change 441508 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/Math@master] formatter-factory-callback should not load math styles https://gerrit.wikimedia.org/r/441508TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

Jdlrobson added a comment. @Physikerwelt any idea why a call to formatPropertyValues in a Lua template would load the Maths modules as a side effect?TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: