gerritbot added a comment.
Change 424847 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove phpunit/phpunit dependency
https://gerrit.wikimedia.org/r/424847TASK DETAILhttps://phabricator.wikimedia.org/T188354EMAIL
gerritbot added a comment.
Change 424846 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove phpunit/phpunit dependency
https://gerrit.wikimedia.org/r/424846TASK DETAILhttps://phabricator.wikimedia.org/T188354EMAIL
gerritbot added a comment.
Change 424847 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove phpunit/phpunit dependency
https://gerrit.wikimedia.org/r/424847TASK DETAILhttps://phabricator.wikimedia.org/T188354EMAIL
gerritbot added a comment.
Change 424846 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikibaseLexeme@master] Remove phpunit/phpunit dependency
https://gerrit.wikimedia.org/r/424846TASK DETAILhttps://phabricator.wikimedia.org/T188354EMAIL
WMDE-leszek added a comment.
but I don't really see much substantial benefit from *running* them separately.
Running those tests without relying on MediaWiki is pretty helpful when test-driving development of some code there that is MW-independent. That said, it would have been even easier if
Legoktm added a comment.
In T188354#4010463, @thiemowmde wrote:
When an extension does not work without mediawiki/core […] When it works without core […]
I'm afraid I did not made my point clear enough. This is not an "either-or" thing. The code bases I talk about are extensions, but contain
WMDE-leszek added a comment.
Keeping the tests different is totally fine, MediaWiki will run anything in tests/phpunit. Once the team wants to split them into a separate library, they can do so, and set up the separate phpunit runner at that time using the normal library bootstrap.
Indeed. And
