[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread daniel 
daniel added a comment.

In T202483#4522033, @Addshore wrote:

In T202483#4522020, @daniel wrote:
I wonder why this wasn't caught on beta. We really need to do more automated testing there.


beta has a single shard, so there was no chance it will catch issues like this https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/db-labs.php


*sigh* right.TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: jcrespo, Stashbot, gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread Addshore 
Addshore added a comment.

In T202483#4522161, @Marostegui wrote:
After this deployment, looks like errors have stopped: https://logstash.wikimedia.org/goto/f8ec4b3e22a8b3d5a8ad0143a4f8982f):
 Let's monitor a bit more before considering it fully resolved?


Fine with me, I'll leave this ticket open for you :)TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: jcrespo, Stashbot, gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread gerritbot 
gerritbot added a comment.
Change 454476 merged by jenkins-bot:
[mediawiki/core@master] The BlobStoreFactory constructor needs an LBFactory

https://gerrit.wikimedia.org/r/454476TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: jcrespo, Stashbot, gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread Marostegui 
Marostegui added a comment.

In T202483#4522091, @Stashbot wrote:
Mentioned in SAL (#wikimedia-operations) [2018-08-22T09:06:54Z]  Synchronized php-1.32.0-wmf.18/includes: T202483 [[gerrit:454486|The BlobStoreFactory constructor needs an LBFactory]] (duration: 01m 18s)


After this deployment, looks like errors have stopped: https://logstash.wikimedia.org/goto/f8ec4b3e22a8b3d5a8ad0143a4f8982f):
Let's monitor a bit more before considering it fully resolved?TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarosteguiCc: jcrespo, Stashbot, gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread jcrespo 
jcrespo added a comment.
beta has a single shard

s/shard/section/TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: jcrespo, Stashbot, gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-22T09:06:54Z]  Synchronized php-1.32.0-wmf.18/includes: T202483 [[gerrit:454486|The BlobStoreFactory constructor needs an LBFactory]] (duration: 01m 18s)TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StashbotCc: Stashbot, gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread gerritbot 
gerritbot added a comment.
Change 454486 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.18] The BlobStoreFactory constructor needs an LBFactory

https://gerrit.wikimedia.org/r/454486TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread Addshore 
Addshore added a comment.

In T202483#4522020, @daniel wrote:
I wonder why this wasn't caught on beta. We really need to do more automated testing there.


beta has a single shard, so there was no chance it will catch issues like this https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/db-labs.phpTASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread daniel 
daniel added a comment.
I wonder why this wasn't caught on beta. We really need to do more automated testing there.TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread gerritbot 
gerritbot added a comment.
Change 454486 had a related patch set uploaded (by Addshore; owner: Tim Starling):
[mediawiki/core@wmf/1.32.0-wmf.18] The BlobStoreFactory constructor needs an LBFactory

https://gerrit.wikimedia.org/r/454486TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread gerritbot 
gerritbot added a comment.
Change 454476 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] The BlobStoreFactory constructor needs an LBFactory

https://gerrit.wikimedia.org/r/454476TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread tstarling 
tstarling added a comment.
BlobStoreFactory has a single LoadBalancer injected into its constructor, but allows the caller to choose the wiki ID in newSqlBlobStore(). So that's wrong. Wikidata just gets the BlobStoreFactory from MediaWikiServices::getBlobStoreFactory(), which doesn't allow you to specify the wiki ID and just gives a BlobStoreFactory with the LoadBalancer for the current wiki. BlobStoreFactory could take an LBFactory instead, which would allow newSqlBlobStore() to fetch the correct LoadBalancer.TASK DETAILhttps://phabricator.wikimedia.org/T202483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarlingCc: Addshore, Anomie, daniel, tstarling, Paladox, Aklapper, greg, Liuxinyu970226, Prtksxna, TerraCodes, Marostegui, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, Liudvikas, Luke081515, Wikidata-bugs, aude, zeljkofilipin, KartikMistry, Mbch331, Rxy, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T202483: www.mediawiki.org showing: error:Unknown database 'wikidatawiki' on shard: s3

2018-08-22 Thread tstarling 
tstarling added a comment.
Passing the wrong LoadBalancer into the SqlBlobStore constructor would have approximately this effect. The "previous.trace" is:

#0 /srv/mediawiki/php-1.32.0-wmf.18/includes/libs/rdbms/loadbalancer/LoadBalancer.php(768): Wikimedia\Rdbms\LoadBalancer->reportConnectionError()
#1 /srv/mediawiki/php-1.32.0-wmf.18/includes/Storage/SqlBlobStore.php(203): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string)
#2 /srv/mediawiki/php-1.32.0-wmf.18/includes/Storage/SqlBlobStore.php(279): MediaWiki\Storage\SqlBlobStore->getDBConnection(integer)
#3 /srv/mediawiki/php-1.32.0-wmf.18/includes/libs/objectcache/WANObjectCache.php(1246): Closure$MediaWiki\Storage\SqlBlobStore::getBlob(boolean, integer, array, NULL)
#4 /srv/mediawiki/php-1.32.0-wmf.18/includes/libs/objectcache/WANObjectCache.php(1119): WANObjectCache->doGetWithSetCallback(string, integer, Closure$MediaWiki\Storage\SqlBlobStore::getBlob;1643, array)
#5 /srv/mediawiki/php-1.32.0-wmf.18/includes/Storage/SqlBlobStore.php(284): WANObjectCache->getWithSetCallback(string, integer, Closure$MediaWiki\Storage\SqlBlobStore::getBlob;1643, array)
#6 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(206): MediaWiki\Storage\SqlBlobStore->getBlob(string)
#7 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(114): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->loadEntity(stdClass)
#8 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#9 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\DispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#10 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#11 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(104): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#12 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php(87): Wikibase\Lib\Store\CachingEntityRevisionLookup->fetchEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#13 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php(39): Wikibase\Lib\Store\CachingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId)
#14 /srv/mediawiki/php-1.32.0-wmf.18/vendor/wikibase/data-model-services/src/Lookup/RedirectResolvingEntityLookup.php(51): Wikibase\Lib\Store\RevisionBasedEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
#15 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/client/includes/LangLinkHandler.php(109): Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
#16 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/client/includes/LangLinkHandler.php(331): Wikibase\Client\LangLinkHandler->getEntityLinks(Title)
#17 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/client/includes/LangLinkHandler.php(352): Wikibase\Client\LangLinkHandler->getEffectiveRepoLinks(Title, ParserOutput)
#18 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(97): Wikibase\Client\LangLinkHandler->addLinksFromRepository(Title, ParserOutput)
#19 /srv/mediawiki/php-1.32.0-wmf.18/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandlers.php(65): Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers->doContentAlterParserOutput(Title, ParserOutput)
#20 /srv/mediawiki/php-1.32.0-wmf.18/includes/Hooks.php(174): Wikibase\Client\Hooks\ParserOutputUpdateHookHandlers::onContentAlterParserOutput(WikitextContent, Title, ParserOutput)
#21 /srv/mediawiki/php-1.32.0-wmf.18/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#22 /srv/mediawiki/php-1.32.0-wmf.18/includes/content/AbstractContent.php(520): Hooks::run(string, array)
#23 /srv/mediawiki/php-1.32.0-wmf.18/includes/poolcounter/PoolWorkArticleView.php(145): AbstractContent->getParserOutput(Title, integer, ParserOptions)
#24 /srv/mediawiki/php-1.32.0-wmf.18/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#25 /srv/mediawiki/php-1.32.0-wmf.18/includes/page/Article.php(604): PoolCounterWork->execute()
#26 /srv/mediawiki/php-1.32.0-wmf.18/includes/actions/ViewAction.php(68): Article->view()
#27 /srv/mediawiki/php-1.32.0-wmf.18/includes/MediaWiki.php(501): ViewAction->show()
#28