[Wikidata-bugs] [Maniphest] [Commented On] T208918: wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object

2018-11-15 Thread Addshore 
Addshore added a comment.

In T208918#4749525, @Lucas_Werkmeister_WMDE wrote:
Not sure how much verification this needs – do we want to wait until the fix is deployed (two weeks), and then see if the logstash errors disappear?


Yup, I think that is a good idea :)TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, AddshoreCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Krinkle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208918: wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object

2018-11-15 Thread gerritbot 
gerritbot added a comment.
Change 473549 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Prevent exception in checker for deleted items

https://gerrit.wikimedia.org/r/473549TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Krinkle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208918: wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object

2018-11-15 Thread Michael 
Michael added a comment.
ContemporaryChecker had the only call for \Wikibase\DataModel\Services\Lookup\EntityLookup::getEntity that wasn't guarded against a null result.TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Krinkle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208918: wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object

2018-11-14 Thread gerritbot 
gerritbot added a comment.
Change 473549 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Prevent exception in checker for deleted items

https://gerrit.wikimedia.org/r/473549TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Krinkle, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208918: wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object

2018-11-07 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
The actual location of the error (PHP excludes it from the stack trace for reasons that escape me):

/srv/mediawiki/php-1.33.0-wmf.2/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/ContemporaryChecker.php:114

This corresponds to the $objectStatements assignment here:

		/** @var EntityId $subjectId */
		$subjectId = $context->getEntity()->getId();
		/** @var EntityId $objectId */
		$objectId = $snak->getDataValue()->getEntityId();
		/** @var Statement[] $subjectStatements */
		$subjectStatements = $context->getEntity()->getStatements()->toArray();
		/** @var Statement[] $objectStatements */
		$objectStatements = $this->entityLookup->getEntity( $objectId )->getStatements()->toArray();
		/** @var String[] $startPropertyIds */
		$startPropertyIds = $this->config->get( self::CONFIG_VARIABLE_START_PROPERTY_IDS );
		/** @var String[] $endPropertyIds */
		$endPropertyIds = $this->config->get( self::CONFIG_VARIABLE_END_PROPERTY_IDS );

In this case, the object item has actually been deleted, which is not supposed to happen on Wikidata (items should only be deleted if they’re not used) but isn’t prevented on a technical level, so I guess ContemporaryChecker needs to guard against it. (If I recall correctly, several other checkers already include such guards.)TASK DETAILhttps://phabricator.wikimedia.org/T208918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Krinkle, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs