[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

jeblad added a comment. In T223792#5593785 , @matthiasmullie wrote: > There is no magic involved. > Term lookups are performed differently for different entity types (because the data lives elsewhere), but in a non-hacky fashion (and i

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545903 **merged** by jenkins-bot: [operations/mediawiki-config@master] Enable Wikibase client access on commonswiki https://gerrit.wikimedia.org/r/545903 TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.w

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545903 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie): [operations/mediawiki-config@master] Enable Wikibase client access on commonswiki https://gerrit.wikimedia.org/r/545903 TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-10-24T15:04:02Z] Synchronized wmf-config/InitialiseSettings.php: testcommonswiki, Enable Wikibase client access T223792 (duration: 00m 53s) TASK DETAIL https://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545862 **merged** by jenkins-bot: [operations/mediawiki-config@master] Enable Wikibase client access on testcommonswiki https://gerrit.wikimedia.org/r/545862 TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545862 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [operations/mediawiki-config@master] Enable Wikibase client access on testcommonswiki https://gerrit.wikimedia.org/r/545862 TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545572 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.3] Also use custom PrefetchingTermLookup in SingleEntitySourceServices https://gerrit.wikimedia.org/r/545572 TASK DETAIL https://phabricator.wikimedia.org/T22379

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545800 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.3] Allow defining entity-type-specific PrefetchingTermLookup https://gerrit.wikimedia.org/r/545800 TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545800 had a related patch set uploaded (by Matthias Mullie; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.3] Allow defining entity-type-specific PrefetchingTermLookup https://gerrit.wikimedia.org/r/545800 TASK DETAIL https://ph

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 545572 had a related patch set uploaded (by Matthias Mullie; owner: WMDE-leszek): [mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.3] Also use custom PrefetchingTermLookup in SingleEntitySourceServices https://gerrit.wikimedia.org/r/545572 TASK

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

WMDE-leszek added a comment. In T223792#5598875 , @matthiasmullie wrote: > In T223792#5598472 , @WMDE-leszek wrote: > >> @matthiasmullie repeating myself from the IRC > > Mmh - d

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. In T223792#5598472 , @WMDE-leszek wrote: > @matthiasmullie repeating myself from the IRC Mmh - didn't see anything - what channel was that in? (or DM?) > I believe those three patches https://ger

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

WMDE-leszek added a comment. @matthiasmullie repeating myself from the IRC I believe those three patches https://gerrit.wikimedia.org/r/#/q/topic:mediainfo-pref-termlookup+(status:open+OR+status:merged) would need to be backported onto the deployment branch Will you be able to do th

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 544973 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Also use custom PrefetchingTermLookup in SingleEntitySourceServices https://gerrit.wikimedia.org/r/544973 TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL P

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 544972 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Allow defining entity-type-specific PrefetchingTermLookup https://gerrit.wikimedia.org/r/544972 TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https:

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. Commons is group 1. Let me know if you'd like me to deploy these patches once merged, or help in any way! TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthi

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

WMDE-leszek added a comment. @matthias I think there is not need to have a direct chat. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/544972 and co are being reviewed here at WMDE. As we missed the branch there will be a need for the backport. Let's figure out tomorrow wh

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. There is no magic involved. Term lookups are performed differently for different entity types (because the data lives elsewhere), but in a non-hacky fashion (and it doesn't really matter where the data comes from or how it's retrieved anyway) Yes, we cou

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

jeblad added a comment. Make a new lib and new function calls if the models are dissimilar, please, please, please,… Swiching on some kind of magic (like the initial char) will only create a mess. TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. AFAICT, most operations seem to be working fine. The one that don't are either: - irrelevant (e.g. `resolvePropertyId` - MediaInfo's aren't properties; or `getDescription` - it works, but MediaInfo's don't tend to have descriptions...) - use `SiteLinkLo

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. In T223792#5592264 , @WMDE-leszek wrote: > Apologies for being hard to reach recently @matthiasmullie. > I've submitted a change pair https://gerrit.wikimedia.org/r/544972 + https://gerrit.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

WMDE-leszek added a comment. Apologies for being hard to reach recently @matthiasmullie. I've submitted a change pair https://gerrit.wikimedia.org/r/544972 + https://gerrit.wikimedia.org/r/544973 with a simple proof-of-concept of what would be my idea how to solve this. I am not certain ho

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 544973 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/WikibaseMediaInfo@master] Also use custom PrefetchingTermLookup in SingleEntitySourceServices https://gerrit.wikimedia.org/r/544973 TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 544972 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Allow defining entity-type-specific PrefetchingTermLookup https://gerrit.wikimedia.org/r/544972 TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. In T223792#5563683 , @WMDE-leszek wrote: > I should be able to help with it @matthiasmullie . Looking into it... I was wondering if you're aware of any pre-existing solution to use an alternative `Pre

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

WMDE-leszek added a comment. I should be able to help with it @matthiasmullie . Looking into it... TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie, WMDE-leszek Cc: WMDE-leszek, T

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 525794 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Provide an alternative PrefetchingTermLookup for MediaInfo entities https://gerrit.wikimedia.org/r/525794 TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL P

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. @LucasWerkmeister Yes - I'm in Stockholm. I'll take a look at your suggestion and then come find you! TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmu

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

LucasWerkmeister added a comment. I don’t think implementing `TermIndex` itself, as the linked change currently does, is a good idea. It’s not a great interface (combining lookup, search and modification), and for the new term store in Wikibase we did not write a new implementation of it, bu

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Addshore added a comment. Looking at the code it looks like indeed either a new TermIndex type thing would be needed for media info, or the fetching of terms, as currently done in https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/84e2062770467eacbb42e8a55bdf77e11141834f/lib/incl

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. I was thinking it'd make most sense to use the existing code & structure already used by Wikidata. But I've since learned about the reasons for not using wb_terms (I figured it was just a case of not having implemented it because there had not been a need fo

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 522355 abandoned by Matthias Mullie: Start writing entities into wb_terms Reason: I assumed we didn't get around to implementing this because we hadn't needed it yet - was not aware there were actual reasons for killing it. https://gerrit.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 525794 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie): [mediawiki/extensions/WikibaseMediaInfo@master] Provide an alternative TermIndex, that doesn't require wb_terms https://gerrit.wikimedia.org/r/525794 TASK DETAIL h

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Multichill added a comment. Just realized https://commons.wikimedia.org/w/api.php?action=wbgetentities&props=labels&format=json&languagefallback=1&sites=commonswiki&titles=File:Charles%20P.%20Gruppe%20-%20Meadow%20Brook%20-%201912.7.1%20-%20Smithsonian%20American%20Art%20Museum.jpg already wo

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Smalyshev added a comment. > would an index of some sort be needed in order to support something like mw.wikibase.getEntity( 'File:Blah.png' ) You'd have to just access page table to look up page by title, then go to the appropriate revision & slot (AFAIR there are services already in Wi

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

MarkTraceur added a comment. @Addshore et al., not to make your lives more difficult here, but assuming caption lookup is not desired (because I can't imagine it would be), would an index of some sort be needed in order to support something like mw.wikibase.getEntity( 'File:Blah.png' ) - i.e

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Smalyshev added a comment. > So as a LUA user I want to do mw.wikibase.getEntity( 'M62798946' ) and get in LUA like But for this you don't need any index at all, 62798946 is literally the page id. Am I missing something here? Why there's talk about indexes? TASK DETAIL https://phabric

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Multichill added a comment. In T223792#5346467 , @Smalyshev wrote: >> It looks like the Wikibase Lua support can mostly deal with MediaInfo already, except that it can't look up the MediaInfo entities. > > What kind of look up is thi

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Smalyshev added a comment. > It looks like the Wikibase Lua support can mostly deal with MediaInfo already, except that it can't look up the MediaInfo entities. What kind of look up is this - matching the exact caption? Or partial matching the caption? `mw.wikibase.getEntity` doesn't see

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

gerritbot added a comment. Change 522355 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie): [mediawiki/extensions/WikibaseMediaInfo@master] Start writing entities into wb_terms https://gerrit.wikimedia.org/r/522355 TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

matthiasmullie added a comment. It looks like the Wikibase Lua support can mostly deal with MediaInfo already, except that it can't look up the MediaInfo entities. Unlike Wikibase properties & items, MediaInfo entities are not currently stored in wb_terms. If MediaInfo starts writing to w

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Cparle added a comment. Comment from Daniel: There are two things here to untangle, which really have very little to do with each other, though they may sound similar. 1. Using Scribunto/Lua to access MediaInfo from within wikitext. This would allow the wikitext part of the pa

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Keegan added a comment. In T223792#5289707 , @Mike_Peel wrote: > Is there an opportunity for a retrospective here to figure out why it wasn't included in the original plan? It seems quite a basic component for SDC, and it's been request

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Jarekt added a comment. I do not speak php, but looking at the code Multichill linked to, it seems like the source code for `getEntity `can be found at EntityAccessor.php

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Multichill added a comment. Relevant code seems to be at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/client/includes/DataAccess/Scribunto/ TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/s

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Keegan added a comment. In T223792#5287083 , @Jarekt wrote: > Thank you for the update. Since SDC and Wikidata are based on the same underlying software, I was (naively) imagining that this task was more like extending mw.wikibase.getEn

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Jarekt added a comment. Thank you for the update. Since SDC and Wikidata are based on the same underlying software, I was (naively) imagining that this task was more like extending mw.wikibase.getEntity to go to www.wikidata.org if input string starts with "Q" and go to commons.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Keegan added a comment. Sorry about the delay in the update, but I'm currently meeting with the SDC team in person and we're discussing this task in real-time. The SDC development team is going to have to look into what it takes to get this done - or if not this, some other technical sol

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

Keegan added a comment. I should have some sort of update on Monday relating to this. TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Keegan Cc: Keegan, Jheald, Mike_Peel, Cparle, Aklapper, Jar