[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

2020-06-17 Thread Addshore
Addshore added a comment. In T253624#6165716 , @Ladsgroup wrote: > In T253624#6165674 , @Krinkle wrote: > >> Note that `phpcs` ruleset is controllable per repository. The same way t

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

2020-05-26 Thread Ladsgroup
Ladsgroup added a comment. In T253624#6165674 , @Krinkle wrote: > Note that `phpcs` ruleset is controllable per repository. The same way that we disable some rules in repositories not yet ready to follow a newer convention, it is also p

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

2020-05-26 Thread Krinkle
Krinkle added a comment. Note that `.phpcs` is controllable per repository. The same way that we disable some rules in repositories not yet ready to follow a newer convention, it is also possible to enable additional rules on a per-repo bases. So these rulesets could easily be put into t

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

2020-05-26 Thread Ladsgroup
Ladsgroup added a comment. I honestly think we should just drop wikibase codesniffer. We have been maintaining too much codebase. TASK DETAIL https://phabricator.wikimedia.org/T253624 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: