[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

[Addshore]

Addshore added a comment.


  In T253624#6165716 , 
@Ladsgroup wrote:
  
  > In T253624#6165674 , 
@Krinkle wrote:
  >
  >> Note that `phpcs` ruleset is controllable per repository. The same way 
that we disable some rules in repositories not yet ready to follow a newer 
convention, it is also possible to enable additional rules on a per-repo bases.
  >
  > I think the reason back then was that wikibase team maintains lots of repos 
instead of one or two (which is another can of worms) and if we want to, for 
example, enforce a different rule for our codebase, we have to change all phpcs 
files one by one.
  
  I think we could solve that with a package anyway (having it use a hook to 
write a file into the correct place).
  But having these rules that synced I believe is undesired.

TASK DETAIL
  https://phabricator.wikimedia.org/T253624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Krinkle, Ladsgroup, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, thiemowmde, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

[Ladsgroup]

Ladsgroup added a comment.


  In T253624#6165674 , 
@Krinkle wrote:
  
  > Note that `phpcs` ruleset is controllable per repository. The same way that 
we disable some rules in repositories not yet ready to follow a newer 
convention, it is also possible to enable additional rules on a per-repo bases.
  
  I think the reason back then was that wikibase team maintains lots of repos 
instead of one or two (which is another can of worms) and if we want to, for 
example, enforce a different rule for our codebase, we have to change all phpcs 
files one by one.
  
  My solution to this is to actually merge back libraries to our repos, which 
we has done in one or two cases already.

TASK DETAIL
  https://phabricator.wikimedia.org/T253624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Krinkle, Ladsgroup, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, thiemowmde, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

[Krinkle]

Krinkle added a comment.


  Note that `.phpcs` is controllable per repository. The same way that we 
disable some rules in repositories not yet ready to follow a newer convention, 
it is also possible to enable additional rules on a per-repo bases.
  
  So these rulesets could easily be put into the phpcs files of the 
repositories in question directly. If there are also PHP classes involved, we 
could ship those in mediawiki-codesniffer as off by default.
  
  If none of that's needed, that's obviously even better, but if it helps 
kick-start this transition, I think that would be fine :)

TASK DETAIL
  https://phabricator.wikimedia.org/T253624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Ladsgroup, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, thiemowmde, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

[Ladsgroup]

Ladsgroup added a comment.


  I honestly think we should just drop wikibase codesniffer. We have been 
maintaining too much codebase.

TASK DETAIL
  https://phabricator.wikimedia.org/T253624

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, thiemowmde, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs