[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the Wikidata-Campsite (Team A Hearth ) board. Lucas_Werkmeister_WMDE added a comment. As far as I can tell, this is all working. TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE closed subtask T301324: Uncaught Error: No Termbox root element found! on (Test) Wikidata mobile history pages as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.21; 2022-02-07); removed MW-1.38-notes (1.38.0-wmf.13; 2021-12-13). TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE moved this task from Peer Review to Tech Verification on the Wikidata-Campsite (Team A Hearth ) board. Lucas_Werkmeister_WMDE added a comment. The final stage should roll out with this week’s train (T300197 , I don’t think

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 757412 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Update Termbox (full Vue 3 migration) https://gerrit.wikimedia.org/r/757412 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 757504 **merged** by jenkins-bot: [wikibase/termbox@master] Update buildAndAttemptHydration for Vue 3 https://gerrit.wikimedia.org/r/757504 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 757659 **merged** by jenkins-bot: [operations/deployment-charts@master] Update termbox to 2022-01-25-175409-production https://gerrit.wikimedia.org/r/757659 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 757659 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [operations/deployment-charts@master] Update termbox to 2022-01-25-175409-production https://gerrit.wikimedia.org/r/757659 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 757504 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Update buildAndAttemptHydration for Vue 3 https://gerrit.wikimedia.org/r/757504 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE added subscribers: Tarrow, Jakob_WMDE. Lucas_Werkmeister_WMDE added a comment. > And I think we’ll want to make sure that this div is in the part of the HTML that doesn’t end up in the parser cache. I discussed this a bit with @Tarrow and it might be trickier than

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE added a comment. The above change doesn’t work properly yet: > Hydration completed but contains mismatches. (You can get more detailed messages with ?debug.) I think this is because of the changed mounting behavior in Vue 3. The SSR contains HTML like ``, and

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 757412 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Update Termbox (full Vue 3 migration) https://gerrit.wikimedia.org/r/757412 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Team A Hearth ) board. Lucas_Werkmeister_WMDE added a comment. Next up: update the submodule in Wikibase.git and the image in deployment-charts. TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753802 **merged** by jenkins-bot: [wikibase/termbox@master] Simplify server tsconfig https://gerrit.wikimedia.org/r/753802 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753801 **merged** by jenkins-bot: [wikibase/termbox@master] Rename Jest config globals.ts-jest.tsConfig to tsconfig https://gerrit.wikimedia.org/r/753801 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753800 **merged** by jenkins-bot: [wikibase/termbox@master] Merge buildApp functions again https://gerrit.wikimedia.org/r/753800 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753799 **merged** by jenkins-bot: [wikibase/termbox@master] Change propsData to props in tests https://gerrit.wikimedia.org/r/753799 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753798 **merged** by jenkins-bot: [wikibase/termbox@master] Remove no-longer-needed ts-ignore comments https://gerrit.wikimedia.org/r/753798 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753797 **merged** by jenkins-bot: [wikibase/termbox@master] Use Vue 3 at build time https://gerrit.wikimedia.org/r/753797 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 754550 **abandoned** by Lucas Werkmeister (WMDE): [wikibase/termbox@master] WIP: Use getSSRProps instead of directiveTransforms Reason: I just wanted to have this up on Gerrit, it’s not actually meant for review.

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 754550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] WIP: Use getSSRProps instead of directiveTransforms https://gerrit.wikimedia.org/r/754550 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753999 **merged** by jenkins-bot: [wikibase/termbox@master] Load all of @storybook/addon-essentials, not just docs https://gerrit.wikimedia.org/r/753999 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753976 **merged** by jenkins-bot: [wikibase/termbox@master] Avoid v-model in Checkbox story https://gerrit.wikimedia.org/r/753976 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753999 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Load all of @storybook/addon-essentials, not just docs https://gerrit.wikimedia.org/r/753999 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753976 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Avoid v-model in Checkbox story https://gerrit.wikimedia.org/r/753976 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753770 **merged** by jenkins-bot: [wikibase/termbox@master] Widen a few SSR-related types https://gerrit.wikimedia.org/r/753770 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753736 **merged** by jenkins-bot: [wikibase/termbox@master] Replace Vue.nextTick() with wrapper.vm.$nextTick() in tests https://gerrit.wikimedia.org/r/753736 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753735 **merged** by jenkins-bot: [wikibase/termbox@master] Prepare tests for Jest 27 https://gerrit.wikimedia.org/r/753735 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753710 **merged** by jenkins-bot: [wikibase/termbox@master] Move directives/ from src/client/ to src/ https://gerrit.wikimedia.org/r/753710 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753706 **merged** by jenkins-bot: [wikibase/termbox@master] Move directives and mixins to buildApp https://gerrit.wikimedia.org/r/753706 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753802 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Simplify server tsconfig https://gerrit.wikimedia.org/r/753802 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753801 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Rename Jest config globals.ts-jest.tsConfig to tsconfig https://gerrit.wikimedia.org/r/753801 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753800 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Merge buildApp functions again https://gerrit.wikimedia.org/r/753800 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753799 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Change propsData to props in tests https://gerrit.wikimedia.org/r/753799 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753798 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Remove no-longer-needed ts-ignore comments https://gerrit.wikimedia.org/r/753798 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753797 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Use Vue 3 at build time https://gerrit.wikimedia.org/r/753797 TASK DETAIL https://phabricator.wikimedia.org/T296202

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753770 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Widen a few SSR-related types https://gerrit.wikimedia.org/r/753770 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753736 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Replace Vue.nextTick() with wrapper.vm.$nextTick() in tests https://gerrit.wikimedia.org/r/753736 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753705 **merged** by jenkins-bot: [wikibase/termbox@master] Remove client/directives/index.ts https://gerrit.wikimedia.org/r/753705 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753735 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Prepare JestCustomEnvironment for Jest 27 https://gerrit.wikimedia.org/r/753735 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753710 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Move directives/ from src/client/ to src/ https://gerrit.wikimedia.org/r/753710 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753706 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Move directives and mixins to buildApp https://gerrit.wikimedia.org/r/753706 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 753705 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Remove client/directives/index.ts https://gerrit.wikimedia.org/r/753705 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE added a comment. Note: I neglected to add this task to several other recent Termbox changes; most of the commits between 502a4ed963660183233fa6ce8de0274612c84df9 and

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 745771 **merged** by jenkins-bot: [wikibase/termbox@master] Don\u2019t use v-on:.native in AliasesEdit https://gerrit.wikimedia.org/r/745771 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 745771 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [wikibase/termbox@master] Don\u2019t use v-on:.native in AliasesEdit https://gerrit.wikimedia.org/r/745771 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE added a comment. You’re right, they don’t seem to be working properly. Thanks for noticing! TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Catrope added a comment. We've noticed problems with `.native` event bindings not working with compiled Vue 2 code running in the Vue 3 migration build, see https://gerrit.wikimedia.org/r/c/wvui/+/745576 . The only two uses of `.native` that codesearch turned up were in WVUI (which that

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06). TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 744852 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Update Termbox (next stage of Vue 3 migration) https://gerrit.wikimedia.org/r/744852 TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

gerritbot added a comment. Change 744852 had a related patch set uploaded (by Catrope; author: Catrope): [mediawiki/extensions/Wikibase@master] Update Termbox (next stage of Vue 3 migration) https://gerrit.wikimedia.org/r/744852 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE closed subtask T297006: Migrate Termbox to Node 12 as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3

Lucas_Werkmeister_WMDE renamed this task from "Remove vue-class-components from Termbox" to "Migrate Termbox to Vue 3". Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES