[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Tacsipacsi added a comment. I don’t have concrete examples now, but categories that come to my mind where it’s common to have longer texts: - Monolingual texts (work titles, quotations, addresses, property usage instructions etc.) - Source text (scores, formulæ, regexes etc.) But

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel added a comment. Thank you @Tacsipacsi! Could you specify the cases where diffs for unstructured-string-valued statements would be particularly useful (you mentioned Commons categories before)? Based on your input I will then discuss with @Lucas_Werkmeister_WMDE to better understand

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Team A Hearth ). TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Manuel Cc: Capmo, Pamputt,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Tacsipacsi reopened this task as "Open". Tacsipacsi added a comment. Sorry, I somehow missed closing this ticket. The acceptance criterion was not met: the criterion mentions “textual fields”, not “terms and sitelinks”; textual statements are still missing. TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

matej_suchanek merged a task: T267297: Improve caption diffs in order to emphasize just the differences. matej_suchanek added subscribers: Pamputt, Capmo. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel closed this task as "Resolved". Manuel added a comment. This was now successfully deployed on Test Wikidata! TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Michael removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Michael Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel added a comment. I can confirm this behavior of WordLevelDiff on my local wiki as well. I never noticed! Digging into the class would undoubtedly be beyond the reasonable scope for this: Time to celebrate that we will soon have word-level diffs on Wikidata!! \o/ TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

karapayneWMDE added a project: Wikidata Dev Team (Sprint-♾). TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, karapayneWMDE Cc: Lucas_Werkmeister_WMDE, noarave, Stang,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18). TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. > Is there something we could do about it? Well, we could spend some time digging into the `WordLevelDiff` class, understanding how it works, trying to improve its behavior without breaking anything, and end up with something that will definitely

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel added a comment. Thank you @Tacsipacsi, this is indeed weird! @Lucas_Werkmeister_WMDE why would WordLevelDiff give results like that? This might not be intended. Is there something we could do about it? TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Tacsipacsi added a comment. It would still be important to be consistent within a wiki, including whitespace handling. These minor differences can be very hard to understand, much harder than the big differences like the current status quo of no word-level diffs (which doesn’t mean the

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel added a comment. Sounds good, thx! TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Manuel Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. I don’t think we should use wikidiff2, though. The inline diff functions don’t seem useful for us, since we want to show a side-by-side diff: >>> wikidiff2_inline_diff( 'This is a example', 'This is an example', 2 ) => """ \n

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. Ohhh, of course, wikitext diffs can use wikidiff2 or an external `diff` executable, not necessarily `WordLevelDiff`… TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. Hm, but on Beta , the space isn’t included in a wikitext word-level diff either. F35306077: image.png

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. Hm, on my local wiki I get this behavior for wikitext diffs as well: F35306037: image.png But not on Wikipedia

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel added a comment. Yay, looking great! :) One thing that I noticed: Unchanged spaces after a changed word are highlighted In the example diffs for some reason. This is not an issue for me, but I am still mentioning just in case, as it's different from how diffs work on Wikipedia.

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. Example diffs on Beta: - label and description - sitelink title TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board. Lucas_Werkmeister_WMDE added a comment. Should be verifiable on Beta soon; will only be deployed to production around July 20 (no

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810362 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for site link titles https://gerrit.wikimedia.org/r/810362 TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810361 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in SiteLinkDiffView https://gerrit.wikimedia.org/r/810361 TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810315 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for Labels/Description/Aliases https://gerrit.wikimedia.org/r/810315 TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE closed subtask T311224: Look into best way forward for word-level diff in Wikibase as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Tacsipacsi added a comment. In T303317#8044115 , @Lucas_Werkmeister_WMDE wrote: > […] diffing statements feels like more work to me, both to define (e.g. should we diff the labels of item values word by word, or just treat the whole

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810362 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for site link titles https://gerrit.wikimedia.org/r/810362 TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810361 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in SiteLinkDiffView https://gerrit.wikimedia.org/r/810361 TASK

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810302 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in BasicDiffView https://gerrit.wikimedia.org/r/810302 TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel added a comment. Good thinking! Yes, let's please diff the titles of sitelink changes as well! I don't want to increase complexity, let's not do the word-by-word diffs for statements for now. If the community wants this at some point, I will create another task for it. TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. In T303317#8043724 , @gerritbot wrote: > Change 810315 had a related patch set uploaded (by Noa wmde; author: Noa wmde): > > [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810315 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for Labels/Description/Aliases https://gerrit.wikimedia.org/r/810315 TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810302 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in BasicDiffView https://gerrit.wikimedia.org/r/810302 TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, noarave, Stang,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810017 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rename item diff related classes for clarity https://gerrit.wikimedia.org/r/810017 TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

gerritbot added a comment. Change 810017 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Rename item diff related classes for clarity https://gerrit.wikimedia.org/r/810017 TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE moved this task from Parents / Waiting to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board. Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T303317 WORKBOARD

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

karapayneWMDE moved this task from Tech backlog to Special:NewLexeme revival - sprint 11 on the Special:NewLexeme revival board. karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 11); removed Special:NewLexeme revival. TASK DETAIL

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

noarave added a comment. @Lucas_Werkmeister_WMDE I linked to this comment in the subtask so it doesn't escape us. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc:

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Lucas_Werkmeister_WMDE added a comment. > Make sure to consider whether the core class WordLevelDiff is marked as "newable", meaning that we are able to instantiate it outside of core WordLevelDiff was last substantially changed in 2016, so it predates the stable interface policy

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

ItamarWMDE added a comment. **Task Breakdown Notes** - If any subtasks are created, they should be created in the currently running sprint board, to be picked up there. - The classes might be involved in detecting merge conflicts, so we might need to tread carefully - We should

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

karapayneWMDE set the point value for this task to "13". TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

karapayneWMDE added a project: Special:NewLexeme revival. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

Manuel renamed this task from "Do word-level diff on textual fields in Wikibase diffs" to "Show word-level diff on textual fields in Wikibase diffs". Manuel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES