subject:"\[Wikidata\-bugs\] \[Maniphest\] T303317\: Show word\-level diff on textual fields in Wikibase diffs"

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-12-12 Thread Tacsipacsi

Tacsipacsi added a comment.


  I don’t have concrete examples now, but categories that come to my mind where 
it’s common to have longer texts:
  
  - Monolingual texts (work titles, quotations, addresses, property usage 
instructions etc.)
  - Source text (scores, formulæ, regexes etc.)
  
  But it can be particularly useful for Commons category names, file names, 
author names etc. as well if only a tiny typo was fixed in a longer name.
  
  
  
  I realized that “textual fields” criterion is not very specific; I think the 
specific criterion could be //terms, sitelinks and snaks with value types 
`string` and `monolingualtext`// (of which terms and sitelinks are already 
done). Looking at the list of data types 
, all `string`- and 
`monolingualtext`-valued data types could all more or less benefit from 
word-level diffs (likely formulæ more and external identifiers less, but it may 
happen that external IDs are multi-word, and it’s probably easier anyway to 
implement it for all `string`-valued data types than only for some of them).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Tacsipacsi
Cc: Capmo, Pamputt, Lucas_Werkmeister_WMDE, noarave, Lydia_Pintscher, Manuel, 
Addshore, ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-12-12 Thread Manuel

Manuel added a comment.


  Thank you @Tacsipacsi! Could you specify the cases where diffs for 
unstructured-string-valued statements would be particularly useful (you 
mentioned Commons categories before)? Based on your input I will then discuss 
with @Lucas_Werkmeister_WMDE to better understand what complexity this would 
add and how to best operationalize it in our process.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Capmo, Pamputt, Lucas_Werkmeister_WMDE, noarave, Lydia_Pintscher, Manuel, 
Addshore, ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-12-12 Thread Manuel

Manuel edited projects, added Wikidata-Campsite; removed Wikidata-Campsite 
(Team A Hearth ).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Capmo, Pamputt, Lucas_Werkmeister_WMDE, noarave, Lydia_Pintscher, Manuel, 
Addshore, ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-12-11 Thread Tacsipacsi

Tacsipacsi reopened this task as "Open".
Tacsipacsi added a comment.


  Sorry, I somehow missed closing this ticket. The acceptance criterion was not 
met: the criterion mentions “textual fields”, not “terms and sitelinks”; 
textual statements are still missing.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Tacsipacsi
Cc: Capmo, Pamputt, Lucas_Werkmeister_WMDE, noarave, Lydia_Pintscher, Manuel, 
Addshore, ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-22 Thread matej_suchanek

matej_suchanek merged a task: T267297: Improve caption diffs in order to 
emphasize just the differences.
matej_suchanek added subscribers: Pamputt, Capmo.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, matej_suchanek
Cc: Capmo, Pamputt, Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, 
Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-20 Thread Manuel

Manuel closed this task as "Resolved".
Manuel added a comment.


  This was now successfully deployed 
 on 
Test Wikidata!

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-15 Thread Michael

Michael removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Hellket777, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-13 Thread Manuel

Manuel added a comment.


  I can confirm this behavior of WordLevelDiff on my local wiki as well. I 
never noticed! 
  Digging into the class would undoubtedly be beyond the reasonable scope for 
this:
  
  Time to celebrate that we will soon have word-level diffs on Wikidata!! \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-12 Thread karapayneWMDE

karapayneWMDE added a project: Wikidata Dev Team (Sprint-♾).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, karapayneWMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-11 Thread ReleaseTaggerBot

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-11 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  > Is there something we could do about it?
  
  Well, we could spend some time digging into the `WordLevelDiff` class, 
understanding how it works, trying to improve its behavior without breaking 
anything, and end up with something that will definitely still behave 
differently from wikidiff2 in some details. I don’t think that would be worth 
it. The current `WordLevelDiff` is considered good enough for wikitext diffs on 
a standard MediaWiki install, after all (since the wikidiff2 extension isn’t 
usually installed, I assume).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-08 Thread Manuel

Manuel added a comment.


  Thank you @Tacsipacsi, this is indeed weird!
  
  @Lucas_Werkmeister_WMDE why would WordLevelDiff give results like that? This 
might not be intended. Is there something we could do about it?

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-08 Thread Tacsipacsi

Tacsipacsi added a comment.


  It would still be important to be consistent within a wiki, including 
whitespace handling. These minor differences can be very hard to understand, 
much harder than the big differences like the current status quo of no 
word-level diffs (which doesn’t mean the word-level diffs are not worth it!). 
Also, it seems to not only //include// the unchanged whitespace after a word, 
but also //exclude// the //changed// whitespace before a word, e.g. here 
 it 
ignored the space before the parenthesis.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Tacsipacsi
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Manuel

Manuel added a comment.


  Sounds good, thx!

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  I don’t think we should use wikidiff2, though. The inline diff functions 
don’t seem useful for us, since we want to show a side-by-side diff:
  
>>> wikidiff2_inline_diff( 'This is a example', 'This is an example', 2 )
=> """
   \n
   This is aan 
example\n
   """
  
>>> wikidiff2_inline_json_diff( 'This is a example', 'This is an example', 
2 )
=> "{"diff": [{"type": 3, "lineNumber": 1, "text": "This is aan example", 
"offset": {"from": 0,"to": 0}, "highlightRanges": [{"start": 8, "length": 1, 
"type": 1 },{"start": 9, "length": 2, "type": 0 }]}]}"
  
  And the regular diff contains too much extra HTML that we’d have to strip out 
again (the `` numbers get localized later 
,
 but make no sense in our context):
  
>>> wikidiff2_do_diff( 'This is a example', 'This is an example', 2 )
=> """
   \n
 \n
 \n
   \n
   \n
 \n
 This is a example\n
 \n
 This is an example\n
   \n
   """
  
  Let’s just stick to `WordLevelDiff` for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Ohhh, of course, wikitext diffs can use wikidiff2 
 or an external `diff` executable, 
not necessarily `WordLevelDiff`…

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Hm, but on Beta 
,
 the space isn’t included in a wikitext word-level diff either.
  F35306077: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Hm, on my local wiki I get this behavior for wikitext diffs as well:
  F35306037: image.png 
  But not on Wikipedia 
:
  F35306047: image.png 
  Not sure what’s going on here…

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Manuel

Manuel added a comment.


  Yay, looking great! :)
  
  One thing that I noticed: Unchanged spaces after a changed word are 
highlighted In the example diffs for some reason. This is not an issue for me, 
but I am still mentioning just in case, as it's different from how diffs work 
on Wikipedia.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Example diffs on Beta:
  
  - label and description 

  - sitelink title 


TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) 
on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE added a comment.


  Should be verifiable on Beta soon; will only be deployed to production around 
July 20 (no deployment train next week).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread gerritbot

gerritbot added a comment.


  Change 810362 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for site link titles
  
  https://gerrit.wikimedia.org/r/810362

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread gerritbot

gerritbot added a comment.


  Change 810361 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in 
SiteLinkDiffView
  
  https://gerrit.wikimedia.org/r/810361

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread gerritbot

gerritbot added a comment.


  Change 810315 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for 
Labels/Description/Aliases
  
  https://gerrit.wikimedia.org/r/810315

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE closed subtask T311224: Look into best way forward for 
word-level diff in Wikibase as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-02 Thread Tacsipacsi

Tacsipacsi added a comment.


  In T303317#8044115 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > […] diffing statements feels like more work to me, both to define (e.g. 
should we diff the labels of item values word by word, or just treat the whole 
thing as one change, because after all the whole item value was changed to a 
different ID?) and to implement.
  
  
  
  In T303317#8044185 , 
@Manuel wrote:
  
  > I don't want to increase complexity, let's not do the word-by-word diffs 
for statements for now.
  
  Word-by-word diffs for entity-typed statements (or sitelink badges) make 
little sense, but I’d like to have them for unstructured-string-valued 
statements as well—see the Commons category in the screenshot. Of course, if 
it’s way more difficult, I’d be happy if word-by-word diffs for terms and 
sitelinks rolled out for now, but I’d like this ticket not to be resolved until 
textual statements have word-by-word diffs as well (or create a new task and 
close this one if that better fits your workflow).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Tacsipacsi
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a comment.


  Change 810362 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for site link titles
  
  https://gerrit.wikimedia.org/r/810362

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a comment.


  Change 810361 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in 
SiteLinkDiffView
  
  https://gerrit.wikimedia.org/r/810361

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a comment.


  Change 810302 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in 
BasicDiffView
  
  https://gerrit.wikimedia.org/r/810302

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread Manuel

Manuel added a comment.


  Good thinking! Yes, let's please diff the titles of sitelink changes as well! 
I don't want to increase complexity, let's not do the word-by-word diffs for 
statements for now.  If the community wants this at some point, I will create 
another task for it.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Manuel
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.

  In T303317#8043724 , 
@gerritbot wrote:

  > Change 810315 had a related patch set uploaded (by Noa wmde; author: Noa 
wmde):
  >
  > [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for 
Labels/Description/Aliases
  >
  > https://gerrit.wikimedia.org/r/810315

  This implements word-level diffs for the contents of labels, descriptions, 
and aliases. I think diffing the titles of sitelink changes would also be 
fairly doable; diffing statements feels like more work to me, both to define 
(should we diff the labels of item values word by word, or just treat the whole 
thing as one change, because after all the whole item value was changed to a 
different ID) and to implement. Should either of those be part of this task as 
well?

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a comment.


  Change 810315 had a related patch set uploaded (by Noa wmde; author: Noa 
wmde):
  
  [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for 
Labels/Description/Aliases
  
  https://gerrit.wikimedia.org/r/810315

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a comment.


  Change 810302 had a related patch set uploaded (by Noa wmde; author: Noa 
wmde):
  
  [mediawiki/extensions/Wikibase@master] Prepare switching to WordLevelDiff in 
BasicDiffView
  
  https://gerrit.wikimedia.org/r/810302

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread Maintenance_bot

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, 
Hellket777, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread gerritbot

gerritbot added a comment.


  Change 810017 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Rename item diff related classes for 
clarity
  
  https://gerrit.wikimedia.org/r/810017

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-30 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-30 Thread gerritbot

gerritbot added a comment.


  Change 810017 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Rename item diff related classes for 
clarity
  
  https://gerrit.wikimedia.org/r/810017

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-30 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE moved this task from Parents / Waiting to Doing on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-28 Thread karapayneWMDE

karapayneWMDE moved this task from Tech backlog to Special:NewLexeme revival - 
sprint 11 on the Special:NewLexeme revival board.
karapayneWMDE edited projects, added Special:NewLexeme revival 
(Special:NewLexeme revival - sprint 11); removed Special:NewLexeme revival.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5674/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-23 Thread noarave

noarave added a comment.


  @Lucas_Werkmeister_WMDE I linked to this comment in the subtask so it doesn't 
escape us.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-23 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  > Make sure to consider whether the core class WordLevelDiff is marked as 
"newable", meaning that we are able to instantiate it outside of core
  
  WordLevelDiff was last substantially changed in 2016, so it predates the 
stable interface policy (created beginning of 2017). To me it seems plausible 
that marking it newable was simply not done yet, but there wouldn’t be any 
reasons not to do it either. (Alternatively, `TableDiffFormatter` is already 
newable and uses `WordLevelDiff`; we might be able to use `TableDiffFormatter`.)

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-23 Thread ItamarWMDE

ItamarWMDE added a comment.


  **Task Breakdown Notes**
  
  - If any subtasks are created, they should be created in the currently 
running sprint board, to be picked up there.
  - The classes might be involved in detecting merge conflicts, so we might 
need to tread carefully
  - We should probably try to work our way from `BasicDiffView` and 
`ItemDiffView` and see what we need to change along the line, but avoid 
touching the merge and conflict resolution functionalities. i.e. the way the 
diff is programmatically represented should probably not be touched.
  - We can use `WordLevelDiff` to try and achieve the acceptance criteria, but 
in case we need to extend or modify it, we should consider the MediaWiki Stable 
Interface Policy [TODO: Link to SIP]
  - Make sure to consider whether the core class `WordLevelDiff` is marked as 
"newable" 
,
 meaning that we are able to instantiate it outside of core
  
  **Understanding the topic Better**
  
  - Figure out where we use `WordLevelDiff`, but also consider alternative 
solutions to understand our way forward. [Create some investigative task]
  - The investigation should focus on `WordLevelDiff` and our possibilities to 
use it, or, if need be, modifying it, so we could use it.
  - It appears the Tech wishes is using it, so asking Adam or Svantje might be 
a good option.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-14 Thread karapayneWMDE

karapayneWMDE set the point value for this task to "13".

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-14 Thread karapayneWMDE

karapayneWMDE added a project: Special:NewLexeme revival.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-05-04 Thread Manuel

Manuel renamed this task from "Do word-level diff on textual fields in Wikibase 
diffs" to "Show word-level diff on textual fields in Wikibase diffs".
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

46 matches

Mail list logo