[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE assigned this task to ArthurTaylor. Lucas_Werkmeister_WMDE added a comment. The

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ArthurTaylor removed ArthurTaylor as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: ArthurTaylor, Lydia_Pintscher, Milimetric, ArielGlenn, BTullis,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. The lexeme part of this looks good to me, I’m seeing `"senses":[]` and `"forms":[]` in curl -s 'https://dumps.wikimedia.org/wikidatawiki/entities/latest-lexemes.json.gz' | gunzip | grep -E --color=yes '"(forms|senses)":[[{][]}]' | head -25

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.17; 2024-02-06); removed MW-1.42-notes (1.42.0-wmf.18; 2024-02-13). TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Maintenance_bot Cc: Lydia_Pintscher, Milimetric, ArielGlenn, BTullis, xcollazo,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. This is deployed now and should take effect with the next dumps; I did some tests on mwdebug2002, and as far as I can tell, lexemes are indeed fixed (`"senses": []`) while items didn’t regress (`"claims": {}`). TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2024-02-12T16:22:42Z] lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:1002431|Disable JSON Dump tests to prepare for schema change in Wikibase (T305660 )]],

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2024-02-12T16:14:22Z] lucaswerkmeister-wmde@deploy2002 lucaswerkmeister-wmde: Backport for [[gerrit:1002431|Disable JSON Dump tests to prepare for schema change in Wikibase (T305660

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2024-02-12T16:12:59Z] lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:1002431|Disable JSON Dump tests to prepare for schema change in Wikibase (T305660 )]],

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 1002433 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@wmf/1.42.0-wmf.17] Change expected serialization format of JSON dumps to include arrays https://gerrit.wikimedia.org/r/1002433 TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 1002432 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.42.0-wmf.17] Return stdClass/Object from Serializers for empty lists https://gerrit.wikimedia.org/r/1002432 TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 1002431 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@wmf/1.42.0-wmf.17] Disable JSON Dump tests to prepare for schema change in Wikibase https://gerrit.wikimedia.org/r/1002431 TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 1002433 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Arthur taylor): [mediawiki/extensions/WikibaseLexeme@wmf/1.42.0-wmf.17] Change expected serialization format of JSON dumps to include arrays

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 1002432 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Arthur taylor): [mediawiki/extensions/Wikibase@wmf/1.42.0-wmf.17] Return stdClass/Object from Serializers for empty lists https://gerrit.wikimedia.org/r/1002432 TASK

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, gerritbot Cc: Lydia_Pintscher, Milimetric, ArielGlenn, BTullis, xcollazo, JEbe-WMF,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 1002431 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Arthur taylor): [mediawiki/extensions/WikibaseLexeme@wmf/1.42.0-wmf.17] Disable JSON Dump tests to prepare for schema change in Wikibase

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Maintenance_bot Cc: Lydia_Pintscher, Milimetric, ArielGlenn, BTullis, xcollazo,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13). TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, ReleaseTaggerBot Cc: Lydia_Pintscher, Milimetric,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 983159 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Change expected serialization format of JSON dumps to include arrays https://gerrit.wikimedia.org/r/983159 TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 983162 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Added strict type and type info to modified files. https://gerrit.wikimedia.org/r/983162 TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 982847 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Return stdClass/Object from Serializers for empty lists https://gerrit.wikimedia.org/r/982847 TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 983081 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Disable JSON Dump tests to prepare for schema change in Wikibase https://gerrit.wikimedia.org/r/983081 TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE changed the task status from "Stalled" to "Open". Lucas_Werkmeister_WMDE moved this task from Waiting for Deployment Window to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. Unstalling, and I’ve

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE changed the task status from "Open" to "Stalled". Lucas_Werkmeister_WMDE added a comment. The announcement says that we’ll deploy this on 8 February

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Mohammed_Sadat_WMDE added a comment. That sounds good to me. Let's prepare an announcement to send out tomorrow. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lydia_Pintscher added a comment. From my side this is good. @Mohammed_Sadat_WMDE What do you say? TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lydia_Pintscher Cc:

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. Alright, then we just need to settle the timing I think. The lexeme JSON dumps run each Wednesday (per Puppet ), and

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lydia_Pintscher added a comment. I don't think we can invest the time right now to do the test dumps, so let's deploy it even if it can't be tested on Test Wikidata unfortunately. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. I think the code is ready and we need a product decision – do we (ask WMF to) set up dumps for Test Wikidata, so we can first roll out the change there? Or do we just announce this and then (after 1 week, 2 weeks, whatever) deploy it to Wikidata for

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. Made a separate task for that: T355127: Add entity dumps to Wikidata Stable Interface Policy TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lydia_Pintscher added a comment. Yeah I'd say this is an oversight and they should be considered stable. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Lydia_Pintscher Cc:

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. In T305660#9435980 , @xcollazo wrote: > It is also my interpretation that the Stable Interface Policy applies to wikidata.org and

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE closed subtask T353626: Remove OPTION_OBJECTS_FOR_MAPS flag from SerializerFactory (dead code) as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. In T305660#9452899 , @ArthurTaylor wrote: > After removing the (used) OPTION_USE_OBJECTS_FOR_MAPS (per T353626 ), I looked at what it would mean to just

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ArthurTaylor added a comment. After removing the (used) OPTION_USE_OBJECTS_FOR_MAPS (per T353626 ), I looked at what it would mean to just apply OPTION_USE_OBJECTS_FOR_EMPTY_MAPS change globally (and thereby simply eliminate the need for the

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. In T305660#9435980 , @xcollazo wrote: >> Additionally, we are exploring the feasibility of making the fixed dumps available for testing on test.wikidata.org > > Is there any use for the

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

xcollazo added a comment. > Since you're involved in generating the dumps, we would appreciate hearing your thoughts before moving forward. I have no objection in fixing what you folks all agree is a bug. It is also my interpretation that the Stable Interface Policy

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Mohammed_Sadat_WMDE added subscribers: JEbe-WMF, xcollazo, BTullis, ArielGlenn, Milimetric. Mohammed_Sadat_WMDE added a comment. @ArielGlenn, @BTullis, @Milimetric, @JEbe-WMF, @xcollazo: Apologies if you've received notifications elsewhere. We are planning to address the issue of how empty

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Arian_Bozorg added a comment. Let's wait for the response from the people pinged before we move ahead on this. cc: @masssly TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Arian_Bozorg added a subscriber: Masssly. Arian_Bozorg added a comment. Thanks everyone, I think Michael's option works well for us here. @Masssly will be in touch with the people working dumps tomorrow. And we can turn on the config option before so that they can see how it can affect them.

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. In T305660#9410130 , @Michael wrote: > Alternatively, how did we handle this in T138104 or T241422 ? Or is

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Michael added a subtask: T353626: Remove OPTION_OBJECTS_FOR_MAPS flag from SerializerFactory (dead code). TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Michael Cc: Michael,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ArthurTaylor added a comment. @Arian_Bozorg re. your comment above - how do you want to proceed here? If we consider this a breaking change, we would need to selectively enable the functionality, and need to setup JSON dumps on testwiki. If we don't consider this a breaking change I guess

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Michael added a comment. In T305660#9409689 , @Lucas_Werkmeister_WMDE wrote: > In T305660#9349563 , @Arian_Bozorg wrote: > >> Before completing this we must consider: >> >> -

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Lucas_Werkmeister_WMDE added a comment. In T305660#9349563 , @Arian_Bozorg wrote: > Before completing this we must consider: > > - Stable interface policy > - Linked

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 983081 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/WikibaseLexeme@master] Disable JSON Dump tests to prepare for schema change in Wikibase https://gerrit.wikimedia.org/r/983081 TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 983162 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@master] Added strict type and type info to modified files https://gerrit.wikimedia.org/r/983162 TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 983159 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/WikibaseLexeme@master] Change expected serialization format of JSON dumps to include arrays https://gerrit.wikimedia.org/r/983159 TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, gerritbot Cc: Michael, Arian_Bozorg, Pintoch, Lucas_Werkmeister_WMDE, Ivan_A_Krestinin,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

gerritbot added a comment. Change 982847 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@master] WIP Return stdClass/Object from Serializers for empty lists https://gerrit.wikimedia.org/r/982847 TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ArthurTaylor claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: Michael, Arian_Bozorg, Pintoch, Lucas_Werkmeister_WMDE, Ivan_A_Krestinin, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: Michael, Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Michael, Arian_Bozorg, Pintoch, Lucas_Werkmeister_WMDE, Ivan_A_Krestinin,

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

Arian_Bozorg added a comment. Before completing this we must consider: - Stable interface policy - Linked data interface TASK DETAIL

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ItamarWMDE moved this task from Radar to [DOT] By Project on the wmde-wikidata-tech board. ItamarWMDE added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T305660 WORKBOARD https://phabricator.wikimedia.org/project/board/5864/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T305660: [LEX] Empty senses/forms lists presentation in dump

ItamarWMDE renamed this task from "Empty senses/forms lists presentation in dump" to "[LEX] Empty senses/forms lists presentation in dump". TASK DETAIL https://phabricator.wikimedia.org/T305660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: