[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 803918 **merged** by jenkins-bot:
  
  [mediawiki/core@master] Revert "phpunit: Default to vendor/bin/phpunit, 
remove suites.xml"
  
  https://gerrit.wikimedia.org/r/803918

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 803918 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/core@master] Revert "phpunit: Default to vendor/bin/phpunit, 
remove suites.xml"
  
  https://gerrit.wikimedia.org/r/803918

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh 
kostajh added a comment.


  In T310255#7991842 , 
@kostajh wrote:
  
  > In T310255#7991676 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >> Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test 
already, both by location (`tests/phpunit/structure/`) and type (`extends 
MediaWikiIntegrationTestCase`).
  >>
  >> But I guess the data providers are evaluated before the 
`onUnitTestsAfterDatabaseSetup()` hook runs 
  >>
  >> I’m actually not sure how this would’ve worked before.
  >
  > Something I observed before the vendor/bin/phpunit switch is that data 
providers with exceptions would silently fail, and thus the test wouldn't run 
at all. But that doesn't seem to be the case here.
  >
  > In T310255#7991644 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >>> I think we’re now running anything that claims to be a unit test against 
the real database of the wiki
  >>
  >> Confirmed:
  >>
  >> name=tests/phpunit/unit/includes/LucasTest.php
  >>   >   
  >>   class LucasTest extends \PHPUnit\Framework\TestCase {
  >>   
  >>public function testDatabaseAccess(): void {
  >>var_dump( wfGetDB( DB_PRIMARY )->selectRow(
  >>'recentchanges',
  >>[ 'rc_title', 'rc_timestamp' ],
  >>'',
  >>__METHOD__,
  >>[
  >>'LIMIT' => 1,
  >>'ORDER BY' => 'rc_timestamp DESC',
  >>]
  >>) );
  >>}
  >>   
  >>   }
  >>
  >>
  >>
  >>   $ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
  >>   Using PHP 8.1.2
  >>   PHPUnit 8.5.26 #StandWithUkraine
  >>   
  >>   LucasTest
  >>☢ testDatabaseAccess
  >>   /var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
  >>   class stdClass#876 (2) {
  >> public $rc_title =>
  >> string(21) "Page_with_1000_commas"
  >> public $rc_timestamp =>
  >> string(14) "20220604150204"
  >>   }
  >>
  >> “Page with 1000 commas” is indeed the latest recentchanges entry on my 
local wiki, from 2022-06-04. This test is accessing the real wiki database. In 
my opinion, **this should never happen** – integration tests should have the 
test DB, and for unit tests, database access should fail.
  >
  > Unit (as opposed to integration) tests need to run with a separate 
bootstrap file. Can you test with `vendor/bin/phunit --bootstrap 
tests/phpunit/bootstrap.php tests/phpunit/unit/includes/LucasTest.php` ? That 
is what `composer phpunit:unit` is using.
  
  @Lucas_Werkmeister_WMDE there's another test to fix as well, see 
https://integration.wikimedia.org/ci/job/wikibase-client-docker/28093/console:
  
13:03:46 INFO:quibble.commands:php tests/phpunit/phpunit.php --verbose 
--log-junit "$LOG_DIR/junit-wikibase-client.xml" --group Wikibase,WikibaseClient
13:03:46 Using PHP 7.3.33-1+0~2029.91+debian10~1.gbp618351
13:03:46 PHP Deprecated:  tests/phpunit/phpunit.php is deprecated and will 
be removed. Please use `composer phpunit` or `vendor/bin/phpunit` [Called from 
unknown in /workspace/src/tests/phpunit/phpunit.php at line 75] in 
/workspace/src/includes/debug/MWDebug.php on line 381
13:03:46 Deprecated: tests/phpunit/phpunit.php is deprecated and will be 
removed. Please use `composer phpunit` or `vendor/bin/phpunit` [Called from 
unknown in /workspace/src/tests/phpunit/phpunit.php at line 75] in 
/workspace/src/includes/debug/MWDebug.php on line 381
13:03:48 [e70351983cbb3759ca54c6bb] [no req]   Exception: entitySources 
must be configured for non-repo client wikis
13:03:48 Backtrace:
13:03:48 from 
/workspace/src/extensions/Wikibase/client/config/WikibaseClient.default.php(211)
13:03:48 #0 
/workspace/src/extensions/Wikibase/lib/includes/SettingsArray.php(68): 
Wikibase\Lib\WikibaseSettings::{closure}(Wikibase\Lib\SettingsArray)
13:03:48 #1 
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(433):
 Wikibase\Lib\SettingsArray->getSetting(string)
13:03:48 #2 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447): 
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
13:03:48 #3 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416): 
Wikimedia\Services\ServiceContainer->createService(string)
13:03:48 #4 /workspace/src/includes/MediaWikiServices.php(295): 
Wikimedia\Services\ServiceContainer->getService(string)
13:03:48 #5 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(424): 
MediaWiki\MediaWikiServices->getService(string)
13:03:48 #6 
/workspace/src/extensions/Wikibase/client/includes/WikibaseClient.php(123): 
Wikimedia\Services\ServiceContainer->get(string)
13:03:48 #7

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh 
kostajh added a comment.


  Let's see if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804319 and 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/804283 work, 
otherwise we should revert 
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/741970 (cc @Krinkle).

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 804319 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/core@master] DevelopmentSettings: Set CentralAuthDatabase to main 
DB name
  
  https://gerrit.wikimedia.org/r/804319

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 804305 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/core@master] phpunit: Temporary revert entrypoint to phpunit.php
  
  https://gerrit.wikimedia.org/r/804305

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh 
kostajh added a comment.


  In T310255#7991664 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T310255#7991620 , 
@gerritbot wrote:
  >
  >> Change 804283 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  >>
  >> [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  >>
  >> https://gerrit.wikimedia.org/r/804283
  >
  > Ugh, this doesn’t work yet because there’s one more warning (and those also 
make gate-and-submit fail):
  >
  >   PHPUnit\Framework\WarningTestCase
  >⚠ Warning
  >  │
  >  │ The data provider specified for ApiStructureTest::testParameters is 
invalid.
  >  │ Wikimedia\Rdbms\DBConnectionError: Cannot access the database: 
Access denied for user 'wikiuser'@'localhost' to database 'centralauth' 
(localhost:/workspace/db/quibble-mysql-wc4x6073/socket)
  >  │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465
  >  │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958
  >  │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931
  >  │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65
  >  │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:270
  >  │ 
/workspace/src/extensions/CentralAuth/includes/GlobalGroup/GlobalGroupLookup.php:56
  >  │ 
/workspace/src/extensions/CentralAuth/includes/Api/ApiQueryGlobalAllUsers.php:273
  >  │ /workspace/src/includes/api/ApiBase.php:1782
  >  │ /workspace/src/tests/phpunit/structure/ApiStructureTest.php:175
  >  │ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
  >
  > This is a unit test in core… should it also be an integration test? It 
tests that the parameter definitions of API modules are valid, and in 
CentralAuth that requires accessing the database so that the defined groups can 
be used for the `group` and `excludegroup` params. (Presumably, other APIs do 
something similar for `tags` parameters, that just doesn’t produce an error 
because the `change_tag_def` table would exist in the real wiki.)
  
  If anyone is able to reproduce this error locally, please let me know. So far 
I haven't been able to, with the same set of extensions as CI.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh 
kostajh added a comment.


  In T310255#7991676 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test 
already, both by location (`tests/phpunit/structure/`) and type (`extends 
MediaWikiIntegrationTestCase`).
  >
  > But I guess the data providers are evaluated before the 
`onUnitTestsAfterDatabaseSetup()` hook runs 
  >
  > I’m actually not sure how this would’ve worked before.
  
  Something I observed before the vendor/bin/phpunit switch is that data 
providers with exceptions would silently fail, and thus the test wouldn't run 
at all. Is it possible that ApiStructureTest did not run in CI prior to T90875 
?
  
  In T310255#7991644 , 
@Lucas_Werkmeister_WMDE wrote:
  
  >> I think we’re now running anything that claims to be a unit test against 
the real database of the wiki
  >
  > Confirmed:
  >
  > name=tests/phpunit/unit/includes/LucasTest.php
  >  
  >   class LucasTest extends \PHPUnit\Framework\TestCase {
  >   
  > public function testDatabaseAccess(): void {
  > var_dump( wfGetDB( DB_PRIMARY )->selectRow(
  > 'recentchanges',
  > [ 'rc_title', 'rc_timestamp' ],
  > '',
  > __METHOD__,
  > [
  > 'LIMIT' => 1,
  > 'ORDER BY' => 'rc_timestamp DESC',
  > ]
  > ) );
  > }
  >   
  >   }
  >
  >
  >
  >   $ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
  >   Using PHP 8.1.2
  >   PHPUnit 8.5.26 #StandWithUkraine
  >   
  >   LucasTest
  >☢ testDatabaseAccess
  >   /var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
  >   class stdClass#876 (2) {
  > public $rc_title =>
  > string(21) "Page_with_1000_commas"
  > public $rc_timestamp =>
  > string(14) "20220604150204"
  >   }
  >
  > “Page with 1000 commas” is indeed the latest recentchanges entry on my 
local wiki, from 2022-06-04. This test is accessing the real wiki database. In 
my opinion, **this should never happen** – integration tests should have the 
test DB, and for unit tests, database access should fail.
  
  Unit (as opposed to integration) tests need to run with a separate bootstrap 
file. Can you test with `vendor/bin/phunit --bootstrap 
tests/phpunit/bootstrap.php tests/phpunit/unit/includes/LucasTest.php` ? That 
is what `composer phpunit:unit` is using.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Nikerabbit 
Nikerabbit added subscribers: ngkountas, Nikerabbit.
Nikerabbit added a comment.


  We also observed the ApiStructureTest failure for ContentTranslation.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikerabbit
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, 
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, 
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test 
already, both by location (`tests/phpunit/structure/`) and type (`extends 
MediaWikiIntegrationTestCase`).
  
  But I guess the data providers are evaluated before the 
`onUnitTestsAfterDatabaseSetup()` hook runs 
  
  I’m actually not sure how this would’ve worked before.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T310255#7991620 , 
@gerritbot wrote:
  
  > Change 804283 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  >
  > [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  >
  > https://gerrit.wikimedia.org/r/804283
  
  Ugh, this doesn’t work yet because there’s one more warning (and those also 
make gate-and-submit fail):
  
PHPUnit\Framework\WarningTestCase
 ⚠ Warning
   │
   │ The data provider specified for ApiStructureTest::testParameters is 
invalid.
   │ Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access 
denied for user 'wikiuser'@'localhost' to database 'centralauth' 
(localhost:/workspace/db/quibble-mysql-wc4x6073/socket)
   │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465
   │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958
   │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931
   │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65
   │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:270
   │ 
/workspace/src/extensions/CentralAuth/includes/GlobalGroup/GlobalGroupLookup.php:56
   │ 
/workspace/src/extensions/CentralAuth/includes/Api/ApiQueryGlobalAllUsers.php:273
   │ /workspace/src/includes/api/ApiBase.php:1782
   │ /workspace/src/tests/phpunit/structure/ApiStructureTest.php:175
   │ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
  
  This is a unit test in core… should it also be an integration test? It tests 
that the parameter definitions of API modules are valid, and in CentralAuth 
that requires accessing the database so that the defined groups can be used for 
the `group` and `excludegroup` params. (Presumably, other APIs do something 
similar for `tags` parameters, that just doesn’t produce an error because the 
`change_tag_def` table would exist in the real wiki.)

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Prior to 7238dff532 
,
 that test produces the following error:
  
Premature access to service container [Called from wfGetDB in 
/var/www/html/wiki1/includes/GlobalFunctions.php at line 1945]

/var/www/html/wiki1/includes/debug/MWDebug.php:381
/var/www/html/wiki1/includes/debug/MWDebug.php:352
/var/www/html/wiki1/includes/GlobalFunctions.php:795
/var/www/html/wiki1/includes/MediaWikiServices.php:278
/var/www/html/wiki1/includes/GlobalFunctions.php:1945
/var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:6

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > I think we’re now running anything that claims to be a unit test against 
the real database of the wiki
  
  Confirmed:
  
  name=tests/phpunit/unit/includes/LucasTest.php
selectRow(
'recentchanges',
[ 'rc_title', 'rc_timestamp' ],
'',
__METHOD__,
[
'LIMIT' => 1,
'ORDER BY' => 'rc_timestamp DESC',
]
) );
}

}
  
  
  
$ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
Using PHP 8.1.2
PHPUnit 8.5.26 #StandWithUkraine

LucasTest
 ☢ testDatabaseAccess
/var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
class stdClass#876 (2) {
  public $rc_title =>
  string(21) "Page_with_1000_commas"
  public $rc_timestamp =>
  string(14) "20220604150204"
}
  
  “Page with 1000 commas” is indeed the latest recentchanges entry on my local 
wiki, from 2022-06-04. This test is accessing the real wiki database. In my 
opinion, this should never happen – integration tests should have the test DB, 
and for unit tests, database access should fail.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 804283 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to 
integration tests
  
  https://gerrit.wikimedia.org/r/804283

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh 
kostajh added a comment.


  In T310255#7991592 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Okay, CentralAuth sets up its database in 
`UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only 
run by `MediaWikiIntegrationTestCase::setupTestDB()`. `ApiFormatReferenceTest` 
and `QuerySearchEntitiesTest` are nominally unit tests, not integration tests, 
so the database doesn’t get set up, but then CentralAuth still runs as if it’s 
in an integration test.
  >
  > I think the correct solution here is to declare those tests as integration 
tests.
  
  +1, that makes sense to me.
  
  As for the general problem about separate unit/integration runs, `composer 
phpunit:unit` runs which uses a fairly restrictive bootstrap file. Any attempts 
to access the database there or MediaWiki services would fail, for example. 
That command looks for tests that are in the `tests/phpunit/unit` subdirectory.
  
  So, we need to update Quibble's PHPUnit commands to then ensure that 
`tests/phpunit/unit` is excluded from integration test runs. We could do that 
by applying `@group Unit` to each unit test class and then using `--exclude 
Unit` in Quibble. That's a lot of work, though. We could also have 
ExtensionTestSuite manually exclude any tests that are in `tests/phpunit/unit` 
subdirectory, but that wouldn't handle the test run that happens for core. 
Maybe it is most straightforward (but also another hack) to just remove the 
`tests/phpunit/unit` directory from each project after `composer phpunit:unit` 
runs.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 804279 **abandoned** by Kosta Harlan:
  
  [mediawiki/extensions/Wikibase@master] ApiFormatReferenceTest: Temporarily 
disable testInvalidReferenceJson
  
  Reason:
  
  
  
  https://gerrit.wikimedia.org/r/804279

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Okay, CentralAuth sets up its database in 
`UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only 
run by `MediaWikiIntegrationTestCase::setupTestDB()`. `ApiFormatReferenceTest` 
and `QuerySearchEntitiesTest` are nominally unit tests, not integration tests, 
so the database doesn’t get set up, but then CentralAuth still runs as if it’s 
in an integration test.
  
  I think the correct solution here is to declare those tests as integration 
tests. Trying to run a whole API module as only a unit test feels like a fool’s 
errand to me, at least at the moment. Perhaps a few years down the line, 
MediaWiki will be disciplined enough about dependency injection that API 
modules won’t interact with global state or the real wiki configuration, but 
until then, this should have its own database.
  
  But this also highlights something that was brought up in the Gerrit 
discussion 
:
  
  > Per Kosta on IRC, there's a chance the speed up is itself suspicious and 
possibly indicating we missed something, e.g. some kind of protection layer or 
reset.
  
  I think that’s exactly what’s happening – these unit tests, and presumably 
many others like them, previously enjoyed the protection layer of having a 
separate database set up for them, and now they don’t. I think we’re now 
running anything that claims to be a unit test against the real database of the 
wiki, and if it happens to hit a code path that isn’t ready for unit tests, so 
to speak (like this CentralAuth hook), then who knows what happens. IMHO this 
needs to be fixed – I don’t think it was sufficiently communicated that all 
extension unit tests would now be less “sandboxed”, so to speak.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: MediaWiki-extensions-CentralAuth.
Lucas_Werkmeister_WMDE added a comment.


  Okay, I can reproduce the error with `wfLoadExtension( 'CentralAuth' );` in 
LocalSettings.
  
  If I add `$wgCentralAuthDatabase = $wgDBname;`, then the error message 
changes:
  
  > Failed asserting that exception of type "Wikimedia\Rdbms\DBQueryError" 
matches expected exception "ApiUsageException". Message was: "Error 1146: Table 
'wiki1.globaluser' doesn't exist
  
  (`wiki1` is my DB name.) And when I then run `php maintenance/mysql.php < 
extensions/CentralAuth/schema/mysql/tables-generated.sql`, then the tests pass:
  
$ vendor/bin/phpunit 
extensions/Wikibase/client/tests/phpunit/unit/includes/Api/ApiFormatReferenceTest.php
 
Using PHP 8.1.2
PHPUnit 8.5.26 #StandWithUkraine

Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest
 ✔ testAsDataBridgeForHtml
 ✔ testInvalidReferenceJson
 ✔ testInvalidReferenceSerialization

Time: 430 ms, Memory: 52.50 MB

OK (3 tests, 8 assertions)
  
  So it’s something about the way CentralAuth is set up that previously used to 
work in CI but now doesn’t.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, 
Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, 
Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, 
thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I can’t reproduce this yet, `vendor/bin/phpunit 
extensions/Wikibase/client/tests/phpunit/unit/` works fine for me with latest 
MediaWiki core and Wikibase…

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, 
Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Izno, thcipriani, Wikidata-bugs, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, 
karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, 
Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Izno, thcipriani, Wikidata-bugs, aude, fredw, Pkra, scfc, Jdforrester-WMF, 
Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Fernandobacasegua34, 786, Suran38, Biggs657, Lalamarie69, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, DannyS712, CucyNoiD, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Maosef, Lewizho99, Maathavan, Debenben, Neuronton, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread gerritbot 
gerritbot added a comment.


  Change 804279 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/extensions/Wikibase@master] ApiFormatReferenceTest: Temporarily 
disable testInvalidReferenceJson
  
  https://gerrit.wikimedia.org/r/804279

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure

2022-06-09 Thread kostajh 
kostajh renamed this task from "Math CI tests fail" to 
"Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson 
failure".
kostajh updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T310255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, 
Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, 
thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org