[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson added a comment. AC2 is T315036 TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ovasileva, Jdlrobson Cc: Patafisik_WMF, Edtadros,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ovasileva, Jdlrobson Cc: Patafisik_WMF, Edtadros, KieranMcCann, Pginer-WMF, TheresNoTime, Patriccck,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ovasileva, Maintenance_bot Cc: Patafisik_WMF, Edtadros, KieranMcCann, Pginer-WMF, TheresNoTime,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Edtadros added a comment. Test Result - Prod -- **Status:** ❌ **Environment:** enwiki, mediawiki **OS:** macOS Ventura **Browser:** Chrome **Device:** MBP **Emulated Device:**NA **Test Artifact(s):** QA Steps ✅ AC1: While logged in

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson added a comment. > But now I'm experiencing that the link "Edit interlanguage links" ("Modifier les liens interlangues" on frwiki in the video) is displayed a few fractions of a second later then other links in the menu, at the same time of other elements of the page, when purging

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Patafisik_WMF added a comment. Hi, the cropped text of "Edit interlanguage links" I noticed in T328069#8620884 is resolved for me on itwiki, frwiki and enwiki. But now I'm experiencing that the link "Edit interlanguage links" ("Modifier

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson added a comment. I can replicate the issue on German Wikipedia (https://de.wikipedia.org/wiki/Chris_Hipkins?useskin=vector-2022=de). A fix was merged March 7th so this should be fixed on March 16th when the fix hits production. TASK DETAIL

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

ovasileva moved this task from Ready for Signoff to QA in Production on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4) board. ovasileva added a comment. In T328069#8692152 , @Patafisik_WMF wrote: > Message from a German user

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Patafisik_WMF added a comment. Message from a German user on MediaWiki, March 13th: > The entry "Edit interlanguage links" in the tools navigation is cut off at the front due to an

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Edtadros reassigned this task from Edtadros to ovasileva. Edtadros moved this task from QA to Ready for Signoff on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4) board. Edtadros added a comment. Test Result - Beta -- **Status:** ✅ PASS **Environment:** beta

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

alexhollender_WMF added a subscriber: KieranMcCann. alexhollender_WMF added a comment. In T328069#8631022 , @Nux wrote: > Also not sure why are going with overlines. I think you will be opening another front of controversial changes.

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06). TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Edtadros,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson reassigned this task from Jdrewniak to Edtadros. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Edtadros, Jdlrobson Cc: Pginer-WMF, TheresNoTime, Patriccck, Urbanecm, jhsoby,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

gerritbot added a comment. Change 887381 **merged** by jenkins-bot: [mediawiki/skins/Vector@master] Remove skinStyles for wikibase.client module https://gerrit.wikimedia.org/r/887381 TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdrewniak added a comment. Ok just a note here, given that the ULS doen't yet support the use-case where pages have no languages, and the Tools menu doesn't support icons yet (given the layout issues & multiple language bugs) I'll remove the icon from this link and leave it in the tools

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Nux added a comment. Note that the same link is also for connecting to an existing WD item when there is no WD connected yet. | link-button | dialog | | F36887506: obraz.png | F36887508: obraz.png

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Patafisik added a comment. @Iniquity I completely agree. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Patafisik Cc: TheresNoTime, Patriccck, Urbanecm, jhsoby, GMikesell-WMF, Nux,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Iniquity added a comment. I think you are right and we need to remove this link from the menu and move it to the first level of ULS. Smth like that: F36886882: image.png The link to the element in the wikidata is still in the menu and in

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson moved this task from Code Review to Needs More Work on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4) board. Jdlrobson added a comment. @alexhollender_WMF (and other's listening who have opinions) I want to play devils advocate here since this is not proving as trivial as

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

LGoto added a project: Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4). TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, LGoto Cc: TheresNoTime, Patriccck, Urbanecm, jhsoby,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

LGoto removed a project: Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4). TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, LGoto Cc: TheresNoTime, Patriccck, Urbanecm, jhsoby,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Iniquity added a comment. In T328069#8641264 , @Patriccck wrote: > This is how it looks on 15,6" notebook (cs.wikipedia.org). F36866794: image.png > > 1. Overlapped text. > 2. I don't

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Patriccck added subscribers: Urbanecm, Patriccck. Patriccck added a comment. This is how it looks on 15,6" notebook (cs.wikipedia.org). F36866794: image.png 1. Overlapped text. 2. I don't like also the second sliding bar but it is probably

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson merged a task: T330221: Test.Wiki: Part of category (Add interlanguage links) on the right side is getting cut off when you switch to a different language.. Jdlrobson added a subscriber: GMikesell-WMF. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Nux added a comment. While you are changing that could you add a span element to the link? That would make things more uniform. Thanks :) F36863074: obraz.png Also note that due to gadgets the tools list can be rather long. And as the font

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Iniquity merged a task: T330046: The Edit interlanguage links item in the General menu on Vector 2022 is not seen completely. Iniquity added a subscriber: Amire80. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Zapipedia-WMF added a comment. On es.wp and pt.wp we seem to have the same problem: F36861644: image.png F36861646: image.png TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Patafisik added a comment. In T328069#8620884 , @Patafisik wrote: > Today on itwiki the link is styled incorrectly but in a different way, see > élément, @media screen, display: flex; > F36853891: Screenshot 2023-02-16 at 08-28-42

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson edited projects, added Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4); removed Readers-Web-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Jdlrobson Cc:

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Patafisik added a comment. Today on itwiki the link is styled incorrectly but in a different way, see élément, @media screen, display: flex; F36853891: Screenshot 2023-02-16 at 08-28-42 Blank Generation (film) - Wikipedia.png TASK DETAIL

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Iniquity merged a task: T329759: Layout failure in General section in case of Vector 2022. Iniquity added a subscriber: RolandUnger. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Iniquity added a comment. Yes, for Russian we have the same problem:F36845845: image.png TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Raymond added a comment. With the activation in all wikis last night it is shown in the German Wikipedia with German as user language this way: F36845815: grafik.png With English as user language it looks better: F36845817: grafik.png

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson added a subscriber: ovasileva. Jdlrobson added a comment. @ovasileva this was removed from the sprint as we felt we were oversubscribed in sprint 3 and weren't show how priority for this aligned with existing priorities. This task if important can be swapped in for another task in

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson added a project: Readers-Web-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Jdlrobson Cc: alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

LGoto removed a project: Web-Team FY2022-23 Q3 Sprint 2. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, LGoto Cc: alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdrewniak added a comment. Looks like I did miss a use-case with patches above (as Jon identified in code review) F36802081: Screen Shot 2023-02-07 at 3.51.57 PM.png TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Jdlrobson Cc: alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, gerritbot Cc: alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

gerritbot added a comment. Change 887381 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak): [mediawiki/skins/Vector@master] Refine styles for linterlanguage links button. https://gerrit.wikimedia.org/r/887381 TASK DETAIL https://phabricator.wikimedia.org/T328069

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson reassigned this task from Jdlrobson to Jdrewniak. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Jdlrobson Cc: alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

alexhollender_WMF moved this task from Design Review to Needs More Work on the Web-Team FY2022-23 Q3 Sprint 2 board. alexhollender_WMF reassigned this task from alexhollender_WMF to Jdlrobson. alexhollender_WMF added a comment. @Jdlrobson sorry for not providing mockups earlier on. |

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdlrobson assigned this task to alexhollender_WMF. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alexhollender_WMF, Jdlrobson Cc: Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail, Aklapper,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

gerritbot added a comment. Change 886396 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove skinStyles for Vector 2022 https://gerrit.wikimedia.org/r/886396 TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Lucas_Werkmeister_WMDE added a comment. Meh, I ended up looking enough into this that it made sense for me to just review it ^^ I +2ed it now so it goes into this week’s train; it can maybe be removed from our boards again, but I’ll leave that to Itamar, I think. To test this locally,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Lucas_Werkmeister_WMDE added subscribers: ItamarWMDE, Lucas_Werkmeister_WMDE. Lucas_Werkmeister_WMDE added projects: wdwb-tech, wmde-wikidata-tech. Lucas_Werkmeister_WMDE added a comment. Restricted Application added a project: User-ItamarWMDE. Tagging WMDE teams for reviewing the Wikibase

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdrewniak added a comment. @Jdlrobson this is what I'm seeing on beta without the wikibase patch. I see the icon is not aligned with the edge of the text and the color is off, is this what you're seeing? F3676: Screen Shot 2023-02-06 at 10.54.25 AM.png

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis,

[Wikidata-bugs] [Maniphest] T328069: "Edit interlanguage link" is styled incorrectly with page tools enabled

Jdrewniak added a project: MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T328069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak Cc: Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71,