[Wikidata-bugs] [Maniphest] [Created] T199409: NewLexeme suggester is behind special page tab

2018-07-12 Thread KaMan
KaMan created this task.KaMan added projects: Lexicographical data, Wikidata. TASK DESCRIPTIONWhen suggester of language is opened then most suitable entry of suggester is behind special page tab at the top of the screen. See screenshot: F23661690: hidden-suggester.pngTASK DETAILhttps://phabricator

[Wikidata-bugs] [Maniphest] [Retitled] T199409: [Bug] NewLexeme suggester menu appears behind special page tab

2018-07-12 Thread Lea_Lacroix_WMDE
Lea_Lacroix_WMDE renamed this task from "NewLexeme suggester is behind special page tab" to "[Bug] NewLexeme suggester menu appears behind special page tab".Lea_Lacroix_WMDE removed Lea_Lacroix_WMDE as the assignee of this task.Lea_Lacroix_WMDE added subscribers: Lea_Lacroix_WMDE, Lydia_Pintscher.

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T191614: wrong translations of Form related strings

2018-07-12 Thread Tarrow
Tarrow added a subscriber: Amire80.Tarrow added a comment. As far as I can tell {{Identical}} is only to be used when the two messages are exactly the same string in English and have the same meaning. It looks like applying it wrongly to Form in the past actually exacerbated the problem. See: T189

[Wikidata-bugs] [Maniphest] [Commented On] T191614: wrong translations of Form related strings

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445359 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/WikibaseLexeme@master] Make Form Translations clearly lexicographical Forms https://gerrit.wikimedia.org/r/445359TASK DETAILhttps://phabricator.wikimedia.org/T191614EMAIL PRE

[Wikidata-bugs] [Maniphest] [Updated] T191614: wrong translations of Form related strings

2018-07-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T191614EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Amire80, Liuxinyu970226, Aklapper, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo,

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-07-12 Thread daniel
daniel removed a parent task: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versu

[Wikidata-bugs] [Maniphest] [Updated] T194037: Track dependencies for multiple Content objects per page

2018-07-12 Thread daniel
daniel added subtasks: T190063: Tracking dependencies for multiple Content objects per page (MCR), T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates. TASK DETAILhttps://phabricator.wikimedia.org/T194037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pan

[Wikidata-bugs] [Maniphest] [Updated] T194038: Introduce ContentHandler::getSecondaryDataUpdates to replace Content::getSecondaryDataUpdates

2018-07-12 Thread daniel
daniel removed a parent task: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T194038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versu

[Wikidata-bugs] [Maniphest] [Unblock] T194037: Track dependencies for multiple Content objects per page

2018-07-12 Thread daniel
daniel closed subtask T190063: Tracking dependencies for multiple Content objects per page (MCR) as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T194037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420,

[Wikidata-bugs] [Maniphest] [Updated] T196087: Refactored implementation of MCR page update interface

2018-07-12 Thread daniel
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC Statement Support - phase 3), Structured-Data-Commons.daniel added a comment. Dropping this off the SDC board, since full implementation of this is not necessary for SDC. Some of the subtasks are needed,

[Wikidata-bugs] [Maniphest] [Unblock] T199352: Deploy Structured Data on Commons with arbitrary Statements

2018-07-12 Thread daniel
daniel closed subtask T190063: Tracking dependencies for multiple Content objects per page (MCR) as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T199352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, G

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-07-12 Thread daniel
daniel added a parent task: T194037: Track dependencies for multiple Content objects per page. TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majest

[Wikidata-bugs] [Maniphest] [Edited] T196087: Refactored implementation of MCR page update interface

2018-07-12 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThe target architecture of the refactoring is described at https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-PageUpdaterTASK DETAILhttps://phabricator.wikimedia.org/T196087EMAIL PREFERENCEShttps://phabricator

[Wikidata-bugs] [Maniphest] [Edited] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...This means that the logic for undoing edits needs to be extracted from EditPage. Note that it may be temporarily acceptable to only support undos that do not touch multiple slotsAt present, undo simply fails if multi

[Wikidata-bugs] [Maniphest] [Edited] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* A diff for each slot should be shown for confirmation (T194731T174036)TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: da

[Wikidata-bugs] [Maniphest] [Edited] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...At present, undo simply fails if multiple slots are involved, see {T194412}* A diff for each slot should be shown for confirmation (T174036), {T194731}. * If undo supports editing, it needs to support preview! If

[Wikidata-bugs] [Maniphest] [Commented On] T199244: Add support for deserializing senses

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 444913 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Extract SenseSerializer https://gerrit.wikimedia.org/r/444913TASK DETAILhttps://phabricator.wikimedia.org/T199244EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Commented On] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-12 Thread Baloch007
Baloch007 added a comment. Yes it's correct :-) In T198818#4417946, @Jdlrobson wrote: @Baloch007 could you please confirm this is working as expected on our test server?: https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?use

[Wikidata-bugs] [Maniphest] [Created] T199420: Misleading error message for add an image statement for imcomplete filenames

2018-07-12 Thread Raymond
Raymond created this task.Raymond added a project: MediaWiki-extensions-WikibaseRepository.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONMisleading error message for add an image value for imcomplete filenames: "File names are not allowed to contain character

[Wikidata-bugs] [Maniphest] [Updated] T198841: Blubber: Web From: Choose specific elements from the UI a user wants to have in his/hers docker compose file - Step 1

2018-07-12 Thread RazShuty
RazShuty added a project: User-MatthiasGeisler. TASK DETAILhttps://phabricator.wikimedia.org/T198841EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc: Aklapper, RazShuty, Gstupp, Abbe98, Jonas, Wikidata-bugs, Lydia_Pintscher, Addshore_

[Wikidata-bugs] [Maniphest] [Assigned] T198841: Blubber: Web From: Choose specific elements from the UI a user wants to have in his/hers docker compose file - Step 1

2018-07-12 Thread Jonas
Jonas assigned this task to Matthias_Geisler_WMDE. TASK DETAILhttps://phabricator.wikimedia.org/T198841EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Matthias_Geisler_WMDE, JonasCc: Aklapper, RazShuty, Gstupp, Abbe98, Jonas, Wikidata-bugs, Lydia_Pintscher, Ad

[Wikidata-bugs] [Maniphest] [Edited] T193641: track number of editors from other Wikimedia projects who also edit on Wikidata over time

2018-07-12 Thread Jonas
Jonas updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[ x] [[ https://gerrit.wikimedia.org/r/#/c/analytics/refinery/source/+/443069/ | Spark job ]]...TASK DETAILhttps://phabricator.wikimedia.org/T193641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai

[Wikidata-bugs] [Maniphest] [Commented On] T199244: Add support for deserializing senses

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 444923 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Add SenseDeserializer https://gerrit.wikimedia.org/r/444923TASK DETAILhttps://phabricator.wikimedia.org/T199244EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefere

[Wikidata-bugs] [Maniphest] [Updated] T199244: Add support for deserializing senses

2018-07-12 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)). TASK DETAILhttps://phabricator.wikimedia.org/T199244EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: gerritbot, Lucas_Werkmeister_WMDE, Mringgaa

[Wikidata-bugs] [Maniphest] [Commented On] T194771: Add "mis" language code to the list of language code options on Special:NewLexeme

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 444000 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] selenium: test creation of new lexemes https://gerrit.wikimedia.org/r/444000TASK DETAILhttps://phabricator.wikimedia.org/T194771EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p

[Wikidata-bugs] [Maniphest] [Commented On] T135155: Create an adapter that implements SiteLookup on top of InterwikiLookup

2018-07-12 Thread RazShuty
RazShuty added a comment. May I ask what's the status of this?TASK DETAILhttps://phabricator.wikimedia.org/T135155EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, RazShutyCc: RazShuty, gerritbot, Ladsgroup, Zppix, Quiddity, Smalyshev, Krenair, Legokt

[Wikidata-bugs] [Maniphest] [Commented On] T135155: Create an adapter that implements SiteLookup on top of InterwikiLookup

2018-07-12 Thread daniel
daniel added a comment. I have been working on one corner of the SiteInfo stuff at the hackathon again. I should sit down with Amir to discuss next steps. The implementation is not so hard, what is tricky is staying compatible with configuration manually added to existing installs. Both of us are

[Wikidata-bugs] [Maniphest] [Commented On] T198197: Make senses UI call wbladdsense API when saving a new sense

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 443654 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Turn glosses into a TermMap in frontend https://gerrit.wikimedia.org/r/443654TASK DETAILhttps://phabricator.wikimedia.org/T198197EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/

[Wikidata-bugs] [Maniphest] [Commented On] T198197: Make senses UI call wbladdsense API when saving a new sense

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 443660 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Introduce SenseSerializer.js https://gerrit.wikimedia.org/r/443660TASK DETAILhttps://phabricator.wikimedia.org/T198197EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/email

[Wikidata-bugs] [Maniphest] [Updated] T198197: Make senses UI call wbladdsense API when saving a new sense

2018-07-12 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)). TASK DETAILhttps://phabricator.wikimedia.org/T198197EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: Ladsgroup, gerritbot, Lydia_Pintscher, RazS

[Wikidata-bugs] [Maniphest] [Updated] T126596: During update.php (and install), add an entry in the sites table / SiteStore for the local wiki

2018-07-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T126596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krinkle, gerritbotCc: gerritbot, Krinkle, daniel, JanZerebecki, Aklapper, aude, StudiesWorld, Gaboe420, Versusxo, M

[Wikidata-bugs] [Maniphest] [Commented On] T126596: During update.php (and install), add an entry in the sites table / SiteStore for the local wiki

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445386 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Remove WikibaseClient.jenkins.php https://gerrit.wikimedia.org/r/445386TASK DETAILhttps://phabricator.wikimedia.org/T126596EMAIL PREFERENCEShttps://phabr

[Wikidata-bugs] [Maniphest] [Claimed] T198196: Add wbladdsense API action to create a new sense for a lexeme

2018-07-12 Thread Addshore
Addshore claimed this task.Herald added a project: User-Addshore. TASK DETAILhttps://phabricator.wikimedia.org/T198196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup, Mikepipo, Lydia_Pintscher, RazShuty, Mringgaard, Lahi, Gq86, GoranSMilo

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445390 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)): [mediawiki/extensions/Wikibase@master] Fix missing label for unit items when displayed on entity page https://gerrit.wikimedia.org/r/445390TASK DETAILhttps:

[Wikidata-bugs] [Maniphest] [Updated] T199379: Qid displayed instead of unit name

2018-07-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Tacsipacsi, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpau

[Wikidata-bugs] [Maniphest] [Updated] T199379: Qid displayed instead of unit name

2018-07-12 Thread Pablo-WMDE
Pablo-WMDE added a comment. Fell over during a refactoring for T195302 / https://gerrit.wikimedia.org/r/443104TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, gerritbot, Tacsipacsi, A

[Wikidata-bugs] [Maniphest] [Updated] T191600: Showing the lemma in recent changes

2018-07-12 Thread Pablo-WMDE
Pablo-WMDE added a comment. This introduced browser tests for core which are flaky T198137 (see #3)TASK DETAILhttps://phabricator.wikimedia.org/T191600EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: gerritbot, WMDE-leszek, Aklapper, Lydia_Pintsch

[Wikidata-bugs] [Maniphest] [Triaged] T199379: Qid displayed instead of unit name

2018-07-12 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Lydia_Pintscher triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T199379WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Created] T199440: Install cache/integration-tests with Wikibase CI tests

2018-07-12 Thread Addshore
Addshore created this task.Addshore added projects: User-Addshore, Continuous-Integration-Config, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIn https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/441203 cache/integration-tests is added as a require-dev dependency o

[Wikidata-bugs] [Maniphest] [Updated] T110022: Create a library with HTTP related functions/code

2018-07-12 Thread Addshore
Addshore added a parent task: T146257: Create objectcache/BagOStuff library. TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricor

[Wikidata-bugs] [Maniphest] [Commented On] T199420: Misleading error message for add an image statement for imcomplete filenames

2018-07-12 Thread Greta_Doci_WMDE
Greta_Doci_WMDE added a comment. I could reproduce this and it happens the same as claimed by Raymond.TASK DETAILhttps://phabricator.wikimedia.org/T199420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Greta_Doci_WMDE, Aklapper, Raymond, Lah

[Wikidata-bugs] [Maniphest] [Triaged] T199420: Misleading error message for add an image statement for imcomplete filenames

2018-07-12 Thread Greta_Doci_WMDE
Greta_Doci_WMDE triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T199420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDECc: Greta_Doci_WMDE, Aklapper, Raymond, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445390 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix missing label for unit items when displayed on entity page https://gerrit.wikimedia.org/r/445390TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445413 had a related patch set uploaded (by Addshore; owner: Aleksey Bekh-Ivanov (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.12] Fix missing label for unit items when displayed on entity page https://gerrit.wikimedia.org/r/445413TASK DETAILhttps://phabr

[Wikidata-bugs] [Maniphest] [Closed] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-12 Thread Jdlrobson
Jdlrobson closed this task as "Resolved".Jdlrobson claimed this task.Jdlrobson added a comment. Thanks for confirming! This will be deployed in 1.32.wmf.13 currently planned for July 17th (https://wikitech.wikimedia.org/wiki/Deployments)TASK DETAILhttps://phabricator.wikimedia.org/T198818EMAIL PREF

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2018-07-12 Thread Mvolz
Mvolz added a comment. I'm oTASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MvolzCc: srishakatux, eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricord

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 445413 merged by Addshore: [mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.12] Fix missing label for unit items when displayed on entity page https://gerrit.wikimedia.org/r/445413TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-07-12T14:37:39Z] Synchronized php-1.32.0-wmf.12/extensions/Wikibase/repo: T199379 Fix missing label for unit items when displayed on entity page [[gerrit:445413]] (duration: 01m 02s)TASK DETAILhttps://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread Addshore
Addshore added a comment. Should be fixed now, but pages that are already showing bad stuff will need a purge!TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Stashbot, Jakob_WMDE, Pablo-

[Wikidata-bugs] [Maniphest] [Closed] T199379: Qid displayed instead of unit name

2018-07-12 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher claimed this task.Lydia_Pintscher added a comment. \o/TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Addshor

[Wikidata-bugs] [Maniphest] [Created] T199449: phan failing for Wikibase on wmf. branches

2018-07-12 Thread Addshore
Addshore created this task.Addshore added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONExample: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/440295/ This is due to the extension directories existing for core on the wmf branches Checks for these di

[Wikidata-bugs] [Maniphest] [Updated] T199449: phan failing for Wikibase on wmf. branches

2018-07-12 Thread Addshore
Addshore added a project: User-Addshore. TASK DETAILhttps://phabricator.wikimedia.org/T199449EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: WMDE-leszek, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude,

[Wikidata-bugs] [Maniphest] [Triaged] T199449: phan failing for Wikibase on wmf. branches

2018-07-12 Thread Addshore
Addshore triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T199449EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: WMDE-leszek, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Commented On] T199449: phan failing for Wikibase on wmf. branches

2018-07-12 Thread Addshore
Addshore added a comment. Marking as high as this keeps slowing down deployments and increases the chances of some other failure being missed for backports.TASK DETAILhttps://phabricator.wikimedia.org/T199449EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Adds

[Wikidata-bugs] [Maniphest] [Updated] T199449: phan failing for Wikibase on wmf. branches

2018-07-12 Thread Addshore
Addshore added a project: Wikidata-Campsite. TASK DETAILhttps://phabricator.wikimedia.org/T199449EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: WMDE-leszek, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-b

[Wikidata-bugs] [Maniphest] [Updated] T199379: Qid displayed instead of unit name

2018-07-12 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)). TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, ReleaseTaggerBotCc: Lydia_Pintscher, Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T199379: Qid displayed instead of unit name

2018-07-12 Thread Multichill
Multichill added a comment. In T199379#4419930, @Addshore wrote: Should be fixed now, but pages that are already showing bad stuff will need a purge! Any task/plan for that? Do you have a time window from when it was broken to when it was fixed? A SPARQL query should be able to return the object

[Wikidata-bugs] [Maniphest] [Unblock] T103070: [Story] Find extensions using code directly from Wikibase and provide mechanism with a stable interface

2018-07-12 Thread Addshore
Addshore closed subtask T109836: Try replacing Wikibase usages with API usages as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T103070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Ricordisamoa, JeroenDeDauw, Legok

[Wikidata-bugs] [Maniphest] [Declined] T109836: Try replacing Wikibase usages with API usages

2018-07-12 Thread Addshore
Addshore closed this task as "Declined".Addshore added a comment. Per the things linked above I'll close this one as declinedTASK DETAILhttps://phabricator.wikimedia.org/T109836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, RobLa-WMF, An

[Wikidata-bugs] [Maniphest] [Commented On] T199228: Define an SLO for Wikidata Query Service public endpoint and communicate it

2018-07-12 Thread Gehel
Gehel added a comment. You can have a look at the historical values we have for update lag: https://grafana.wikimedia.org/dashboard/db/wikidata-query-service?refresh=1m&panelId=8&fullscreen&orgId=1&from=now-30d&to=now response times: https://grafana.wikimedia.org/dashboard/db/wikidata-query-servi

[Wikidata-bugs] [Maniphest] [Updated] T185481: [Bug] Unexpected order of Lexeme DataModel elements in complex diffs

2018-07-12 Thread Addshore
Addshore removed a project: Technical-Debt.Addshore added a comment. I don't think this is really technical debt, just a bug / feature not considered when defining requirements, so removing the tagTASK DETAILhttps://phabricator.wikimedia.org/T185481EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T163915: Wikibase: Rework class hierarchy of special pages

2018-07-12 Thread Addshore
Addshore added a comment. @Lucas_Werkmeister_WMDE Any idea on the state of this 1 year down the line? Has this changed at all?TASK DETAILhttps://phabricator.wikimedia.org/T163915EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkme

[Wikidata-bugs] [Maniphest] [Closed] T45855: [Task] UI messages in repo, JS is in lib

2018-07-12 Thread Addshore
Addshore closed this task as "Resolved".Addshore claimed this task.Addshore added a comment.Herald added a project: User-Addshore. Looking at our code now it looks like this is fixed in most places, back in the day https://github.com/wikimedia/mediawiki-extensions-Wikibase/tree/ed156d83da786bc994d

[Wikidata-bugs] [Maniphest] [Closed] T75020: [Task] Move JS and PHP view code to separate repo

2018-07-12 Thread Addshore
Addshore closed this task as "Resolved".Addshore claimed this task.Addshore added a comment.Herald added a project: User-Addshore. The code is now all split up in different git repos included as submodules, and can also be found as npm packages. https://github.com/wikimedia/mediawiki-extensions-Wik

[Wikidata-bugs] [Maniphest] [Unblock] T45855: [Task] UI messages in repo, JS is in lib

2018-07-12 Thread Addshore
Addshore closed subtask T75020: [Task] Move JS and PHP view code to separate repo as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T45855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, adrianheine, JeroenDeDauw, aude,

[Wikidata-bugs] [Maniphest] [Closed] T46967: [Task] Clean up Claims::getDiff()

2018-07-12 Thread Addshore
Addshore closed this task as "Invalid".Addshore added a comment.Herald removed a subscriber: Liuxinyu970226. This class and method no longer exist And I guess the replacement is StatementList, which also has no diff methodTASK DETAILhttps://phabricator.wikimedia.org/T46967EMAIL PREFERENCEShttps://p

[Wikidata-bugs] [Maniphest] [Unblock] T75496: [Epic] Support new types of Entities in Wikibase Repository

2018-07-12 Thread Addshore
Addshore closed subtask T43106: [Task] Tests for PropertyDiff etc need refactoring as "Invalid". TASK DETAILhttps://phabricator.wikimedia.org/T75496EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Bene, Ricordisamoa, Aklapper, adrianheine, GPHemsley

[Wikidata-bugs] [Maniphest] [Closed] T43106: [Task] Tests for PropertyDiff etc need refactoring

2018-07-12 Thread Addshore
Addshore closed this task as "Invalid".Addshore added a comment. These classes and tests no longer exist in their old form.TASK DETAILhttps://phabricator.wikimedia.org/T43106EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Denny,

[Wikidata-bugs] [Maniphest] [Closed] T99777: [Task] Merge LinkInjectionHookHandlers with SidebarHookHandlers

2018-07-12 Thread Addshore
Addshore closed this task as "Invalid".Addshore added a comment. I don't appear to be able to find LinkInjectionHookHandlers in our current code, or infect in any of the history of Wikibase. adam@adsh ~/dev/git/gerrit/mediawiki/core/extensions/Wikibase (master) $ git log --all --grep='LinkInjectio

[Wikidata-bugs] [Maniphest] [Edited] T98169: [Task] Split EntityDataSerializationService into EntityDataSerializers and an EntityDataSerializerFactory

2018-07-12 Thread Addshore
Addshore updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... getSerializeder( $format, $flavor )...TASK DETAILhttps://phabricator.wikimedia.org/T98169EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Aklapper, daniel, Lahi, G

[Wikidata-bugs] [Maniphest] [Commented On] T98169: [Task] Split EntityDataSerializationService into EntityDataSerializers and an EntityDataSerializerFactory

2018-07-12 Thread Addshore
Addshore added a comment. @daniel any chance you could take a look at this task and perhaps update the description to match our newer code? It looks like the class is still there but has grown further?TASK DETAILhttps://phabricator.wikimedia.org/T98169EMAIL PREFERENCEShttps://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Changed Status] T157673: Don't use PHP serialization to determine revision size for Entities

2018-07-12 Thread Addshore
Addshore changed the task status from "Open" to "Stalled".Addshore added a comment. Going to mark this as stalled as a decision would need to be made regarding how we should measure entities and this is not currently being worked on in any wayTASK DETAILhttps://phabricator.wikimedia.org/T157673EMAI

[Wikidata-bugs] [Maniphest] [Commented On] T118498: Rename "DataType" to "PropertyType" across the code base and documentation.

2018-07-12 Thread Addshore
Addshore added a comment. In T118498#2308748, @Lydia_Pintscher wrote: We have trained people on datatype now and it is all our user-facing documentation. I think changing this now to introduce yet another term creates more confusion than it resolves. /me agrees In T118498#3132096, @thiemowmde

[Wikidata-bugs] [Maniphest] [Updated] T118498: Rename "DataType" to "PropertyType" across the code base and documentation.

2018-07-12 Thread Addshore
Addshore added a project: User-Addshore. TASK DETAILhttps://phabricator.wikimedia.org/T118498EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, thiemowmde, Liuxinyu970226, Lydia_Pintscher, Aklapper, StudiesWorld, daniel, Lahi, Gq86, GoranSMi

[Wikidata-bugs] [Maniphest] [Changed Status] T118498: Rename "DataType" to "PropertyType" across the code base and documentation.

2018-07-12 Thread Addshore
Addshore changed the task status from "Open" to "Stalled". TASK DETAILhttps://phabricator.wikimedia.org/T118498EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, thiemowmde, Liuxinyu970226, Lydia_Pintscher, Aklapper, StudiesWorld, daniel, La

[Wikidata-bugs] [Maniphest] [Updated] T97928: [Task] wbgetclaims api module should provide resolving of redirects

2018-07-12 Thread Addshore
Addshore removed a project: Technical-Debt.Addshore added a comment. I don't think this is really tech debt, this is just a feature / some functionality that has not been requested before. For example, T59744 that added the redirect ability (and the other linked tasks) don't mention that api modul

[Wikidata-bugs] [Maniphest] [Commented On] T98035: [Task] Drop support for php-serialized output from Special:EntityData

2018-07-12 Thread Addshore
Addshore added a comment. For reference PHP is still availible https://test.wikidata.org/wiki/Special:EntityData/L84.phpTASK DETAILhttps://phabricator.wikimedia.org/T98035EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, PokestarFan, Jonas,

[Wikidata-bugs] [Maniphest] [Merged] T143038: Remove use of jquery.tipsy in Wikibase

2018-07-12 Thread Addshore
Addshore added subscribers: Addshore, MZMcBride.Addshore merged a task: T143031: Remove use of jquery.tipsy in Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T143038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: MZMcBride, Addshore, thiemo

[Wikidata-bugs] [Maniphest] [Updated] T143031: Remove use of jquery.tipsy in Wikidata

2018-07-12 Thread Addshore
Addshore closed this task as a duplicate of T143038: Remove use of jquery.tipsy in Wikibase. TASK DETAILhttps://phabricator.wikimedia.org/T143031EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, MZMcBride, Jdforrester-WMF, Aklapper, Lahi, G

[Wikidata-bugs] [Maniphest] [Updated] T143031: Remove use of jquery.tipsy in Wikidata

2018-07-12 Thread Addshore
Addshore added a comment. I guess this refers to the Wikidata build which no longer exists, so I'll close and point at T143038 which is for wikibaseTASK DETAILhttps://phabricator.wikimedia.org/T143031EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc:

[Wikidata-bugs] [Maniphest] [Commented On] T143038: Remove use of jquery.tipsy in Wikibase

2018-07-12 Thread Addshore
Addshore added a comment. Just confirming ~1.5-2 years down the line this is still used in Wikibase by at least jquery.wikibase.wbtooltipTASK DETAILhttps://phabricator.wikimedia.org/T143038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: MZMcBride,

[Wikidata-bugs] [Maniphest] [Retitled] T182983: Consistently check permissions in API modules that modify entities

2018-07-12 Thread Addshore
Addshore renamed this task from "Consistently check permissions in API moduloes that modify entities" to "Consistently check permissions in API modules that modify entities". TASK DETAILhttps://phabricator.wikimedia.org/T182983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Commented On] T194263: Deprecate/Remove ContentHandler::makeParserOptions()

2018-07-12 Thread daniel
daniel added a comment. The longer I think about this, the more I want ParserOptions creation to have a Title for context. The reason is that default parser behavior may vary with the type of page. The special case for conversion tables in WikiPage::makeParserOptions() is the point in case. We ca

[Wikidata-bugs] [Maniphest] [Commented On] T199228: Define an SLO for Wikidata Query Service public endpoint and communicate it

2018-07-12 Thread Smalyshev
Smalyshev added a comment. I think response times and number of timeouts are not a good metric for this type of thing - people run a lot of heavy queries, for which it's OK to time out, and the query response time is largely dependent on the type of queries (and bots) running. We could look at p95

[Wikidata-bugs] [Maniphest] [Commented On] T194263: Deprecate/Remove ContentHandler::makeParserOptions()

2018-07-12 Thread Anomie
Anomie added a comment. In T194263#4420512, @daniel wrote: The longer I think about this, the more I want ParserOptions creation to have a Title for context. The reason is that default parser behavior may vary with the type of page. The special case for conversion tables in WikiPage::makeParserO

[Wikidata-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing

2018-07-12 Thread Addshore
Addshore added a comment. Looks like this is all done, and it looks like yesterday for a couple of periods the dispatch lag was high and the maxlag as a result was higher. F23686506: image.png It looks like roughly ~6000 requests were stopped due to max lag out of ~20 made yesterday There ar

[Wikidata-bugs] [Maniphest] [Closed] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing

2018-07-12 Thread Addshore
Addshore closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Stashbot, Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshor

[Wikidata-bugs] [Maniphest] [Unblock] T196868: Track maxlag for wikidata on grafana dashboard

2018-07-12 Thread Addshore
Addshore closed subtask T194950: Include Wikibase dispatch lag in API "maxlag" enforcing as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T196868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, AddshoreCc: Aklapper, GoranSMilovanovic, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T199228: Define an SLO for Wikidata Query Service public endpoint and communicate it

2018-07-12 Thread Gehel
Gehel added a comment. I think response times and number of timeouts are not a good metric for this type of thing To echo what @Smalyshev is saying, yes, I agree that we don't have good measures of either the reliability or the performances of WDQS. And it is somewhat related to the fact that we d

[Wikidata-bugs] [Maniphest] [Commented On] T199228: Define an SLO for Wikidata Query Service public endpoint and communicate it

2018-07-12 Thread Smalyshev
Smalyshev added a comment. ( ASK{ ?x ?y ?z };) does timeout from time to time. This is definitely the thing that should not be happening, but I wonder how we can build metric around it beyond "this should never happen". We could solve those issues by throwing loads of hardware at the problem. I

[Wikidata-bugs] [Maniphest] [Triaged] T199228: Define an SLO for Wikidata Query Service public endpoint and communicate it

2018-07-12 Thread Smalyshev
Smalyshev triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T199228EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lydia_Pintscher, EBjune, debt, Joe, Smalyshev, Gehel, Aklapper, AndyTan, Davinaclare77, Qtn1293,

[Wikidata-bugs] [Maniphest] [Commented On] T178652: Wikidata dispatchers should use a LockManager with a short TTL

2018-07-12 Thread gerritbot
gerritbot added a comment. Change 395967 merged by jenkins-bot: [operations/mediawiki-config@master] Wikidata dispatch, Use a LockManager with short TTL for testwikidata https://gerrit.wikimedia.org/r/395967TASK DETAILhttps://phabricator.wikimedia.org/T178652EMAIL PREFERENCEShttps://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T178652: Wikidata dispatchers should use a LockManager with a short TTL

2018-07-12 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-07-12T18:32:05Z] Synchronized wmf-config/: Wikidata dispatch, Use a LockManager with short TTL for testwikidata T178652 (duration: 00m 51s)TASK DETAILhttps://phabricator.wikimedia.org/T178652EMAIL PREFERENCEShttps://phabricat

[Wikidata-bugs] [Maniphest] [Claimed] T178652: Wikidata dispatchers should use a LockManager with a short TTL

2018-07-12 Thread Addshore
Addshore claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T178652EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Stashbot, aaron, gerritbot, Ladsgroup, daniel, Lydia_Pintscher, Addshore, Aklapper, hoo, Gaboe420, Versusxo, Majesticalr

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T178652: Wikidata dispatchers should use a LockManager with a short TTL

2018-07-12 Thread Addshore
Addshore added a subscriber: Niharika.Addshore added a comment. This is all done for testwikidatawiki now (thanks @Niharika) and the new lock manager works as expected. I'll follow up and do this for real wikidata in a few days or so (maybe at wikimania) Some steps that should work and keep this

[Wikidata-bugs] [Maniphest] [Closed] T192963: Store Kafka poller position data in the WDQS database

2018-07-12 Thread Smalyshev
Smalyshev closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T192963EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Gehel, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, C

[Wikidata-bugs] [Maniphest] [Unblock] T189458: re-enable wdqs kafka poller

2018-07-12 Thread Smalyshev
Smalyshev closed subtask T192963: Store Kafka poller position data in the WDQS database as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T189458EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, SmalyshevCc: Jonas, Smalyshev, Gehel, Aklapper, el

[Wikidata-bugs] [Maniphest] [Commented On] T189458: re-enable wdqs kafka poller

2018-07-12 Thread Smalyshev
Smalyshev added a comment. Current plan is to try again after July 23th, test hosts first and then others.TASK DETAILhttps://phabricator.wikimedia.org/T189458EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, SmalyshevCc: Jonas, Smalyshev, Gehel, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T189458: re-enable wdqs kafka poller

2018-07-12 Thread Smalyshev
Smalyshev added a project: Discovery-Wikidata-Query-Service-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T189458EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, SmalyshevCc: Jonas, Smalyshev, Gehel, Aklapper, elukey, Lahi, Gq86, Darkminds3113, Lu

[Wikidata-bugs] [Maniphest] [Merged] T199379: Qid displayed instead of unit name

2018-07-12 Thread matej_suchanek
matej_suchanek added a subscriber: Considering.Different.Routes.matej_suchanek merged a task: T199438: Unit of measure in Quantity datatype when written with bots (Wikidata API) is not (correctly) shown in Wikidata pages.. TASK DETAILhttps://phabricator.wikimedia.org/T199379EMAIL PREFERENCEShttps:/

  1   2   >