[Wikidata-bugs] [Maniphest] T277564: [Curious Facts] take separators into account for single value constraints

2021-07-06 Thread Manuel
Manuel added a project: Wikidata Analytics. TASK DETAIL https://phabricator.wikimedia.org/T277564 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: GoranSMilovanovic, Manuel Cc: Mohammed_Sadat_WMDE, Manuel, Tobi_WMDE_SW, amy_rc, WMDE-leszek, Aklapper,

[Wikidata-bugs] [Maniphest] T285250: View Import status of an uploaded mismatch file

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285250 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Sarai-WMDE, Mattia_Capozzi_WMDE, Aklapper, Lydia_Pintscher, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. So what exactly do we want to prevent… - The `Wikimedia\Rdmbs\` namespace: this would be closest to the existing repo/client/lib usage test, but I’m pretty sure this isn’t feasible – there are several uses of other types in that namespace, notably

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T286053: Set up route (feature / integration) testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T286053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Backlog to Mismatch Finder - sprint 2 on the Mismatch Finder board. Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 2); removed Mismatch Finder. TASK DETAIL https://phabricator.wikimedia.org/T285838 WORKBOARD

[Wikidata-bugs] [Maniphest] T286053: Set up route (feature / integration) testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Backlog to Mismatch Finder - sprint 2 on the Mismatch Finder board. Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 2); removed Mismatch Finder. TASK DETAIL https://phabricator.wikimedia.org/T286053 WORKBOARD

[Wikidata-bugs] [Maniphest] T246446: WikibaseLexeme: Validate response structure

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T246446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Would it be an option to change the tracking key and then move the existing data in Graphite? (Maybe literally `mv` them – IIRC they’re actually stored as files in directories?) TASK DETAIL https://phabricator.wikimedia.org/T272128 EMAIL

[Wikidata-bugs] [Maniphest] T280910: Usage tracking for redirect resolving Lua functions

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. "X" usage is deprecated and has caused all sorts of issues including a major outage in ruwiki, we really should avoid using it unless absolutely necessary. If I understand it correctly, the usage is transient so if I check P123

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. Where the test should reside? In Lib? I want to avoid that as lib should be dismantled. In Client and repo separately? then how are going to test lib? Maybe we shouldn't test lib in this regard at all. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T286209 WORKBOARD

[Wikidata-bugs] [Maniphest] T226097: Termbox: Browserslist: caniuse-lite is outdated. Please run next command `npm update caniuse-lite browserslist`

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "Browserslist: caniuse-lite is outdated. Please run next command `npm update caniuse-lite browserslist`" to "Termbox: Browserslist: caniuse-lite is outdated. Please run next command `npm update caniuse-lite browserslist`". Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T285950: Investigate moving some Wikibase tests to @group Standalone

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Inbox to Prioritized on the wdwb-tech board. Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T285950 WORKBOARD https://phabricator.wikimedia.org/project/board/3532/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. I was thinking of asking WMF

[Wikidata-bugs] [Maniphest] T282086: Improve Wikibase secondary CI message (Github Actions)

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703433 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup): [mediawiki/extensions/Wikibase@master] Add more information to failed job email of github actions https://gerrit.wikimedia.org/r/703433 TASK DETAIL

[Wikidata-bugs] [Maniphest] T282086: Improve Wikibase secondary CI message (Github Actions)

2021-07-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T282086 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Addshore, Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule,

[Wikidata-bugs] [Maniphest] T286210: Update wikimedia-ui-base to 0.19.0

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T286210 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T282086: Improve Wikibase secondary CI message (Github Actions)

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It's a bit hard to test. I can

[Wikidata-bugs] [Maniphest] T286056: Use `rsync` to synchronise uploaded repository with live site

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T286056 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703445 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/Wikibase@master] Update documentation of "Other" usage aspect https://gerrit.wikimedia.org/r/703445 TASK DETAIL

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T283040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Michael, Manuel, Addshore, RBrounley_WMF,

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. group() would work here but sometimes doesn't, depending on how we are transforming data. TASK DETAIL https://phabricator.wikimedia.org/T272128 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Manuel,

[Wikidata-bugs] [Maniphest] T184914: Convert external-id property P3424 ("Polish cultural heritage register number") to string

2021-07-06 Thread Esc3300
Esc3300 added a comment. Thanks. Noted it on Property_talk:P3424 TASK DETAIL https://phabricator.wikimedia.org/T184914 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Esc3300 Cc: Esc3300,

[Wikidata-bugs] [Maniphest] T285851: basic file upload page to upload mismatch file

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285851 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Sarai-WMDE, Mattia_Capozzi_WMDE, Aklapper, Lydia_Pintscher, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subscriber: Addshore. Lucas_Werkmeister_WMDE added a comment. @Addshore had previously found phparch and phpat , two projects that are supposed to help you keep your architecture clean. Though

[Wikidata-bugs] [Maniphest] T235499: Share config for using SASS

2021-07-06 Thread Volker_E
Volker_E added a comment. I'd favor adding this ability upstream https://gerrit.wikimedia.org/r/admin/repos/wikimedia-ui-base TASK DETAIL https://phabricator.wikimedia.org/T235499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc:

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-06 Thread Urbanecm
Urbanecm added a comment. Note trying to use pywikibot's interwikidata.py script returns `[{'parameters': [], 'name': 'wikibase-api-illegal-ids-or-sites-titles-selector', 'html': {'*': 'Either provide the Item "ids" or pairs of "sites" and "titles" for corresponding page'}}]]`, which looks

[Wikidata-bugs] [Maniphest] T285299: Import of a Mismatch File

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Ready for sprint start to Mismatch Finder - sprint 2 on the Mismatch Finder board. Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 2); removed Mismatch Finder. TASK DETAIL https://phabricator.wikimedia.org/T285299

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T285838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T286056: Use `rsync` to synchronise uploaded repository with live site

2021-07-06 Thread Silvan_WMDE
Silvan_WMDE added a comment. > come up with a good way to remove resources from production again if they are removed from the repository `rsync --delete` could do the trick for removing unneeded resources and `--exclude` should be able to save us the .env file with that approach

[Wikidata-bugs] [Maniphest] T246446: WikibaseLexeme: Validate response structure

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Backlog to Prioritized on the wdwb-tech board. Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T246446 WORKBOARD https://phabricator.wikimedia.org/project/board/3532/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286242: [Curious Facts] link to displayed image (if any)

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, WMDE-Analytics-Engineering, Wikidata Analytics. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Curious Facts sometimes includes images from the subject item, but without any

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Doesn’t look like there’s any existing PHPCS ruleset we could easily use. (mediawiki-codesniffer has several sniffs for forbidden or deprecated things, but they’re all hard-coded, not configurable. Slevomat coding standard has a forbidden classes

[Wikidata-bugs] [Maniphest] T286248: Add Wikidata support for jvwikisource

2021-07-06 Thread Maintenance_bot
Maintenance_bot created this task. Maintenance_bot added projects: Wikidata-Campsite, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Per https://wikitech.wikimedia.org/wiki/Add_a_wiki once the wiki has been created TASK DETAIL

[Wikidata-bugs] [Maniphest] T280910: Usage tracking for redirect resolving Lua functions

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In T280910#7198823 , @Ladsgroup wrote: > "X" usage is deprecated and has caused all sorts of issues including a major outage in ruwiki, we really should avoid using it unless absolutely

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. It's the same underlying problem. TASK DETAIL https://phabricator.wikimedia.org/T285919 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Vahurzpu, Urbanecm, Ladsgroup, Masssly, Lotje, Aklapper, Invadibot,

[Wikidata-bugs] [Maniphest] T286210: Update wikimedia-ui-base to 0.19.0

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T286210 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T285950: Investigate moving some Wikibase tests to @group Standalone

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Mgagat,

[Wikidata-bugs] [Maniphest] T286210: Update wikimedia-ui-base to 0.19.0

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T286210 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. One note, it's not as easy as it looks because one of the paths has an extra node. E.g. `wikibase.queryService.ui.app.result.received.success.sum` and `wikibase.queryService.ui.embed.app.result.received.success.sum` And so far

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. I spent more than two hours just trying to make this work. It's quite messy, at the end I just abandoned it. Let's try to move the data instead. TASK DETAIL https://phabricator.wikimedia.org/T272128 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286024: Implement allow list for uploading mismatch files

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Mismatch Finder - sprint 1 to Mismatch Finder - sprint 2 on the Mismatch Finder board. Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 2); removed Mismatch Finder (Mismatch Finder - sprint 1). TASK DETAIL

[Wikidata-bugs] [Maniphest] T285249: Upload of a Mismatch File

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Mismatch Finder - sprint 1 to Mismatch Finder - sprint 2 on the Mismatch Finder board. Lydia_Pintscher edited projects, added Mismatch Finder (Mismatch Finder - sprint 2); removed Mismatch Finder (Mismatch Finder - sprint 1). TASK DETAIL

[Wikidata-bugs] [Maniphest] T246446: WikibaseLexeme: Validate response structure

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Note: we have some similar code in data bridge, usually called something like “is well formed” (e.g. `ApiRenderReferencesRepository.isWellFormedFormatReferenceResponse`). TASK DETAIL https://phabricator.wikimedia.org/T246446 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286053: Set up route (feature / integration) testing

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T286053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T286056: Use `rsync` to synchronise uploaded repository with live site

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T286056 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, ItamarWMDE, karapayneWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T285838: Set up unit testing

2021-07-06 Thread Silvan_WMDE
Silvan_WMDE claimed this task. Silvan_WMDE moved this task from To Do to Doing on the Mismatch Finder (Mismatch Finder - sprint 2) board. TASK DETAIL https://phabricator.wikimedia.org/T285838 WORKBOARD https://phabricator.wikimedia.org/project/board/5422/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703445 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Update documentation of "Other" usage aspect https://gerrit.wikimedia.org/r/703445 TASK DETAIL https://phabricator.wikimedia.org/T283040 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703415 had a related patch set uploaded (by Reedy; author: Michael Große): [mediawiki/extensions/Wikibase@REL1_36] Update documentation of "Other" usage aspect https://gerrit.wikimedia.org/r/703415 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTION Note that `wfGetDB()` uses `\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check if //that// connection ref is really necessary for this

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28). TASK DETAIL https://phabricator.wikimedia.org/T283040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael,

[Wikidata-bugs] [Maniphest] T286242: [Curious Facts] link to displayed image (if any)

2021-07-06 Thread LucasWerkmeister
LucasWerkmeister added a comment. You can get some attribution information from the `query+imageinfo+extmetadata` API, if you want to (example code ), but it’s probably

[Wikidata-bugs] [Maniphest] T286250: Replace wfGetDB() by injecting new Db-Service in Repo's DispatchStats class

2021-07-06 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTION Note that `wfGetDB()` uses `\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check if _that_ connection ref is really necessary for this use

[Wikidata-bugs] [Maniphest] T286251: Replace wfGetDB() by injecting new Db-Service in Repo's SqlEntityIdPager class

2021-07-06 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTION Note that `wfGetDB()` uses `\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check if _that_ connection ref is really necessary for this use

[Wikidata-bugs] [Maniphest] T280910: Usage tracking for redirect resolving Lua functions

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. okay, that's not great and needs fixing indeed but I suggest fixing it by making it transient TASK DETAIL https://phabricator.wikimedia.org/T280910 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc:

[Wikidata-bugs] [Maniphest] T286253: Replace wfGetDB() by injecting new Db-Service in Repo's WikiPageEntityStore class

2021-07-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286253 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Michael, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule,

[Wikidata-bugs] [Maniphest] T286253: Replace wfGetDB() by injecting new Db-Service in Repo's WikiPageEntityStore class

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703469 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup): [mediawiki/extensions/Wikibase@master] Inject RepoDomainDb in WikiPageEntityStore https://gerrit.wikimedia.org/r/703469 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286253: Replace wfGetDB() by injecting new Db-Service in Repo's WikiPageEntityStore class

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286253

[Wikidata-bugs] [Maniphest] T286257: Insights from the Wikidata Languages Landscape project

2021-07-06 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T286257 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Tobi_WMDE_SW, Manuel, GoranSMilovanovic, Aklapper, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T277564: [Curious Facts] take separators into account for single value constraints

2021-07-06 Thread amy_rc
amy_rc added a comment. Hello, Goran. Thank you for taking the time to explain everything. We believe that if the issue descriptions can be changed to reflect the new approach, this ticket can be closed for the time being. Current - hypoparathyroidism familial isolated

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703460 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Test number of MW RDBMS references in lib/ https://gerrit.wikimedia.org/r/703460 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T286251: Replace wfGetDB() by injecting new Db-Service in Repo's SqlEntityIdPager class

2021-07-06 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T286251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T286253: Replace wfGetDB() by injecting new Db-Service in Repo's WikiPageEntityStore class

2021-07-06 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTION Note that `wfGetDB()` uses `\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check if //that// connection ref is really necessary for this

[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-06 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTION Note that `wfGetDB()` uses `\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check if //that// connection ref is really necessary for this

[Wikidata-bugs] [Maniphest] T286250: Replace wfGetDB() by injecting new Db-Service in Repo's DispatchStats class

2021-07-06 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T286250 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T286242: [Curious Facts] link to displayed image (if any)

2021-07-06 Thread GoranSMilovanovic
GoranSMilovanovic added subscribers: LucasWerkmeister, Manuel, Tobi_WMDE_SW, GoranSMilovanovic. GoranSMilovanovic added a comment. @LucasWerkmeister Thanks for catching this. I will take a look at the API that the Curious Facts project currently uses to fetch Wikimedia Commons images

[Wikidata-bugs] [Maniphest] T286242: [Curious Facts] link to displayed image (if any)

2021-07-06 Thread GoranSMilovanovic
GoranSMilovanovic claimed this task. GoranSMilovanovic added a project: User-GoranSMilovanovic. TASK DETAIL https://phabricator.wikimedia.org/T286242 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: GoranSMilovanovic Cc: GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] T277564: [Curious Facts] take separators into account for single value constraints

2021-07-06 Thread GoranSMilovanovic
GoranSMilovanovic added a comment. @amy_rc Fixed; please take a look at Qurator Curious Facts . TASK DETAIL https://phabricator.wikimedia.org/T277564 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T286239: Make tlh-latn and tlh-piqd a valid monolingual string language

2021-07-06 Thread Mahir256
Mahir256 added projects: Language codes, Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T286239 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mahir256 Cc: Aklapper, Loominade, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T283246: Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used

2021-07-06 Thread Michael
Michael moved this task from Test (Verification) to Parent tasks on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael added a comment. We forgot about `wfGetDB()`. I'll be creating a couple more subtasks... TASK DETAIL https://phabricator.wikimedia.org/T283246 WORKBOARD

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703462 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Also strip line comments in NoBadDependencyUsageTest https://gerrit.wikimedia.org/r/703462 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Michael, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule,

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703467 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup): [mediawiki/extensions/Wikibase@master] Avoid injecting the whole DB object in SiteLinkConflictLookup https://gerrit.wikimedia.org/r/703467 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286254

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703414 had a related patch set uploaded (by Reedy; author: Michael Große): [mediawiki/extensions/Wikibase@REL1_35] Update documentation of "Other" usage aspect https://gerrit.wikimedia.org/r/703414 TASK DETAIL

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12). TASK DETAIL https://phabricator.wikimedia.org/T286254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, ReleaseTaggerBot Cc: Aklapper, Michael, Biggs657, Invadibot,

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T286254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Maintenance_bot Cc: Aklapper, Michael, Invadibot, maantietaja, Hazizibinmahdi,

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread gerritbot
gerritbot added a comment. Change 703467 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Avoid injecting the whole DB object in SiteLinkConflictLookup https://gerrit.wikimedia.org/r/703467 TASK DETAIL https://phabricator.wikimedia.org/T286254 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T285458: Generate inputs for 1st sensemaking session about ORES quality score distributions across the Wikidata classes

2021-07-06 Thread GoranSMilovanovic
GoranSMilovanovic added a comment. @Manuel Here is my current take on > ideas about possible next steps (towards a better understanding of the current distribution of the ORES quality scores across Wikidata’s classes) - Gather potential explanatory variables and model

[Wikidata-bugs] [Maniphest] T285248: Authenticate to the Mismatch Finder Web Service

2021-07-06 Thread karapayneWMDE
karapayneWMDE closed subtask T285330: Authenticate API consumers against Wikidata + Access List as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T285248 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, karapayneWMDE Cc:

[Wikidata-bugs] [Maniphest] T285330: Authenticate API consumers against Wikidata + Access List

2021-07-06 Thread karapayneWMDE
karapayneWMDE closed this task as "Resolved". karapayneWMDE added a comment. Everyone happy with Sanctum; manages token giving/revocation correctly TASK DETAIL https://phabricator.wikimedia.org/T285330 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T285249: Upload of a Mismatch File

2021-07-06 Thread karapayneWMDE
karapayneWMDE added a comment. Sprint 1 Review - //very// close to passing peer review. TASK DETAIL https://phabricator.wikimedia.org/T285249 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Silvan_WMDE, karapayneWMDE Cc: karapayneWMDE, Esc3300,

[Wikidata-bugs] [Maniphest] T280910: Usage tracking for redirect resolving Lua functions

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added subscribers: Ladsgroup, hoo, Lucas_Werkmeister_WMDE. Lucas_Werkmeister_WMDE added a comment. @Ladsgroup @hoo do you think tracking an “all” usage in this case would be okay? Or should it maybe be some other usage (“other”, or maybe a new type)? TASK DETAIL

[Wikidata-bugs] [Maniphest] T285746: Install and configure PHP linter

2021-07-06 Thread karapayneWMDE
karapayneWMDE closed this task as "Resolved". karapayneWMDE added a comment. Solution selected is working and people involved are satisfied. TASK DETAIL https://phabricator.wikimedia.org/T285746 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T285330: Authenticate API consumers against Wikidata + Access List

2021-07-06 Thread karapayneWMDE
karapayneWMDE added a comment. Relevant github PR : https://github.com/wmde/wikidata-mismatch-finder/pull/7 TASK DETAIL https://phabricator.wikimedia.org/T285330 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Silvan_WMDE, karapayneWMDE Cc:

[Wikidata-bugs] [Maniphest] T286024: Implement allow list for uploading mismatch files

2021-07-06 Thread karapayneWMDE
karapayneWMDE set the point value for this task to "8". karapayneWMDE added a comment. Sprint 1 - Review : last minute addition to sprint, simply not enough time to finish - PR#12 - Admin class was not on the radar when stories

[Wikidata-bugs] [Maniphest] T286041: deactivate Special:MergeItems on wikidata.org

2021-07-06 Thread Lydia_Pintscher
Lydia_Pintscher changed the task status from "Open" to "Stalled". Lydia_Pintscher added a comment. Sorry. I can't send someone on a treasure hunt like that. We need some links to concrete problem reports, wrong diffs or a problem description here to have a meaningful investigation. TASK

[Wikidata-bugs] [Maniphest] T277564: [Curious Facts] take separators into account for single value constraints

2021-07-06 Thread amy_rc
amy_rc added a comment. Thank you for the reminder :) I tested and found a similar case - restrictive cardiomyopathy has 2 values for Property Orphanet ID but is generally expected to have only one. F34540620: image.png

[Wikidata-bugs] [Maniphest] T285761: Add proper security headers to Query Builder

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Is this task about the current Toolforge deployment or the eventual production one? Because I expect the way to configure these headers will be totally different for both. TASK DETAIL https://phabricator.wikimedia.org/T285761 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T236893: edit tag for all edits done through the Wikidata UI

2021-07-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. > any edit made with a gadget or user script is not tagged this way I think this AC will have to be relaxed a bit, because some scripts that integrate very closely with the UI, such as currentDate

[Wikidata-bugs] [Maniphest] T285331: Document local development setup

2021-07-06 Thread karapayneWMDE
karapayneWMDE closed this task as "Resolved". karapayneWMDE added a comment. Both Guergana and Marius followed the guide with successful results. Great job! TASK DETAIL https://phabricator.wikimedia.org/T285331 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T285761: Add proper security headers to Query Builder

2021-07-06 Thread Michael
Michael added a comment. The eventual production one. We discussed that these headers are likely not to be added in the Query Builder code itself, but in the Apache server configuration, which probably does not live inside the Query Builder Repo. Though adding them to the test-server as

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread Michael
Michael removed a project: Patch-For-Review. Michael added a comment. In T283040#7197517 , @gerritbot wrote: > Change 703192 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup): > >

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-06 Thread Michael
Michael added a comment. (I'll be finishing my work on this, tackling the remaining ACs) TASK DETAIL https://phabricator.wikimedia.org/T283040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Michael,

[Wikidata-bugs] [Maniphest] T284826: Tracking of on wiki registrations and edits during newsletter campaign

2021-07-06 Thread GoranSMilovanovic
GoranSMilovanovic added a subscriber: Manuel. GoranSMilovanovic added a comment. @Hanna_Klein_WMDE @Merle_von_Wittich_WMDE @Manuel @Tobi_WMDE_SW The campaign analytics code is now running on an automatic daily schedule from stat1007's crontab. Please let me know until when do we

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

2021-07-06 Thread Michael
Michael added a comment. This recently added Setting on GitHub seems relevant here: https://github.blog/changelog/2021-07-01-github-actions-new-settings-for-maintainers/ TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T235499: Share config for using SASS

2021-07-06 Thread Michael
Michael added a project: Wikidata Design System. Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Tarrow, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T285849: record reviewer decision and associated metadata for a specific mismatch

2021-07-06 Thread Esc3300
Esc3300 added a comment. Maybe the following 9 choices can summarize what is usually found at Wikidata: | Both | Mismatch file | Wikidata | Sample: dob| Sample: pob | | |

  1   2   >