Lucas_Werkmeister_WMDE added a comment.
So what exactly do we want to prevent… - The `Wikimedia\Rdmbs\` namespace: this would be closest to the existing repo/client/lib usage test, but I’m pretty sure this isn’t feasible – there are several uses of other types in that namespace, notably `IResultWrapper`, that should be allowed. - The `I?(LoadBalancer|LBFactory)` types (with an exception to allow `ILoadBalancer::CONN_TRX_AUTOCOMMIT`, unless we copy that flag somewhere else). - The `getDBLoadBalancer(Factory)?` service container functions, and/or the old-style `wfGet[DL]B` global functions. Maybe both of the last ones? We want to disallow classes with `ILoadBalancer` parameters, and also inline usage like `MediaWikiServices::getInstance()->getDBLoadBalancer()->getConnection()`. TASK DETAIL https://phabricator.wikimedia.org/T286209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
