[Wikidata-bugs] [Maniphest] [Commented On] T196883: Compute an estimated label cache space usage for Items

2018-06-18 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. For a not full cluster you would expect to see no evictions. Depends on how you use it. If you let memcached remove items on his own when they expire (or if they never expire, like revision content) and create new items faster than the old expire then it is normal to

[Wikidata-bugs] [Maniphest] [Commented On] T198868: Do not get entity data from wb_terms when "prefetching" data for displaying on pages

2018-07-10 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Apparently, the "prefetching"/buffering is done for LabelDescriptionLookup services, so that when the label/description of particular item/property is to be shown multiple times (e.g. the item appears several times on a page), the label/description is only

[Wikidata-bugs] [Maniphest] [Commented On] T196883: Compute an estimated label cache space usage for Items

2018-07-11 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. So, 0.6GB of raw data ish? More like 6GB+TASK DETAILhttps://phabricator.wikimedia.org/T196883EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, gerritbot, Addshore, Aleksey_WMDE, WMDE-leszek, Gaboe420

[Wikidata-bugs] [Maniphest] [Commented On] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. The failure happened in code where we store a value with TTL 1s and next line try to get it back. The value was considered expired, so null was returned. The failure, probably, happened because we use time() and $date->getTimestamp() which return integer values.

[Wikidata-bugs] [Maniphest] [Claimed] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-08 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Addshore, WMDE-leszek, Aleksey_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Commented On] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Solution 2: Add 1 to the result of time() and $date->getTimestamp(). In this case effective TTL will always be up to 1 second greater than the given one. In production it will not matter; Tests already sleep for 2 seconds when TTL is 1 second, which is alw

[Wikidata-bugs] [Maniphest] [Commented On] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Both solutions don't work for test when 0 is given as TTL. Special case is needed.TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Addshore, WMDE-l

[Wikidata-bugs] [Maniphest] [Commented On] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Patch is merged - should be fixed. I think we should wait, lets say, for a week and if nothing pops up close the ticket.TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Changed Project Column] T196882: Create a code abstraction for "display entity link" use-case

2018-08-15 Thread Aleksey_WMDE
Aleksey_WMDE moved this task from Peer Review to Doing on the Wikidata-Ugly-Cat-Trailblaze (wb_terms trail blazing) board.Aleksey_WMDE added a comment. Found the problem with current solution. lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:142 if ( $row && $row->page_late

[Wikidata-bugs] [Maniphest] [Claimed] T173742: [Story] Editable Grammatical Feature of a Form (presistent)

2017-09-07 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T173742EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Jonas, Aklapper, daniel, Cinemantique, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah

[Wikidata-bugs] [Maniphest] [Block] T173744: [Story] Editable Representations of a Form (presistent)

2017-09-22 Thread Aleksey_WMDE
Aleksey_WMDE created subtask T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer. TASK DETAILhttps://phabricator.wikimedia.org/T173744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Addshore, Jonas

[Wikidata-bugs] [Maniphest] [Created] T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer

2017-09-22 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added projects: Wikidata, Lexicographical data, Story, Wikidata-Sprint. TASK DESCRIPTIONCurrently, we have only one serializer that is used everywhere. We need to have a distinction between storage layer serialization and public interface serialization

[Wikidata-bugs] [Maniphest] [Updated] T173744: [Story] Editable Representations of a Form (presistent)

2017-09-22 Thread Aleksey_WMDE
Aleksey_WMDE removed a subtask: T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer. TASK DETAILhttps://phabricator.wikimedia.org/T173744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Addshore, Jonas

[Wikidata-bugs] [Maniphest] [Updated] T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer

2017-09-22 Thread Aleksey_WMDE
Aleksey_WMDE edited parent tasks, added: T173742: [Story] Editable Grammatical Feature of a Form (presistent); removed: T173744: [Story] Editable Representations of a Form (presistent). TASK DETAILhttps://phabricator.wikimedia.org/T176473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Updated] T173742: [Story] Editable Grammatical Feature of a Form (presistent)

2017-09-22 Thread Aleksey_WMDE
Aleksey_WMDE added a subtask: T176473: [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer. TASK DETAILhttps://phabricator.wikimedia.org/T173742EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, Jonas, Aklapper

[Wikidata-bugs] [Maniphest] [Claimed] T150205: Refactor SpecialNewEntity so it can be extended to SpecialNewLexme

2016-12-12 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T150205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: WMDE-leszek, User-Daniel, Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Commented On] T154221: Special:NewLexeme should have validation for language and lexical category

2016-12-28 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I believe that it should be done in both places. As I understood ChangeOp is more (correct me if I'm wrong) Data Access Layer thingy and responsible for persistence: generate Summary and ensure that we won't get inconsistent data in DB. But in this case, I

[Wikidata-bugs] [Maniphest] [Commented On] T152491: Allow the EditEntity API module to work with all types of entities

2017-01-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Vote for dropping "callback" suffix.TASK DETAILhttps://phabricator.wikimedia.org/T152491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Aleksey_WMDECc: thiemowmde, Aleksey_WMDE, gerritbot, Jakob_WMDE, W

[Wikidata-bugs] [Maniphest] [Commented On] T152491: Allow the EditEntity API module to work with all types of entities

2017-01-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. As soon as we don't need to wrap it in a closure I don't see a reason to put callback in the name - it will only bring confusion. If we need to wrap it in a closure I don't understand why do we need an interface in the first place?T

[Wikidata-bugs] [Maniphest] [Commented On] T151329: [Task] investigate https://tools.wmflabs.org/wikidata-externalid-url to see if we can do some of that in Wikibase directly

2017-01-19 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Ways to build URL for external IDs Here are some thoughts on this topic: Replace $1 with id in URL template like http://domain.com/$1 (current way) CONS Doesn't work for a range of websites (see: current workaround) Use external IDs format that will work

[Wikidata-bugs] [Maniphest] [Commented On] T151329: [Task] investigate https://tools.wmflabs.org/wikidata-externalid-url to see if we can do some of that in Wikibase directly

2017-01-20 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Use Lua code as property's property to define formatter function (as a raw code or a module reference). also: * CONS Have to be supported by developers Probably I didn't put it the right way: The idea is to allow "any" user to add and/or

[Wikidata-bugs] [Maniphest] [Commented On] T151329: [Task] investigate https://tools.wmflabs.org/wikidata-externalid-url to see if we can do some of that in Wikibase directly

2017-02-03 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Draft: https://gerrit.wikimedia.org/r/#/c/335832/TASK DETAILhttps://phabricator.wikimedia.org/T151329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Gstupp, Glorian_WD, WMDE-leszek, Mbch331, Aleksey_WMDE

[Wikidata-bugs] [Maniphest] [Edited] T157687: wbentitysearch should match foreign entity IDs.

2017-02-10 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILSwbwbsearchentitysearchies currently has special handling for the case where the search term is an entity ID, and the respective entity exists. This code can be found in EntitySearchHelper::getExactMatchForEntityId(). It currently

[Wikidata-bugs] [Maniphest] [Retitled] T157687: wbsearchentities should match foreign entity IDs.

2017-02-10 Thread Aleksey_WMDE
Aleksey_WMDE changed the title from "wbentitysearch should match foreign entity IDs." to "wbsearchentities should match foreign entity IDs.". TASK DETAILhttps://phabricator.wikimedia.org/T157687EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefere

[Wikidata-bugs] [Maniphest] [Commented On] T157674: EntityChange must not use BasicEntityIdParser

2017-02-10 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I failed to find where this code is called. Can anyone help me? What page should I open to get EntityChange::getEntityId() called?TASK DETAILhttps://phabricator.wikimedia.org/T157674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T151329: [Task] investigate https://tools.wmflabs.org/wikidata-externalid-url to see if we can do some of that in Wikibase directly

2017-02-17 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Decision matrix: https://docs.google.com/spreadsheets/d/1CTxB7I2BodpdOh0JNwzrR-ekA63q2SzV1j1T4dyBtDcTASK DETAILhttps://phabricator.wikimedia.org/T151329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Gstupp

[Wikidata-bugs] [Maniphest] [Commented On] T69122: [Story] Create Hamcrest based replacement for PHPUnit's assertTag

2017-02-20 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Ups. Missed part about creating tickets for each separate extension. Anyway, there are patches removing assertTag() usages in extensions: WikibaseQualityConstraints Capiunto WikibaseQualityExternalValidation TASK DETAILhttps://phabricator.wikimedia.org/T69122EMAIL

[Wikidata-bugs] [Maniphest] [Triaged] T151578: Remove usage of ItemId::newFromNumber and PropertyId::newFromNumber

2017-02-20 Thread Aleksey_WMDE
Aleksey_WMDE triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T151578EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Aleksey_WMDECc: gerritbot, WMDE-leszek, thiemowmde, Aklapper, daniel, Th3d3v1ls, Ramalep

[Wikidata-bugs] [Maniphest] [Created] T158598: Create currently missing browser test (stories) for Wikibase Federation

2017-02-20 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added projects: Wikidata, Wikidata-Sprint.Herald added a subscriber: Aklapper. TASK DESCRIPTIONSome functionality of Federation feature is implemented, but no story is written. Known use cases: Add property ->type part of property on fore

[Wikidata-bugs] [Maniphest] [Retitled] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-20 Thread Aleksey_WMDE
Aleksey_WMDE changed the title from "Create currently missing browser test (stories) for Wikibase Federation" to "Create currently missing browser tests (stories) for Wikibase Federation". TASK DETAILhttps://phabricator.wikimedia.org/T158598EMAIL PREFERENCEShttps://phabr

[Wikidata-bugs] [Maniphest] [Edited] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS... * **(Not implemented)** Open Item with foreign property -> see property label * **What else?**...TASK DETAILhttps://phabricator.wikimedia.org/T158598EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Edited] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS... * Open Item with foreign property -> click on foreign property -> property view on foreign repository is opened * **(Not implemented)** Open Item with foreign property -> see property label...TASK DE

[Wikidata-bugs] [Maniphest] [Edited] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS... * Open Item with foreign property -> click on foreign property label -> property view on foreign repository is opened...TASK DETAILhttps://phabricator.wikimedia.org/T158598EMAIL PREFERENCEShttps://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Edited] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS... * Open `Special:ListProperties` -> can see foreign properties in the list (linked to property view on foreign repository) * **(Not implemented)** Open Item with foreign property -> see property label...TASK DETAI

[Wikidata-bugs] [Maniphest] [Edited] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILSSome functionality of Federation feature is implemented, but no story is written. **Background:** * System set up: items are local; properties are in foreign repository **Known use cases:**...PS: As soon as currently we don&#

[Wikidata-bugs] [Maniphest] [Edited] T158598: Create currently missing browser tests (stories) for Wikibase Federation

2017-02-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS... ** searching for the property using its fields: part of a label of the foreign property is put in theadd-property field -> the property appears in suggestion list... ** ** **(Not yet implemented)** searching for

[Wikidata-bugs] [Maniphest] [Updated] T57549: [Story] Add a new datatype for geoshapes

2017-03-09 Thread Aleksey_WMDE
Aleksey_WMDE added a subtask: T160069: Make GeoShape URL configurable. TASK DETAILhttps://phabricator.wikimedia.org/T57549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Aleksey_WMDECc: WMDE-leszek, Pasleim, LikeLifer, jmac, TheDJ, Jonas, Micru

[Wikidata-bugs] [Maniphest] [Closed] T160096: Create new entity should not be visible in special page list

2017-03-14 Thread Aleksey_WMDE
Aleksey_WMDE closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T160096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: WMDE-leszek, gerritbot, Aleksey_WMDE, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev

[Wikidata-bugs] [Maniphest] [Closed] T160069: Make GeoShape URL configurable

2017-03-14 Thread Aleksey_WMDE
Aleksey_WMDE closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T160069EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, Aklapper, Aleksey_WMDE, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden,

[Wikidata-bugs] [Maniphest] [Unblock] T57549: [Story] Add a new datatype for geoshapes

2017-03-14 Thread Aleksey_WMDE
Aleksey_WMDE closed subtask T160069: Make GeoShape URL configurable as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T57549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Aleksey_WMDECc: WMDE-leszek, Pasleim, LikeLifer, jmac, Th

[Wikidata-bugs] [Maniphest] [Edited] T159244: [Bug] Wrongly disabled save button while editing in value view experts

2017-03-14 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...#patch-for-review: * [ * [+] https://gerrit.wikimedia.org/r/331607...TASK DETAILhttps://phabricator.wikimedia.org/T159244EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-14 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...** [ x] https://github.com/wmde/WikibaseDataModel/pull/439 is an actual breaking change to SnakList. This removes 2 of 3 constructor parameters, along with the possibility to call it with nullTASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-14 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...** [ x] https://github.com/wmde/WikibaseDataModel/pull/714 does the same with the getHash() methodTASK DETAILhttps://phabricator.wikimedia.org/T157965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...** [ x] https://github.com/wmde/WikibaseDataModel/pull/713 moves the equals() method from the base class to the only implementation, and rewrites the tests from scratchTASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Edited] T159244: [Bug] Wrongly disabled save button while editing in value view experts

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [x] https://gerrit.wikimedia.org/r/331607 * [ * [x] Tag a ValueView release (this will be done with the release we need to do for T159876 anyway, also see https://gerrit.wikimedia.org/r/#/q/status:open+project:data-values

[Wikidata-bugs] [Maniphest] [Commented On] T155699: Integrate WikibaseLexeme with EditEntity API module

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Why is this task in "Monitoring" state?TASK DETAILhttps://phabricator.wikimedia.org/T155699EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aleksey_WMDE, gerritbot, Aklapper, Ladsgroup, Adik2382,

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [x] https://github.com/wmde/WikibaseDataModel/pull/654 is an unrelated (braking) bugfix I would like to see in this release. * [ * [x] https://github.com/wmde/WikibaseDataModel/pull/719 adds release notesTASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [x] https://github.com/wmde/WikibaseDataModel/pull/719 adds release notes. * [ * [x] Tag the releaseTASK DETAILhttps://phabricator.wikimedia.org/T157965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [ ] https://gerrit.wikimedia.org/r/342817 updates Wikibase to use DataModel 7.0. https://gerrit.wikimedia.org/r/#/c/342817 The 7.0.0 milestone on GitHub: https://github.com/wmde/WikibaseDataModel/milestone/20TASK

[Wikidata-bugs] [Maniphest] [Edited] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-15 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [ ] https://gerrit.wikimedia.org/r/342817 updates Wikibase to use DataModel 7.0. https://gerrit.wikimedia.org/r/#/c/342817 The 7.0.0 milestone on GitHub: https://github.com/wmde/WikibaseDataModel/milestone/20TASK

[Wikidata-bugs] [Maniphest] [Edited] T160522: [Story] List for Forms

2017-03-21 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...Then List for Forms should be there And for each Form there is a representation and an ID And each representation enclosed in tag having lang attribute with "some language" as a value ```TASK D

[Wikidata-bugs] [Maniphest] [Commented On] T161201: Run browser tests in CI

2017-03-23 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Done?TASK DETAILhttps://phabricator.wikimedia.org/T161201EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Aleksey_WMDECc: Aleksey_WMDE, gerritbot, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99

[Wikidata-bugs] [Maniphest] [Lowered Priority] T158108: Incorrect display of Special:ListProperties (regression)

2017-03-27 Thread Aleksey_WMDE
Aleksey_WMDE moved this task from Review to Done on the Wikidata-Sprint board.Aleksey_WMDE lowered the priority of this task from "High" to "Normal". TASK DETAILhttps://phabricator.wikimedia.org/T158108WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EM

[Wikidata-bugs] [Maniphest] [Lowered Priority] T161201: Run browser tests in CI

2017-03-27 Thread Aleksey_WMDE
Aleksey_WMDE moved this task from Review to Done on the Wikidata-Sprint board.Aleksey_WMDE lowered the priority of this task from "High" to "Normal". TASK DETAILhttps://phabricator.wikimedia.org/T161201WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EM

[Wikidata-bugs] [Maniphest] [Updated] T157965: [Task] Release Wikibase DataModel 7.0.0

2017-03-27 Thread Aleksey_WMDE
Aleksey_WMDE removed a project: Patch-For-Review.Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [x] Tag the release. * [ * [x] https://gerrit.wikimedia.org/r/342817 updates Wikibase to use DataModel 7.0TASK DETAILhttps://phabricator.wikimedia.org/T157965EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T154590: Concept URIs of foreign entities should be based on URL of the repo entity belongs to, and not be including a prefixed entity ID

2017-03-27 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Is it "Done"?TASK DETAILhttps://phabricator.wikimedia.org/T154590EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, Aleksey_WMDECc: Aleksey_WMDE, gerritbot, daniel, WMDE-leszek, thiemowmde, Aklapper, Adik2382,

[Wikidata-bugs] [Maniphest] [Commented On] T160524: [Story] Add Form to list of Forms

2017-03-29 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I remember someone was complaining that we don't experiment. Statement like "This is a subclass of the existing listview JS code" or "This uses the toolbar infrastructure", as I see it, instantly throw away any opportunity to make things d

[Wikidata-bugs] [Maniphest] [Commented On] T160524: [Story] Add Form to list of Forms

2017-03-30 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. More or lessTASK DETAILhttps://phabricator.wikimedia.org/T160524EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aleksey_WMDE, thiemowmde, Jan_Dittrich, Jonas, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Commented On] T161359: WikidataBuildResources not installable

2017-04-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. What is left?TASK DETAILhttps://phabricator.wikimedia.org/T161359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, Aleksey_WMDECc: Aleksey_WMDE, gerritbot, WMDE-leszek, aude, thiemowmde, Aklapper, Mattflaschen-WMF, Adik2382

[Wikidata-bugs] [Maniphest] [Changed Project Column] T160623: Move SiteLinkRdfBuilder from RdfBuilder to Item entitytype definition

2017-04-08 Thread Aleksey_WMDE
Aleksey_WMDE moved this task from Review to Doing on the Wikidata-Sprint board.Aleksey_WMDE added a comment. Tests are failing. I'm moving this ticket backTASK DETAILhttps://phabricator.wikimedia.org/T160623WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T161631: [Task] Remove "all" option for Special:EntitiesWithout*"

2017-04-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Done?TASK DETAILhttps://phabricator.wikimedia.org/T161631EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, Aleksey_WMDECc: Aleksey_WMDE, hoo, thiemowmde, aude, gerritbot, daniel, Aklapper, Lydia_Pintscher, Adik2382

[Wikidata-bugs] [Maniphest] [Edited] T161631: [Task] Remove "all" option for Special:EntitiesWithout*"

2017-04-08 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...* [x] https://gerrit.wikimedia.org/r/345782 * [ * [x] https://gerrit.wikimedia.org/r/345532TASK DETAILhttps://phabricator.wikimedia.org/T161631EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo

2017-04-25 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Seems like task has incomplete description. I cannot understand what the problem is and also what needs to be changed and how. Can anyone provide more info?TASK DETAILhttps://phabricator.wikimedia.org/T75643EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Claimed] T162788: [Story] basic non-editable list of Grammatical Features of a Form

2017-04-25 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T162788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, Lydia_Pintscher, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah

[Wikidata-bugs] [Maniphest] [Claimed] T163722: [Story] viewable statements on a Form

2017-04-27 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task.Aleksey_WMDE moved this task from Backlog to Doing on the Wikidata-Sprint board. TASK DETAILhttps://phabricator.wikimedia.org/T163722WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Edited] T163775: [Task] Release DataValues Geo 2.0.0

2017-05-08 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILS...#patch-for-review: * [ * [x] https://github.com/DataValues/Geo/pull/53 adds missing sanity checks to GlobeCoordinateValue. * [ * [x] https://github.com/DataValues/Geo/pull/23 changes all confusing "GeoCoordinate…" c

[Wikidata-bugs] [Maniphest] [Block] T163723: [Story] non-persistently editable statements on a Form

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE created subtask T165480: Bix bug with Froms' statements always switching to edit mode on page load. TASK DETAILhttps://phabricator.wikimedia.org/T163723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, Lydia_Pint

[Wikidata-bugs] [Maniphest] [Created] T165480: Bix bug with Froms' statements always switching to edit mode on page load

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added projects: Story, Wikidata, Lexicographical data, Wikidata-Sprint. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T165480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Jonas

[Wikidata-bugs] [Maniphest] [Block] T163723: [Story] non-persistently editable statements on a Form

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE created subtask T165481: When add new form statement list should be rendered correctly. TASK DETAILhttps://phabricator.wikimedia.org/T163723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Created] T165481: When add new form statement list should be rendered correctly

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added projects: Story, Wikidata, Lexicographical data, Wikidata-Sprint. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T165481EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: WMDE-leszek

[Wikidata-bugs] [Maniphest] [Block] T163723: [Story] non-persistently editable statements on a Form

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE created subtask T165482: When save a Form's statement it should be persisted on the client and rendered correctly. TASK DETAILhttps://phabricator.wikimedia.org/T163723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Akl

[Wikidata-bugs] [Maniphest] [Created] T165482: When save a Form's statement it should be persisted on the client and rendered correctly

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added projects: Story, Wikidata, Lexicographical data, Wikidata-Sprint. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T165482EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: WMDE-leszek

[Wikidata-bugs] [Maniphest] [Edited] T165480: Bix bug with Froms' statements always switching to edit mode on page load

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILSCurrently, when you open a Lexeme page, Form's statements rendered correctly, but switch to edit mode as soon as page is loaded. They should stay in view mode unless user clicked an Edit button.TASK DETAIL

[Wikidata-bugs] [Maniphest] [Edited] T165481: When add new form statement list should be rendered correctly

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILSCurrently, when one clicks add (Form) button, the added form contains text "Statements' section will be here" instead of actual statement list. What expected is that instead of this text there should be statem

[Wikidata-bugs] [Maniphest] [Edited] T165482: When save a Form's statement it should be persisted on the client and rendered correctly

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE edited the task description. (Show Details) EDIT DETAILSCurrently, when you change and save statement on the Lexeme Form it is persisted as Lexeme's statement (also, sometimes error message appears and nothing is persisted) How it should work: when I click save on changed (or

[Wikidata-bugs] [Maniphest] [Retitled] T165480: Fix bug with Froms' statements always switching to edit mode on page load

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE changed the title from "Bix bug with Froms' statements always switching to edit mode on page load" to "Fix bug with Froms' statements always switching to edit mode on page load". TASK DETAILhttps://phabricator.wikimedia.org/T165480EMAIL PREFERENCEShtt

[Wikidata-bugs] [Maniphest] [Commented On] T165328: Allow entity sub-structures to be treated like entities (so called sub-entities).

2017-05-16 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Introduce a SubEntityContainer interface, with methods getSubEntity and setSubEntity. I don't think it should be done like this. I remember that we discussed that Forms, for example, will have consequent ids (F1, F2, F3, ...) which will be controlled by the L

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2017-05-17 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I downloaded the Q183 entity and removed wbEntity manually, and then compared sizes: $ curl https://www.wikidata.org/wiki/Q183 > Q183.html $ # Manually removed wbEntity and saved as Q183_no_wbEntity.html $ cat Q183.html | wc -c 3316781 $ gzip -c Q183.html | wc

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2017-05-17 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Also, you've made a mistake in your command, this one is correct: $ curl --compressed -so /dev/null https://www.wikidata.org/wiki/Q183 -w '%{size_download}' 260312TASK DETAILhttps://phabricator.wikimedia.org/T85499EMAIL PREFERENCEShttps://phabricato

[Wikidata-bugs] [Maniphest] [Claimed] T165481: When add new form statement list should be rendered correctly

2017-05-18 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T165481EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, WMDE-leszek, Jonas, thiemowmde, Lydia_Pintscher, Aklapper, Aleksey_WMDE, GoranSMilovanovic, Adik2382

[Wikidata-bugs] [Maniphest] [Claimed] T165482: When save a Form's statement it should be persisted on the client and rendered correctly

2017-05-22 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T165482EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, WMDE-leszek, Jonas, thiemowmde, Lydia_Pintscher, Aklapper, Aleksey_WMDE, GoranSMilovanovic, Adik2382

[Wikidata-bugs] [Maniphest] [Commented On] T165482: When save a Form's statement it should be persisted on the client and rendered correctly

2017-05-24 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Add a browser test!TASK DETAILhttps://phabricator.wikimedia.org/T165482EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, WMDE-leszek, Jonas, thiemowmde, Lydia_Pintscher, Aklapper, Aleksey_WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T157974: [Task] rework "term box" and header for Lexeme

2017-05-31 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T157974EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: WMDE-leszek, Jan_Dittrich, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Closed] T165482: When save a Form's statement it should be persisted on the client and rendered correctly

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T165482EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, WMDE-leszek, Jonas, thiemowmde, Lydia_Pintscher, Aklapper, Al

[Wikidata-bugs] [Maniphest] [Unblock] T163723: [Story] non-persistently editable statements on a Form

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE closed subtask T165480: Fix bug with Froms' statements always switching to edit mode on page load as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T163723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_W

[Wikidata-bugs] [Maniphest] [Unblock] T163723: [Story] non-persistently editable statements on a Form

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE closed subtask T165482: When save a Form's statement it should be persisted on the client and rendered correctly as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T163723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Closed] T165480: Fix bug with Froms' statements always switching to edit mode on page load

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T165480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, Jonas, thiemowmde, WMDE-leszek, Lydia_Pintscher, Aklapper, Al

[Wikidata-bugs] [Maniphest] [Commented On] T167136: Evaluate vue.js browser compatibility

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Note that Vue.js only supports ES5-compliant browsers (IE8 and below are not supported). From https://github.com/vuejs/vue [vuex] vuex requires a Promise polyfill in this browser. From the source code (https://github.com/vuejs/vuex/blob

[Wikidata-bugs] [Maniphest] [Commented On] T167145: Evaluate OOUI.js integration with vue.js

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I would say it depends on the exact component we might want to use, but it is possible. Here is example of jQuery widget integration (OOUI.js widgets are conceptually similar): https://vuejs.org/v2/examples/select2.html Example of Wikibase widget integration: https

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. @Ladsgroup What I've noticed that this pattern is wrong. For example: MediaWiki:Gadget-Merge.js contains access to wbEntityId but not to wbEntity. Can you try it with regexp: \bwbEntity\b ? Or may be like: :~$ mwgrep '\'wbEntity\&#x

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. To check correctness: MediaWiki:Gadget-AuthorityControl.js should be in the listTASK DETAILhttps://phabricator.wikimedia.org/T85499EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Ladsgroup, gerritbot, Aleksey_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2017-06-06 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Script to download all found scripts: #!/usr/bin/env bash curl 'https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-AuthorityControl.js&action=""> > 'MediaWiki:Gadget-AuthorityControl.js' curl 'https://www.wikidat

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2017-06-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I've downloaded all the scripts that present in the former list and analyzed them manually here summary of the analysis. Total: 58 scripts Discovered use cases: Check only for existence of wbEntity: 11 scripts Check only for existence of wbEntity.sitelink

[Wikidata-bugs] [Maniphest] [Created] T167432: Run Wikibase daily browser tests on Jenkins

2017-06-08 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONNow Wikibase daily browser tests run using Souce Labs. And they randomly fail for reasons not related to the code but related to Souce Labs API. See T152963 Increase in

[Wikidata-bugs] [Maniphest] [Commented On] T167432: Run Wikibase daily browser tests on Jenkins

2017-06-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. I didn't know what tags should I add, so can you help me with that?TASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Jonas, thiemowmde, WMDE-leszek, zeljkofi

[Wikidata-bugs] [Maniphest] [Commented On] T167432: Run Wikibase daily browser tests on Jenkins

2017-06-08 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. We talked with @hashar before and I said that I'll try to create a patch for config creating and enabling this job. What can I say: I've failed. Need your help, @hashar @zeljkofilipinTASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Updated] T165574: [Story] Multi-lingual Glosses

2017-06-14 Thread Aleksey_WMDE
Aleksey_WMDE closed this task as a duplicate of T165567: [Story] Editable Glosses on Senses (non-persistent). TASK DETAILhttps://phabricator.wikimedia.org/T165574EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Merged] T165567: [Story] Editable Glosses on Senses (non-persistent)

2017-06-14 Thread Aleksey_WMDE
Aleksey_WMDE merged a task: T165574: [Story] Multi-lingual Glosses. TASK DETAILhttps://phabricator.wikimedia.org/T165567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, Lydia_Pintscher, Cinemantique, GoranSMilovanovic, QZanden, Izno

[Wikidata-bugs] [Maniphest] [Block] T167143: Decide on a server side rendering mechanism for vue.js components (for Wikibase)

2017-06-14 Thread Aleksey_WMDE
Aleksey_WMDE created subtask T167895: Create basic VueJs templating component in PHP. TASK DETAILhttps://phabricator.wikimedia.org/T167143EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: gerritbot, Aklapper, Jonas, thiemowmde, Aleksey_WMDE

[Wikidata-bugs] [Maniphest] [Created] T167895: Create basic VueJs templating component in PHP

2017-06-14 Thread Aleksey_WMDE
Aleksey_WMDE created this task.Aleksey_WMDE added projects: Wikidata, Wikidata-Sprint, Patch-For-Review.Herald removed a project: Patch-For-Review. TASK DESCRIPTIONCreate basic VueJs templating component in PHP that will be able to handle cases that we need.TASK DETAILhttps

  1   2   3   >