[Wikidata-bugs] [Maniphest] [Commented On] T134097: Primary Sources breaking other gadgets and user scripts due to "ReferenceError: Can't find variable: async"

2016-05-04 Thread Ricordisamoa
Ricordisamoa added a comment. Perhaps it'd be cleaner to split MediaWiki:Gadget-PrimarySources-async.js into its own hidden gadget (i.e. ResourceLoader module), make the 'real' gadget depend on it and `require()` it. TASK DETAIL https://phabricator.wikimedia.org/T134097 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134097: Primary Sources breaking other gadgets and user scripts due to "ReferenceError: Can't find variable: async"

2016-05-01 Thread Ricordisamoa
Ricordisamoa added a comment. In https://phabricator.wikimedia.org/T134097#2254500, @Sjoerddebruin wrote: > Can you also do a pull request on the GitHub project, to avoid introducing the error again? https://github.com/google/primarysources/pull/96 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134097: Primary Sources breaking other gadgets and user scripts due to "ReferenceError: Can't find variable: async"

2016-05-01 Thread Sjoerddebruin
Sjoerddebruin added a comment. In https://phabricator.wikimedia.org/T134097#2254479, @Ricordisamoa wrote: > Because of T108655: Standardise on how to access/register JavaScript interfaces , ResourceLoader closures have a `module` argument,