[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
gerritbot added a comment. Change 354725 merged by jenkins-bot: [integration/config@master] Reduce the number of Wikibase jobs https://gerrit.wikimedia.org/r/354725TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, WMDE-leszek, Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
WMDE-leszek added a comment. With https://phabricator.wikimedia.org/T161895 in, I've had another look at Wikibase Jenkins jobs. Current jobs running PHPUnit jobs look as follows: test jobs JobWikibase componentsPHPDB mwext-testextension-hhvm-composer-jessieRepo and Clienthhvmmysql mwext-Wikibase-repo-tests-sqlite-hhvm-jessieRepo and Clienthhvmsqlite mwext-Wikibase-client-tests-mysql-hhvm-jessieClienthhvmmysql mwext-Wikibase-client-tests-sqlite-hhvm-jessieClienthhvmsqlite gate-and-submit jobs JobWikibase componentsPHPDB mwext-testextension-php55-composer-trustyRepo and Clientphp55mysql mwext-testextension-hhvm-composer-jessieRepo and Clienthhvmmysql mwext-Wikibase-repo-tests-sqlite-php55-trustyRepo and Clientphp55sqlite mwext-Wikibase-repo-tests-sqlite-hhvm-jessieRepo and Clienthhvmsqlite mwext-Wikibase-client-tests-mysql-php55-trustyClientphp55mysql mwext-Wikibase-client-tests-sqlite-php55-trustyClientphp55sqlite mwext-Wikibase-client-tests-mysql-hhvm-jessieClienthhvmmysql mwext-Wikibase-client-tests-sqlite-hhvm-jessieClienthhvmsqlite Possible improvements: It seems we don't need jobs running tests against sqlite with only Client enabled. We should be OK with only running does test in the Repo+Client set up Similar thing regarding php55 job - it should be enough to only run sqlite job with hhvm php flavour We actually might not even need mwext-testextension-php55-composer-trusty but dropping this would mean Wikibase is configured different than all other extensions, so we don't want to follow this path :) Further optimisation could be to make sqlite jobs only run PHPUnit tests that require sqlite, not all tests. There is only handful of those tests in Wikibase, so this would make this job/jobs faster. But this is something to do as a next step. So what I believe would make sense from the Wikibase/Wikidata point of view would be the following set of jobs: test JobWikibase componentsPHPDB mwext-testextension-hhvm-composer-jessieRepo and Clienthhvmmysql mwext-Wikibase-repo-tests-sqlite-hhvm-jessieRepo and Clienthhvmsqlite mwext-Wikibase-client-tests-mysql-hhvm-jessieClienthhvmmysql gate and submit JobWikibase componentsPHPDB mwext-testextension-php55-composer-trustyRepo and Clientphp55mysql mwext-testextension-hhvm-composer-jessieRepo and Clienthhvmmysql mwext-Wikibase-repo-tests-sqlite-hhvm-jessieRepo and Clienthhvmsqlite mwext-Wikibase-client-tests-mysql-php55-trustyClientphp55mysql mwext-Wikibase-client-tests-mysql-hhvm-jessieClienthhvmmysql Together with @Addshore we've tinkered a patch dropping a few jobs as describe above: https://gerrit.wikimedia.org/r/354725. @hashar: if you think changes like this make sense for you, we would be happy to try it out!TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
WMDE-leszek added a comment. What @Krinkle has suggested sounds like a good plan at glance! We just need to make sure that all tests are run in such set up. I will be looking at differences between jobs, and keep spamming here if I find something relevant. Wikimedia solely uses MySQL, my understanding is that the sqlite jobs were kept around since developers tend to use sqlite on their development box. This in general sounds like a good explanation of why sqlite jobs are around. As such it makes them quite good candidates for jobs to be kicked out. However, as far as I understand, there are few tests that are skipped in mysql jobs and only run as part of sqlite jobs. Those are test of functionality where there some more complex DB queries are done. PHPUnit test use temporary tables and MySQL does not allow self-joins on temporary tables, so those test must be skipped. We still want to have those test run, so that seems like a good reason to That said, there is only a handful of such tests. Maybe it makes sense to have a sqlite job running only those tests that are skipped in mysql jobs? That would should be quite performant, I assume. We could use a separate @group tag for those or so. As far as I know, for such a sqlite job it would not be needed to have repo/client split (just run test with both components enabled), same for php55/hhvm (hhvm should be enough I guess).TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, Salgo60, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
Krinkle added a comment. Current For gate-and-submit we end up triggering: Job nameDescription npm-node-6-jessie_javascript_ lint/style and others composer-php55-trustylint/style composer-hhvm-jessielint/style php55lintLint on permanent slave. Composer already run parallel-lint mwext-testextension-php55-composer-trustyPHPUnit mwext-testextension-hhvm-composer-jessiePHPUnit mwext-qunit-composer-jessieQUnit tests with Karma mwext-mw-selenium-composer-jessieBrowser tests based on ruby/selenium Job nameAppDB PHP mwext-Wikibase-repo-tests-sqlite-php55-trustyReposqlite php55 mwext-Wikibase-repo-tests-sqlite-hhvm-jessieReposqliteHHVM mwext-Wikibase-client-tests-mysql-php55-trustyClientMySQLphp55 mwext-Wikibase-client-tests-sqlite-php55-trustyClient sqlitephp55 mwext-Wikibase-client-tests-mysql-hhvm-jessieClientMysqlHHVM mwext-Wikibase-client-tests-sqlite-hhvm-jessieClientsqliteHHVM Propose to change: mwext-testextension-php55-composer-trusty include composer test (for lint/style) mwext-testextension-hhvm-composer-trusty include composer test (for lint/style) Merge mwext-Wikibase-repo-* and mwext-Wikibase-client-* tests. Propose to remove: php55lint (redundant with composer-php55-trusty) composer-php55-trusty (redundant with mwext-testextension-php55-composer-trusty) composer-hhvm-jessie (redundant with mwext-testextension-hhvm-composer-trusty) all 6 mwext-Wikibase-*-tests-* jobs. Redunant with mwext-testextension-*-composer-*. Propose to add: mwext-testextension-hhvm-sqlite-composer-trusty to ensure sqlite is covered in addition to mysql. No need to cover it with both hhvm and php55. Questions: What is the difference between mwext-Wikibase-*-tests-* and mwext-testextension-*-composer-*? It seems like the latter already runs all PHPUnit tests (both client and repo). It also varies by PHP flavour already, but not by RDBMS. It would make sense to add a third variation to sqlite with one of the PHP flavours. Job nameDescription npm-node-6-jessie_javascript_ lint/style and others mwext-Wikibase-tests-php55-mysqlComposer test (lint, style, PHPUnit) mwext-Wikibase-tests-hhvm-mysqlComposer test (lint, style, PHPUnit) mwext-Wikibase-tests-hhvm-sqliteComposer test (lint, style, PHPUnit) mwext-qunit-composer-jessieQUnit tests with Karma mwext-mw-selenium-composer-jessieBrowser tests based on ruby/selenium This means a small amount is duplicated (2x lint/style for HHVM) but that seems marginal and unimportant, given they run in parallel anyway.TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
hashar added a comment. Moving some jobs to postmerge would at least prevent them from running on every patchsets. The postmerge jobs reports on the Gerrit change that triggered them, so most probably developers will pay attention to the eventual failure message. Eg move out of test / gate-and-submit to postmerge the three jobs: mwext-Wikibase-repo-tests-sqlite-php55-trusty mwext-Wikibase-client-tests-sqlite-php55-trusty mwext-Wikibase-client-tests-sqlite-hhvm-jessie TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
Addshore added a comment. In T160989#3121754, @Ladsgroup wrote: What about moving it to Travis? It would help because the number of triggered jobs will be limited to the ones that get merged. I'm not sure if anyone follows travis reports in github though. Personally I would prefer to move it to a post merge job than move it to travis.TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
Ladsgroup added a comment. In T160989#3118490, @Addshore wrote: Drop the Zend PHP 5.5 jobs entirely Wikimedia is on HHVM and we don't really release Wikibase for outside world reuse. Would let us drop three jobs: Wikibase is used outside of Wikimedia and dropping all testing for zend PHP would probably be a bad idea. What about moving it to Travis? It would help because the number of triggered jobs will be limited to the ones that get merged. I'm not sure if anyone follows travis reports in github though.TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
Addshore added a comment. Drop the Zend PHP 5.5 jobs entirely Wikimedia is on HHVM and we don't really release Wikibase for outside world reuse. Would let us drop three jobs: Wikibase is used outside of Wikimedia and dropping all testing for zend PHP would probably be a bad idea.TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
