[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 444250 merged by jenkins-bot: [mediawiki/extensions/Thanks@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/444250TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, CucyNoiD, Nandana, NebulousIris, Kieubinhtb, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, _jensen, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453941 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use ExtensionRegistry check for Echo in tests instead of class_exists https://gerrit.wikimedia.org/r/453941TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453939 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] use ::class for class_exists checks instead of string https://gerrit.wikimedia.org/r/453939TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde added a comment. Sorry, I confused two ideas: Yes, we certainly can create a sniff that forbids class_exists( 'string' ). To make a sniff understand if a class_exists can be replaced with an ExtensionRegistry check, the sniff would need to know which class belongs to which extension, and if the extension even can be used via ExtensionRegistry. TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453941 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Use ExtensionRegistry check for Echo in tests instead of class_exists https://gerrit.wikimedia.org/r/453941TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453939 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] use ::class for class_exists checks instead of string https://gerrit.wikimedia.org/r/453939TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
Addshore added a comment. In T183096#4513119, @thiemowmde wrote: I wish there would be a way to automatically forbid problematic class_exists, while still allowing non-problematic ones, but I can't think of a way. That sounds like it should be possible in code sniffer. I suggest to close this task as "done" as the bigger part of the issue (references to classes hidden in strings) got resolved for the most part. Can close it as don, and file follow ups for the CirrusSearch cases.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453761 merged by jenkins-bot: [mediawiki/extensions/TimedMediaHandler@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/453761TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453760 merged by jenkins-bot: [mediawiki/extensions/WikiEditor@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/453760TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
TheDJ added a comment. whoops, copied a little bit too much there. Those weren't meant to attach to this ticket.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TheDJCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453761 had a related patch set uploaded (by TheDJ; owner: TheDJ): [mediawiki/extensions/TimedMediaHandler@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/453761TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 453760 had a related patch set uploaded (by TheDJ; owner: TheDJ): [mediawiki/extensions/WikiEditor@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/453760TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde added a comment. The Wikibase codebase currently contains about 40 class_exists checks. The vast majority checks for CirrusSearch – I guess because that extension still doesn't have an extension.json. Just making people aware of the issue is not very successful, as the most problematic class_exists( '…' ) checks with strings instead of the ::class feature get introduced repeatedly, some just a few days ago (https://gerrit.wikimedia.org/r/449209). I wish there would be a way to automatically forbid problematic class_exists, while still allowing non-problematic ones, but I can't think of a way. I suggest to close this task as "done" as the bigger part of the issue (references to classes hidden in strings) got resolved for the most part.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
Addshore added a comment. Is there an up to date list of what needs to be done here? This task is pretty hard to follow as it is! :)TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, KasiaWMDE, Izno, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 444250 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [mediawiki/extensions/Thanks@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/444250TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, Dinoguy1000, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 407873 merged by jenkins-bot: [mediawiki/extensions/AbuseFilter@master] Use ExtensionRegistry to check if CheckUser is installed https://gerrit.wikimedia.org/r/407873TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 407873 had a related patch set uploaded (by Matěj Suchánek; owner: Huji): [mediawiki/extensions/AbuseFilter@master] Use ExtensionRegistry to check if CheckUser is installed https://gerrit.wikimedia.org/r/407873TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400398 merged by jenkins-bot: [mediawiki/extensions/MobileFrontend@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/400398TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400395 merged by jenkins-bot: [mediawiki/extensions/Echo@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/400395TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400576 merged by jenkins-bot: [mediawiki/extensions/CirrusSearch@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/400576TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400576 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)): [mediawiki/extensions/CirrusSearch@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/400576TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400463 merged by jenkins-bot: [mediawiki/extensions/Score@master] Replace class_exists with ExtensionRegistry checks https://gerrit.wikimedia.org/r/400463TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400463 had a related patch set uploaded (by Ebe123; owner: Ebe123): [mediawiki/extensions/Score@master] Replace class_exists with ExtensionRegistry checks https://gerrit.wikimedia.org/r/400463TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde added a comment. @Ladsgroup, the numbers in my comment are from my local codebase and not something others can work on. Note that the only problematic class_exists checks are the ones that don't utilize the …::class feature. class_exists( Babel::class ) is fine, but class_exists( '\Babel' ) is not. Only the later should be cleaned up systematically. In many cases it's just fine to do a class_exists check, especially if the code below actually uses the very same class. For example, class_exists( WikibaseRepo::class ) should (in my opinion) not be replaced with an extension registration check, because that would introduce the problematic string "Wikibase Repository" I don't want to hard-code in to many places.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400398 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/MobileFrontend@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/400398TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
Ladsgroup added a comment. http://codesearch.wmflabs.org/extensions/?q=class_exists=nope== says 381 cases which most of them are just to check extensions.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 400395 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Echo@master] Use ExtensionRegistry instead of class_exists https://gerrit.wikimedia.org/r/400395TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398794 merged by jenkins-bot: [mediawiki/extensions/CentralAuth@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398794TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398797 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398797TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398820 merged by jenkins-bot: [mediawiki/extensions/TwoColConflict@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398820TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398831 merged by jenkins-bot: [mediawiki/extensions/ORES@master] Use ExtensionRegistry to check if BetaFeatures is loaded https://gerrit.wikimedia.org/r/398831TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398831 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/ORES@master] Use ExtensionRegistry to check if BetaFeatures is loaded https://gerrit.wikimedia.org/r/398831TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398820 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch): [mediawiki/extensions/TwoColConflict@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398820TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398796 merged by jenkins-bot: [mediawiki/extensions/AdvancedSearch@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398796TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398797 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)): [mediawiki/extensions/Wikibase@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398797TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398796 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)): [mediawiki/extensions/AdvancedSearch@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398796TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
gerritbot added a comment. Change 398794 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)): [mediawiki/extensions/CentralAuth@master] Replace class_exists with proper extension registration checks https://gerrit.wikimedia.org/r/398794TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde added a comment. Feel free to pick this up too, but please create a separate ticket. I'm going to close this when all code bases relevant for Wikidata have this resolved. I did a quick search in my dev code base (which contains many more extensions) and found the following class names appear more than once in class_exists checks. Many of them are very obviously not checks for classes, but for enabled extensions. EchoEvent (18) BetaFeatures (15) CirrusSearch (15) CentralAuthUser (7) CentralAuthSpoofUser (6) EventLogging (6) LqtDispatch (6) GeoData (5) ResourceLoaderSchemaModule (4) SiteMatrix (4) AbuseFilter (3) AntiSpoofAuthenticationRequest (3) CommentStore (3) GuidedTourHooks (3) RenameuserSQL (3) ThanksHooks (3) WikiEditorHooks (3) ApiUsageException (2) AuthManager (2) Babel (2) EchoHooks (2) GlobalBlocking (2) Imagick (2) MobileContext (2) PageImages (2) PageProps (2) PHPUnit_Framework_TestCase (2) Scribunto_LuaEngineTestBase (2) tidy (2) TitleBlacklist (2) VisualEditorHooks (2) WikibaseClient (2) XMLReader (2) TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, CXuesong, Zoranzoki21, Lea_WMDE, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
