[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 506573 abandoned by BPirkle:
  Remove references to db fields rev_text_id and ar_text_id
  
  Reason:
  Extremely outdated
  
  https://gerrit.wikimedia.org/r/506573

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel, gerritbot
Cc: holger.knust, BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, 
aude, Aklapper, daniel, Alter-paule, Beast1978, CBogen, Un1tY, eprodromou, 
Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 538599 restored by Daimona Eaytoy:
  Use a BlobStore for storing var dumps.
  
  Reason:
  This can be rebased on top of Icada720ab62d187f2dd0c4760697e465f2ff to 
remove any concern about back-compat stuff.
  
  @Daniel would you like to do that yourself, or should I revamp this patch and 
you/CPT will review?
  
  https://gerrit.wikimedia.org/r/538599

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel, gerritbot
Cc: holger.knust, BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, 
aude, Aklapper, daniel, Beast1978, CBogen, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 524560 abandoned by Daniel Kinzler:
  Revision::getRevisionText(): support old schemas
  
  Reason:
  per Anomie's comment
  
  https://gerrit.wikimedia.org/r/524560

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: holger.knust, BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, 
aude, Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 442358 abandoned by Daniel Kinzler:
  MCR WIP Remove references to rev_text_id and ar_text_id
  
  Reason:
  Obsolete,see I5ea972bb07ca1cfb3a2ad8ef120aef77e460745c
  
  https://gerrit.wikimedia.org/r/442358

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: holger.knust, BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, 
aude, Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 538599 abandoned by Daniel Kinzler:
  Use a BlobStore for storing var dumps.
  
  Reason:
  see I22cf698c5be77506727cbd227c67e037a5d89b5c
  
  https://gerrit.wikimedia.org/r/538599

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: holger.knust, BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, 
aude, Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 538599 had a related patch set uploaded (by Daniel Kinzler; owner: 
Daniel Kinzler):
  [mediawiki/extensions/AbuseFilter@master] Use a BlobStore for stroing var 
dumps.
  
  https://gerrit.wikimedia.org/r/538599

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: holger.knust, BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, 
aude, Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 538113 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
  [mediawiki/extensions/WikimediaMaintenance@master] Remove obsolete scripts 
that use rev_text_id.
  
  https://gerrit.wikimedia.org/r/538113

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: holger.knust, gerritbot
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 524593 had a related patch set uploaded (by Daniel Kinzler; owner: 
Daniel Kinzler):
  [mediawiki/extensions/Translate@master] Remove direct access to text table
  
  https://gerrit.wikimedia.org/r/524593

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, 
_jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  It seems like our search for usages in extensions failed to take into account 
usages in joins. There is quite a bit of code that does this. Critically, the 
Translate extension heavily depends on rev_text_id in joins.
  
  Here's the code search:
  
https://codesearch.wmflabs.org/extensions/?q=rev_text_id%7Car_text_id=nope==

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, 
_jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 524560 had a related patch set uploaded (by Daniel Kinzler; owner: 
Daniel Kinzler):
  [mediawiki/core@master] Revision::getRevisionText(): support old schemas
  
  https://gerrit.wikimedia.org/r/524560

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, 
_jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 58 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/extensions/Duplicator@master] Only use the revision.rev_text_id if 
it exists.
  
  https://gerrit.wikimedia.org/r/58

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 506325 **merged** by jenkins-bot:
  [mediawiki/core@master] Remove references to db field ar_text_id
  
  https://gerrit.wikimedia.org/r/506325

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 506573 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/extensions/DeletePagesForGood@master] Remove references to db 
fields rev_text_id and ar_text_id
  
  https://gerrit.wikimedia.org/r/506573

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  I don't think ApiQueryDeletedrevs will need larger changes, actually. Like 
the other accesses to `old_id`, the JOIN with `text` there was just to prefetch 
fields for a call to `Revision::getRevisionText()`. Removing the JOIN will just 
make the later `getRevisionText()` call have to do an extra DB query.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, Anomie
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 506325 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/core@master] Remove referencs to db field ar_text_id
  
  https://gerrit.wikimedia.org/r/506325

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  I'm also seeing three few ungated ar_text_id references in core:
  
  - ApiQueryAllDeletedRevisions::run()
  - ApiQueryDeletedRevisions::run()
  - ApiQueryDeletedrevs::execute()
  
  These all use ar_text_id to load content by joining the text table. I'll 
refactor that to use the newer approach.
  
  The ar_text_id field shows up a number of other times in core code, but after 
looking at them individually, I think the rest are intentional, and the above 
three are the only problematic references remaining.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 500755 **merged** by jenkins-bot:
  [mediawiki/core@master] Remove references to field rev_text_id
  
  https://gerrit.wikimedia.org/r/500755

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  I still see a couple of usages of rev_text_id or ar_text_id in extensions 
that will need to be fixed[1]:
  
  - ActionDeletePagePermanently.php in DeletePagesForGood
  - Duplicator.page.php in Duplicator
  - bug-53687/fixOrphans.php in WikimediaMaintenance can probably be ignored
  
  [1] 
https://codesearch.wmflabs.org/extensions/?q=-%3Erev_text_id%7C-%3Ear_text_id=nope==

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 499013 **merged** by jenkins-bot:
  [mediawiki/core@master] Remove references to field rev_text_id
  
  https://gerrit.wikimedia.org/r/499013

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 500755 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/core@master] Remove references to field rev_text_id
  
  https://gerrit.wikimedia.org/r/500755

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 499013 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/core@master] Remove references to field rev_text_id
  
  https://gerrit.wikimedia.org/r/499013

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#5049455 , 
@Anomie wrote:
  
  > In T198341#5046541 , 
@daniel wrote:
  >
  > > And let's look into fixing postgres later. And by "later" I mean "when 
there is nothing more urgent or more important to be done".
  >
  >
  > That sounds like code for "never". :(
  
  
  Don't get me wrong - I'd like to see this done. But I'd like to see twenty 
other things done //more//. And we, the core platform team, can only do so 
much. So we have to be picky about the rabbit holes we choose to fall into.
  
  In the end, it's the job of product managers to decide which of all the 
things that we'd like to do are the most important, and should be worked on 
first.
  
  Also, perhaps the necessary work can be done by someone outside the WMF, if 
they have an interest in making this work in postgres. Apparently it hasn't 
bothered anyone in the past ten years...

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  The annoying bit is that the join condition for `pagecontent` will look 
something like `old_id = substring( content_address from '^tt:(8[0-9]+)$' 
)::int`, which hard-codes the "tt:". Thankfully PG has that regexp-based 
substring and casting NULL to `int` works right or it'd be even worse.
  
  In T198341#5046541 , 
@daniel wrote:
  
  > And let's look into fixing postgres later. And by "later" I mean "when 
there is nothing more urgent or more important to be done".
  
  
  That sounds like code for "never". :(

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, Anomie
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#5046362 , 
@Anomie wrote:
  
  > Yes, we //could// do something like that. Probably we wouldn't even need to 
change the triggers, just the SeachPostgres code to join 
revision↔slots↔content↔text (and that last join would probably be really hacky).
  >
  > But IMO this is a situation where it would be better to cut out the bad 
code now instead of trying to hack around it and leave tech debt for the 
future. That way when we get to the part about wanting SearchMySQL and so on to 
handle more than just the main slot the changes to SearchPostgres will be 
similar rather than entirely different (and probably punted on again).
  
  
  I agree we should do that, but that is way beyond the scope of this ticket, 
and should not block other things blocked on this ticket. The factors that go 
into prioritizing "get rid of rev_text_id" are very different from the ones 
that go into "fix postgres search". So I strongly suggest to split the efforts 
and track them in different tickets.
  
  Now, if getting rid of rev_text_id in the postgres script is a hard thing to 
do, and would produce a lot of code that we'd have to throw away again once we 
address the searchindex issue, I agree that we should do both together (though 
the searchindex thing should still have a separate ticket). But that doesn't 
seem to be the case, your suggestion above makes it sound rather trivial.
  
  So let's do the trivial thing first to move this ticket, and unblock the 
things blocked on it. And let's look into fixing postgres later. And by "later" 
I mean "when there is nothing more urgent or more important to be done".

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  In T198341#502 , 
@BPirkle wrote:
  
  > To make sure I'm heading in the right direction:
  >
  > - Postgres currently uses columns in specific tables 
(pagecontent.textvector and page.titlevector, both of type tsvector) to store 
search index information
  > - Postgres also currently uses triggers/procedures to maintain these tables
  > - And directly related to this task, searchPostgres.php currently and 
undesirably references fields rev_text_id and old_id
  
  
  All correct.
  
  > I should:
  > 
  > - add a searchindex table, similar to the MySQL one, but adapted to 
Postgres data types
  
  Yes. Basically `page.titlevector` becomes `searchindex.si_title` and 
`pagecontent.textvector` becomes `searchindex.si_text`. `searchindex.si_page` 
works exactly like it does in MySQL.
  
  > - add related indexes/triggers/procedures to maintain this table
  
  Per T164898 , we don't want to 
keep using triggers for this. `SearchPostgres::update()` should do it, similar 
to what `SearchMySQL::update()` does. Same for `::updateTitle()`.
  
  > - add necessary documentation and install/update support for these db 
changes
  > - modify searchPostgres.php to use the new db changes
  
  Yes to both.
  
  > Questions:
  > 
  > - I'm assuming we are using triggers/procedures to maintain the existing 
tsvector search columns because that works well in Postgres, and we want to 
retain that technique with the searchindex table. Am I right, or do we want to 
do more of this at the PHP level per SearchMySQL.php?
  
  My guess is that whoever originally wrote the SearchPostgres code just 
thought triggers were nicer/"cleaner" than doing it from PHP. Unfortunately 
there's no explanation on r15335 

 or  r15336  as to 
why they did it.
  
  > - should I remove/refactor the existing columns/triggers/procedures and 
have all Postgres searches work off (only) the new searchindex table? Or should 
I leave that alone for now and use $wgMultiContentRevisionSchemaMigrationStage 
gating in searchPostgres.php to continue to use the existing columns if we're 
reading the old schema? Leaving the old and maintaining two sets of indexes at 
the db level sounds inefficient. But maybe there's a reason I'm missing to 
retain it.
  
  Just transition straight to the new searchindex table, no need for a 
migration flag.
  
  > - there are a. bunch of "ts2_" prefixes floating around in 
postgres/tables.sql (ex. "CREATE TRIGGER ts2_page_text..."). Is that a 
meaningful naming convention I should be aware of and retain, or is that just 
"text search 2" to indicate it was a "new thing" at some point?
  
  I think it's just namespacing. It's not anything that you'd have to preserve, 
just name the new things whatever makes sense.
  
  > - is there developer documentation on 
update.php/DatabaseUpdater.php/PostgresUpdater.php? I've looked through that 
code (and postgres/tables.sql). I have a formative understanding, but I need to 
be more solid on how all this works.
  
  Not that I'm aware of. Feel free to ask any questions you have.
  
  In T198341#5045616 , 
@daniel wrote:
  
  > That sounds like "completely change how postgres does search". Now, my 
initial impression is that the way postgres does search is broken by design, 
since a database trigger has no way to correctly interpret the contents of the 
text table, which may be a serialized object, or compressed, or JSON, or a 
reference to an external storage system, or all of these. This has been the 
case for over ten years now.
  
  
  Your initial impression is correct.
  
  > So, my (possibly completely wrong) understanding of how this currently 
works is: pagecontent.textvector  contains the searchable version of the page 
text. We can keep that as it is, the trigger just needs to use the slots and 
content tables to connect rows in pagecontent to rows in revision, instead of 
using rev_text_id. From my current understanding, that should be it. But 
perhaps Brad has different ideas.
  
  Yes, we //could// do something like that. Probably we wouldn't even need to 
change the triggers, just the SeachPostgres code to join 
revision↔slots↔content↔text (and that last join would probably be really hacky).
  
  But IMO this is a situation where it would be better to cut out the bad code 
now instead of trying to hack around it and leave tech debt for the future. 
That way when we get to the part about wanting SearchMySQL and so on to handle 
more than just the main slot the changes to SearchPostgres will be similar 
rather than entirely different (and probably punted on again).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#502 , 
@BPirkle wrote:
  
  > To make sure I'm heading in the right direction:
  >
  > - Postgres currently uses columns in specific tables 
(pagecontent.textvector and page.titlevector, both of type tsvector) to store 
search index information
  > - Postgres also currently uses triggers/procedures to maintain these tables
  > - And directly related to this task, searchPostgres.php currently and 
undesirably references fields rev_text_id and old_id
  
  
  That sounds right to me, but then, I don't actually know how each works on 
postgres.
  
  > I should:
  > 
  > - add a searchindex table, similar to the MySQL one, but adapted to 
Postgres data types
  > - add related indexes/triggers/procedures to maintain this table
  > - add necessary documentation and install/update support for these db 
changes
  > - modify searchPostgres.php to use the new db changes
  
  That sounds like "completely change how postgres does search". Now, my 
initial impression is that the way postgres does search is broken by design, 
since a database trigger has no way to correctly interpret the contents of the 
text table, which may be a serialized object, or compressed, or JSON, or a 
reference to an external storage system, or all of these. This has been the 
case for over ten years now.
  
  But maybe I'm wrong about what it's trying to do. In any case, I'd recommend 
to simply try to keep the current functionality as-is, without trying to fix 
its semantics.
  
  So, my (possibly completely wrong) understanding of how this currently works 
is: pagecontent.textvector  contains the searchable version of the page text. 
We can keep that as it is, the trigger just needs to use the slots and content 
tables to connect rows in pagecontent to rows in revision, instead of using 
rev_text_id. From my current understanding, that should be it. But perhaps Brad 
has different ideas.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  In T198341#5024626 , 
@Anomie wrote:
  
  > In T198341#5022412 , 
@daniel wrote:
  >
  > > In T198341#5021347 , 
@BPirkle wrote:
  > >
  > > > - includes/search/SearchPostgres.php
  > >
  > >
  > > odd stuff, maybe @anomie can help. Two uses seem completely pointless, 
the third one should probably use getQueryInfo?
  >
  >
  > Note in the PostgreSQL schema the "text" table is named "pagecontent". That 
was done in rSVN15791 ; I don't 
know why quoting wasn't just used instead. The plan for T164898 
/T191231 
 includes renaming it back to "text".
  >
  > It looks like that file needs some #technical-debt 
 cleanup to use the 
IDatabase querying methods rather than building SQL strings directly, but that 
alone would probably be out of scope here.
  >
  > What is in scope is that it's trying to search directly against the `text` 
table, having added an extra column for that purpose, and will need to be 
converted to use a `searchindex` table like MySQL does.
  
  
  To make sure I'm heading in the right direction:
  
  - Postgres currently uses columns in specific tables (pagecontent.textvector 
and page.titlevector, both of type tsvector) to store search index information
  - Postgres also currently uses triggers/procedures to maintain these tables
  - And directly related to this task, searchPostgres.php currently and 
undesirably references fields rev_text_id and old_id
  
  I should:
  
  - add a searchindex table, similar to the MySQL one, but adapted to Postgres 
data types
  - add related indexes/triggers/procedures to maintain this table
  - add necessary documentation and install/update support for these db changes
  - modify searchPostgres.php to use the new db changes
  
  Questions:
  
  - I'm assuming we are using triggers/procedures to maintain the existing 
tsvector search columns because that works well in Postgres, and we want to 
retain that technique with the searchindex table. Am I right, or do we want to 
do more of this at the PHP level per SearchMySQL.php?
  - should I remove/refactor the existing columns/triggers/procedures and have 
all Postgres searches work off (only) the new searchindex table? Or should I 
leave that alone for now and use $wgMultiContentRevisionSchemaMigrationStage 
gating in searchPostgres.php to continue to use the existing columns if we're 
reading the old schema? Leaving the old and maintaining two sets of indexes at 
the db level sounds inefficient. But maybe there's a reason I'm missing to 
retain it.
  - there are a. bunch of "ts2_" prefixes floating around in 
postgres/tables.sql (ex. "CREATE TRIGGER ts2_page_text..."). Is that a 
meaningful naming convention I should be aware of and retain, or is that just 
"text search 2" to indicate it was a "new thing" at some point?
  - is there developer documentation on 
update.php/DatabaseUpdater.php/PostgresUpdater.php? I've looked through that 
code (and postgres/tables.sql). I have a formative understanding, but I need to 
be more solid on how all this works.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 496816 **merged** by jenkins-bot:
  [mediawiki/core@master] Remove many references to db fields being retired as 
part of MCR Schema Migration
  
  https://gerrit.wikimedia.org/r/496816

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 496816 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/core@master] Remove many references to db fields being retired as 
part of MCR Schema Migration
  
  https://gerrit.wikimedia.org/r/496816

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.


  Change 496816 had a related patch set uploaded (by BPirkle; owner: BPirkle):
  [mediawiki/core@master] Remove many references to db fields being retired as 
part of MCR Schema Migration
  
  https://gerrit.wikimedia.org/r/496816

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, gerritbot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#5025722 , 
@BPirkle wrote:
  
  > Should compressOld.php and trackBlobs.php be in the same patch, as they 
both suffer from the " processing multiple blobs per revision" problem?
  
  
  Oh, right. Yea, probably.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  In T198341#5025536 , 
@daniel wrote:
  
  > In T198341#5024626 , 
@Anomie wrote:
  >
  > > Here's one place where Daniel and I differ: I'd put most of these in one 
patch instead of having 10+ single-file changes.
  >
  >
  > Ok, compromise: one patch for SearchPostgres, one for checkStorage.php and 
compressOld.php, and one for the rest.
  
  
  Should compressOld.php and trackBlobs.php be in the same patch, as they both 
suffer from the " processing multiple blobs per revision" problem?

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#5024626 , 
@Anomie wrote:
  
  > Here's one place where Daniel and I differ: I'd put most of these in one 
patch instead of having 10+ single-file changes.
  
  
  Ok, compromise: one patch for SearchPostgres, one for checkStorage.php and 
compressOld.php, and one for the rest.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#5021347 , 
@BPirkle wrote:
  
  > rev_text_id references that will be removed/refactored in this task:
  >
  > - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo().  All 
other references are either gated directly, or are in private functions with 
all calls gated)
  
  
  see my previous comment
  
  > - includes/search/SearchPostgres.php
  
  odd stuff, maybe @anomie can help. Two uses seem completely pointless, the 
third one should probably use getQueryInfo?
  
  > - maintenance/Maintenance.php
  
  Hm, purgeRedundantText() looks like it needs a switch based on the migration 
stage. If the SCHEMA_READ_OLD is set, it should read rev_text_id, if 
SCHEMA_READ_NEW is set, it should read from content.cont_address, and use 
SqlBlobStore::getTextIdFromAddress to get the numeric ID (if any).
  
  > - maintenance/populateContentTables.php
  
  See Anomie'S comment
  
  > - maintenance/rebuildtextindex.php
  
  Just drop the 'text' flag from getQueryInfo() and the rev_text_id = old_id 
condition. And try that it still works ;)
  
  > - maintenance/storage/checkStorage.php
  
  Not sure this works at all any more for our wikis, since it has no batching. 
Anyway, the queries against the text table can stay as they are. The code that 
builds $this->oldIdMap needs to be modified much like  the code in 
purgeRedundantText()
  
  > - maintenance/storage/compressOld.php
  
  $fields and friends should come from getQueryInfo(). $textRow  and 
Revision::getRevisionText should be replaced by SqlBlobStore. 
  The logic also needs to be changed so it can process the blobs for multiple 
slots per revision. Probably needs input from Tim.
  
  > - maintenance/storage/fixT22757.php (this script will be removed entirely, 
pending confirmation from @tstarling )
  
  that
  
  > - maintenance/storage/trackBlobs.php
  
  Same approach as compressOld.php, same issue with processing multiple blobs 
per revision.
  
  > - tests/phpunit/includes/ActorMigrationTest.php
  
  I think Anomie siad somehwre that the rev_text_id stuff should just be 
removed, right?
  
  I recommend doing separate patches for all of these.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  > includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All 
other references are either gated directly, or are in private functions with 
all calls gated)
  
  getQueryInfo() should have proper gating as well. If you think it  does not, 
let's talk before you change things.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  Thanks.
  
  MessageCache.php was not listed in my previous comment, because I've already 
incorporated Daniel's patch from June into my local codebase, but that'll be 
part of the final change as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  Thank you. Will ping Tim on that one when it is daylight for him.
  
  One more question: rev_text_id is referenced in 
tests/phpunit/includes/ActorMigrationTest.php function provideInsertRoundTrip, 
which is a data provider for function testInsertRoundTrip. That function does 
many things with the SCHEMA_COMPAT_ constants, but related to the Actor 
migration, not the MCR Schema migration. Therefore the rev_text_id reference 
needs to be removed from that file. Am I correct about that?

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  Question on one occurrence of these fields:  is the maintenance script 
fixT22757.php still relevant?

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.

In T198341#4962428, @BPirkle wrote:
Task description refers to "RevisionStore::newRevisionRecordFromRow()".  Should that be "RevisionStore::newRevisionFromRow()"?


Yes, sorry about that. I'll fix the description.TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkle, danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.
Task description refers to "RevisionStore::newRevisionRecordFromRow()".  Should that be "RevisionStore::newRevisionFromRow()"?TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a comment.
Change 442358 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] MCR WIP Remove references to rev_text_id and ar_text_id

https://gerrit.wikimedia.org/r/442358TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs