[Wikidata-bugs] [Maniphest] [Commented On] T202848: Change property suggester to use hook instead of monkey patching

2018-10-16 Thread Tarrow
Tarrow added a comment. I believe now that https://gerrit.wikimedia.org/r/459505 is merged we can go ahead. Jonas' -2 We need to first teach the hook to evaluate ranking information, otherwise we have a running condition that randomly sorts suggestions. is, I believe, satisfied by the above

[Wikidata-bugs] [Maniphest] [Commented On] T202848: Change property suggester to use hook instead of monkey patching

2018-10-11 Thread hoo
hoo added a comment. What's the state of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/458187? @Jonas can it be merged?TASK DETAILhttps://phabricator.wikimedia.org/T202848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas,

[Wikidata-bugs] [Maniphest] [Commented On] T202848: Change property suggester to use hook instead of monkey patching

2018-09-24 Thread gerritbot
gerritbot added a comment. Change 459505 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Teach EntitySelector._combineResults() to evaluate rank https://gerrit.wikimedia.org/r/459505TASK DETAILhttps://phabricator.wikimedia.org/T202848EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T202848: Change property suggester to use hook instead of monkey patching

2018-09-10 Thread gerritbot
gerritbot added a comment. Change 459505 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)): [mediawiki/extensions/Wikibase@master] Teach EntitySelector._combineResults() to evaluate rank https://gerrit.wikimedia.org/r/459505TASK

[Wikidata-bugs] [Maniphest] [Commented On] T202848: Change property suggester to use hook instead of monkey patching

2018-09-05 Thread gerritbot
gerritbot added a comment. Change 458187 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)): [mediawiki/extensions/PropertySuggester@master] Change property suggester to use hook instead of monkey patching https://gerrit.wikimedia.org/r/458187TASK