[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570921 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: fix vertical marging of bailout heading https://gerrit.wikimedia.org/r/570921 TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570921 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: fix vertical marging of bailout heading https://gerrit.wikimedia.org/r/570921 TASK DETAIL https://

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570634 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: show property labels in bailout components https://gerrit.wikimedia.org/r/570634 TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570634 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: WIP: show property labels in bailout components https://gerrit.wikimedia.org/r/570634 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Lucas_Werkmeister_WMDE added a comment. Uh, another thing… we still need to pass the property //label// into the message, rather than the property //ID//. IIRC we said during code review that we were going to do that in a separate change – well, we still have to do it :) TASK DETAIL https:

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Michael added a comment. In T235753#5852246 , @Lucas_Werkmeister_WMDE wrote: > So either we apply the same fix (scale the margin appropriately to cancel out the font size), or we rethink this whole `px-to-em` business, because at least

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Lucas_Werkmeister_WMDE added a comment. Ah, I see – seems to be the same issue as the one fixed in fix vertical spacing for the button: the element (in this case, the heading) has a `font-size`, which throws off the size of the `margin`. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Charlie_WMDE added a comment. @Lucas_Werkmeister_WMDE sorry to be the party pooper. I found these very strange margin sizes (should be 16 at the bottom and 24 on top). do you know what's causing them? in other places i get the correct 8/16/24px so it can't be purely a conversion thing i

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570098 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: fix vertical spacing of ErrorUnsupportedDatatype https://gerrit.wikimedia.org/r/570098 TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES https:/

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570097 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: fix horizontal spacing of ErrorUnsupportedDatatype https://gerrit.wikimedia.org/r/570097 TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570098 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: fix vertical spacing of ErrorUnsupportedDatatype https://gerrit.wikimedia.org/r/570098 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 570097 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: fix horizontal spacing of ErrorUnsupportedDatatype https://gerrit.wikimedia.org/r/570097 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 568983 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Add header and body messages for unsupported data type https://gerrit.wikimedia.org/r/568983 TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES h

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

gerritbot added a comment. Change 568983 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova): [mediawiki/extensions/Wikibase@master] bridge: Add header and body messages for unsupported data type https://gerrit.wikimedia.org/r/568983 TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Lucas_Werkmeister_WMDE added a comment. That would work, yes. TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, darthmon_wmde, Pablo-WMDE, Addshore, Lucas_Werk

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Charlie_WMDE added a comment. @Lucas_Werkmeister_WMDE what if we change the copy to "instead you could do the following:". then all bullet points and the header message could be separate, right? TASK DETAIL https://phabricator.wikimedia.org/T235753 EMAIL PREFERENCES https://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Michael added a comment. In T235753#5819595 , @Lucas_Werkmeister_WMDE wrote: > The second bullet point already doesn’t work as a continuation of the “Instead you could” sentence beginning, so it might make sense to make the first bullet

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Lucas_Werkmeister_WMDE added a comment. I think the screenshot is a bit ambiguous in terms of the message. The beginning of the first bullet point, “Edit the value on $repoName”, could be a sentence of its own, but also a continuation of the previous text, “Instead you could”. That’s not goi

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Lucas_Werkmeister_WMDE added a comment. > thank you Lucas. how much more effort would it be to show the translatable names? or is it the same and you would just need to know which one to use? It probably means we need to make an extra API request to get the interface message for the name

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Charlie_WMDE added a comment. In T235753#5810011 , @Pablo-WMDE wrote: >> The x-button should stay as is, that's correct. The "publish"-button shouldn't be disabled but should be removed entirely. I have updated the mocks accordingly.

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Charlie_WMDE added a comment. In T235753#5805334 , @Lucas_Werkmeister_WMDE wrote: >>> - `$datatype` will be shown as the datatype identifier (as used in code), not their translatable names as seen in e.g. https://www.wikidata.org/wiki/S

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Pablo-WMDE added a comment. > The x-button should stay as is, that's correct. The "publish"-button shouldn't be disabled but should be removed entirely. I have updated the mocks accordingly. i.e. the header is not out of scope, our assumption was wrong, and the header needs to be touche

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Lucas_Werkmeister_WMDE added a comment. >> - `$datatype` will be shown as the datatype identifier (as used in code), not their translatable names as seen in e.g. https://www.wikidata.org/wiki/Special:ListDatatypes > > I don't know how these two differ. Could you give me some examples? I t

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Charlie_WMDE added a comment. Heyho! thanks for bringing this up @Pablo-WMDE ! I'll comment inline. In T235753#5804709 , @Pablo-WMDE wrote: > During task break-down we assumed: > > - that the application header shown in the mocks

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Pablo-WMDE added a comment. During task break-down we assumed that the application header shown in the mocks is not in scope (i.e. that there in fact will be an x-button, disabled save button, and header text as it currently stands - we will not touch this in this story). TASK DETAIL http

[Wikidata-bugs] [Maniphest] [Commented On] T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Charlie_WMDE added a comment. In T235753#5674828 , @Addshore wrote: > My only additional thought about this ticket is the sentence: > >> overwrite the value locally in the wikitext > > Perhaps UX should have another pass over this