[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 579302 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/579302 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572259 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/572259 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 579302 had a related patch set uploaded (by Tarrow; owner: Ladsgroup): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/579302 TASK DETAIL https://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Jdforrester-WMF added a comment. I deployed this just now, and the error has gone. Thanks, all. Filing a follow-up for the `class@anonymous` logging bug. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-02-14T19:09:59Z] Synchronized php-1.35.0-wmf.19/extensions/Wikibase: T245062 Prevent invalid term languages from cached PrefetchingTermLookup (duration: 01m 09s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572228 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Prevent invalid term languages from cached PrefetchingTermLookup https://gerrit.wikimedia.org/r/572228 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Jdforrester-WMF added a comment. OK, this works OK, but SRE vetoed deploying to production this late on a holiday Friday, so I'll sync it out early on Tuesday SF time. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-02-14T17:37:00Z] Unlocked for deployment [ALL REPOSITORIES]: Testing T245062 fix on mwdebug1001 (duration: 03m 05s) TASK DETAIL https://phabricator.wikimedia.org/T245062

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-02-14T17:33:54Z] Locking from deployment [ALL REPOSITORIES]: Testing T245062 fix on mwdebug1001 (planned duration: 60m 00s) TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572264 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.19] Prevent invalid term languages from cached PrefetchingTermLookup https://gerrit.wikimedia.org/r/572264 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PR

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572264 had a related patch set uploaded (by Jakob; owner: Tarrow): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.19] Prevent invalid term languages from cached PrefetchingTermLookup https://gerrit.wikimedia.org/r/572264 TASK DETAIL https://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572259 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/572259 TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Ladsgroup added a comment. On the lua side of things: You can reproduce this problem by setting the language to almost anything other than a valid one like "uselang=???" . The good news is that I couldn't break out o

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572228 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Filter to only prefect valid terms https://gerrit.wikimedia.org/r/572228 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Krinkle added a comment. @WMDE-leszek If I understand correctly, the issue is that an unsafe value is passed to `BagOStuff->get()`. Specifically, a value that has not gone through `makeKey()` on the same BagOStuff. A BagOStuff implementation may have any number of restrictions on its cache k

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572054 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] DNM Possible band aid for T245062 https://gerrit.wikimedia.org/r/572054 TASK DETAIL http

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

WMDE-leszek added a comment. I am note sure if the issue has been introduced in some recent work as @Ladsgroup said. Looking at the stacktrace, and what happens in `WikibaseLanguageDependentLuaBindings` I see that the the instance of `UsageTrackingLanguageFallbackLabelDescriptionLookup` ca

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

gerritbot added a comment. Change 572045 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] DNM Test reproducing the issue reported in T245062 https://gerrit.wikimedia.org/r/572045 T

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Jdforrester-WMF added a comment. I'm not sure this should block the train; it'd be better if they emitted 400 errors rather than 500s, but it's definitely undefined behaviour territory. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

WMDE-leszek added a comment. Looks like the provided "language code" is not validated/sanitized? TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Liuxinyu970226, Krinkle, Addshor

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

Krinkle added a comment. There is another variation of this error: url: /w/api.php?origin=*&action=wbsearchentities&format=json&limit=50&continue=0&language=en&uselang=en&search=…%3AP17&type=property InvalidArgumentException: Invalid code "internal_api_error_class@anonymous