[Wikidata-bugs] [Maniphest] [Commented On] T249717: Wire up generic save error component in ErrorWrapper

[gerritbot]

gerritbot added a comment.


  Change 592685 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: wire up ErrorSaving in 
ErrorWrapper
  
  https://gerrit.wikimedia.org/r/592685

TASK DETAIL
  https://phabricator.wikimedia.org/T249717

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249717: Wire up generic save error component in ErrorWrapper

[gerritbot]

gerritbot added a comment.


  Change 592685 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] bridge: wire up ErrorSaving in 
ErrorWrapper
  
  https://gerrit.wikimedia.org/r/592685

TASK DETAIL
  https://phabricator.wikimedia.org/T249717

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249717: Wire up generic save error component in ErrorWrapper

[Michael]

Michael added a comment.


  In T249717#6079266 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > The implementation for this might be interesting, I think. Currently, 
`ErrorWrapper` has a lot of getters in its own class, for processing the list 
of errors from the store: `permissionErrors`, `unsupportedDatatypeError`, etc. 
The straightforward approach (to me) would be to add something similar for 
`saveErrors`, and mount the `ErrorSaving` if that list is not empty.
  > But it looks like we’ll also need some similar logic in the store itself, 
for the store getter that indicates whether the “back” button should be shown 
or not (T249718 ). So maybe some of 
this logic to filter the errors should move from `ErrorWrapper` into the store 
itself? What do you think, @Michael?
  
  I'm fine with that logic moving (partly) back into the store.  Probably in 
form of a getter `isSavingError()`? Maybe that could then also be used by the 
`canGoBackToPreviousState()` getter 樂

TASK DETAIL
  https://phabricator.wikimedia.org/T249717

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs